* [PATCH] sstate.bbclass: use tabs for indentation
@ 2019-12-16 9:56 Martin Jansa
2019-12-16 10:41 ` Jacob Kroon
2019-12-16 10:56 ` [PATCHv2] " Martin Jansa
0 siblings, 2 replies; 4+ messages in thread
From: Martin Jansa @ 2019-12-16 9:56 UTC (permalink / raw)
To: openembedded-core
* it's terrible, but this is what oe-core wants and it's better than mixing tabs and spaces in the same function
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
---
meta/classes/sstate.bbclass | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/meta/classes/sstate.bbclass b/meta/classes/sstate.bbclass
index 14de791c81..18e3492674 100644
--- a/meta/classes/sstate.bbclass
+++ b/meta/classes/sstate.bbclass
@@ -753,13 +753,13 @@ sstate_create_package () {
return
fi
- mkdir -p `dirname ${SSTATE_PKG}`
+ mkdir -p `dirname ${SSTATE_PKG}`
TFILE=`mktemp ${SSTATE_PKG}.XXXXXXXX`
- # Use pigz if available
- OPT="-czS"
- if [ -x "$(command -v pigz)" ]; then
- OPT="-I pigz -cS"
+ # Use pigz if available
+ OPT="-czS"
+ if [ -x "$(command -v pigz)" ]; then
+ OPT="-I pigz -cS"
fi
# Need to handle empty directories
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] sstate.bbclass: use tabs for indentation
2019-12-16 9:56 [PATCH] sstate.bbclass: use tabs for indentation Martin Jansa
@ 2019-12-16 10:41 ` Jacob Kroon
2019-12-16 10:58 ` Martin Jansa
2019-12-16 10:56 ` [PATCHv2] " Martin Jansa
1 sibling, 1 reply; 4+ messages in thread
From: Jacob Kroon @ 2019-12-16 10:41 UTC (permalink / raw)
To: Martin Jansa, openembedded-core
On 12/16/19 10:56 AM, Martin Jansa wrote:
> * it's terrible, but this is what oe-core wants and it's better than mixing tabs and spaces in the same function
>
> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> ---
> meta/classes/sstate.bbclass | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/meta/classes/sstate.bbclass b/meta/classes/sstate.bbclass
> index 14de791c81..18e3492674 100644
> --- a/meta/classes/sstate.bbclass
> +++ b/meta/classes/sstate.bbclass
> @@ -753,13 +753,13 @@ sstate_create_package () {
> return
> fi
>
> - mkdir -p `dirname ${SSTATE_PKG}`
> + mkdir -p `dirname ${SSTATE_PKG}`
> TFILE=`mktemp ${SSTATE_PKG}.XXXXXXXX`
>
> - # Use pigz if available
> - OPT="-czS"
> - if [ -x "$(command -v pigz)" ]; then
> - OPT="-I pigz -cS"
> + # Use pigz if available
> + OPT="-czS"
> + if [ -x "$(command -v pigz)" ]; then
> + OPT="-I pigz -cS"
> fi
>
Nice cleanup. Doesn't this final 'fi' still look funky though ?
> # Need to handle empty directories
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] sstate.bbclass: use tabs for indentation
2019-12-16 10:41 ` Jacob Kroon
@ 2019-12-16 10:58 ` Martin Jansa
0 siblings, 0 replies; 4+ messages in thread
From: Martin Jansa @ 2019-12-16 10:58 UTC (permalink / raw)
To: Jacob Kroon; +Cc: openembedded-core
[-- Attachment #1: Type: text/plain, Size: 1462 bytes --]
On Mon, Dec 16, 2019 at 11:41:53AM +0100, Jacob Kroon wrote:
> On 12/16/19 10:56 AM, Martin Jansa wrote:
> > * it's terrible, but this is what oe-core wants and it's better than mixing tabs and spaces in the same function
> >
> > Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> > ---
> > meta/classes/sstate.bbclass | 10 +++++-----
> > 1 file changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/meta/classes/sstate.bbclass b/meta/classes/sstate.bbclass
> > index 14de791c81..18e3492674 100644
> > --- a/meta/classes/sstate.bbclass
> > +++ b/meta/classes/sstate.bbclass
> > @@ -753,13 +753,13 @@ sstate_create_package () {
> > return
> > fi
> > - mkdir -p `dirname ${SSTATE_PKG}`
> > + mkdir -p `dirname ${SSTATE_PKG}`
> > TFILE=`mktemp ${SSTATE_PKG}.XXXXXXXX`
> > - # Use pigz if available
> > - OPT="-czS"
> > - if [ -x "$(command -v pigz)" ]; then
> > - OPT="-I pigz -cS"
> > + # Use pigz if available
> > + OPT="-czS"
> > + if [ -x "$(command -v pigz)" ]; then
> > + OPT="-I pigz -cS"
> > fi
>
> Nice cleanup. Doesn't this final 'fi' still look funky though ?
Yes, you're right, it was still using 8 spaces as well. Hard to notice
when the other half of the file commonly uses 8 spaces and the git diff
with mixed tabs and spaces is always a bit ugly.
Sent v2. Thanks for noticing.
>
> > # Need to handle empty directories
> >
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 201 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCHv2] sstate.bbclass: use tabs for indentation
2019-12-16 9:56 [PATCH] sstate.bbclass: use tabs for indentation Martin Jansa
2019-12-16 10:41 ` Jacob Kroon
@ 2019-12-16 10:56 ` Martin Jansa
1 sibling, 0 replies; 4+ messages in thread
From: Martin Jansa @ 2019-12-16 10:56 UTC (permalink / raw)
To: openembedded-core
* it's terrible, but this is what oe-core wants and it's better than mixing tabs and spaces in the same function
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
---
meta/classes/sstate.bbclass | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/meta/classes/sstate.bbclass b/meta/classes/sstate.bbclass
index 14de791c81..6603c6e926 100644
--- a/meta/classes/sstate.bbclass
+++ b/meta/classes/sstate.bbclass
@@ -753,14 +753,14 @@ sstate_create_package () {
return
fi
- mkdir -p `dirname ${SSTATE_PKG}`
+ mkdir -p `dirname ${SSTATE_PKG}`
TFILE=`mktemp ${SSTATE_PKG}.XXXXXXXX`
- # Use pigz if available
- OPT="-czS"
- if [ -x "$(command -v pigz)" ]; then
- OPT="-I pigz -cS"
- fi
+ # Use pigz if available
+ OPT="-czS"
+ if [ -x "$(command -v pigz)" ]; then
+ OPT="-I pigz -cS"
+ fi
# Need to handle empty directories
if [ "$(ls -A)" ]; then
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-12-16 10:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-16 9:56 [PATCH] sstate.bbclass: use tabs for indentation Martin Jansa
2019-12-16 10:41 ` Jacob Kroon
2019-12-16 10:58 ` Martin Jansa
2019-12-16 10:56 ` [PATCHv2] " Martin Jansa
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.