* [PATCH net-next] mlx4: Bump up MAX_MSIX from 64 to 128
@ 2020-01-09 19:23 Jonathan Lemon
2020-01-10 8:51 ` Jack Wang
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Jonathan Lemon @ 2020-01-09 19:23 UTC (permalink / raw)
To: netdev, tariqt; +Cc: davem, kernel-team
On modern hardware with a large number of cpus and using XDP,
the current MSIX limit is insufficient. Bump the limit in
order to allow more queues.
Signed-off-by: Jonathan Lemon <jonathan.lemon@gmail.com>
---
include/linux/mlx4/device.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/mlx4/device.h b/include/linux/mlx4/device.h
index 36e412c3d657..20372de0b587 100644
--- a/include/linux/mlx4/device.h
+++ b/include/linux/mlx4/device.h
@@ -47,7 +47,7 @@
#define DEFAULT_UAR_PAGE_SHIFT 12
#define MAX_MSIX_P_PORT 17
-#define MAX_MSIX 64
+#define MAX_MSIX 128
#define MIN_MSIX_P_PORT 5
#define MLX4_IS_LEGACY_EQ_MODE(dev_cap) ((dev_cap).num_comp_vectors < \
(dev_cap).num_ports * MIN_MSIX_P_PORT)
--
2.17.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH net-next] mlx4: Bump up MAX_MSIX from 64 to 128
2020-01-09 19:23 [PATCH net-next] mlx4: Bump up MAX_MSIX from 64 to 128 Jonathan Lemon
@ 2020-01-10 8:51 ` Jack Wang
2020-01-11 0:50 ` David Miller
2020-01-12 20:50 ` Jakub Kicinski
2 siblings, 0 replies; 8+ messages in thread
From: Jack Wang @ 2020-01-10 8:51 UTC (permalink / raw)
To: Jonathan Lemon; +Cc: netdev, tariqt, davem, kernel-team
Jonathan Lemon <jonathan.lemon@gmail.com> 于2020年1月9日周四 下午9:47写道:
>
> On modern hardware with a large number of cpus and using XDP,
> the current MSIX limit is insufficient. Bump the limit in
> order to allow more queues.
>
> Signed-off-by: Jonathan Lemon <jonathan.lemon@gmail.com>
Reveiwed-by: Jack Wang <jinpu.wang@cloud.ionos.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH net-next] mlx4: Bump up MAX_MSIX from 64 to 128
2020-01-09 19:23 [PATCH net-next] mlx4: Bump up MAX_MSIX from 64 to 128 Jonathan Lemon
2020-01-10 8:51 ` Jack Wang
@ 2020-01-11 0:50 ` David Miller
2020-01-12 14:52 ` Tariq Toukan
2020-01-12 20:50 ` Jakub Kicinski
2 siblings, 1 reply; 8+ messages in thread
From: David Miller @ 2020-01-11 0:50 UTC (permalink / raw)
To: jonathan.lemon; +Cc: netdev, tariqt, kernel-team
From: Jonathan Lemon <jonathan.lemon@gmail.com>
Date: Thu, 9 Jan 2020 11:23:17 -0800
> On modern hardware with a large number of cpus and using XDP,
> the current MSIX limit is insufficient. Bump the limit in
> order to allow more queues.
>
> Signed-off-by: Jonathan Lemon <jonathan.lemon@gmail.com>
Tariq et al., please review.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH net-next] mlx4: Bump up MAX_MSIX from 64 to 128
2020-01-11 0:50 ` David Miller
@ 2020-01-12 14:52 ` Tariq Toukan
0 siblings, 0 replies; 8+ messages in thread
From: Tariq Toukan @ 2020-01-12 14:52 UTC (permalink / raw)
To: David Miller, jonathan.lemon; +Cc: netdev, kernel-team
On 1/11/2020 2:50 AM, David Miller wrote:
> From: Jonathan Lemon <jonathan.lemon@gmail.com>
> Date: Thu, 9 Jan 2020 11:23:17 -0800
>
>> On modern hardware with a large number of cpus and using XDP,
>> the current MSIX limit is insufficient. Bump the limit in
>> order to allow more queues.
>>
>> Signed-off-by: Jonathan Lemon <jonathan.lemon@gmail.com>
>
> Tariq et al., please review.
>
Reviewed-by: Tariq Toukan <tariqt@mellanox.com>
Regards,
Tariq
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH net-next] mlx4: Bump up MAX_MSIX from 64 to 128
2020-01-09 19:23 [PATCH net-next] mlx4: Bump up MAX_MSIX from 64 to 128 Jonathan Lemon
2020-01-10 8:51 ` Jack Wang
2020-01-11 0:50 ` David Miller
@ 2020-01-12 20:50 ` Jakub Kicinski
2020-01-13 8:47 ` Jinpu Wang
2 siblings, 1 reply; 8+ messages in thread
From: Jakub Kicinski @ 2020-01-12 20:50 UTC (permalink / raw)
To: Jonathan Lemon; +Cc: netdev, tariqt, davem, kernel-team, Jack Wang
On Thu, 9 Jan 2020 11:23:17 -0800, Jonathan Lemon wrote:
> On modern hardware with a large number of cpus and using XDP,
> the current MSIX limit is insufficient. Bump the limit in
> order to allow more queues.
>
> Signed-off-by: Jonathan Lemon <jonathan.lemon@gmail.com>
Applied to net-next, thanks everyone!
(Jack, please make sure you spell your tags right)
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH net-next] mlx4: Bump up MAX_MSIX from 64 to 128
2020-01-12 20:50 ` Jakub Kicinski
@ 2020-01-13 8:47 ` Jinpu Wang
2020-01-13 11:20 ` Jakub Kicinski
0 siblings, 1 reply; 8+ messages in thread
From: Jinpu Wang @ 2020-01-13 8:47 UTC (permalink / raw)
To: Jakub Kicinski
Cc: Jonathan Lemon, netdev, tariqt, David S. Miller, kernel-team
On Sun, Jan 12, 2020 at 9:51 PM Jakub Kicinski <kubakici@wp.pl> wrote:
>
> On Thu, 9 Jan 2020 11:23:17 -0800, Jonathan Lemon wrote:
> > On modern hardware with a large number of cpus and using XDP,
> > the current MSIX limit is insufficient. Bump the limit in
> > order to allow more queues.
> >
> > Signed-off-by: Jonathan Lemon <jonathan.lemon@gmail.com>
>
> Applied to net-next, thanks everyone!
>
> (Jack, please make sure you spell your tags right)
Checked, It's correct both in my reply and in net-next.git.
Thanks,
Jack Wang
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH net-next] mlx4: Bump up MAX_MSIX from 64 to 128
2020-01-13 8:47 ` Jinpu Wang
@ 2020-01-13 11:20 ` Jakub Kicinski
2020-01-13 11:23 ` Jinpu Wang
0 siblings, 1 reply; 8+ messages in thread
From: Jakub Kicinski @ 2020-01-13 11:20 UTC (permalink / raw)
To: Jinpu Wang; +Cc: Jonathan Lemon, netdev, tariqt, David S. Miller, kernel-team
On Mon, 13 Jan 2020 09:47:59 +0100, Jinpu Wang wrote:
> On Sun, Jan 12, 2020 at 9:51 PM Jakub Kicinski <kubakici@wp.pl> wrote:
> > On Thu, 9 Jan 2020 11:23:17 -0800, Jonathan Lemon wrote:
> > > On modern hardware with a large number of cpus and using XDP,
> > > the current MSIX limit is insufficient. Bump the limit in
> > > order to allow more queues.
> > >
> > > Signed-off-by: Jonathan Lemon <jonathan.lemon@gmail.com>
> >
> > Applied to net-next, thanks everyone!
> >
> > (Jack, please make sure you spell your tags right)
> Checked, It's correct both in my reply and in net-next.git.
I manually corrected it in tree. You swapped 'i' and 'e'
in the word reviewed, your email had "reveiwed".
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH net-next] mlx4: Bump up MAX_MSIX from 64 to 128
2020-01-13 11:20 ` Jakub Kicinski
@ 2020-01-13 11:23 ` Jinpu Wang
0 siblings, 0 replies; 8+ messages in thread
From: Jinpu Wang @ 2020-01-13 11:23 UTC (permalink / raw)
To: Jakub Kicinski
Cc: Jonathan Lemon, netdev, tariqt, David S. Miller, kernel-team
On Mon, Jan 13, 2020 at 12:20 PM Jakub Kicinski <kubakici@wp.pl> wrote:
>
> On Mon, 13 Jan 2020 09:47:59 +0100, Jinpu Wang wrote:
> > On Sun, Jan 12, 2020 at 9:51 PM Jakub Kicinski <kubakici@wp.pl> wrote:
> > > On Thu, 9 Jan 2020 11:23:17 -0800, Jonathan Lemon wrote:
> > > > On modern hardware with a large number of cpus and using XDP,
> > > > the current MSIX limit is insufficient. Bump the limit in
> > > > order to allow more queues.
> > > >
> > > > Signed-off-by: Jonathan Lemon <jonathan.lemon@gmail.com>
> > >
> > > Applied to net-next, thanks everyone!
> > >
> > > (Jack, please make sure you spell your tags right)
> > Checked, It's correct both in my reply and in net-next.git.
>
> I manually corrected it in tree. You swapped 'i' and 'e'
> in the word reviewed, your email had "reveiwed".
oh, sorry for that, will be more careful next time.
And thanks for the correction.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2020-01-13 11:23 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-09 19:23 [PATCH net-next] mlx4: Bump up MAX_MSIX from 64 to 128 Jonathan Lemon
2020-01-10 8:51 ` Jack Wang
2020-01-11 0:50 ` David Miller
2020-01-12 14:52 ` Tariq Toukan
2020-01-12 20:50 ` Jakub Kicinski
2020-01-13 8:47 ` Jinpu Wang
2020-01-13 11:20 ` Jakub Kicinski
2020-01-13 11:23 ` Jinpu Wang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.