[PATCH net-next] mlx4: Bump up MAX_MSIX from 64 to 128

[PATCH net-next] mlx4: Bump up MAX_MSIX from 64 to 128

[Jonathan Lemon]

On modern hardware with a large number of cpus and using XDP,
the current MSIX limit is insufficient.  Bump the limit in
order to allow more queues.

Signed-off-by: Jonathan Lemon <jonathan.lemon@gmail.com>
---
 include/linux/mlx4/device.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/mlx4/device.h b/include/linux/mlx4/device.h
index 36e412c3d657..20372de0b587 100644
--- a/include/linux/mlx4/device.h
+++ b/include/linux/mlx4/device.h
@@ -47,7 +47,7 @@
 #define DEFAULT_UAR_PAGE_SHIFT  12
 
 #define MAX_MSIX_P_PORT		17
-#define MAX_MSIX		64
+#define MAX_MSIX		128
 #define MIN_MSIX_P_PORT		5
 #define MLX4_IS_LEGACY_EQ_MODE(dev_cap) ((dev_cap).num_comp_vectors < \
 					 (dev_cap).num_ports * MIN_MSIX_P_PORT)
-- 
2.17.1

Re: [PATCH net-next] mlx4: Bump up MAX_MSIX from 64 to 128

[Jack Wang]

Jonathan Lemon <jonathan.lemon@gmail.com> 于2020年1月9日周四 下午9:47写道：
>
> On modern hardware with a large number of cpus and using XDP,
> the current MSIX limit is insufficient.  Bump the limit in
> order to allow more queues.
>
> Signed-off-by: Jonathan Lemon <jonathan.lemon@gmail.com>
Reveiwed-by: Jack Wang <jinpu.wang@cloud.ionos.com>

Re: [PATCH net-next] mlx4: Bump up MAX_MSIX from 64 to 128

[David Miller]

From: Jonathan Lemon <jonathan.lemon@gmail.com>
Date: Thu, 9 Jan 2020 11:23:17 -0800

> On modern hardware with a large number of cpus and using XDP,
> the current MSIX limit is insufficient.  Bump the limit in
> order to allow more queues.
> 
> Signed-off-by: Jonathan Lemon <jonathan.lemon@gmail.com>

Tariq et al., please review.

Re: [PATCH net-next] mlx4: Bump up MAX_MSIX from 64 to 128

[Tariq Toukan]

On 1/11/2020 2:50 AM, David Miller wrote:
> From: Jonathan Lemon <jonathan.lemon@gmail.com>
> Date: Thu, 9 Jan 2020 11:23:17 -0800
> 
>> On modern hardware with a large number of cpus and using XDP,
>> the current MSIX limit is insufficient.  Bump the limit in
>> order to allow more queues.
>>
>> Signed-off-by: Jonathan Lemon <jonathan.lemon@gmail.com>
> 
> Tariq et al., please review.
> 

Reviewed-by: Tariq Toukan <tariqt@mellanox.com>

Regards,
Tariq

Re: [PATCH net-next] mlx4: Bump up MAX_MSIX from 64 to 128

[Jakub Kicinski]

On Thu, 9 Jan 2020 11:23:17 -0800, Jonathan Lemon wrote:
> On modern hardware with a large number of cpus and using XDP,
> the current MSIX limit is insufficient.  Bump the limit in
> order to allow more queues.
> 
> Signed-off-by: Jonathan Lemon <jonathan.lemon@gmail.com>

Applied to net-next, thanks everyone!

(Jack, please make sure you spell your tags right)

Re: [PATCH net-next] mlx4: Bump up MAX_MSIX from 64 to 128

[Jinpu Wang]

On Sun, Jan 12, 2020 at 9:51 PM Jakub Kicinski <kubakici@wp.pl> wrote:
>
> On Thu, 9 Jan 2020 11:23:17 -0800, Jonathan Lemon wrote:
> > On modern hardware with a large number of cpus and using XDP,
> > the current MSIX limit is insufficient.  Bump the limit in
> > order to allow more queues.
> >
> > Signed-off-by: Jonathan Lemon <jonathan.lemon@gmail.com>
>
> Applied to net-next, thanks everyone!
>
> (Jack, please make sure you spell your tags right)
Checked, It's correct both in my reply and in net-next.git.

Thanks,
Jack Wang

Re: [PATCH net-next] mlx4: Bump up MAX_MSIX from 64 to 128

[Jakub Kicinski]

On Mon, 13 Jan 2020 09:47:59 +0100, Jinpu Wang wrote:
> On Sun, Jan 12, 2020 at 9:51 PM Jakub Kicinski <kubakici@wp.pl> wrote:
> > On Thu, 9 Jan 2020 11:23:17 -0800, Jonathan Lemon wrote:  
> > > On modern hardware with a large number of cpus and using XDP,
> > > the current MSIX limit is insufficient.  Bump the limit in
> > > order to allow more queues.
> > >
> > > Signed-off-by: Jonathan Lemon <jonathan.lemon@gmail.com>  
> >
> > Applied to net-next, thanks everyone!
> >
> > (Jack, please make sure you spell your tags right)  
> Checked, It's correct both in my reply and in net-next.git.

I manually corrected it in tree. You swapped 'i' and 'e' 
in the word reviewed, your email had "reveiwed".

Re: [PATCH net-next] mlx4: Bump up MAX_MSIX from 64 to 128

[Jinpu Wang]

On Mon, Jan 13, 2020 at 12:20 PM Jakub Kicinski <kubakici@wp.pl> wrote:
>
> On Mon, 13 Jan 2020 09:47:59 +0100, Jinpu Wang wrote:
> > On Sun, Jan 12, 2020 at 9:51 PM Jakub Kicinski <kubakici@wp.pl> wrote:
> > > On Thu, 9 Jan 2020 11:23:17 -0800, Jonathan Lemon wrote:
> > > > On modern hardware with a large number of cpus and using XDP,
> > > > the current MSIX limit is insufficient.  Bump the limit in
> > > > order to allow more queues.
> > > >
> > > > Signed-off-by: Jonathan Lemon <jonathan.lemon@gmail.com>
> > >
> > > Applied to net-next, thanks everyone!
> > >
> > > (Jack, please make sure you spell your tags right)
> > Checked, It's correct both in my reply and in net-next.git.
>
> I manually corrected it in tree. You swapped 'i' and 'e'
> in the word reviewed, your email had "reveiwed".
oh, sorry for that, will be more careful next time.
And thanks for the correction.