All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Dave Chinner <david@fromorbit.com>
Cc: Christoph Hellwig <hch@lst.de>,
	linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	Waiman Long <longman@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Will Deacon <will@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-ext4@vger.kernel.org, cluster-devel@redhat.com,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: RFC: hold i_rwsem until aio completes
Date: Mon, 3 Feb 2020 18:46:41 +0100	[thread overview]
Message-ID: <20200203174641.GA20035@lst.de> (raw)
In-Reply-To: <20200118092838.GB9407@dread.disaster.area>

On Sat, Jan 18, 2020 at 08:28:38PM +1100, Dave Chinner wrote:
> I think it's pretty gross, actually. It  makes the same mistake made
> with locking in the old direct IO code - it encodes specific lock
> operations via flags into random locations in the DIO path. This is
> a very slippery slope, and IMO it is an layering violation to encode
> specific filesystem locking smeantics into a layer that is supposed
> to be generic and completely filesystem agnostic. i.e.  this
> mechanism breaks if a filesystem moves to a different type of lock
> (e.g. range locks), and history teaches us that we'll end up making
> a horrible, unmaintainable mess to support different locking
> mechanisms and contexts.
> 
> I think that we should be moving to a model where the filesystem
> provides an unlock method in the iomap operations structure, and if
> the method is present in iomap_dio_complete() it gets called for the
> filesystem to unlock the inode at the appropriate point. This also
> allows the filesystem to provide a different method for read or
> write unlock, depending on what type of lock it held at submission.
> This gets rid of the need for the iomap code to know what type of
> lock the caller holds, too.

I'd rather avoid yet another method.  But I think with a little
tweaking we can move the unlock into the ->end_io method.

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] RFC: hold i_rwsem until aio completes
Date: Mon, 3 Feb 2020 18:46:41 +0100	[thread overview]
Message-ID: <20200203174641.GA20035@lst.de> (raw)
In-Reply-To: <20200118092838.GB9407@dread.disaster.area>

On Sat, Jan 18, 2020 at 08:28:38PM +1100, Dave Chinner wrote:
> I think it's pretty gross, actually. It  makes the same mistake made
> with locking in the old direct IO code - it encodes specific lock
> operations via flags into random locations in the DIO path. This is
> a very slippery slope, and IMO it is an layering violation to encode
> specific filesystem locking smeantics into a layer that is supposed
> to be generic and completely filesystem agnostic. i.e.  this
> mechanism breaks if a filesystem moves to a different type of lock
> (e.g. range locks), and history teaches us that we'll end up making
> a horrible, unmaintainable mess to support different locking
> mechanisms and contexts.
> 
> I think that we should be moving to a model where the filesystem
> provides an unlock method in the iomap operations structure, and if
> the method is present in iomap_dio_complete() it gets called for the
> filesystem to unlock the inode at the appropriate point. This also
> allows the filesystem to provide a different method for read or
> write unlock, depending on what type of lock it held at submission.
> This gets rid of the need for the iomap code to know what type of
> lock the caller holds, too.

I'd rather avoid yet another method.  But I think with a little
tweaking we can move the unlock into the ->end_io method.




  reply	other threads:[~2020-02-03 17:46 UTC|newest]

Thread overview: 80+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-14 16:12 RFC: hold i_rwsem until aio completes Christoph Hellwig
2020-01-14 16:12 ` [Cluster-devel] " Christoph Hellwig
2020-01-14 16:12 ` [PATCH 01/12] mm: fix a comment in sys_swapon Christoph Hellwig
2020-01-14 16:12   ` [Cluster-devel] " Christoph Hellwig
2020-02-10 23:29   ` Andrew Morton
2020-02-10 23:29     ` [Cluster-devel] " Andrew Morton
2020-02-12  7:37     ` Christoph Hellwig
2020-02-12  7:37       ` [Cluster-devel] " Christoph Hellwig
2020-01-14 16:12 ` [PATCH 02/12] locking/rwsem: Exit early when held by an anonymous owner Christoph Hellwig
2020-01-14 16:12   ` [Cluster-devel] " Christoph Hellwig
2020-01-14 18:17   ` Waiman Long
2020-01-14 18:17     ` [Cluster-devel] " Waiman Long
2020-01-14 18:25     ` Christoph Hellwig
2020-01-14 18:25       ` [Cluster-devel] " Christoph Hellwig
2020-01-14 18:33       ` Waiman Long
2020-01-14 18:33         ` [Cluster-devel] " Waiman Long
2020-01-14 18:55       ` Waiman Long
2020-01-14 18:55         ` [Cluster-devel] " Waiman Long
2020-01-14 16:12 ` [PATCH 03/12] xfs: fix IOCB_NOWAIT handling in xfs_file_dio_aio_read Christoph Hellwig
2020-01-14 16:12   ` [Cluster-devel] " Christoph Hellwig
2020-01-14 16:12 ` [PATCH 04/12] gfs2: move setting current->backing_dev_info Christoph Hellwig
2020-01-14 16:12   ` [Cluster-devel] " Christoph Hellwig
2020-01-14 16:12 ` [PATCH 05/12] gfs2: fix O_SYNC write handling Christoph Hellwig
2020-01-14 16:12   ` [Cluster-devel] " Christoph Hellwig
2020-01-27  9:03   ` Christoph Hellwig
2020-01-28 16:57     ` Bob Peterson
2020-02-06 15:31   ` Andreas Gruenbacher
2020-02-06 15:31     ` Andreas Gruenbacher
2020-02-06 15:31     ` Andreas Gruenbacher
2020-01-14 16:12 ` [PATCH 06/12] iomap: pass a flags value to iomap_dio_rw Christoph Hellwig
2020-01-14 16:12   ` [Cluster-devel] " Christoph Hellwig
2020-01-14 16:12 ` [PATCH 07/12] iomap: allow holding i_rwsem until aio completion Christoph Hellwig
2020-01-14 16:12 ` [PATCH 08/12] ext4: hold i_rwsem until AIO completes Christoph Hellwig
2020-01-14 16:12   ` [Cluster-devel] " Christoph Hellwig
2020-01-14 21:50   ` Theodore Y. Ts'o
2020-01-14 21:50     ` [Cluster-devel] " Theodore Y. Ts'o
2020-01-15  6:48     ` Christoph Hellwig
2020-01-15  6:48       ` [Cluster-devel] " Christoph Hellwig
2020-01-14 16:12 ` [PATCH 09/12] gfs2: " Christoph Hellwig
2020-01-14 16:12   ` [Cluster-devel] " Christoph Hellwig
2020-01-14 16:12 ` [PATCH 10/12] xfs: " Christoph Hellwig
2020-01-14 16:12   ` [Cluster-devel] " Christoph Hellwig
2020-01-14 16:12 ` [PATCH 11/12] xfs: don't set IOMAP_DIO_SYNCHRONOUS for unaligned I/O Christoph Hellwig
2020-01-14 16:12   ` [Cluster-devel] " Christoph Hellwig
2020-01-14 16:12 ` [PATCH 12/12] iomap: remove the inode_dio_begin/end calls Christoph Hellwig
2020-01-14 16:12   ` [Cluster-devel] " Christoph Hellwig
2020-01-14 18:47 ` RFC: hold i_rwsem until aio completes Matthew Wilcox
2020-01-14 18:47   ` [Cluster-devel] " Matthew Wilcox
2020-01-15  6:54   ` Christoph Hellwig
2020-01-15  6:54     ` [Cluster-devel] " Christoph Hellwig
2020-01-14 19:27 ` Jason Gunthorpe
2020-01-14 19:27   ` [Cluster-devel] " Jason Gunthorpe
2020-01-15  6:56   ` Christoph Hellwig
2020-01-15  6:56     ` [Cluster-devel] " Christoph Hellwig
2020-01-15 13:24     ` Jason Gunthorpe
2020-01-15 13:24       ` [Cluster-devel] " Jason Gunthorpe
2020-01-15 14:33       ` Peter Zijlstra
2020-01-15 14:33         ` [Cluster-devel] " Peter Zijlstra
2020-01-15 14:49         ` Jason Gunthorpe
2020-01-15 14:49           ` [Cluster-devel] " Jason Gunthorpe
2020-01-15 19:03           ` Waiman Long
2020-01-15 19:03             ` [Cluster-devel] " Waiman Long
2020-01-15 19:07             ` Christoph Hellwig
2020-01-15 19:07               ` [Cluster-devel] " Christoph Hellwig
2020-01-18 22:40         ` Matthew Wilcox
2020-01-18 22:40           ` [Cluster-devel] " Matthew Wilcox
2020-01-15 15:36       ` Christoph Hellwig
2020-01-15 15:36         ` [Cluster-devel] " Christoph Hellwig
2020-01-15 16:26         ` Jason Gunthorpe
2020-01-15 16:26           ` [Cluster-devel] " Jason Gunthorpe
2020-01-16 14:00 ` Jan Kara
2020-01-16 14:00   ` [Cluster-devel] " Jan Kara
2020-02-03 17:44   ` Christoph Hellwig
2020-02-03 17:44     ` [Cluster-devel] " Christoph Hellwig
2020-01-18  9:28 ` Dave Chinner
2020-01-18  9:28   ` [Cluster-devel] " Dave Chinner
2020-02-03 17:46   ` Christoph Hellwig [this message]
2020-02-03 17:46     ` Christoph Hellwig
2020-02-03 23:02     ` Dave Chinner
2020-02-03 23:02       ` [Cluster-devel] " Dave Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200203174641.GA20035@lst.de \
    --to=hch@lst.de \
    --cc=akpm@linux-foundation.org \
    --cc=cluster-devel@redhat.com \
    --cc=david@fromorbit.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=longman@redhat.com \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.