All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Zyngier <maz@kernel.org>
To: linux-arm-kernel@lists.infradead.org,
	kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
	Jason Cooper <jason@lakedaemon.net>,
	Robert Richter <rrichter@marvell.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Zenghui Yu <yuzenghui@huawei.com>,
	Eric Auger <eric.auger@redhat.com>,
	James Morse <james.morse@arm.com>,
	Julien Thierry <julien.thierry.kdev@gmail.com>,
	Suzuki K Poulose <suzuki.poulose@arm.com>
Subject: [PATCH v4 14/20] KVM: arm64: GICv4.1: Let doorbells be auto-enabled
Date: Fri, 14 Feb 2020 14:57:30 +0000	[thread overview]
Message-ID: <20200214145736.18550-15-maz@kernel.org> (raw)
In-Reply-To: <20200214145736.18550-1-maz@kernel.org>

As GICv4.1 understands the life cycle of doorbells (instead of
just randomly firing them at the most inconvenient time), just
enable them at irq_request time, and be done with it.

Signed-off-by: Marc Zyngier <maz@kernel.org>
---
 virt/kvm/arm/vgic/vgic-v4.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/virt/kvm/arm/vgic/vgic-v4.c b/virt/kvm/arm/vgic/vgic-v4.c
index 1eb0f8c76219..c2fcde104ea2 100644
--- a/virt/kvm/arm/vgic/vgic-v4.c
+++ b/virt/kvm/arm/vgic/vgic-v4.c
@@ -141,6 +141,7 @@ int vgic_v4_init(struct kvm *kvm)
 
 	kvm_for_each_vcpu(i, vcpu, kvm) {
 		int irq = dist->its_vm.vpes[i]->irq;
+		unsigned long irq_flags = DB_IRQ_FLAGS;
 
 		/*
 		 * Don't automatically enable the doorbell, as we're
@@ -148,8 +149,14 @@ int vgic_v4_init(struct kvm *kvm)
 		 * blocked. Also disable the lazy disabling, as the
 		 * doorbell could kick us out of the guest too
 		 * early...
+		 *
+		 * On GICv4.1, the doorbell is managed in HW and must
+		 * be left enabled.
 		 */
-		irq_set_status_flags(irq, DB_IRQ_FLAGS);
+		if (kvm_vgic_global_state.has_gicv4_1)
+			irq_flags &= ~IRQ_NOAUTOEN;
+		irq_set_status_flags(irq, irq_flags);
+
 		ret = request_irq(irq, vgic_v4_doorbell_handler,
 				  0, "vcpu", vcpu);
 		if (ret) {
-- 
2.20.1


WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: linux-arm-kernel@lists.infradead.org,
	kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
	Jason Cooper <jason@lakedaemon.net>,
	Robert Richter <rrichter@marvell.com>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: [PATCH v4 14/20] KVM: arm64: GICv4.1: Let doorbells be auto-enabled
Date: Fri, 14 Feb 2020 14:57:30 +0000	[thread overview]
Message-ID: <20200214145736.18550-15-maz@kernel.org> (raw)
In-Reply-To: <20200214145736.18550-1-maz@kernel.org>

As GICv4.1 understands the life cycle of doorbells (instead of
just randomly firing them at the most inconvenient time), just
enable them at irq_request time, and be done with it.

Signed-off-by: Marc Zyngier <maz@kernel.org>
---
 virt/kvm/arm/vgic/vgic-v4.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/virt/kvm/arm/vgic/vgic-v4.c b/virt/kvm/arm/vgic/vgic-v4.c
index 1eb0f8c76219..c2fcde104ea2 100644
--- a/virt/kvm/arm/vgic/vgic-v4.c
+++ b/virt/kvm/arm/vgic/vgic-v4.c
@@ -141,6 +141,7 @@ int vgic_v4_init(struct kvm *kvm)
 
 	kvm_for_each_vcpu(i, vcpu, kvm) {
 		int irq = dist->its_vm.vpes[i]->irq;
+		unsigned long irq_flags = DB_IRQ_FLAGS;
 
 		/*
 		 * Don't automatically enable the doorbell, as we're
@@ -148,8 +149,14 @@ int vgic_v4_init(struct kvm *kvm)
 		 * blocked. Also disable the lazy disabling, as the
 		 * doorbell could kick us out of the guest too
 		 * early...
+		 *
+		 * On GICv4.1, the doorbell is managed in HW and must
+		 * be left enabled.
 		 */
-		irq_set_status_flags(irq, DB_IRQ_FLAGS);
+		if (kvm_vgic_global_state.has_gicv4_1)
+			irq_flags &= ~IRQ_NOAUTOEN;
+		irq_set_status_flags(irq, irq_flags);
+
 		ret = request_irq(irq, vgic_v4_doorbell_handler,
 				  0, "vcpu", vcpu);
 		if (ret) {
-- 
2.20.1

_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: linux-arm-kernel@lists.infradead.org,
	kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
	Jason Cooper <jason@lakedaemon.net>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Eric Auger <eric.auger@redhat.com>,
	Robert Richter <rrichter@marvell.com>,
	James Morse <james.morse@arm.com>,
	Zenghui Yu <yuzenghui@huawei.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Julien Thierry <julien.thierry.kdev@gmail.com>
Subject: [PATCH v4 14/20] KVM: arm64: GICv4.1: Let doorbells be auto-enabled
Date: Fri, 14 Feb 2020 14:57:30 +0000	[thread overview]
Message-ID: <20200214145736.18550-15-maz@kernel.org> (raw)
In-Reply-To: <20200214145736.18550-1-maz@kernel.org>

As GICv4.1 understands the life cycle of doorbells (instead of
just randomly firing them at the most inconvenient time), just
enable them at irq_request time, and be done with it.

Signed-off-by: Marc Zyngier <maz@kernel.org>
---
 virt/kvm/arm/vgic/vgic-v4.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/virt/kvm/arm/vgic/vgic-v4.c b/virt/kvm/arm/vgic/vgic-v4.c
index 1eb0f8c76219..c2fcde104ea2 100644
--- a/virt/kvm/arm/vgic/vgic-v4.c
+++ b/virt/kvm/arm/vgic/vgic-v4.c
@@ -141,6 +141,7 @@ int vgic_v4_init(struct kvm *kvm)
 
 	kvm_for_each_vcpu(i, vcpu, kvm) {
 		int irq = dist->its_vm.vpes[i]->irq;
+		unsigned long irq_flags = DB_IRQ_FLAGS;
 
 		/*
 		 * Don't automatically enable the doorbell, as we're
@@ -148,8 +149,14 @@ int vgic_v4_init(struct kvm *kvm)
 		 * blocked. Also disable the lazy disabling, as the
 		 * doorbell could kick us out of the guest too
 		 * early...
+		 *
+		 * On GICv4.1, the doorbell is managed in HW and must
+		 * be left enabled.
 		 */
-		irq_set_status_flags(irq, DB_IRQ_FLAGS);
+		if (kvm_vgic_global_state.has_gicv4_1)
+			irq_flags &= ~IRQ_NOAUTOEN;
+		irq_set_status_flags(irq, irq_flags);
+
 		ret = request_irq(irq, vgic_v4_doorbell_handler,
 				  0, "vcpu", vcpu);
 		if (ret) {
-- 
2.20.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2020-02-14 15:21 UTC|newest]

Thread overview: 142+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-14 14:57 [PATCH v4 00/20] irqchip/gic-v4: GICv4.1 architecture support Marc Zyngier
2020-02-14 14:57 ` Marc Zyngier
2020-02-14 14:57 ` Marc Zyngier
2020-02-14 14:57 ` [PATCH v4 01/20] irqchip/gic-v4.1: Skip absent CPUs while iterating over redistributors Marc Zyngier
2020-02-14 14:57   ` Marc Zyngier
2020-02-14 14:57   ` Marc Zyngier
2020-02-17  9:11   ` Zenghui Yu
2020-02-17  9:11     ` Zenghui Yu
2020-02-17  9:11     ` Zenghui Yu
2020-02-14 14:57 ` [PATCH v4 02/20] irqchip/gic-v3: Use SGIs without active state if offered Marc Zyngier
2020-02-14 14:57   ` Marc Zyngier
2020-02-14 14:57   ` Marc Zyngier
2020-02-17  9:18   ` Zenghui Yu
2020-02-17  9:18     ` Zenghui Yu
2020-02-17  9:18     ` Zenghui Yu
2020-02-14 14:57 ` [PATCH v4 03/20] irqchip/gic-v4.1: Advertise support v4.1 to KVM Marc Zyngier
2020-02-14 14:57   ` Marc Zyngier
2020-02-14 14:57   ` Marc Zyngier
2020-02-17  9:09   ` Zenghui Yu
2020-02-17  9:09     ` Zenghui Yu
2020-02-17  9:09     ` Zenghui Yu
2020-02-14 14:57 ` [PATCH v4 04/20] irqchip/gic-v4.1: Map the ITS SGIR register page Marc Zyngier
2020-02-14 14:57   ` Marc Zyngier
2020-02-14 14:57   ` Marc Zyngier
2020-02-20  3:17   ` Zenghui Yu
2020-02-20  3:17     ` Zenghui Yu
2020-02-20  3:17     ` Zenghui Yu
2020-02-14 14:57 ` [PATCH v4 05/20] irqchip/gic-v4.1: Plumb skeletal VSGI irqchip Marc Zyngier
2020-02-14 14:57   ` Marc Zyngier
2020-02-14 14:57   ` Marc Zyngier
2020-02-20  3:21   ` Zenghui Yu
2020-02-20  3:21     ` Zenghui Yu
2020-02-20  3:21     ` Zenghui Yu
2020-02-14 14:57 ` [PATCH v4 06/20] irqchip/gic-v4.1: Add initial SGI configuration Marc Zyngier
2020-02-14 14:57   ` Marc Zyngier
2020-02-14 14:57   ` Marc Zyngier
2020-02-18  7:25   ` Zenghui Yu
2020-02-18  7:25     ` Zenghui Yu
2020-02-18  7:25     ` Zenghui Yu
2020-02-18  9:46     ` Marc Zyngier
2020-02-18  9:46       ` Marc Zyngier
2020-02-18  9:46       ` Marc Zyngier
2020-02-20  3:25       ` Zenghui Yu
2020-02-20  3:25         ` Zenghui Yu
2020-02-20  3:25         ` Zenghui Yu
2020-02-14 14:57 ` [PATCH v4 07/20] irqchip/gic-v4.1: Plumb mask/unmask SGI callbacks Marc Zyngier
2020-02-14 14:57   ` Marc Zyngier
2020-02-14 14:57   ` Marc Zyngier
2020-02-20  3:32   ` Zenghui Yu
2020-02-20  3:32     ` Zenghui Yu
2020-02-20  3:32     ` Zenghui Yu
2020-02-14 14:57 ` [PATCH v4 08/20] irqchip/gic-v4.1: Plumb get/set_irqchip_state " Marc Zyngier
2020-02-14 14:57   ` Marc Zyngier
2020-02-14 14:57   ` Marc Zyngier
2020-02-18  7:00   ` Zenghui Yu
2020-02-18  7:00     ` Zenghui Yu
2020-02-18  7:00     ` Zenghui Yu
2020-02-18  9:27     ` Marc Zyngier
2020-02-18  9:27       ` Marc Zyngier
2020-02-18  9:27       ` Marc Zyngier
2020-02-18 15:31       ` Marc Zyngier
2020-02-18 15:31         ` Marc Zyngier
2020-02-18 15:31         ` Marc Zyngier
2020-02-19 11:50         ` Zenghui Yu
2020-02-19 11:50           ` Zenghui Yu
2020-02-19 11:50           ` Zenghui Yu
2020-02-19 15:18           ` Zenghui Yu
2020-02-19 15:18             ` Zenghui Yu
2020-02-19 15:18             ` Zenghui Yu
2020-02-20  3:11         ` Zenghui Yu
2020-02-20  3:11           ` Zenghui Yu
2020-02-20  3:11           ` Zenghui Yu
2020-02-28 19:37           ` Marc Zyngier
2020-02-28 19:37             ` Marc Zyngier
2020-02-28 19:37             ` Marc Zyngier
2020-03-01 19:00             ` Marc Zyngier
2020-03-01 19:00               ` Marc Zyngier
2020-03-01 19:00               ` Marc Zyngier
2020-03-02  8:18               ` Zenghui Yu
2020-03-02  8:18                 ` Zenghui Yu
2020-03-02  8:18                 ` Zenghui Yu
2020-03-02 12:09                 ` Marc Zyngier
2020-03-02 12:09                   ` Marc Zyngier
2020-03-02 12:09                   ` Marc Zyngier
2020-03-02 14:21                   ` Bill Barrow
2020-02-14 14:57 ` [PATCH v4 09/20] irqchip/gic-v4.1: Plumb set_vcpu_affinity " Marc Zyngier
2020-02-14 14:57   ` Marc Zyngier
2020-02-14 14:57   ` Marc Zyngier
2020-02-20  3:37   ` Zenghui Yu
2020-02-20  3:37     ` Zenghui Yu
2020-02-20  3:37     ` Zenghui Yu
2020-02-28 19:00     ` Marc Zyngier
2020-02-28 19:00       ` Marc Zyngier
2020-02-28 19:00       ` Marc Zyngier
2020-02-14 14:57 ` [PATCH v4 10/20] irqchip/gic-v4.1: Move doorbell management to the GICv4 abstraction layer Marc Zyngier
2020-02-14 14:57   ` Marc Zyngier
2020-02-14 14:57   ` Marc Zyngier
2020-02-14 14:57 ` [PATCH v4 11/20] irqchip/gic-v4.1: Add VSGI allocation/teardown Marc Zyngier
2020-02-14 14:57   ` Marc Zyngier
2020-02-14 14:57   ` Marc Zyngier
2020-02-14 14:57 ` [PATCH v4 12/20] irqchip/gic-v4.1: Add VSGI property setup Marc Zyngier
2020-02-14 14:57   ` Marc Zyngier
2020-02-14 14:57   ` Marc Zyngier
2020-02-14 14:57 ` [PATCH v4 13/20] irqchip/gic-v4.1: Eagerly vmap vPEs Marc Zyngier
2020-02-14 14:57   ` Marc Zyngier
2020-02-14 14:57   ` Marc Zyngier
2020-02-14 14:57 ` Marc Zyngier [this message]
2020-02-14 14:57   ` [PATCH v4 14/20] KVM: arm64: GICv4.1: Let doorbells be auto-enabled Marc Zyngier
2020-02-14 14:57   ` Marc Zyngier
2020-02-14 14:57 ` [PATCH v4 15/20] KVM: arm64: GICv4.1: Add direct injection capability to SGI registers Marc Zyngier
2020-02-14 14:57   ` Marc Zyngier
2020-02-14 14:57   ` Marc Zyngier
2020-02-18  8:46   ` Zenghui Yu
2020-02-18  8:46     ` Zenghui Yu
2020-02-18  8:46     ` Zenghui Yu
2020-02-18  9:41     ` Marc Zyngier
2020-02-18  9:41       ` Marc Zyngier
2020-02-18  9:41       ` Marc Zyngier
2020-02-14 14:57 ` [PATCH v4 16/20] KVM: arm64: GICv4.1: Allow SGIs to switch between HW and SW interrupts Marc Zyngier
2020-02-14 14:57   ` Marc Zyngier
2020-02-14 14:57   ` Marc Zyngier
2020-02-20  3:55   ` Zenghui Yu
2020-02-20  3:55     ` Zenghui Yu
2020-02-20  3:55     ` Zenghui Yu
2020-02-28 19:16     ` Marc Zyngier
2020-02-28 19:16       ` Marc Zyngier
2020-02-28 19:16       ` Marc Zyngier
2020-03-02  2:40       ` Zenghui Yu
2020-03-02  2:40         ` Zenghui Yu
2020-03-02  2:40         ` Zenghui Yu
2020-02-14 14:57 ` [PATCH v4 17/20] KVM: arm64: GICv4.1: Plumb SGI implementation selection in the distributor Marc Zyngier
2020-02-14 14:57   ` Marc Zyngier
2020-02-14 14:57   ` Marc Zyngier
2020-02-14 14:57 ` [PATCH v4 18/20] KVM: arm64: GICv4.1: Reload VLPI configuration on distributor enable/disable Marc Zyngier
2020-02-14 14:57   ` Marc Zyngier
2020-02-14 14:57   ` Marc Zyngier
2020-02-14 14:57 ` [PATCH v4 19/20] KVM: arm64: GICv4.1: Allow non-trapping WFI when using HW SGIs Marc Zyngier
2020-02-14 14:57   ` Marc Zyngier
2020-02-14 14:57   ` Marc Zyngier
2020-02-14 14:57 ` [PATCH v4 20/20] KVM: arm64: GICv4.1: Expose HW-based SGIs in debugfs Marc Zyngier
2020-02-14 14:57   ` Marc Zyngier
2020-02-14 14:57   ` Marc Zyngier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200214145736.18550-15-maz@kernel.org \
    --to=maz@kernel.org \
    --cc=eric.auger@redhat.com \
    --cc=james.morse@arm.com \
    --cc=jason@lakedaemon.net \
    --cc=julien.thierry.kdev@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=rrichter@marvell.com \
    --cc=suzuki.poulose@arm.com \
    --cc=tglx@linutronix.de \
    --cc=yuzenghui@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.