* [PATCH v2 01/13] block/stream: Remove redundant statement in stream_run()
2020-02-26 8:46 [PATCH v2 00/13] redundant code: Fix warnings reported by Clang static code analyzer kuhn.chenqun
@ 2020-02-26 8:46 ` kuhn.chenqun
2020-02-26 9:51 ` Kevin Wolf
2020-02-26 8:46 ` [PATCH v2 02/13] block/iscsi:Remove redundant statement in iscsi_open() kuhn.chenqun
` (11 subsequent siblings)
12 siblings, 1 reply; 32+ messages in thread
From: kuhn.chenqun @ 2020-02-26 8:46 UTC (permalink / raw)
To: qemu-devel, qemu-trivial
Cc: Kevin Wolf, peter.maydell, zhang.zhanghailiang, Max Reitz,
Euler Robot, Chen Qun, John Snow
From: Chen Qun <kuhn.chenqun@huawei.com>
Clang static code analyzer show warning:
block/stream.c:186:9: warning: Value stored to 'ret' is never read
ret = 0;
^ ~
Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
Reviewed-by: John Snow <jsnow@redhat.com>
---
Cc: John Snow <jsnow@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>
Cc: Max Reitz <mreitz@redhat.com>
---
block/stream.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/block/stream.c b/block/stream.c
index 5562ccbf57..d78074ac80 100644
--- a/block/stream.c
+++ b/block/stream.c
@@ -183,7 +183,6 @@ static int coroutine_fn stream_run(Job *job, Error **errp)
break;
}
}
- ret = 0;
/* Publish progress */
job_progress_update(&s->common.job, n);
--
2.23.0
^ permalink raw reply related [flat|nested] 32+ messages in thread* Re: [PATCH v2 01/13] block/stream: Remove redundant statement in stream_run()
2020-02-26 8:46 ` [PATCH v2 01/13] block/stream: Remove redundant statement in stream_run() kuhn.chenqun
@ 2020-02-26 9:51 ` Kevin Wolf
2020-02-26 10:21 ` Chenqun (kuhn)
0 siblings, 1 reply; 32+ messages in thread
From: Kevin Wolf @ 2020-02-26 9:51 UTC (permalink / raw)
To: kuhn.chenqun
Cc: peter.maydell, zhang.zhanghailiang, qemu-trivial, qemu-devel,
Max Reitz, Euler Robot, John Snow
Am 26.02.2020 um 09:46 hat kuhn.chenqun@huawei.com geschrieben:
> From: Chen Qun <kuhn.chenqun@huawei.com>
>
> Clang static code analyzer show warning:
> block/stream.c:186:9: warning: Value stored to 'ret' is never read
> ret = 0;
> ^ ~
> Reported-by: Euler Robot <euler.robot@huawei.com>
> Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
> Reviewed-by: John Snow <jsnow@redhat.com>
Let's mention that this is unnecessary since commit 1d809098aa9.
Since the same commit, the initialisation 'int ret = 0;' is unnecessary
because we never read ret before overwriting the initial value. We could
clean this up in the same patch.
With or without the changes:
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
^ permalink raw reply [flat|nested] 32+ messages in thread
* RE: [PATCH v2 01/13] block/stream: Remove redundant statement in stream_run()
2020-02-26 9:51 ` Kevin Wolf
@ 2020-02-26 10:21 ` Chenqun (kuhn)
2020-02-26 10:36 ` Kevin Wolf
0 siblings, 1 reply; 32+ messages in thread
From: Chenqun (kuhn) @ 2020-02-26 10:21 UTC (permalink / raw)
To: Kevin Wolf, John Snow
Cc: peter.maydell, Zhanghailiang, qemu-trivial, qemu-devel,
Max Reitz, Euler Robot
>-----Original Message-----
>From: Kevin Wolf [mailto:kwolf@redhat.com]
>Sent: Wednesday, February 26, 2020 5:51 PM
>To: Chenqun (kuhn) <kuhn.chenqun@huawei.com>
>Cc: qemu-devel@nongnu.org; qemu-trivial@nongnu.org;
>peter.maydell@linaro.org; Zhanghailiang <zhang.zhanghailiang@huawei.com>;
>Euler Robot <euler.robot@huawei.com>; John Snow <jsnow@redhat.com>;
>Max Reitz <mreitz@redhat.com>
>Subject: Re: [PATCH v2 01/13] block/stream: Remove redundant statement in
>stream_run()
>
>Am 26.02.2020 um 09:46 hat kuhn.chenqun@huawei.com geschrieben:
>> From: Chen Qun <kuhn.chenqun@huawei.com>
>>
>> Clang static code analyzer show warning:
>> block/stream.c:186:9: warning: Value stored to 'ret' is never read
>> ret = 0;
>> ^ ~
>> Reported-by: Euler Robot <euler.robot@huawei.com>
>> Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
>> Reviewed-by: John Snow <jsnow@redhat.com>
>
>Let's mention that this is unnecessary since commit 1d809098aa9.
>
>Since the same commit, the initialisation 'int ret = 0;' is unnecessary because
>we never read ret before overwriting the initial value. We could clean this up
>in the same patch.
Yes, we can clean it and move 'ret' declaration to the for() statement.
Modify just Like this：
@@ -114,7 +114,6 @@ static int coroutine_fn stream_run(Job *job, Error **errp)
int64_t offset = 0;
uint64_t delay_ns = 0;
int error = 0;
- int ret = 0;
int64_t n = 0; /* bytes */
if (bs == s->bottom) {
@@ -139,6 +138,7 @@ static int coroutine_fn stream_run(Job *job, Error **errp)
for ( ; offset < len; offset += n) {
bool copy;
+ int ret;
/* Note that even when no rate limit is applied we need to yield
* with no pending I/O here so that bdrv_drain_all() returns.
@@ -183,7 +183,6 @@ static int coroutine_fn stream_run(Job *job, Error **errp)
break;
}
}
- ret = 0;
/* Publish progress */
job_progress_update(&s->common.job, n);
>
>With or without the changes:
>
>Reviewed-by: Kevin Wolf <kwolf@redhat.com>
^ permalink raw reply [flat|nested] 32+ messages in thread* Re: [PATCH v2 01/13] block/stream: Remove redundant statement in stream_run()
2020-02-26 10:21 ` Chenqun (kuhn)
@ 2020-02-26 10:36 ` Kevin Wolf
2020-02-26 10:41 ` Chenqun (kuhn)
0 siblings, 1 reply; 32+ messages in thread
From: Kevin Wolf @ 2020-02-26 10:36 UTC (permalink / raw)
To: Chenqun (kuhn)
Cc: peter.maydell, Zhanghailiang, qemu-trivial, qemu-devel,
Max Reitz, Euler Robot, John Snow
Am 26.02.2020 um 11:21 hat Chenqun (kuhn) geschrieben:
>
>
> >-----Original Message-----
> >From: Kevin Wolf [mailto:kwolf@redhat.com]
> >Sent: Wednesday, February 26, 2020 5:51 PM
> >To: Chenqun (kuhn) <kuhn.chenqun@huawei.com>
> >Cc: qemu-devel@nongnu.org; qemu-trivial@nongnu.org;
> >peter.maydell@linaro.org; Zhanghailiang <zhang.zhanghailiang@huawei.com>;
> >Euler Robot <euler.robot@huawei.com>; John Snow <jsnow@redhat.com>;
> >Max Reitz <mreitz@redhat.com>
> >Subject: Re: [PATCH v2 01/13] block/stream: Remove redundant statement in
> >stream_run()
> >
> >Am 26.02.2020 um 09:46 hat kuhn.chenqun@huawei.com geschrieben:
> >> From: Chen Qun <kuhn.chenqun@huawei.com>
> >>
> >> Clang static code analyzer show warning:
> >> block/stream.c:186:9: warning: Value stored to 'ret' is never read
> >> ret = 0;
> >> ^ ~
> >> Reported-by: Euler Robot <euler.robot@huawei.com>
> >> Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
> >> Reviewed-by: John Snow <jsnow@redhat.com>
> >
> >Let's mention that this is unnecessary since commit 1d809098aa9.
> >
> >Since the same commit, the initialisation 'int ret = 0;' is unnecessary because
> >we never read ret before overwriting the initial value. We could clean this up
> >in the same patch.
>
> Yes, we can clean it and move 'ret' declaration to the for() statement.
>
> Modify just Like this：
> [...]
Godd point, makes sense to me. Please keep my R-b if you make this
change.
Kevin
> @@ -114,7 +114,6 @@ static int coroutine_fn stream_run(Job *job, Error **errp)
> int64_t offset = 0;
> uint64_t delay_ns = 0;
> int error = 0;
> - int ret = 0;
> int64_t n = 0; /* bytes */
>
> if (bs == s->bottom) {
> @@ -139,6 +138,7 @@ static int coroutine_fn stream_run(Job *job, Error **errp)
>
> for ( ; offset < len; offset += n) {
> bool copy;
> + int ret;
>
> /* Note that even when no rate limit is applied we need to yield
> * with no pending I/O here so that bdrv_drain_all() returns.
> @@ -183,7 +183,6 @@ static int coroutine_fn stream_run(Job *job, Error **errp)
> break;
> }
> }
> - ret = 0;
>
> /* Publish progress */
> job_progress_update(&s->common.job, n);
>
> >
> >With or without the changes:
> >
> >Reviewed-by: Kevin Wolf <kwolf@redhat.com>
>
^ permalink raw reply [flat|nested] 32+ messages in thread* RE: [PATCH v2 01/13] block/stream: Remove redundant statement in stream_run()
2020-02-26 10:36 ` Kevin Wolf
@ 2020-02-26 10:41 ` Chenqun (kuhn)
0 siblings, 0 replies; 32+ messages in thread
From: Chenqun (kuhn) @ 2020-02-26 10:41 UTC (permalink / raw)
To: Kevin Wolf
Cc: peter.maydell, Zhanghailiang, qemu-trivial, qemu-devel,
Max Reitz, Euler Robot, John Snow
>-----Original Message-----
>From: Kevin Wolf [mailto:kwolf@redhat.com]
>Sent: Wednesday, February 26, 2020 6:36 PM
>To: Chenqun (kuhn) <kuhn.chenqun@huawei.com>
>Cc: John Snow <jsnow@redhat.com>; qemu-devel@nongnu.org; qemu-
>trivial@nongnu.org; peter.maydell@linaro.org; Zhanghailiang
><zhang.zhanghailiang@huawei.com>; Euler Robot
><euler.robot@huawei.com>; Max Reitz <mreitz@redhat.com>
>Subject: Re: [PATCH v2 01/13] block/stream: Remove redundant statement in
>stream_run()
>
>Am 26.02.2020 um 11:21 hat Chenqun (kuhn) geschrieben:
>>
>>
>> >-----Original Message-----
>> >From: Kevin Wolf [mailto:kwolf@redhat.com]
>> >Sent: Wednesday, February 26, 2020 5:51 PM
>> >To: Chenqun (kuhn) <kuhn.chenqun@huawei.com>
>> >Cc: qemu-devel@nongnu.org; qemu-trivial@nongnu.org;
>> >peter.maydell@linaro.org; Zhanghailiang
>> ><zhang.zhanghailiang@huawei.com>; Euler Robot
>> ><euler.robot@huawei.com>; John Snow <jsnow@redhat.com>; Max Reitz
>> ><mreitz@redhat.com>
>> >Subject: Re: [PATCH v2 01/13] block/stream: Remove redundant
>> >statement in
>> >stream_run()
>> >
>> >Am 26.02.2020 um 09:46 hat kuhn.chenqun@huawei.com geschrieben:
>> >> From: Chen Qun <kuhn.chenqun@huawei.com>
>> >>
>> >> Clang static code analyzer show warning:
>> >> block/stream.c:186:9: warning: Value stored to 'ret' is never read
>> >> ret = 0;
>> >> ^ ~
>> >> Reported-by: Euler Robot <euler.robot@huawei.com>
>> >> Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
>> >> Reviewed-by: John Snow <jsnow@redhat.com>
>> >
>> >Let's mention that this is unnecessary since commit 1d809098aa9.
>> >
>> >Since the same commit, the initialisation 'int ret = 0;' is
>> >unnecessary because we never read ret before overwriting the initial
>> >value. We could clean this up in the same patch.
>>
>> Yes, we can clean it and move 'ret' declaration to the for() statement.
>>
>> Modify just Like this：
>> [...]
>
>Godd point, makes sense to me. Please keep my R-b if you make this change.
OK, no problem！
Thanks.
>
>Kevin
>
>> @@ -114,7 +114,6 @@ static int coroutine_fn stream_run(Job *job, Error
>**errp)
>> int64_t offset = 0;
>> uint64_t delay_ns = 0;
>> int error = 0;
>> - int ret = 0;
>> int64_t n = 0; /* bytes */
>>
>> if (bs == s->bottom) {
>> @@ -139,6 +138,7 @@ static int coroutine_fn stream_run(Job *job, Error
>> **errp)
>>
>> for ( ; offset < len; offset += n) {
>> bool copy;
>> + int ret;
>>
>> /* Note that even when no rate limit is applied we need to yield
>> * with no pending I/O here so that bdrv_drain_all() returns.
>> @@ -183,7 +183,6 @@ static int coroutine_fn stream_run(Job *job, Error
>**errp)
>> break;
>> }
>> }
>> - ret = 0;
>>
>> /* Publish progress */
>> job_progress_update(&s->common.job, n);
>>
>> >
>> >With or without the changes:
>> >
>> >Reviewed-by: Kevin Wolf <kwolf@redhat.com>
>>
^ permalink raw reply [flat|nested] 32+ messages in thread
* [PATCH v2 02/13] block/iscsi:Remove redundant statement in iscsi_open()
2020-02-26 8:46 [PATCH v2 00/13] redundant code: Fix warnings reported by Clang static code analyzer kuhn.chenqun
2020-02-26 8:46 ` [PATCH v2 01/13] block/stream: Remove redundant statement in stream_run() kuhn.chenqun
@ 2020-02-26 8:46 ` kuhn.chenqun
2020-02-26 9:54 ` Kevin Wolf
2020-02-26 8:46 ` [PATCH v2 03/13] block/file-posix: Remove redundant statement in raw_handle_perm_lock() kuhn.chenqun
` (10 subsequent siblings)
12 siblings, 1 reply; 32+ messages in thread
From: kuhn.chenqun @ 2020-02-26 8:46 UTC (permalink / raw)
To: qemu-devel, qemu-trivial
Cc: Kevin Wolf, peter.maydell, zhang.zhanghailiang, Chen Qun,
Peter Lieven, Max Reitz, Ronnie Sahlberg, Euler Robot,
Paolo Bonzini
From: Chen Qun <kuhn.chenqun@huawei.com>
Clang static code analyzer show warning:
block/iscsi.c:1920:9: warning: Value stored to 'flags' is never read
flags &= ~BDRV_O_RDWR;
^ ~~~~~~~~~~~~
Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
---
Cc: Ronnie Sahlberg <ronniesahlberg@gmail.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Peter Lieven <pl@kamp.de>
Cc: Kevin Wolf <kwolf@redhat.com>
Cc: Max Reitz <mreitz@redhat.com>
---
block/iscsi.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/block/iscsi.c b/block/iscsi.c
index 682abd8e09..ed88479ede 100644
--- a/block/iscsi.c
+++ b/block/iscsi.c
@@ -1917,7 +1917,6 @@ static int iscsi_open(BlockDriverState *bs, QDict *options, int flags,
if (ret < 0) {
goto out;
}
- flags &= ~BDRV_O_RDWR;
}
iscsi_readcapacity_sync(iscsilun, &local_err);
--
2.23.0
^ permalink raw reply related [flat|nested] 32+ messages in thread* Re: [PATCH v2 02/13] block/iscsi:Remove redundant statement in iscsi_open()
2020-02-26 8:46 ` [PATCH v2 02/13] block/iscsi:Remove redundant statement in iscsi_open() kuhn.chenqun
@ 2020-02-26 9:54 ` Kevin Wolf
2020-02-27 1:49 ` Chenqun (kuhn)
0 siblings, 1 reply; 32+ messages in thread
From: Kevin Wolf @ 2020-02-26 9:54 UTC (permalink / raw)
To: kuhn.chenqun
Cc: peter.maydell, zhang.zhanghailiang, qemu-trivial, Peter Lieven,
qemu-devel, Max Reitz, Ronnie Sahlberg, Euler Robot,
Paolo Bonzini
Am 26.02.2020 um 09:46 hat kuhn.chenqun@huawei.com geschrieben:
> From: Chen Qun <kuhn.chenqun@huawei.com>
>
> Clang static code analyzer show warning:
> block/iscsi.c:1920:9: warning: Value stored to 'flags' is never read
> flags &= ~BDRV_O_RDWR;
> ^ ~~~~~~~~~~~~
>
> Reported-by: Euler Robot <euler.robot@huawei.com>
> Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
Hmm, I'm not so sure about this one because if we remove the line, flags
will be inconsistent with bs->open_flags. It feels like setting a trap
for anyone who wants to add code using flags in the future.
Kevin
> Cc: Ronnie Sahlberg <ronniesahlberg@gmail.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Peter Lieven <pl@kamp.de>
> Cc: Kevin Wolf <kwolf@redhat.com>
> Cc: Max Reitz <mreitz@redhat.com>
> ---
> block/iscsi.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/block/iscsi.c b/block/iscsi.c
> index 682abd8e09..ed88479ede 100644
> --- a/block/iscsi.c
> +++ b/block/iscsi.c
> @@ -1917,7 +1917,6 @@ static int iscsi_open(BlockDriverState *bs, QDict *options, int flags,
> if (ret < 0) {
> goto out;
> }
> - flags &= ~BDRV_O_RDWR;
> }
>
> iscsi_readcapacity_sync(iscsilun, &local_err);
> --
> 2.23.0
>
>
^ permalink raw reply [flat|nested] 32+ messages in thread* RE: [PATCH v2 02/13] block/iscsi:Remove redundant statement in iscsi_open()
2020-02-26 9:54 ` Kevin Wolf
@ 2020-02-27 1:49 ` Chenqun (kuhn)
2020-02-27 10:30 ` Kevin Wolf
0 siblings, 1 reply; 32+ messages in thread
From: Chenqun (kuhn) @ 2020-02-27 1:49 UTC (permalink / raw)
To: Kevin Wolf
Cc: peter.maydell, Zhanghailiang, qemu-trivial, Peter Lieven,
qemu-devel, Max Reitz, Ronnie Sahlberg, Euler Robot,
Paolo Bonzini
>-----Original Message-----
>From: Kevin Wolf [mailto:kwolf@redhat.com]
>Sent: Wednesday, February 26, 2020 5:55 PM
>To: Chenqun (kuhn) <kuhn.chenqun@huawei.com>
>Cc: qemu-devel@nongnu.org; qemu-trivial@nongnu.org;
>peter.maydell@linaro.org; Zhanghailiang <zhang.zhanghailiang@huawei.com>;
>Euler Robot <euler.robot@huawei.com>; Ronnie Sahlberg
><ronniesahlberg@gmail.com>; Paolo Bonzini <pbonzini@redhat.com>; Peter
>Lieven <pl@kamp.de>; Max Reitz <mreitz@redhat.com>
>Subject: Re: [PATCH v2 02/13] block/iscsi:Remove redundant statement in
>iscsi_open()
>
>Am 26.02.2020 um 09:46 hat kuhn.chenqun@huawei.com geschrieben:
>> From: Chen Qun <kuhn.chenqun@huawei.com>
>>
>> Clang static code analyzer show warning:
>> block/iscsi.c:1920:9: warning: Value stored to 'flags' is never read
>> flags &= ~BDRV_O_RDWR;
>> ^ ~~~~~~~~~~~~
>>
>> Reported-by: Euler Robot <euler.robot@huawei.com>
>> Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
>
>Hmm, I'm not so sure about this one because if we remove the line, flags will
>be inconsistent with bs->open_flags. It feels like setting a trap for anyone
>who wants to add code using flags in the future.
Hi Kevin,
I find it exists since 8f3bf50d34037266. : )
It's not a big deal, just upset clang static code analyzer.
As you said, it could be a trap for the future.
It ’s okay, whether it exists or not.
Thanks.
>
>Kevin
>
>> Cc: Ronnie Sahlberg <ronniesahlberg@gmail.com>
>> Cc: Paolo Bonzini <pbonzini@redhat.com>
>> Cc: Peter Lieven <pl@kamp.de>
>> Cc: Kevin Wolf <kwolf@redhat.com>
>> Cc: Max Reitz <mreitz@redhat.com>
>> ---
>> block/iscsi.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/block/iscsi.c b/block/iscsi.c index
>> 682abd8e09..ed88479ede 100644
>> --- a/block/iscsi.c
>> +++ b/block/iscsi.c
>> @@ -1917,7 +1917,6 @@ static int iscsi_open(BlockDriverState *bs, QDict
>*options, int flags,
>> if (ret < 0) {
>> goto out;
>> }
>> - flags &= ~BDRV_O_RDWR;
>> }
>>
>> iscsi_readcapacity_sync(iscsilun, &local_err);
>> --
>> 2.23.0
>>
>>
^ permalink raw reply [flat|nested] 32+ messages in thread* Re: [PATCH v2 02/13] block/iscsi:Remove redundant statement in iscsi_open()
2020-02-27 1:49 ` Chenqun (kuhn)
@ 2020-02-27 10:30 ` Kevin Wolf
2020-02-27 11:28 ` Chenqun (kuhn)
2020-02-28 7:30 ` Chenqun (kuhn)
0 siblings, 2 replies; 32+ messages in thread
From: Kevin Wolf @ 2020-02-27 10:30 UTC (permalink / raw)
To: Chenqun (kuhn)
Cc: peter.maydell, Zhanghailiang, qemu-trivial, Peter Lieven,
qemu-devel, Max Reitz, Ronnie Sahlberg, Euler Robot,
Paolo Bonzini
Am 27.02.2020 um 02:49 hat Chenqun (kuhn) geschrieben:
> >-----Original Message-----
> >From: Kevin Wolf [mailto:kwolf@redhat.com]
> >Sent: Wednesday, February 26, 2020 5:55 PM
> >To: Chenqun (kuhn) <kuhn.chenqun@huawei.com>
> >Cc: qemu-devel@nongnu.org; qemu-trivial@nongnu.org;
> >peter.maydell@linaro.org; Zhanghailiang <zhang.zhanghailiang@huawei.com>;
> >Euler Robot <euler.robot@huawei.com>; Ronnie Sahlberg
> ><ronniesahlberg@gmail.com>; Paolo Bonzini <pbonzini@redhat.com>; Peter
> >Lieven <pl@kamp.de>; Max Reitz <mreitz@redhat.com>
> >Subject: Re: [PATCH v2 02/13] block/iscsi:Remove redundant statement in
> >iscsi_open()
> >
> >Am 26.02.2020 um 09:46 hat kuhn.chenqun@huawei.com geschrieben:
> >> From: Chen Qun <kuhn.chenqun@huawei.com>
> >>
> >> Clang static code analyzer show warning:
> >> block/iscsi.c:1920:9: warning: Value stored to 'flags' is never read
> >> flags &= ~BDRV_O_RDWR;
> >> ^ ~~~~~~~~~~~~
> >>
> >> Reported-by: Euler Robot <euler.robot@huawei.com>
> >> Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
> >
> >Hmm, I'm not so sure about this one because if we remove the line, flags will
> >be inconsistent with bs->open_flags. It feels like setting a trap for anyone
> >who wants to add code using flags in the future.
> Hi Kevin,
> I find it exists since 8f3bf50d34037266. : )
Yes, it has existed from the start with auto-read-only.
> It's not a big deal, just upset clang static code analyzer.
> As you said, it could be a trap for the future.
What's interesting is that we do have one user of the flags later in the
function, but it uses bs->open_flags instead:
ret = iscsi_allocmap_init(iscsilun, bs->open_flags);
Maybe this should be using flags? (The value of the bits we're
interested in is the same, but when flags is passed as a parameter, I
would expect it to be used.)
Kevin
^ permalink raw reply [flat|nested] 32+ messages in thread* RE: [PATCH v2 02/13] block/iscsi:Remove redundant statement in iscsi_open()
2020-02-27 10:30 ` Kevin Wolf
@ 2020-02-27 11:28 ` Chenqun (kuhn)
2020-02-28 7:30 ` Chenqun (kuhn)
1 sibling, 0 replies; 32+ messages in thread
From: Chenqun (kuhn) @ 2020-02-27 11:28 UTC (permalink / raw)
To: Kevin Wolf
Cc: peter.maydell, Zhanghailiang, qemu-trivial, Peter Lieven,
qemu-devel, Max Reitz, Ronnie Sahlberg, Euler Robot,
Paolo Bonzini
>-----Original Message-----
>From: Kevin Wolf [mailto:kwolf@redhat.com]
>Sent: Thursday, February 27, 2020 6:31 PM
>To: Chenqun (kuhn) <kuhn.chenqun@huawei.com>
>Cc: qemu-devel@nongnu.org; qemu-trivial@nongnu.org;
>peter.maydell@linaro.org; Zhanghailiang <zhang.zhanghailiang@huawei.com>;
>Euler Robot <euler.robot@huawei.com>; Ronnie Sahlberg
><ronniesahlberg@gmail.com>; Paolo Bonzini <pbonzini@redhat.com>; Peter
>Lieven <pl@kamp.de>; Max Reitz <mreitz@redhat.com>
>Subject: Re: [PATCH v2 02/13] block/iscsi:Remove redundant statement in
>iscsi_open()
>
>Am 27.02.2020 um 02:49 hat Chenqun (kuhn) geschrieben:
>> >-----Original Message-----
>> >From: Kevin Wolf [mailto:kwolf@redhat.com]
>> >Sent: Wednesday, February 26, 2020 5:55 PM
>> >To: Chenqun (kuhn) <kuhn.chenqun@huawei.com>
>> >Cc: qemu-devel@nongnu.org; qemu-trivial@nongnu.org;
>> >peter.maydell@linaro.org; Zhanghailiang
>> ><zhang.zhanghailiang@huawei.com>; Euler Robot
>> ><euler.robot@huawei.com>; Ronnie Sahlberg
><ronniesahlberg@gmail.com>;
>> >Paolo Bonzini <pbonzini@redhat.com>; Peter Lieven <pl@kamp.de>; Max
>> >Reitz <mreitz@redhat.com>
>> >Subject: Re: [PATCH v2 02/13] block/iscsi:Remove redundant statement
>> >in
>> >iscsi_open()
>> >
>> >Am 26.02.2020 um 09:46 hat kuhn.chenqun@huawei.com geschrieben:
>> >> From: Chen Qun <kuhn.chenqun@huawei.com>
>> >>
>> >> Clang static code analyzer show warning:
>> >> block/iscsi.c:1920:9: warning: Value stored to 'flags' is never read
>> >> flags &= ~BDRV_O_RDWR;
>> >> ^ ~~~~~~~~~~~~
>> >>
>> >> Reported-by: Euler Robot <euler.robot@huawei.com>
>> >> Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
>> >
>> >Hmm, I'm not so sure about this one because if we remove the line,
>> >flags will be inconsistent with bs->open_flags. It feels like setting
>> >a trap for anyone who wants to add code using flags in the future.
>> Hi Kevin,
>> I find it exists since 8f3bf50d34037266. : )
>
>Yes, it has existed from the start with auto-read-only.
>
>> It's not a big deal, just upset clang static code analyzer.
>> As you said, it could be a trap for the future.
>
>What's interesting is that we do have one user of the flags later in the function,
>but it uses bs->open_flags instead:
>
> ret = iscsi_allocmap_init(iscsilun, bs->open_flags);
>
Good point, I think this is exactly where the 'flags' are needed now.
It should be right to keep it for the future, too.
Later version, I will modify it.
Thanks.
>
>Maybe this should be using flags? (The value of the bits we're interested in is
>the same, but when flags is passed as a parameter, I would expect it to be
>used.)
^ permalink raw reply [flat|nested] 32+ messages in thread
* RE: [PATCH v2 02/13] block/iscsi:Remove redundant statement in iscsi_open()
2020-02-27 10:30 ` Kevin Wolf
2020-02-27 11:28 ` Chenqun (kuhn)
@ 2020-02-28 7:30 ` Chenqun (kuhn)
2020-02-28 10:55 ` Kevin Wolf
1 sibling, 1 reply; 32+ messages in thread
From: Chenqun (kuhn) @ 2020-02-28 7:30 UTC (permalink / raw)
To: Kevin Wolf
Cc: peter.maydell, Zhanghailiang, qemu-trivial, Peter Lieven,
qemu-devel, Max Reitz, Ronnie Sahlberg, Euler Robot,
Paolo Bonzini
>-----Original Message-----
>From: Kevin Wolf [mailto:kwolf@redhat.com]
>Sent: Thursday, February 27, 2020 6:31 PM
>To: Chenqun (kuhn) <kuhn.chenqun@huawei.com>
>Cc: qemu-devel@nongnu.org; qemu-trivial@nongnu.org;
>peter.maydell@linaro.org; Zhanghailiang <zhang.zhanghailiang@huawei.com>;
>Euler Robot <euler.robot@huawei.com>; Ronnie Sahlberg
><ronniesahlberg@gmail.com>; Paolo Bonzini <pbonzini@redhat.com>; Peter
>Lieven <pl@kamp.de>; Max Reitz <mreitz@redhat.com>
>Subject: Re: [PATCH v2 02/13] block/iscsi:Remove redundant statement in
>iscsi_open()
>
>Am 27.02.2020 um 02:49 hat Chenqun (kuhn) geschrieben:
>> >-----Original Message-----
>> >From: Kevin Wolf [mailto:kwolf@redhat.com]
>> >Sent: Wednesday, February 26, 2020 5:55 PM
>> >To: Chenqun (kuhn) <kuhn.chenqun@huawei.com>
>> >Cc: qemu-devel@nongnu.org; qemu-trivial@nongnu.org;
>> >peter.maydell@linaro.org; Zhanghailiang
>> ><zhang.zhanghailiang@huawei.com>; Euler Robot
>> ><euler.robot@huawei.com>; Ronnie Sahlberg
><ronniesahlberg@gmail.com>;
>> >Paolo Bonzini <pbonzini@redhat.com>; Peter Lieven <pl@kamp.de>; Max
>> >Reitz <mreitz@redhat.com>
>> >Subject: Re: [PATCH v2 02/13] block/iscsi:Remove redundant statement
>> >in
>> >iscsi_open()
>> >
>> >Am 26.02.2020 um 09:46 hat kuhn.chenqun@huawei.com geschrieben:
>> >> From: Chen Qun <kuhn.chenqun@huawei.com>
>> >>
>> >> Clang static code analyzer show warning:
>> >> block/iscsi.c:1920:9: warning: Value stored to 'flags' is never read
>> >> flags &= ~BDRV_O_RDWR;
>> >> ^ ~~~~~~~~~~~~
>> >>
>> >> Reported-by: Euler Robot <euler.robot@huawei.com>
>> >> Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
>> >
>> >Hmm, I'm not so sure about this one because if we remove the line,
>> >flags will be inconsistent with bs->open_flags. It feels like setting
>> >a trap for anyone who wants to add code using flags in the future.
>> Hi Kevin,
>> I find it exists since 8f3bf50d34037266. : )
>
>Yes, it has existed from the start with auto-read-only.
>
>> It's not a big deal, just upset clang static code analyzer.
>> As you said, it could be a trap for the future.
>
>What's interesting is that we do have one user of the flags later in the function,
>but it uses bs->open_flags instead:
>
> ret = iscsi_allocmap_init(iscsilun, bs->open_flags);
>
>Maybe this should be using flags? (The value of the bits we're interested in is
>the same, but when flags is passed as a parameter, I would expect it to be
>used.)
>
Hi Kevin,
I have a question: are 'flags' exactly the same as 'bs-> open_flags'?
In the function bdrv_open_common() at block.c file, the existence of statement( open_flags = bdrv_open_flags(bs, bs->open_flags); ) makes them a little different.
Will this place affect them inconsistently ?
Is it safer if we assign bs-> open_flags to flags?
Modify just like：
@@ -1917,7 +1917,7 @@ static int iscsi_open(BlockDriverState *bs, QDict *options, int flags,
if (ret < 0) {
goto out;
}
- flags &= ~BDRV_O_RDWR;
+ flags = bs->open_flags;
}
iscsi_readcapacity_sync(iscsilun, &local_err);
@@ -2002,7 +2002,7 @@ static int iscsi_open(BlockDriverState *bs, QDict *options, int flags,
iscsilun->cluster_size = iscsilun->bl.opt_unmap_gran *
iscsilun->block_size;
if (iscsilun->lbprz) {
- ret = iscsi_allocmap_init(iscsilun, bs->open_flags);
+ ret = iscsi_allocmap_init(iscsilun, flags);
}
}
Thanks.
^ permalink raw reply [flat|nested] 32+ messages in thread* Re: [PATCH v2 02/13] block/iscsi:Remove redundant statement in iscsi_open()
2020-02-28 7:30 ` Chenqun (kuhn)
@ 2020-02-28 10:55 ` Kevin Wolf
2020-02-29 2:21 ` Chenqun (kuhn)
0 siblings, 1 reply; 32+ messages in thread
From: Kevin Wolf @ 2020-02-28 10:55 UTC (permalink / raw)
To: Chenqun (kuhn)
Cc: peter.maydell, Zhanghailiang, qemu-trivial, Peter Lieven,
qemu-devel, Max Reitz, Ronnie Sahlberg, Euler Robot,
Paolo Bonzini
Am 28.02.2020 um 08:30 hat Chenqun (kuhn) geschrieben:
> >-----Original Message-----
> >From: Kevin Wolf [mailto:kwolf@redhat.com]
> >Sent: Thursday, February 27, 2020 6:31 PM
> >To: Chenqun (kuhn) <kuhn.chenqun@huawei.com>
> >Cc: qemu-devel@nongnu.org; qemu-trivial@nongnu.org;
> >peter.maydell@linaro.org; Zhanghailiang <zhang.zhanghailiang@huawei.com>;
> >Euler Robot <euler.robot@huawei.com>; Ronnie Sahlberg
> ><ronniesahlberg@gmail.com>; Paolo Bonzini <pbonzini@redhat.com>; Peter
> >Lieven <pl@kamp.de>; Max Reitz <mreitz@redhat.com>
> >Subject: Re: [PATCH v2 02/13] block/iscsi:Remove redundant statement in
> >iscsi_open()
> >
> >Am 27.02.2020 um 02:49 hat Chenqun (kuhn) geschrieben:
> >> >-----Original Message-----
> >> >From: Kevin Wolf [mailto:kwolf@redhat.com]
> >> >Sent: Wednesday, February 26, 2020 5:55 PM
> >> >To: Chenqun (kuhn) <kuhn.chenqun@huawei.com>
> >> >Cc: qemu-devel@nongnu.org; qemu-trivial@nongnu.org;
> >> >peter.maydell@linaro.org; Zhanghailiang
> >> ><zhang.zhanghailiang@huawei.com>; Euler Robot
> >> ><euler.robot@huawei.com>; Ronnie Sahlberg
> ><ronniesahlberg@gmail.com>;
> >> >Paolo Bonzini <pbonzini@redhat.com>; Peter Lieven <pl@kamp.de>; Max
> >> >Reitz <mreitz@redhat.com>
> >> >Subject: Re: [PATCH v2 02/13] block/iscsi:Remove redundant statement
> >> >in
> >> >iscsi_open()
> >> >
> >> >Am 26.02.2020 um 09:46 hat kuhn.chenqun@huawei.com geschrieben:
> >> >> From: Chen Qun <kuhn.chenqun@huawei.com>
> >> >>
> >> >> Clang static code analyzer show warning:
> >> >> block/iscsi.c:1920:9: warning: Value stored to 'flags' is never read
> >> >> flags &= ~BDRV_O_RDWR;
> >> >> ^ ~~~~~~~~~~~~
> >> >>
> >> >> Reported-by: Euler Robot <euler.robot@huawei.com>
> >> >> Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
> >> >
> >> >Hmm, I'm not so sure about this one because if we remove the line,
> >> >flags will be inconsistent with bs->open_flags. It feels like setting
> >> >a trap for anyone who wants to add code using flags in the future.
> >> Hi Kevin,
> >> I find it exists since 8f3bf50d34037266. : )
> >
> >Yes, it has existed from the start with auto-read-only.
> >
> >> It's not a big deal, just upset clang static code analyzer.
> >> As you said, it could be a trap for the future.
> >
> >What's interesting is that we do have one user of the flags later in the function,
> >but it uses bs->open_flags instead:
> >
> > ret = iscsi_allocmap_init(iscsilun, bs->open_flags);
> >
> >Maybe this should be using flags? (The value of the bits we're interested in is
> >the same, but when flags is passed as a parameter, I would expect it to be
> >used.)
> >
> Hi Kevin,
> I have a question: are 'flags' exactly the same as 'bs-> open_flags'?
> In the function bdrv_open_common() at block.c file, the existence of statement( open_flags = bdrv_open_flags(bs, bs->open_flags); ) makes them a little different.
> Will this place affect them inconsistently ?
Not exactly the same, that's why I said "value of the bits we're
interested in is the same". bdrv_open_flags() basically just filters out
things that are handled by the generic block layer and none of the block
driver's business.
To be precise, iscsi_allocmap_init() only checks BDRV_O_NOCACHE, which
is the same in both.
> Is it safer if we assign bs-> open_flags to flags?
This would add back the flags that we consciously filtered out before,
so I would say no.
Kevin
> Modify just like：
> @@ -1917,7 +1917,7 @@ static int iscsi_open(BlockDriverState *bs, QDict *options, int flags,
> if (ret < 0) {
> goto out;
> }
> - flags &= ~BDRV_O_RDWR;
> + flags = bs->open_flags;
> }
>
> iscsi_readcapacity_sync(iscsilun, &local_err);
> @@ -2002,7 +2002,7 @@ static int iscsi_open(BlockDriverState *bs, QDict *options, int flags,
> iscsilun->cluster_size = iscsilun->bl.opt_unmap_gran *
> iscsilun->block_size;
> if (iscsilun->lbprz) {
> - ret = iscsi_allocmap_init(iscsilun, bs->open_flags);
> + ret = iscsi_allocmap_init(iscsilun, flags);
> }
> }
>
> Thanks.
>
>
>
^ permalink raw reply [flat|nested] 32+ messages in thread* RE: [PATCH v2 02/13] block/iscsi:Remove redundant statement in iscsi_open()
2020-02-28 10:55 ` Kevin Wolf
@ 2020-02-29 2:21 ` Chenqun (kuhn)
0 siblings, 0 replies; 32+ messages in thread
From: Chenqun (kuhn) @ 2020-02-29 2:21 UTC (permalink / raw)
To: Kevin Wolf
Cc: peter.maydell, Zhanghailiang, qemu-trivial, Peter Lieven,
qemu-devel, Max Reitz, Ronnie Sahlberg, Euler Robot,
Paolo Bonzini
>-----Original Message-----
>From: Kevin Wolf [mailto:kwolf@redhat.com]
>Sent: Friday, February 28, 2020 6:55 PM
>To: Chenqun (kuhn) <kuhn.chenqun@huawei.com>
>Cc: qemu-devel@nongnu.org; qemu-trivial@nongnu.org;
>peter.maydell@linaro.org; Zhanghailiang <zhang.zhanghailiang@huawei.com>;
>Euler Robot <euler.robot@huawei.com>; Ronnie Sahlberg
><ronniesahlberg@gmail.com>; Paolo Bonzini <pbonzini@redhat.com>; Peter
>Lieven <pl@kamp.de>; Max Reitz <mreitz@redhat.com>
>Subject: Re: [PATCH v2 02/13] block/iscsi:Remove redundant statement in
>iscsi_open()
>
>Am 28.02.2020 um 08:30 hat Chenqun (kuhn) geschrieben:
>> >-----Original Message-----
>> >From: Kevin Wolf [mailto:kwolf@redhat.com]
>> >Sent: Thursday, February 27, 2020 6:31 PM
>> >To: Chenqun (kuhn) <kuhn.chenqun@huawei.com>
>> >Cc: qemu-devel@nongnu.org; qemu-trivial@nongnu.org;
>> >peter.maydell@linaro.org; Zhanghailiang
>> ><zhang.zhanghailiang@huawei.com>; Euler Robot
>> ><euler.robot@huawei.com>; Ronnie Sahlberg
><ronniesahlberg@gmail.com>;
>> >Paolo Bonzini <pbonzini@redhat.com>; Peter Lieven <pl@kamp.de>; Max
>> >Reitz <mreitz@redhat.com>
>> >Subject: Re: [PATCH v2 02/13] block/iscsi:Remove redundant statement
>> >in
>> >iscsi_open()
>> >
>> >Am 27.02.2020 um 02:49 hat Chenqun (kuhn) geschrieben:
>> >> >-----Original Message-----
>> >> >From: Kevin Wolf [mailto:kwolf@redhat.com]
>> >> >Sent: Wednesday, February 26, 2020 5:55 PM
>> >> >To: Chenqun (kuhn) <kuhn.chenqun@huawei.com>
>> >> >Cc: qemu-devel@nongnu.org; qemu-trivial@nongnu.org;
>> >> >peter.maydell@linaro.org; Zhanghailiang
>> >> ><zhang.zhanghailiang@huawei.com>; Euler Robot
>> >> ><euler.robot@huawei.com>; Ronnie Sahlberg
>> ><ronniesahlberg@gmail.com>;
>> >> >Paolo Bonzini <pbonzini@redhat.com>; Peter Lieven <pl@kamp.de>;
>> >> >Max Reitz <mreitz@redhat.com>
>> >> >Subject: Re: [PATCH v2 02/13] block/iscsi:Remove redundant
>> >> >statement in
>> >> >iscsi_open()
>> >> >
>> >> >Am 26.02.2020 um 09:46 hat kuhn.chenqun@huawei.com geschrieben:
>> >> >> From: Chen Qun <kuhn.chenqun@huawei.com>
>> >> >>
>> >> >> Clang static code analyzer show warning:
>> >> >> block/iscsi.c:1920:9: warning: Value stored to 'flags' is never read
>> >> >> flags &= ~BDRV_O_RDWR;
>> >> >> ^ ~~~~~~~~~~~~
>> >> >>
>> >> >> Reported-by: Euler Robot <euler.robot@huawei.com>
>> >> >> Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
>> >> >
>> >> >Hmm, I'm not so sure about this one because if we remove the line,
>> >> >flags will be inconsistent with bs->open_flags. It feels like
>> >> >setting a trap for anyone who wants to add code using flags in the
>future.
>> >> Hi Kevin,
>> >> I find it exists since 8f3bf50d34037266. : )
>> >
>> >Yes, it has existed from the start with auto-read-only.
>> >
>> >> It's not a big deal, just upset clang static code analyzer.
>> >> As you said, it could be a trap for the future.
>> >
>> >What's interesting is that we do have one user of the flags later in
>> >the function, but it uses bs->open_flags instead:
>> >
>> > ret = iscsi_allocmap_init(iscsilun, bs->open_flags);
>> >
>> >Maybe this should be using flags? (The value of the bits we're
>> >interested in is the same, but when flags is passed as a parameter, I
>> >would expect it to be
>> >used.)
>> >
>> Hi Kevin,
>> I have a question: are 'flags' exactly the same as 'bs-> open_flags'?
>> In the function bdrv_open_common() at block.c file, the existence of
>statement( open_flags = bdrv_open_flags(bs, bs->open_flags); ) makes them
>a little different.
>> Will this place affect them inconsistently ?
>
>Not exactly the same, that's why I said "value of the bits we're interested in is
>the same". bdrv_open_flags() basically just filters out things that are handled
>by the generic block layer and none of the block driver's business.
>
>To be precise, iscsi_allocmap_init() only checks BDRV_O_NOCACHE, which is
>the same in both.
>
>> Is it safer if we assign bs-> open_flags to flags?
>
>This would add back the flags that we consciously filtered out before, so I
>would say no.
>
Well, I see, thank you very much for your detailed explanation!
Thanks.
^ permalink raw reply [flat|nested] 32+ messages in thread
* [PATCH v2 03/13] block/file-posix: Remove redundant statement in raw_handle_perm_lock()
2020-02-26 8:46 [PATCH v2 00/13] redundant code: Fix warnings reported by Clang static code analyzer kuhn.chenqun
2020-02-26 8:46 ` [PATCH v2 01/13] block/stream: Remove redundant statement in stream_run() kuhn.chenqun
2020-02-26 8:46 ` [PATCH v2 02/13] block/iscsi:Remove redundant statement in iscsi_open() kuhn.chenqun
@ 2020-02-26 8:46 ` kuhn.chenqun
2020-02-26 10:37 ` Kevin Wolf
2020-02-26 8:46 ` [PATCH v2 04/13] scsi/esp-pci: Remove redundant statement in esp_pci_io_write() kuhn.chenqun
` (9 subsequent siblings)
12 siblings, 1 reply; 32+ messages in thread
From: kuhn.chenqun @ 2020-02-26 8:46 UTC (permalink / raw)
To: qemu-devel, qemu-trivial
Cc: Kevin Wolf, peter.maydell, zhang.zhanghailiang, Max Reitz,
Euler Robot, Chen Qun
From: Chen Qun <kuhn.chenqun@huawei.com>
Clang static code analyzer show warning:
block/file-posix.c:891:9: warning: Value stored to 'op' is never read
op = RAW_PL_ABORT;
^ ~~~~~~~~~~~~
Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
---
Cc: Kevin Wolf <kwolf@redhat.com>
Cc: Max Reitz <mreitz@redhat.com>
---
block/file-posix.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/block/file-posix.c b/block/file-posix.c
index 6345477112..0f77447a25 100644
--- a/block/file-posix.c
+++ b/block/file-posix.c
@@ -888,7 +888,6 @@ static int raw_handle_perm_lock(BlockDriverState *bs,
"Is another process using the image [%s]?\n",
bs->filename);
}
- op = RAW_PL_ABORT;
/* fall through to unlock bytes. */
case RAW_PL_ABORT:
raw_apply_lock_bytes(s, s->fd, s->perm, ~s->shared_perm,
--
2.23.0
^ permalink raw reply related [flat|nested] 32+ messages in thread* [PATCH v2 04/13] scsi/esp-pci: Remove redundant statement in esp_pci_io_write()
2020-02-26 8:46 [PATCH v2 00/13] redundant code: Fix warnings reported by Clang static code analyzer kuhn.chenqun
` (2 preceding siblings ...)
2020-02-26 8:46 ` [PATCH v2 03/13] block/file-posix: Remove redundant statement in raw_handle_perm_lock() kuhn.chenqun
@ 2020-02-26 8:46 ` kuhn.chenqun
2020-02-26 8:46 ` [PATCH v2 05/13] scsi/scsi-disk: Remove redundant statement in scsi_disk_emulate_command() kuhn.chenqun
` (8 subsequent siblings)
12 siblings, 0 replies; 32+ messages in thread
From: kuhn.chenqun @ 2020-02-26 8:46 UTC (permalink / raw)
To: qemu-devel, qemu-trivial
Cc: peter.maydell, Euler Robot, zhang.zhanghailiang, Paolo Bonzini, Chen Qun
From: Chen Qun <kuhn.chenqun@huawei.com>
Clang static code analyzer show warning:
hw/scsi/esp-pci.c:198:9: warning: Value stored to 'size' is never read
size = 4;
^ ~
Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
---
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc:Fam Zheng <fam@euphon.net>
---
hw/scsi/esp-pci.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/scsi/esp-pci.c b/hw/scsi/esp-pci.c
index d5a1f9e017..2e6cc07d4e 100644
--- a/hw/scsi/esp-pci.c
+++ b/hw/scsi/esp-pci.c
@@ -195,7 +195,6 @@ static void esp_pci_io_write(void *opaque, hwaddr addr,
val <<= shift;
val |= current & ~(mask << shift);
addr &= ~3;
- size = 4;
}
if (addr < 0x40) {
--
2.23.0
^ permalink raw reply related [flat|nested] 32+ messages in thread* [PATCH v2 05/13] scsi/scsi-disk: Remove redundant statement in scsi_disk_emulate_command()
2020-02-26 8:46 [PATCH v2 00/13] redundant code: Fix warnings reported by Clang static code analyzer kuhn.chenqun
` (3 preceding siblings ...)
2020-02-26 8:46 ` [PATCH v2 04/13] scsi/esp-pci: Remove redundant statement in esp_pci_io_write() kuhn.chenqun
@ 2020-02-26 8:46 ` kuhn.chenqun
2020-02-26 8:46 ` [PATCH v2 06/13] display/pxa2xx_lcd: Remove redundant statement in pxa2xx_palette_parse() kuhn.chenqun
` (7 subsequent siblings)
12 siblings, 0 replies; 32+ messages in thread
From: kuhn.chenqun @ 2020-02-26 8:46 UTC (permalink / raw)
To: qemu-devel, qemu-trivial
Cc: Fam Zheng, peter.maydell, zhang.zhanghailiang, Chen Qun,
Euler Robot, Paolo Bonzini
From: Chen Qun <kuhn.chenqun@huawei.com>
Clang static code analyzer show warning:
scsi/scsi-disk.c:1918:5: warning: Value stored to 'buflen' is never read
buflen = req->cmd.xfer;
^ ~~~~~~~~~~~~~
Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
---
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Fam Zheng <fam@euphon.net>
---
hw/scsi/scsi-disk.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c
index 10d0794d60..1c0cb63a6f 100644
--- a/hw/scsi/scsi-disk.c
+++ b/hw/scsi/scsi-disk.c
@@ -1915,7 +1915,6 @@ static int32_t scsi_disk_emulate_command(SCSIRequest *req, uint8_t *buf)
r->iov.iov_base = blk_blockalign(s->qdev.conf.blk, r->buflen);
}
- buflen = req->cmd.xfer;
outbuf = r->iov.iov_base;
memset(outbuf, 0, r->buflen);
switch (req->cmd.buf[0]) {
--
2.23.0
^ permalink raw reply related [flat|nested] 32+ messages in thread* [PATCH v2 06/13] display/pxa2xx_lcd: Remove redundant statement in pxa2xx_palette_parse()
2020-02-26 8:46 [PATCH v2 00/13] redundant code: Fix warnings reported by Clang static code analyzer kuhn.chenqun
` (4 preceding siblings ...)
2020-02-26 8:46 ` [PATCH v2 05/13] scsi/scsi-disk: Remove redundant statement in scsi_disk_emulate_command() kuhn.chenqun
@ 2020-02-26 8:46 ` kuhn.chenqun
2020-02-26 8:46 ` [PATCH v2 07/13] display/exynos4210_fimd: Remove redundant statement in exynos4210_fimd_update() kuhn.chenqun
` (6 subsequent siblings)
12 siblings, 0 replies; 32+ messages in thread
From: kuhn.chenqun @ 2020-02-26 8:46 UTC (permalink / raw)
To: qemu-devel, qemu-trivial
Cc: peter.maydell, Euler Robot, zhang.zhanghailiang, Chen Qun
From: Chen Qun <kuhn.chenqun@huawei.com>
Clang static code analyzer show warning:
hw/display/pxa2xx_lcd.c:596:9: warning: Value stored to 'format' is never read
format = 0;
^ ~
Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
---
Cc: Andrzej Zaborowski <balrogg@gmail.com>
Cc: Peter Maydell <peter.maydell@linaro.org>
---
hw/display/pxa2xx_lcd.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/display/pxa2xx_lcd.c b/hw/display/pxa2xx_lcd.c
index 05f5f84671..464e93161a 100644
--- a/hw/display/pxa2xx_lcd.c
+++ b/hw/display/pxa2xx_lcd.c
@@ -593,7 +593,6 @@ static void pxa2xx_palette_parse(PXA2xxLCDState *s, int ch, int bpp)
n = 256;
break;
default:
- format = 0;
return;
}
--
2.23.0
^ permalink raw reply related [flat|nested] 32+ messages in thread* [PATCH v2 07/13] display/exynos4210_fimd: Remove redundant statement in exynos4210_fimd_update()
2020-02-26 8:46 [PATCH v2 00/13] redundant code: Fix warnings reported by Clang static code analyzer kuhn.chenqun
` (5 preceding siblings ...)
2020-02-26 8:46 ` [PATCH v2 06/13] display/pxa2xx_lcd: Remove redundant statement in pxa2xx_palette_parse() kuhn.chenqun
@ 2020-02-26 8:46 ` kuhn.chenqun
2020-02-26 8:46 ` [PATCH v2 08/13] display/blizzard: Remove redundant statement in blizzard_draw_line16_32() kuhn.chenqun
` (5 subsequent siblings)
12 siblings, 0 replies; 32+ messages in thread
From: kuhn.chenqun @ 2020-02-26 8:46 UTC (permalink / raw)
To: qemu-devel, qemu-trivial
Cc: Igor Mitsyanko, peter.maydell, Euler Robot, zhang.zhanghailiang,
Chen Qun
From: Chen Qun <kuhn.chenqun@huawei.com>
Clang static code analyzer show warning:
hw/display/exynos4210_fimd.c:1313:17: warning: Value stored to 'is_dirty' is never read
is_dirty = false;
Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
---
Cc: Igor Mitsyanko <i.mitsyanko@gmail.com>
Cc: Peter Maydell <peter.maydell@linaro.org>
---
hw/display/exynos4210_fimd.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/display/exynos4210_fimd.c b/hw/display/exynos4210_fimd.c
index c1071ecd46..05d3265b76 100644
--- a/hw/display/exynos4210_fimd.c
+++ b/hw/display/exynos4210_fimd.c
@@ -1310,7 +1310,6 @@ static void exynos4210_fimd_update(void *opaque)
}
host_fb_addr += inc_size;
fb_line_addr += inc_size;
- is_dirty = false;
}
g_free(snap);
blend = true;
--
2.23.0
^ permalink raw reply related [flat|nested] 32+ messages in thread* [PATCH v2 08/13] display/blizzard: Remove redundant statement in blizzard_draw_line16_32()
2020-02-26 8:46 [PATCH v2 00/13] redundant code: Fix warnings reported by Clang static code analyzer kuhn.chenqun
` (6 preceding siblings ...)
2020-02-26 8:46 ` [PATCH v2 07/13] display/exynos4210_fimd: Remove redundant statement in exynos4210_fimd_update() kuhn.chenqun
@ 2020-02-26 8:46 ` kuhn.chenqun
2020-02-26 8:46 ` [PATCH v2 09/13] dma/xlnx-zdma: Remove redundant statement in zdma_write_dst() kuhn.chenqun
` (4 subsequent siblings)
12 siblings, 0 replies; 32+ messages in thread
From: kuhn.chenqun @ 2020-02-26 8:46 UTC (permalink / raw)
To: qemu-devel, qemu-trivial
Cc: peter.maydell, Euler Robot, zhang.zhanghailiang, Chen Qun
From: Chen Qun <kuhn.chenqun@huawei.com>
Clang static code analyzer show warning:
hw/display/blizzard.c:940:9: warning: Value stored to 'data' is never read
data >>= 5;
^ ~
Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
---
Cc: Andrzej Zaborowski <balrogg@gmail.com>
Cc: Peter Maydell <peter.maydell@linaro.org>
---
hw/display/blizzard.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/display/blizzard.c b/hw/display/blizzard.c
index 359e399c2a..62517bdf75 100644
--- a/hw/display/blizzard.c
+++ b/hw/display/blizzard.c
@@ -937,7 +937,6 @@ static void blizzard_draw_line16_32(uint32_t *dest,
g = (data & 0x3f) << 2;
data >>= 6;
r = (data & 0x1f) << 3;
- data >>= 5;
*dest++ = rgb_to_pixel32(r, g, b);
}
}
--
2.23.0
^ permalink raw reply related [flat|nested] 32+ messages in thread* [PATCH v2 09/13] dma/xlnx-zdma: Remove redundant statement in zdma_write_dst()
2020-02-26 8:46 [PATCH v2 00/13] redundant code: Fix warnings reported by Clang static code analyzer kuhn.chenqun
` (7 preceding siblings ...)
2020-02-26 8:46 ` [PATCH v2 08/13] display/blizzard: Remove redundant statement in blizzard_draw_line16_32() kuhn.chenqun
@ 2020-02-26 8:46 ` kuhn.chenqun
2020-02-26 8:51 ` Philippe Mathieu-Daudé
` (2 more replies)
2020-02-26 8:46 ` [PATCH v2 10/13] migration/vmstate: Remove redundant statement in vmstate_save_state_v() kuhn.chenqun
` (3 subsequent siblings)
12 siblings, 3 replies; 32+ messages in thread
From: kuhn.chenqun @ 2020-02-26 8:46 UTC (permalink / raw)
To: qemu-devel, qemu-trivial
Cc: peter.maydell, zhang.zhanghailiang, Chen Qun, Alistair Francis,
Euler Robot, Edgar E. Iglesias, Philippe Mathieu-Daudé
From: Chen Qun <kuhn.chenqun@huawei.com>
Clang static code analyzer show warning:
hw/dma/xlnx-zdma.c:399:13: warning: Value stored to 'dst_type' is never read
dst_type = FIELD_EX32(s->dsc_dst.words[3], ZDMA_CH_DST_DSCR_WORD3,
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
---
Cc: Alistair Francis <alistair@alistair23.me>
Cc: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Cc: Peter Maydell <peter.maydell@linaro.org>
Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
v1->v2: move the 'dst_type' declaration.(Base on Philippe's suggestion).
---
hw/dma/xlnx-zdma.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/hw/dma/xlnx-zdma.c b/hw/dma/xlnx-zdma.c
index 8fb83f5b07..eeacad59ce 100644
--- a/hw/dma/xlnx-zdma.c
+++ b/hw/dma/xlnx-zdma.c
@@ -373,7 +373,7 @@ static uint64_t zdma_update_descr_addr(XlnxZDMA *s, bool type,
static void zdma_write_dst(XlnxZDMA *s, uint8_t *buf, uint32_t len)
{
uint32_t dst_size, dlen;
- bool dst_intr, dst_type;
+ bool dst_intr;
unsigned int ptype = ARRAY_FIELD_EX32(s->regs, ZDMA_CH_CTRL0, POINT_TYPE);
unsigned int rw_mode = ARRAY_FIELD_EX32(s->regs, ZDMA_CH_CTRL0, MODE);
unsigned int burst_type = ARRAY_FIELD_EX32(s->regs, ZDMA_CH_DATA_ATTR,
@@ -387,17 +387,17 @@ static void zdma_write_dst(XlnxZDMA *s, uint8_t *buf, uint32_t len)
while (len) {
dst_size = FIELD_EX32(s->dsc_dst.words[2], ZDMA_CH_DST_DSCR_WORD2,
SIZE);
- dst_type = FIELD_EX32(s->dsc_dst.words[3], ZDMA_CH_DST_DSCR_WORD3,
- TYPE);
if (dst_size == 0 && ptype == PT_MEM) {
uint64_t next;
+ bool dst_type = FIELD_EX32(s->dsc_dst.words[3],
+ ZDMA_CH_DST_DSCR_WORD3,
+ TYPE);
+
next = zdma_update_descr_addr(s, dst_type,
R_ZDMA_CH_DST_CUR_DSCR_LSB);
zdma_load_descriptor(s, next, &s->dsc_dst);
dst_size = FIELD_EX32(s->dsc_dst.words[2], ZDMA_CH_DST_DSCR_WORD2,
SIZE);
- dst_type = FIELD_EX32(s->dsc_dst.words[3], ZDMA_CH_DST_DSCR_WORD3,
- TYPE);
}
/* Match what hardware does by ignoring the dst_size and only using
--
2.23.0
^ permalink raw reply related [flat|nested] 32+ messages in thread* Re: [PATCH v2 09/13] dma/xlnx-zdma: Remove redundant statement in zdma_write_dst()
2020-02-26 8:46 ` [PATCH v2 09/13] dma/xlnx-zdma: Remove redundant statement in zdma_write_dst() kuhn.chenqun
@ 2020-02-26 8:51 ` Philippe Mathieu-Daudé
2020-02-26 14:15 ` Francisco Iglesias
2020-02-26 17:56 ` Alistair Francis
2 siblings, 0 replies; 32+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-02-26 8:51 UTC (permalink / raw)
To: kuhn.chenqun, qemu-devel, qemu-trivial
Cc: peter.maydell, Alistair Francis, Edgar E. Iglesias,
zhang.zhanghailiang, Euler Robot
On 2/26/20 9:46 AM, kuhn.chenqun@huawei.com wrote:
> From: Chen Qun <kuhn.chenqun@huawei.com>
>
> Clang static code analyzer show warning:
> hw/dma/xlnx-zdma.c:399:13: warning: Value stored to 'dst_type' is never read
> dst_type = FIELD_EX32(s->dsc_dst.words[3], ZDMA_CH_DST_DSCR_WORD3,
> ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Reported-by: Euler Robot <euler.robot@huawei.com>
> Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
> ---
> Cc: Alistair Francis <alistair@alistair23.me>
> Cc: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
> Cc: Peter Maydell <peter.maydell@linaro.org>
> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
>
> v1->v2: move the 'dst_type' declaration.(Base on Philippe's suggestion).
> ---
> hw/dma/xlnx-zdma.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/hw/dma/xlnx-zdma.c b/hw/dma/xlnx-zdma.c
> index 8fb83f5b07..eeacad59ce 100644
> --- a/hw/dma/xlnx-zdma.c
> +++ b/hw/dma/xlnx-zdma.c
> @@ -373,7 +373,7 @@ static uint64_t zdma_update_descr_addr(XlnxZDMA *s, bool type,
> static void zdma_write_dst(XlnxZDMA *s, uint8_t *buf, uint32_t len)
> {
> uint32_t dst_size, dlen;
> - bool dst_intr, dst_type;
> + bool dst_intr;
> unsigned int ptype = ARRAY_FIELD_EX32(s->regs, ZDMA_CH_CTRL0, POINT_TYPE);
> unsigned int rw_mode = ARRAY_FIELD_EX32(s->regs, ZDMA_CH_CTRL0, MODE);
> unsigned int burst_type = ARRAY_FIELD_EX32(s->regs, ZDMA_CH_DATA_ATTR,
> @@ -387,17 +387,17 @@ static void zdma_write_dst(XlnxZDMA *s, uint8_t *buf, uint32_t len)
> while (len) {
> dst_size = FIELD_EX32(s->dsc_dst.words[2], ZDMA_CH_DST_DSCR_WORD2,
> SIZE);
> - dst_type = FIELD_EX32(s->dsc_dst.words[3], ZDMA_CH_DST_DSCR_WORD3,
> - TYPE);
> if (dst_size == 0 && ptype == PT_MEM) {
> uint64_t next;
> + bool dst_type = FIELD_EX32(s->dsc_dst.words[3],
> + ZDMA_CH_DST_DSCR_WORD3,
> + TYPE);
> +
> next = zdma_update_descr_addr(s, dst_type,
> R_ZDMA_CH_DST_CUR_DSCR_LSB);
> zdma_load_descriptor(s, next, &s->dsc_dst);
> dst_size = FIELD_EX32(s->dsc_dst.words[2], ZDMA_CH_DST_DSCR_WORD2,
> SIZE);
> - dst_type = FIELD_EX32(s->dsc_dst.words[3], ZDMA_CH_DST_DSCR_WORD3,
> - TYPE);
> }
>
> /* Match what hardware does by ignoring the dst_size and only using
>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
^ permalink raw reply [flat|nested] 32+ messages in thread* Re: [PATCH v2 09/13] dma/xlnx-zdma: Remove redundant statement in zdma_write_dst()
2020-02-26 8:46 ` [PATCH v2 09/13] dma/xlnx-zdma: Remove redundant statement in zdma_write_dst() kuhn.chenqun
2020-02-26 8:51 ` Philippe Mathieu-Daudé
@ 2020-02-26 14:15 ` Francisco Iglesias
2020-02-26 17:56 ` Alistair Francis
2 siblings, 0 replies; 32+ messages in thread
From: Francisco Iglesias @ 2020-02-26 14:15 UTC (permalink / raw)
To: kuhn.chenqun
Cc: peter.maydell, zhang.zhanghailiang, qemu-trivial,
Alistair Francis, qemu-devel, Euler Robot, Edgar E. Iglesias,
Philippe Mathieu-Daudé
On [2020 Feb 26] Wed 16:46:43, kuhn.chenqun@huawei.com wrote:
> From: Chen Qun <kuhn.chenqun@huawei.com>
>
> Clang static code analyzer show warning:
> hw/dma/xlnx-zdma.c:399:13: warning: Value stored to 'dst_type' is never read
> dst_type = FIELD_EX32(s->dsc_dst.words[3], ZDMA_CH_DST_DSCR_WORD3,
> ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Reported-by: Euler Robot <euler.robot@huawei.com>
> Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
Reviewed-by: Francisco Iglesias <frasse.iglesias@gmail.com>
> ---
> Cc: Alistair Francis <alistair@alistair23.me>
> Cc: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
> Cc: Peter Maydell <peter.maydell@linaro.org>
> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
>
> v1->v2: move the 'dst_type' declaration.(Base on Philippe's suggestion).
> ---
> hw/dma/xlnx-zdma.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/hw/dma/xlnx-zdma.c b/hw/dma/xlnx-zdma.c
> index 8fb83f5b07..eeacad59ce 100644
> --- a/hw/dma/xlnx-zdma.c
> +++ b/hw/dma/xlnx-zdma.c
> @@ -373,7 +373,7 @@ static uint64_t zdma_update_descr_addr(XlnxZDMA *s, bool type,
> static void zdma_write_dst(XlnxZDMA *s, uint8_t *buf, uint32_t len)
> {
> uint32_t dst_size, dlen;
> - bool dst_intr, dst_type;
> + bool dst_intr;
> unsigned int ptype = ARRAY_FIELD_EX32(s->regs, ZDMA_CH_CTRL0, POINT_TYPE);
> unsigned int rw_mode = ARRAY_FIELD_EX32(s->regs, ZDMA_CH_CTRL0, MODE);
> unsigned int burst_type = ARRAY_FIELD_EX32(s->regs, ZDMA_CH_DATA_ATTR,
> @@ -387,17 +387,17 @@ static void zdma_write_dst(XlnxZDMA *s, uint8_t *buf, uint32_t len)
> while (len) {
> dst_size = FIELD_EX32(s->dsc_dst.words[2], ZDMA_CH_DST_DSCR_WORD2,
> SIZE);
> - dst_type = FIELD_EX32(s->dsc_dst.words[3], ZDMA_CH_DST_DSCR_WORD3,
> - TYPE);
> if (dst_size == 0 && ptype == PT_MEM) {
> uint64_t next;
> + bool dst_type = FIELD_EX32(s->dsc_dst.words[3],
> + ZDMA_CH_DST_DSCR_WORD3,
> + TYPE);
> +
> next = zdma_update_descr_addr(s, dst_type,
> R_ZDMA_CH_DST_CUR_DSCR_LSB);
> zdma_load_descriptor(s, next, &s->dsc_dst);
> dst_size = FIELD_EX32(s->dsc_dst.words[2], ZDMA_CH_DST_DSCR_WORD2,
> SIZE);
> - dst_type = FIELD_EX32(s->dsc_dst.words[3], ZDMA_CH_DST_DSCR_WORD3,
> - TYPE);
> }
>
> /* Match what hardware does by ignoring the dst_size and only using
> --
> 2.23.0
>
>
>
^ permalink raw reply [flat|nested] 32+ messages in thread* Re: [PATCH v2 09/13] dma/xlnx-zdma: Remove redundant statement in zdma_write_dst()
2020-02-26 8:46 ` [PATCH v2 09/13] dma/xlnx-zdma: Remove redundant statement in zdma_write_dst() kuhn.chenqun
2020-02-26 8:51 ` Philippe Mathieu-Daudé
2020-02-26 14:15 ` Francisco Iglesias
@ 2020-02-26 17:56 ` Alistair Francis
2 siblings, 0 replies; 32+ messages in thread
From: Alistair Francis @ 2020-02-26 17:56 UTC (permalink / raw)
To: kuhn.chenqun
Cc: Peter Maydell, zhang.zhanghailiang, QEMU Trivial,
Alistair Francis, qemu-devel@nongnu.org Developers, Euler Robot,
Edgar E. Iglesias, Philippe Mathieu-Daudé
On Wed, Feb 26, 2020 at 12:52 AM <kuhn.chenqun@huawei.com> wrote:
>
> From: Chen Qun <kuhn.chenqun@huawei.com>
>
> Clang static code analyzer show warning:
> hw/dma/xlnx-zdma.c:399:13: warning: Value stored to 'dst_type' is never read
> dst_type = FIELD_EX32(s->dsc_dst.words[3], ZDMA_CH_DST_DSCR_WORD3,
> ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Reported-by: Euler Robot <euler.robot@huawei.com>
> Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
> ---
> Cc: Alistair Francis <alistair@alistair23.me>
> Cc: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
> Cc: Peter Maydell <peter.maydell@linaro.org>
> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Alistair
>
> v1->v2: move the 'dst_type' declaration.(Base on Philippe's suggestion).
> ---
> hw/dma/xlnx-zdma.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/hw/dma/xlnx-zdma.c b/hw/dma/xlnx-zdma.c
> index 8fb83f5b07..eeacad59ce 100644
> --- a/hw/dma/xlnx-zdma.c
> +++ b/hw/dma/xlnx-zdma.c
> @@ -373,7 +373,7 @@ static uint64_t zdma_update_descr_addr(XlnxZDMA *s, bool type,
> static void zdma_write_dst(XlnxZDMA *s, uint8_t *buf, uint32_t len)
> {
> uint32_t dst_size, dlen;
> - bool dst_intr, dst_type;
> + bool dst_intr;
> unsigned int ptype = ARRAY_FIELD_EX32(s->regs, ZDMA_CH_CTRL0, POINT_TYPE);
> unsigned int rw_mode = ARRAY_FIELD_EX32(s->regs, ZDMA_CH_CTRL0, MODE);
> unsigned int burst_type = ARRAY_FIELD_EX32(s->regs, ZDMA_CH_DATA_ATTR,
> @@ -387,17 +387,17 @@ static void zdma_write_dst(XlnxZDMA *s, uint8_t *buf, uint32_t len)
> while (len) {
> dst_size = FIELD_EX32(s->dsc_dst.words[2], ZDMA_CH_DST_DSCR_WORD2,
> SIZE);
> - dst_type = FIELD_EX32(s->dsc_dst.words[3], ZDMA_CH_DST_DSCR_WORD3,
> - TYPE);
> if (dst_size == 0 && ptype == PT_MEM) {
> uint64_t next;
> + bool dst_type = FIELD_EX32(s->dsc_dst.words[3],
> + ZDMA_CH_DST_DSCR_WORD3,
> + TYPE);
> +
> next = zdma_update_descr_addr(s, dst_type,
> R_ZDMA_CH_DST_CUR_DSCR_LSB);
> zdma_load_descriptor(s, next, &s->dsc_dst);
> dst_size = FIELD_EX32(s->dsc_dst.words[2], ZDMA_CH_DST_DSCR_WORD2,
> SIZE);
> - dst_type = FIELD_EX32(s->dsc_dst.words[3], ZDMA_CH_DST_DSCR_WORD3,
> - TYPE);
> }
>
> /* Match what hardware does by ignoring the dst_size and only using
> --
> 2.23.0
>
>
>
^ permalink raw reply [flat|nested] 32+ messages in thread
* [PATCH v2 10/13] migration/vmstate: Remove redundant statement in vmstate_save_state_v()
2020-02-26 8:46 [PATCH v2 00/13] redundant code: Fix warnings reported by Clang static code analyzer kuhn.chenqun
` (8 preceding siblings ...)
2020-02-26 8:46 ` [PATCH v2 09/13] dma/xlnx-zdma: Remove redundant statement in zdma_write_dst() kuhn.chenqun
@ 2020-02-26 8:46 ` kuhn.chenqun
2020-02-27 18:01 ` Juan Quintela
2020-02-26 8:46 ` [PATCH v2 11/13] timer/exynos4210_mct: Remove redundant statement in exynos4210_mct_write() kuhn.chenqun
` (2 subsequent siblings)
12 siblings, 1 reply; 32+ messages in thread
From: kuhn.chenqun @ 2020-02-26 8:46 UTC (permalink / raw)
To: qemu-devel, qemu-trivial
Cc: peter.maydell, zhang.zhanghailiang, Juan Quintela,
Dr. David Alan Gilbert, Euler Robot, Chen Qun
From: Chen Qun <kuhn.chenqun@huawei.com>
The "ret" has been assigned in all branches. It didn't need to be
assigned separately.
Clang static code analyzer show warning:
migration/vmstate.c:365:17: warning: Value stored to 'ret' is never read
ret = 0;
^ ~
Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
---
Cc: Juan Quintela <quintela@redhat.com>
Cc: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
---
migration/vmstate.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/migration/vmstate.c b/migration/vmstate.c
index 7dd8ef66c6..bafa890384 100644
--- a/migration/vmstate.c
+++ b/migration/vmstate.c
@@ -362,7 +362,6 @@ int vmstate_save_state_v(QEMUFile *f, const VMStateDescription *vmsd,
}
for (i = 0; i < n_elems; i++) {
void *curr_elem = first_elem + size * i;
- ret = 0;
vmsd_desc_field_start(vmsd, vmdesc_loop, field, i, n_elems);
old_offset = qemu_ftell_fast(f);
--
2.23.0
^ permalink raw reply related [flat|nested] 32+ messages in thread* Re: [PATCH v2 10/13] migration/vmstate: Remove redundant statement in vmstate_save_state_v()
2020-02-26 8:46 ` [PATCH v2 10/13] migration/vmstate: Remove redundant statement in vmstate_save_state_v() kuhn.chenqun
@ 2020-02-27 18:01 ` Juan Quintela
0 siblings, 0 replies; 32+ messages in thread
From: Juan Quintela @ 2020-02-27 18:01 UTC (permalink / raw)
To: kuhn.chenqun
Cc: peter.maydell, zhang.zhanghailiang, qemu-trivial, qemu-devel,
Dr. David Alan Gilbert, Euler Robot
<kuhn.chenqun@huawei.com> wrote:
> From: Chen Qun <kuhn.chenqun@huawei.com>
>
> The "ret" has been assigned in all branches. It didn't need to be
> assigned separately.
>
> Clang static code analyzer show warning:
> migration/vmstate.c:365:17: warning: Value stored to 'ret' is never read
> ret = 0;
> ^ ~
>
> Reported-by: Euler Robot <euler.robot@huawei.com>
> Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
I thought I had already reviewed it.
Reviewed-by: Juan Quintela <quintela@redhat.com>
queued
^ permalink raw reply [flat|nested] 32+ messages in thread
* [PATCH v2 11/13] timer/exynos4210_mct: Remove redundant statement in exynos4210_mct_write()
2020-02-26 8:46 [PATCH v2 00/13] redundant code: Fix warnings reported by Clang static code analyzer kuhn.chenqun
` (9 preceding siblings ...)
2020-02-26 8:46 ` [PATCH v2 10/13] migration/vmstate: Remove redundant statement in vmstate_save_state_v() kuhn.chenqun
@ 2020-02-26 8:46 ` kuhn.chenqun
2020-02-26 8:46 ` [PATCH v2 12/13] usb/hcd-ehci: Remove redundant statements kuhn.chenqun
2020-02-26 8:46 ` [PATCH v2 13/13] monitor/hmp-cmds: Remove redundant statement in hmp_rocker_of_dpa_groups() kuhn.chenqun
12 siblings, 0 replies; 32+ messages in thread
From: kuhn.chenqun @ 2020-02-26 8:46 UTC (permalink / raw)
To: qemu-devel, qemu-trivial
Cc: Igor Mitsyanko, peter.maydell, Euler Robot, zhang.zhanghailiang,
Chen Qun
From: Chen Qun <kuhn.chenqun@huawei.com>
Clang static code analyzer show warning:
hw/timer/exynos4210_mct.c:1370:9: warning: Value stored to 'index' is never read
index = GET_L_TIMER_CNT_REG_IDX(offset, lt_i);
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
hw/timer/exynos4210_mct.c:1399:9: warning: Value stored to 'index' is never read
index = GET_L_TIMER_CNT_REG_IDX(offset, lt_i);
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
hw/timer/exynos4210_mct.c:1441:9: warning: Value stored to 'index' is never read
index = GET_L_TIMER_CNT_REG_IDX(offset, lt_i);
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
---
Cc: Igor Mitsyanko <i.mitsyanko@gmail.com>
Cc: Peter Maydell <peter.maydell@linaro.org>
---
hw/timer/exynos4210_mct.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/hw/timer/exynos4210_mct.c b/hw/timer/exynos4210_mct.c
index 944120aea5..570cf7075b 100644
--- a/hw/timer/exynos4210_mct.c
+++ b/hw/timer/exynos4210_mct.c
@@ -1367,7 +1367,6 @@ static void exynos4210_mct_write(void *opaque, hwaddr offset,
case L0_TCNTB: case L1_TCNTB:
lt_i = GET_L_TIMER_IDX(offset);
- index = GET_L_TIMER_CNT_REG_IDX(offset, lt_i);
/*
* TCNTB is updated to internal register only after CNT expired.
@@ -1396,7 +1395,6 @@ static void exynos4210_mct_write(void *opaque, hwaddr offset,
case L0_ICNTB: case L1_ICNTB:
lt_i = GET_L_TIMER_IDX(offset);
- index = GET_L_TIMER_CNT_REG_IDX(offset, lt_i);
s->l_timer[lt_i].reg.wstat |= L_WSTAT_ICNTB_WRITE;
s->l_timer[lt_i].reg.cnt[L_REG_CNT_ICNTB] = value &
@@ -1438,8 +1436,6 @@ static void exynos4210_mct_write(void *opaque, hwaddr offset,
case L0_FRCNTB: case L1_FRCNTB:
lt_i = GET_L_TIMER_IDX(offset);
- index = GET_L_TIMER_CNT_REG_IDX(offset, lt_i);
-
DPRINTF("local timer[%d] FRCNTB write %llx\n", lt_i, value);
s->l_timer[lt_i].reg.wstat |= L_WSTAT_FRCCNTB_WRITE;
--
2.23.0
^ permalink raw reply related [flat|nested] 32+ messages in thread* [PATCH v2 12/13] usb/hcd-ehci: Remove redundant statements
2020-02-26 8:46 [PATCH v2 00/13] redundant code: Fix warnings reported by Clang static code analyzer kuhn.chenqun
` (10 preceding siblings ...)
2020-02-26 8:46 ` [PATCH v2 11/13] timer/exynos4210_mct: Remove redundant statement in exynos4210_mct_write() kuhn.chenqun
@ 2020-02-26 8:46 ` kuhn.chenqun
2020-03-09 10:13 ` Gerd Hoffmann
2020-02-26 8:46 ` [PATCH v2 13/13] monitor/hmp-cmds: Remove redundant statement in hmp_rocker_of_dpa_groups() kuhn.chenqun
12 siblings, 1 reply; 32+ messages in thread
From: kuhn.chenqun @ 2020-02-26 8:46 UTC (permalink / raw)
To: qemu-devel, qemu-trivial
Cc: peter.maydell, zhang.zhanghailiang, Gerd Hoffmann, Euler Robot,
Chen Qun, Philippe Mathieu-Daudé
From: Chen Qun <kuhn.chenqun@huawei.com>
The "again" assignment is meaningless before g_assert_not_reached.
In addition, the break statements no longer needs to be after
g_assert_not_reached.
Clang static code analyzer show warning:
hw/usb/hcd-ehci.c:2108:13: warning: Value stored to 'again' is never read
again = -1;
^ ~~
Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
---
hw/usb/hcd-ehci.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c
index 56ab2f457f..29d49c2d7e 100644
--- a/hw/usb/hcd-ehci.c
+++ b/hw/usb/hcd-ehci.c
@@ -1301,7 +1301,6 @@ static void ehci_execute_complete(EHCIQueue *q)
/* should not be triggerable */
fprintf(stderr, "USB invalid response %d\n", p->packet.status);
g_assert_not_reached();
- break;
}
/* TODO check 4.12 for splits */
@@ -2105,9 +2104,7 @@ static void ehci_advance_state(EHCIState *ehci, int async)
default:
fprintf(stderr, "Bad state!\n");
- again = -1;
g_assert_not_reached();
- break;
}
if (again < 0 || itd_count > 16) {
--
2.23.0
^ permalink raw reply related [flat|nested] 32+ messages in thread* Re: [PATCH v2 12/13] usb/hcd-ehci: Remove redundant statements
2020-02-26 8:46 ` [PATCH v2 12/13] usb/hcd-ehci: Remove redundant statements kuhn.chenqun
@ 2020-03-09 10:13 ` Gerd Hoffmann
0 siblings, 0 replies; 32+ messages in thread
From: Gerd Hoffmann @ 2020-03-09 10:13 UTC (permalink / raw)
To: kuhn.chenqun
Cc: peter.maydell, zhang.zhanghailiang, qemu-trivial, qemu-devel,
Euler Robot, Philippe Mathieu-Daudé
On Wed, Feb 26, 2020 at 04:46:46PM +0800, kuhn.chenqun@huawei.com wrote:
> From: Chen Qun <kuhn.chenqun@huawei.com>
>
> The "again" assignment is meaningless before g_assert_not_reached.
> In addition, the break statements no longer needs to be after
> g_assert_not_reached.
>
> Clang static code analyzer show warning:
> hw/usb/hcd-ehci.c:2108:13: warning: Value stored to 'again' is never read
> again = -1;
> ^ ~~
>
> Reported-by: Euler Robot <euler.robot@huawei.com>
> Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Patch added to usb queue.
thanks,
Gerd
^ permalink raw reply [flat|nested] 32+ messages in thread
* [PATCH v2 13/13] monitor/hmp-cmds: Remove redundant statement in hmp_rocker_of_dpa_groups()
2020-02-26 8:46 [PATCH v2 00/13] redundant code: Fix warnings reported by Clang static code analyzer kuhn.chenqun
` (11 preceding siblings ...)
2020-02-26 8:46 ` [PATCH v2 12/13] usb/hcd-ehci: Remove redundant statements kuhn.chenqun
@ 2020-02-26 8:46 ` kuhn.chenqun
2020-02-26 8:52 ` Philippe Mathieu-Daudé
12 siblings, 1 reply; 32+ messages in thread
From: kuhn.chenqun @ 2020-02-26 8:46 UTC (permalink / raw)
To: qemu-devel, qemu-trivial
Cc: peter.maydell, zhang.zhanghailiang, Dr. David Alan Gilbert,
Euler Robot, Chen Qun, Philippe Mathieu-Daudé
From: Chen Qun <kuhn.chenqun@huawei.com>
Clang static code analyzer show warning:
monitor/hmp-cmds.c:2867:17: warning: Value stored to 'set' is never read
set = true;
^ ~~~~
Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
---
Cc: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
v1->v2: move the 'set' declaration to the for() statement(Base on Philippe's suggestion).
---
monitor/hmp-cmds.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c
index 53bc3f76c4..c6b0495822 100644
--- a/monitor/hmp-cmds.c
+++ b/monitor/hmp-cmds.c
@@ -2808,7 +2808,6 @@ void hmp_rocker_of_dpa_groups(Monitor *mon, const QDict *qdict)
const char *name = qdict_get_str(qdict, "name");
uint8_t type = qdict_get_try_int(qdict, "type", 9);
Error *err = NULL;
- bool set = false;
list = qmp_query_rocker_of_dpa_groups(name, type != 9, type, &err);
if (err != NULL) {
@@ -2820,6 +2819,7 @@ void hmp_rocker_of_dpa_groups(Monitor *mon, const QDict *qdict)
for (g = list; g; g = g->next) {
RockerOfDpaGroup *group = g->value;
+ bool set = false;
monitor_printf(mon, "0x%08x", group->id);
@@ -2864,14 +2864,11 @@ void hmp_rocker_of_dpa_groups(Monitor *mon, const QDict *qdict)
if (group->has_set_eth_dst) {
if (!set) {
- set = true;
monitor_printf(mon, " set");
}
monitor_printf(mon, " dst %s", group->set_eth_dst);
}
- set = false;
-
if (group->has_ttl_check && group->ttl_check) {
monitor_printf(mon, " check TTL");
}
--
2.23.0
^ permalink raw reply related [flat|nested] 32+ messages in thread* Re: [PATCH v2 13/13] monitor/hmp-cmds: Remove redundant statement in hmp_rocker_of_dpa_groups()
2020-02-26 8:46 ` [PATCH v2 13/13] monitor/hmp-cmds: Remove redundant statement in hmp_rocker_of_dpa_groups() kuhn.chenqun
@ 2020-02-26 8:52 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 32+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-02-26 8:52 UTC (permalink / raw)
To: kuhn.chenqun, qemu-devel, qemu-trivial
Cc: peter.maydell, zhang.zhanghailiang, Dr. David Alan Gilbert, Euler Robot
On 2/26/20 9:46 AM, kuhn.chenqun@huawei.com wrote:
> From: Chen Qun <kuhn.chenqun@huawei.com>
>
> Clang static code analyzer show warning:
> monitor/hmp-cmds.c:2867:17: warning: Value stored to 'set' is never read
> set = true;
> ^ ~~~~
>
> Reported-by: Euler Robot <euler.robot@huawei.com>
> Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
> ---
> Cc: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
>
> v1->v2: move the 'set' declaration to the for() statement(Base on Philippe's suggestion).
> ---
> monitor/hmp-cmds.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c
> index 53bc3f76c4..c6b0495822 100644
> --- a/monitor/hmp-cmds.c
> +++ b/monitor/hmp-cmds.c
> @@ -2808,7 +2808,6 @@ void hmp_rocker_of_dpa_groups(Monitor *mon, const QDict *qdict)
> const char *name = qdict_get_str(qdict, "name");
> uint8_t type = qdict_get_try_int(qdict, "type", 9);
> Error *err = NULL;
> - bool set = false;
>
> list = qmp_query_rocker_of_dpa_groups(name, type != 9, type, &err);
> if (err != NULL) {
> @@ -2820,6 +2819,7 @@ void hmp_rocker_of_dpa_groups(Monitor *mon, const QDict *qdict)
>
> for (g = list; g; g = g->next) {
> RockerOfDpaGroup *group = g->value;
> + bool set = false;
>
> monitor_printf(mon, "0x%08x", group->id);
>
> @@ -2864,14 +2864,11 @@ void hmp_rocker_of_dpa_groups(Monitor *mon, const QDict *qdict)
>
> if (group->has_set_eth_dst) {
> if (!set) {
> - set = true;
> monitor_printf(mon, " set");
> }
> monitor_printf(mon, " dst %s", group->set_eth_dst);
> }
>
> - set = false;
> -
> if (group->has_ttl_check && group->ttl_check) {
> monitor_printf(mon, " check TTL");
> }
>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
^ permalink raw reply [flat|nested] 32+ messages in thread