* [PATCH] staging: wfx: match parentheses alignment
@ 2020-02-23 19:32 ` Kaaira Gupta
0 siblings, 0 replies; 10+ messages in thread
From: Kaaira Gupta @ 2020-02-23 19:32 UTC (permalink / raw)
To: Jérôme Pouiller, Greg Kroah-Hartman, devel, linux-kernel
match next line with open parentheses by giving appropriate tabs.
Signed-off-by: Kaaira Gupta <kgupta@es.iitr.ac.in>
---
drivers/staging/wfx/data_tx.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/wfx/data_tx.c b/drivers/staging/wfx/data_tx.c
index 20f4740734f2..815fde0913f5 100644
--- a/drivers/staging/wfx/data_tx.c
+++ b/drivers/staging/wfx/data_tx.c
@@ -300,8 +300,8 @@ static void wfx_tx_manage_pm(struct wfx_vif *wvif, struct ieee80211_hdr *hdr,
}
static u8 wfx_tx_get_raw_link_id(struct wfx_vif *wvif,
- struct ieee80211_sta *sta,
- struct ieee80211_hdr *hdr)
+ struct ieee80211_sta *sta,
+ struct ieee80211_hdr *hdr)
{
struct wfx_sta_priv *sta_priv =
sta ? (struct wfx_sta_priv *) &sta->drv_priv : NULL;
@@ -368,7 +368,7 @@ static void wfx_tx_fixup_rates(struct ieee80211_tx_rate *rates)
}
static u8 wfx_tx_get_rate_id(struct wfx_vif *wvif,
- struct ieee80211_tx_info *tx_info)
+ struct ieee80211_tx_info *tx_info)
{
bool tx_policy_renew = false;
u8 rate_id;
--
2.17.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH] staging: wfx: match parentheses alignment
@ 2020-02-23 19:32 ` Kaaira Gupta
0 siblings, 0 replies; 10+ messages in thread
From: Kaaira Gupta @ 2020-02-23 19:32 UTC (permalink / raw)
To: Jérôme Pouiller, Greg Kroah-Hartman, devel, linux-kernel
match next line with open parentheses by giving appropriate tabs.
Signed-off-by: Kaaira Gupta <kgupta@es.iitr.ac.in>
---
drivers/staging/wfx/data_tx.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/wfx/data_tx.c b/drivers/staging/wfx/data_tx.c
index 20f4740734f2..815fde0913f5 100644
--- a/drivers/staging/wfx/data_tx.c
+++ b/drivers/staging/wfx/data_tx.c
@@ -300,8 +300,8 @@ static void wfx_tx_manage_pm(struct wfx_vif *wvif, struct ieee80211_hdr *hdr,
}
static u8 wfx_tx_get_raw_link_id(struct wfx_vif *wvif,
- struct ieee80211_sta *sta,
- struct ieee80211_hdr *hdr)
+ struct ieee80211_sta *sta,
+ struct ieee80211_hdr *hdr)
{
struct wfx_sta_priv *sta_priv =
sta ? (struct wfx_sta_priv *) &sta->drv_priv : NULL;
@@ -368,7 +368,7 @@ static void wfx_tx_fixup_rates(struct ieee80211_tx_rate *rates)
}
static u8 wfx_tx_get_rate_id(struct wfx_vif *wvif,
- struct ieee80211_tx_info *tx_info)
+ struct ieee80211_tx_info *tx_info)
{
bool tx_policy_renew = false;
u8 rate_id;
--
2.17.1
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH] staging: wfx: match parentheses alignment
2020-02-23 19:32 ` Kaaira Gupta
@ 2020-02-24 9:22 ` Jérôme Pouiller
-1 siblings, 0 replies; 10+ messages in thread
From: Jérôme Pouiller @ 2020-02-24 9:22 UTC (permalink / raw)
To: Kaaira Gupta; +Cc: Greg Kroah-Hartman, devel, linux-kernel
On Sunday 23 February 2020 20:32:01 CET Kaaira Gupta wrote:
>
> match next line with open parentheses by giving appropriate tabs.
Maybe the body of the commit message should start with a capital letter,
else:
Reviewed-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
>
> Signed-off-by: Kaaira Gupta <kgupta@es.iitr.ac.in>
> ---
> drivers/staging/wfx/data_tx.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/wfx/data_tx.c b/drivers/staging/wfx/data_tx.c
> index 20f4740734f2..815fde0913f5 100644
> --- a/drivers/staging/wfx/data_tx.c
> +++ b/drivers/staging/wfx/data_tx.c
> @@ -300,8 +300,8 @@ static void wfx_tx_manage_pm(struct wfx_vif *wvif, struct ieee80211_hdr *hdr,
> }
>
> static u8 wfx_tx_get_raw_link_id(struct wfx_vif *wvif,
> - struct ieee80211_sta *sta,
> - struct ieee80211_hdr *hdr)
> + struct ieee80211_sta *sta,
> + struct ieee80211_hdr *hdr)
> {
> struct wfx_sta_priv *sta_priv =
> sta ? (struct wfx_sta_priv *) &sta->drv_priv : NULL;
> @@ -368,7 +368,7 @@ static void wfx_tx_fixup_rates(struct ieee80211_tx_rate *rates)
> }
>
> static u8 wfx_tx_get_rate_id(struct wfx_vif *wvif,
> - struct ieee80211_tx_info *tx_info)
> + struct ieee80211_tx_info *tx_info)
> {
> bool tx_policy_renew = false;
> u8 rate_id;
--
Jérôme Pouiller
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] staging: wfx: match parentheses alignment
@ 2020-02-24 9:22 ` Jérôme Pouiller
0 siblings, 0 replies; 10+ messages in thread
From: Jérôme Pouiller @ 2020-02-24 9:22 UTC (permalink / raw)
To: Kaaira Gupta; +Cc: devel, Greg Kroah-Hartman, linux-kernel
On Sunday 23 February 2020 20:32:01 CET Kaaira Gupta wrote:
>
> match next line with open parentheses by giving appropriate tabs.
Maybe the body of the commit message should start with a capital letter,
else:
Reviewed-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
>
> Signed-off-by: Kaaira Gupta <kgupta@es.iitr.ac.in>
> ---
> drivers/staging/wfx/data_tx.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/wfx/data_tx.c b/drivers/staging/wfx/data_tx.c
> index 20f4740734f2..815fde0913f5 100644
> --- a/drivers/staging/wfx/data_tx.c
> +++ b/drivers/staging/wfx/data_tx.c
> @@ -300,8 +300,8 @@ static void wfx_tx_manage_pm(struct wfx_vif *wvif, struct ieee80211_hdr *hdr,
> }
>
> static u8 wfx_tx_get_raw_link_id(struct wfx_vif *wvif,
> - struct ieee80211_sta *sta,
> - struct ieee80211_hdr *hdr)
> + struct ieee80211_sta *sta,
> + struct ieee80211_hdr *hdr)
> {
> struct wfx_sta_priv *sta_priv =
> sta ? (struct wfx_sta_priv *) &sta->drv_priv : NULL;
> @@ -368,7 +368,7 @@ static void wfx_tx_fixup_rates(struct ieee80211_tx_rate *rates)
> }
>
> static u8 wfx_tx_get_rate_id(struct wfx_vif *wvif,
> - struct ieee80211_tx_info *tx_info)
> + struct ieee80211_tx_info *tx_info)
> {
> bool tx_policy_renew = false;
> u8 rate_id;
--
Jérôme Pouiller
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] staging: wfx: match parentheses alignment
2020-02-23 19:32 ` Kaaira Gupta
@ 2020-02-24 14:13 ` Joe Perches
-1 siblings, 0 replies; 10+ messages in thread
From: Joe Perches @ 2020-02-24 14:13 UTC (permalink / raw)
To: Kaaira Gupta, Jérôme Pouiller, Greg Kroah-Hartman,
devel, linux-kernel
On Mon, 2020-02-24 at 01:02 +0530, Kaaira Gupta wrote:
> match next line with open parentheses by giving appropriate tabs.
This patch is only for data_tx.c
There are many more parentheses that are not aligned
in staging/wfx in other files.
Realistically, either change the subject to show
that it's only for data_tx or do them all.
(but not traces.h, those use a different style)
$ ./scripts/checkpatch.pl -f --terse --nosummary --types=parenthesis_alignment drivers/staging/wfx/*.[ch]
drivers/staging/wfx/data_tx.c:303: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/data_tx.c:371: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/debug.c:35: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/key.c:35: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/key.c:45: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/key.c:55: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/key.c:72: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/key.c:97: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/key.c:106: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/key.c:118: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/key.c:133: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/key.c:147: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/queue.c:393: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/queue.c:408: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/queue.c:433: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/sta.c:123: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/sta.c:235: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/sta.c:291: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/sta.c:340: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/sta.c:717: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/traces.h:156: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/traces.h:194: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/traces.h:206: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/traces.h:211: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/traces.h:234: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/traces.h:257: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/traces.h:265: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/traces.h:271: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/traces.h:278: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/traces.h:296: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/traces.h:302: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/traces.h:307: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/traces.h:313: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/traces.h:324: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/traces.h:329: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/traces.h:334: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/traces.h:351: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/traces.h:362: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/traces.h:416: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/traces.h:418: CHECK: Alignment should match open parenthesis
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] staging: wfx: match parentheses alignment
@ 2020-02-24 14:13 ` Joe Perches
0 siblings, 0 replies; 10+ messages in thread
From: Joe Perches @ 2020-02-24 14:13 UTC (permalink / raw)
To: Kaaira Gupta, Jérôme Pouiller, Greg Kroah-Hartman,
devel, linux-kernel
On Mon, 2020-02-24 at 01:02 +0530, Kaaira Gupta wrote:
> match next line with open parentheses by giving appropriate tabs.
This patch is only for data_tx.c
There are many more parentheses that are not aligned
in staging/wfx in other files.
Realistically, either change the subject to show
that it's only for data_tx or do them all.
(but not traces.h, those use a different style)
$ ./scripts/checkpatch.pl -f --terse --nosummary --types=parenthesis_alignment drivers/staging/wfx/*.[ch]
drivers/staging/wfx/data_tx.c:303: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/data_tx.c:371: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/debug.c:35: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/key.c:35: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/key.c:45: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/key.c:55: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/key.c:72: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/key.c:97: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/key.c:106: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/key.c:118: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/key.c:133: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/key.c:147: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/queue.c:393: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/queue.c:408: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/queue.c:433: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/sta.c:123: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/sta.c:235: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/sta.c:291: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/sta.c:340: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/sta.c:717: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/traces.h:156: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/traces.h:194: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/traces.h:206: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/traces.h:211: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/traces.h:234: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/traces.h:257: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/traces.h:265: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/traces.h:271: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/traces.h:278: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/traces.h:296: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/traces.h:302: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/traces.h:307: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/traces.h:313: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/traces.h:324: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/traces.h:329: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/traces.h:334: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/traces.h:351: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/traces.h:362: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/traces.h:416: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/traces.h:418: CHECK: Alignment should match open parenthesis
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v2] staging: wfx: data_tx.c: match parentheses alignment
2020-02-24 14:13 ` Joe Perches
@ 2020-02-24 16:26 ` Kaaira Gupta
-1 siblings, 0 replies; 10+ messages in thread
From: Kaaira Gupta @ 2020-02-24 16:26 UTC (permalink / raw)
To: Joe Perches, jerome.pouiller, Greg Kroah-Hartman, devel, linux-kernel
On Mon, Feb 24, 2020 at 06:13:32AM -0800, Joe Perches wrote:
> On Mon, 2020-02-24 at 01:02 +0530, Kaaira Gupta wrote:
> > Match next line with open parentheses by giving appropriate tabs.
Changed the first word to caps. Will keep this in mind from now on.
Thanks!
>
> This patch is only for data_tx.c
>
> There are many more parentheses that are not aligned
> in staging/wfx in other files.
>
> Realistically, either change the subject to show
> that it's only for data_tx or do them all.
I have made the changes in the subject line and will submit a separate
patch with clean-ups in all the other files
>
> (but not traces.h, those use a different style)
>
> $ ./scripts/checkpatch.pl -f --terse --nosummary --types=parenthesis_alignment drivers/staging/wfx/*.[ch]
> drivers/staging/wfx/data_tx.c:303: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/data_tx.c:371: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/debug.c:35: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/key.c:35: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/key.c:45: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/key.c:55: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/key.c:72: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/key.c:97: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/key.c:106: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/key.c:118: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/key.c:133: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/key.c:147: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/queue.c:393: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/queue.c:408: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/queue.c:433: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/sta.c:123: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/sta.c:235: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/sta.c:291: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/sta.c:340: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/sta.c:717: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/traces.h:156: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/traces.h:194: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/traces.h:206: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/traces.h:211: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/traces.h:234: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/traces.h:257: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/traces.h:265: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/traces.h:271: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/traces.h:278: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/traces.h:296: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/traces.h:302: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/traces.h:307: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/traces.h:313: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/traces.h:324: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/traces.h:329: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/traces.h:334: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/traces.h:351: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/traces.h:362: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/traces.h:416: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/traces.h:418: CHECK: Alignment should match open parenthesis
>
>
>
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v2] staging: wfx: data_tx.c: match parentheses alignment
@ 2020-02-24 16:26 ` Kaaira Gupta
0 siblings, 0 replies; 10+ messages in thread
From: Kaaira Gupta @ 2020-02-24 16:26 UTC (permalink / raw)
To: Joe Perches, jerome.pouiller, Greg Kroah-Hartman, devel, linux-kernel
On Mon, Feb 24, 2020 at 06:13:32AM -0800, Joe Perches wrote:
> On Mon, 2020-02-24 at 01:02 +0530, Kaaira Gupta wrote:
> > Match next line with open parentheses by giving appropriate tabs.
Changed the first word to caps. Will keep this in mind from now on.
Thanks!
>
> This patch is only for data_tx.c
>
> There are many more parentheses that are not aligned
> in staging/wfx in other files.
>
> Realistically, either change the subject to show
> that it's only for data_tx or do them all.
I have made the changes in the subject line and will submit a separate
patch with clean-ups in all the other files
>
> (but not traces.h, those use a different style)
>
> $ ./scripts/checkpatch.pl -f --terse --nosummary --types=parenthesis_alignment drivers/staging/wfx/*.[ch]
> drivers/staging/wfx/data_tx.c:303: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/data_tx.c:371: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/debug.c:35: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/key.c:35: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/key.c:45: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/key.c:55: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/key.c:72: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/key.c:97: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/key.c:106: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/key.c:118: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/key.c:133: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/key.c:147: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/queue.c:393: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/queue.c:408: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/queue.c:433: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/sta.c:123: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/sta.c:235: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/sta.c:291: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/sta.c:340: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/sta.c:717: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/traces.h:156: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/traces.h:194: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/traces.h:206: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/traces.h:211: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/traces.h:234: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/traces.h:257: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/traces.h:265: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/traces.h:271: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/traces.h:278: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/traces.h:296: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/traces.h:302: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/traces.h:307: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/traces.h:313: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/traces.h:324: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/traces.h:329: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/traces.h:334: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/traces.h:351: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/traces.h:362: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/traces.h:416: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/traces.h:418: CHECK: Alignment should match open parenthesis
>
>
>
>
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2] staging: wfx: data_tx.c: match parentheses alignment
2020-02-24 16:26 ` Kaaira Gupta
@ 2020-03-04 6:48 ` Greg Kroah-Hartman
-1 siblings, 0 replies; 10+ messages in thread
From: Greg Kroah-Hartman @ 2020-03-04 6:48 UTC (permalink / raw)
To: Kaaira Gupta; +Cc: Joe Perches, jerome.pouiller, devel, linux-kernel
On Mon, Feb 24, 2020 at 09:56:21PM +0530, Kaaira Gupta wrote:
> On Mon, Feb 24, 2020 at 06:13:32AM -0800, Joe Perches wrote:
> > On Mon, 2020-02-24 at 01:02 +0530, Kaaira Gupta wrote:
> > > Match next line with open parentheses by giving appropriate tabs.
>
> Changed the first word to caps. Will keep this in mind from now on.
> Thanks!
>
There was no "v2" patch in this email, what happened to it?
I've dropped this thread now, please resend the patch if you have an
updated version.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2] staging: wfx: data_tx.c: match parentheses alignment
@ 2020-03-04 6:48 ` Greg Kroah-Hartman
0 siblings, 0 replies; 10+ messages in thread
From: Greg Kroah-Hartman @ 2020-03-04 6:48 UTC (permalink / raw)
To: Kaaira Gupta; +Cc: Joe Perches, devel, linux-kernel
On Mon, Feb 24, 2020 at 09:56:21PM +0530, Kaaira Gupta wrote:
> On Mon, Feb 24, 2020 at 06:13:32AM -0800, Joe Perches wrote:
> > On Mon, 2020-02-24 at 01:02 +0530, Kaaira Gupta wrote:
> > > Match next line with open parentheses by giving appropriate tabs.
>
> Changed the first word to caps. Will keep this in mind from now on.
> Thanks!
>
There was no "v2" patch in this email, what happened to it?
I've dropped this thread now, please resend the patch if you have an
updated version.
thanks,
greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2020-03-04 6:48 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-23 19:32 [PATCH] staging: wfx: match parentheses alignment Kaaira Gupta
2020-02-23 19:32 ` Kaaira Gupta
2020-02-24 9:22 ` Jérôme Pouiller
2020-02-24 9:22 ` Jérôme Pouiller
2020-02-24 14:13 ` Joe Perches
2020-02-24 14:13 ` Joe Perches
2020-02-24 16:26 ` [PATCH v2] staging: wfx: data_tx.c: " Kaaira Gupta
2020-02-24 16:26 ` Kaaira Gupta
2020-03-04 6:48 ` Greg Kroah-Hartman
2020-03-04 6:48 ` Greg Kroah-Hartman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.