[PATCH 0/4] [Outreachy kernel] staging: qlge: remove unneeded variables

[PATCH 0/4] [Outreachy kernel] staging: qlge: remove unneeded variables

[Payal Kshirsagar]

Remove unneeded temporary local variables from the files of drivers/staging/qlge directory.

Payal Kshirsagar (4):
  [Outreachy kernel] staging: qlge: qlge_main.c: remove an unneeded
    variable
  [Outreachy kernel] staging: qlge: qlge_mpi.c: remove an unneeded
    variable
  [Outreachy kernel] staging: qlge: qlge_dbg.c: remove an unneeded
    variable
  [Outreachy kernel] staging: qlge: qlge_ethtool.c: remove an unneeded
    variable

 drivers/staging/qlge/qlge_dbg.c     | 5 +----
 drivers/staging/qlge/qlge_ethtool.c | 5 +----
 drivers/staging/qlge/qlge_main.c    | 5 +----
 drivers/staging/qlge/qlge_mpi.c     | 4 +---
 4 files changed, 4 insertions(+), 15 deletions(-)

-- 
2.17.1

[PATCH 1/4] [Outreachy kernel] staging: qlge: qlge_main.c: remove an unneeded variable

[Payal Kshirsagar]

Remove unneeded temporary local variable, cleanup suggested by coccinelle.

Signed-off-by: Payal Kshirsagar <payalskshirsagar1234@gmail.com>
---
 drivers/staging/qlge/qlge_main.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c
index c712e1af90de..057034319e4e 100644
--- a/drivers/staging/qlge/qlge_main.c
+++ b/drivers/staging/qlge/qlge_main.c
@@ -3905,14 +3905,11 @@ static void ql_release_adapter_resources(struct ql_adapter *qdev)
 
 static int ql_get_adapter_resources(struct ql_adapter *qdev)
 {
-	int status = 0;
-
 	if (ql_alloc_mem_resources(qdev)) {
 		netif_err(qdev, ifup, qdev->ndev, "Unable to  allocate memory.\n");
 		return -ENOMEM;
 	}
-	status = ql_request_irq(qdev);
-	return status;
+	return ql_request_irq(qdev);
 }
 
 static int qlge_close(struct net_device *ndev)
-- 
2.17.1

[PATCH 2/4] [Outreachy kernel] staging: qlge: qlge_mpi.c: remove an unneeded variable

[Payal Kshirsagar]

Remove unneeded temporary local variable, cleanup suggested by coccinelle.

Signed-off-by: Payal Kshirsagar <payalskshirsagar1234@gmail.com>
---
 drivers/staging/qlge/qlge_mpi.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/staging/qlge/qlge_mpi.c b/drivers/staging/qlge/qlge_mpi.c
index bb03b2fa7233..eae168e94b82 100644
--- a/drivers/staging/qlge/qlge_mpi.c
+++ b/drivers/staging/qlge/qlge_mpi.c
@@ -90,9 +90,7 @@ int ql_write_mpi_reg(struct ql_adapter *qdev, u32 reg, u32 data)
 
 int ql_soft_reset_mpi_risc(struct ql_adapter *qdev)
 {
-	int status;
-	status = ql_write_mpi_reg(qdev, 0x00001010, 1);
-	return status;
+	return ql_write_mpi_reg(qdev, 0x00001010, 1);
 }
 
 /* Determine if we are in charge of the firwmare. If
-- 
2.17.1

[PATCH 3/4] [Outreachy kernel] staging: qlge: qlge_dbg.c: remove an unneeded variable

[Payal Kshirsagar]

Remove unneeded temporary local variable, cleanup suggested by coccinelle.

Signed-off-by: Payal Kshirsagar <payalskshirsagar1234@gmail.com>
---
 drivers/staging/qlge/qlge_dbg.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/staging/qlge/qlge_dbg.c b/drivers/staging/qlge/qlge_dbg.c
index 670361873d1d..f1a6157fb7e1 100644
--- a/drivers/staging/qlge/qlge_dbg.c
+++ b/drivers/staging/qlge/qlge_dbg.c
@@ -29,15 +29,12 @@ static int ql_write_other_func_reg(struct ql_adapter *qdev,
 				   u32 reg, u32 reg_val)
 {
 	u32 register_to_read;
-	int status = 0;
 
 	register_to_read = MPI_NIC_REG_BLOCK
 				| MPI_NIC_READ
 				| (qdev->alt_func << MPI_NIC_FUNCTION_SHIFT)
 				| reg;
-	status = ql_write_mpi_reg(qdev, register_to_read, reg_val);
-
-	return status;
+	return ql_write_mpi_reg(qdev, register_to_read, reg_val);
 }
 
 static int ql_wait_other_func_reg_rdy(struct ql_adapter *qdev, u32 reg,
-- 
2.17.1

[PATCH 4/4] [Outreachy kernel] staging: qlge: qlge_ethtool.c: remove an unneeded variable

[Payal Kshirsagar]

Remove unneeded temporary local variable, cleanup suggested by coccinelle.

Signed-off-by: Payal Kshirsagar <payalskshirsagar1234@gmail.com>
---
 drivers/staging/qlge/qlge_ethtool.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/staging/qlge/qlge_ethtool.c b/drivers/staging/qlge/qlge_ethtool.c
index 592ca7edfc44..e15f9723b5c0 100644
--- a/drivers/staging/qlge/qlge_ethtool.c
+++ b/drivers/staging/qlge/qlge_ethtool.c
@@ -692,7 +692,6 @@ static int ql_set_pauseparam(struct net_device *netdev,
 			     struct ethtool_pauseparam *pause)
 {
 	struct ql_adapter *qdev = netdev_priv(netdev);
-	int status = 0;
 
 	if ((pause->rx_pause) && (pause->tx_pause))
 		qdev->link_config |= CFG_PAUSE_STD;
@@ -700,9 +699,7 @@ static int ql_set_pauseparam(struct net_device *netdev,
 		qdev->link_config &= ~CFG_PAUSE_STD;
 	else
 		return -EINVAL;
-
-	status = ql_mb_set_port_cfg(qdev);
-	return status;
+	return ql_mb_set_port_cfg(qdev);
 }
 
 static u32 ql_get_msglevel(struct net_device *ndev)
-- 
2.17.1

Re: [PATCH 4/4] [Outreachy kernel] staging: qlge: qlge_ethtool.c: remove an unneeded variable

[Stefano Brivio]

On Wed, 11 Mar 2020 14:58:15 +0530
Payal Kshirsagar <payalskshirsagar1234@gmail.com> wrote:

> Remove unneeded temporary local variable, cleanup suggested by coccinelle.
> 
> Signed-off-by: Payal Kshirsagar <payalskshirsagar1234@gmail.com>
> ---
>  drivers/staging/qlge/qlge_ethtool.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/qlge/qlge_ethtool.c b/drivers/staging/qlge/qlge_ethtool.c
> index 592ca7edfc44..e15f9723b5c0 100644
> --- a/drivers/staging/qlge/qlge_ethtool.c
> +++ b/drivers/staging/qlge/qlge_ethtool.c
> @@ -692,7 +692,6 @@ static int ql_set_pauseparam(struct net_device *netdev,
>  			     struct ethtool_pauseparam *pause)
>  {
>  	struct ql_adapter *qdev = netdev_priv(netdev);
> -	int status = 0;
>  
>  	if ((pause->rx_pause) && (pause->tx_pause))
>  		qdev->link_config |= CFG_PAUSE_STD;
> @@ -700,9 +699,7 @@ static int ql_set_pauseparam(struct net_device *netdev,
>  		qdev->link_config &= ~CFG_PAUSE_STD;
>  	else
>  		return -EINVAL;
> -
> -	status = ql_mb_set_port_cfg(qdev);
> -	return status;
> +	return ql_mb_set_port_cfg(qdev);

Here, you're also removing a newline that is typically inserted before
a second return (or the last one in a function) for readability, or
whenever there are two logically distinct branches, same in 3/4.

And in 1/4, you might want to add one. In 2/4, there's no need.

-- 
Stefano

Re: [PATCH 4/4] [Outreachy kernel] staging: qlge: qlge_ethtool.c: remove an unneeded variable

[Payal Kshirsagar]

[-- Attachment #1: Type: text/plain, Size: 1837 bytes --]

On Wed, Mar 11, 2020, 5:38 PM Stefano Brivio <sbrivio@redhat.com> wrote:

> On Wed, 11 Mar 2020 14:58:15 +0530
> Payal Kshirsagar <payalskshirsagar1234@gmail.com> wrote:
>
> > Remove unneeded temporary local variable, cleanup suggested by
> coccinelle.
> >
> > Signed-off-by: Payal Kshirsagar <payalskshirsagar1234@gmail.com>
> > ---
> >  drivers/staging/qlge/qlge_ethtool.c | 5 +----
> >  1 file changed, 1 insertion(+), 4 deletions(-)
> >
> > diff --git a/drivers/staging/qlge/qlge_ethtool.c
> b/drivers/staging/qlge/qlge_ethtool.c
> > index 592ca7edfc44..e15f9723b5c0 100644
> > --- a/drivers/staging/qlge/qlge_ethtool.c
> > +++ b/drivers/staging/qlge/qlge_ethtool.c
> > @@ -692,7 +692,6 @@ static int ql_set_pauseparam(struct net_device
> *netdev,
> >                            struct ethtool_pauseparam *pause)
> >  {
> >       struct ql_adapter *qdev = netdev_priv(netdev);
> > -     int status = 0;
> >
> >       if ((pause->rx_pause) && (pause->tx_pause))
> >               qdev->link_config |= CFG_PAUSE_STD;
> > @@ -700,9 +699,7 @@ static int ql_set_pauseparam(struct net_device
> *netdev,
> >               qdev->link_config &= ~CFG_PAUSE_STD;
> >       else
> >               return -EINVAL;
> > -
> > -     status = ql_mb_set_port_cfg(qdev);
> > -     return status;
> > +     return ql_mb_set_port_cfg(qdev);
>
> Here, you're also removing a newline that is typically inserted before
> a second return (or the last one in a function) for readability, or
> whenever there are two logically distinct branches, same in 3/4.
>

Thanks for the suggestion.
I thought there is no need to keep the newline as is:D
But I did not understand what do you want me to do, patch is okay or need
to be resend by adding a newline for readability:)

payal

And in 1/4, you might want to add one. In 2/4, there's no need.
>
> --
> Stefano
>

[-- Attachment #2: Type: text/html, Size: 2893 bytes --]

Re: [PATCH 4/4] [Outreachy kernel] staging: qlge: qlge_ethtool.c: remove an unneeded variable

[Stefano Brivio]

On Wed, 11 Mar 2020 17:50:35 +0530
Payal Kshirsagar <payalskshirsagar1234@gmail.com> wrote:

> On Wed, Mar 11, 2020, 5:38 PM Stefano Brivio <sbrivio@redhat.com> wrote:
> 
> > On Wed, 11 Mar 2020 14:58:15 +0530
> > Payal Kshirsagar <payalskshirsagar1234@gmail.com> wrote:
> >  
> > > Remove unneeded temporary local variable, cleanup suggested by  
> > coccinelle.  
> > >
> > > Signed-off-by: Payal Kshirsagar <payalskshirsagar1234@gmail.com>
> > > ---
> > >  drivers/staging/qlge/qlge_ethtool.c | 5 +----
> > >  1 file changed, 1 insertion(+), 4 deletions(-)
> > >
> > > diff --git a/drivers/staging/qlge/qlge_ethtool.c  
> > b/drivers/staging/qlge/qlge_ethtool.c  
> > > index 592ca7edfc44..e15f9723b5c0 100644
> > > --- a/drivers/staging/qlge/qlge_ethtool.c
> > > +++ b/drivers/staging/qlge/qlge_ethtool.c
> > > @@ -692,7 +692,6 @@ static int ql_set_pauseparam(struct net_device  
> > *netdev,  
> > >                            struct ethtool_pauseparam *pause)
> > >  {
> > >       struct ql_adapter *qdev = netdev_priv(netdev);
> > > -     int status = 0;
> > >
> > >       if ((pause->rx_pause) && (pause->tx_pause))
> > >               qdev->link_config |= CFG_PAUSE_STD;
> > > @@ -700,9 +699,7 @@ static int ql_set_pauseparam(struct net_device  
> > *netdev,  
> > >               qdev->link_config &= ~CFG_PAUSE_STD;
> > >       else
> > >               return -EINVAL;
> > > -
> > > -     status = ql_mb_set_port_cfg(qdev);
> > > -     return status;
> > > +     return ql_mb_set_port_cfg(qdev);  
> >
> > Here, you're also removing a newline that is typically inserted before
> > a second return (or the last one in a function) for readability, or
> > whenever there are two logically distinct branches, same in 3/4.
> >  
> 
> Thanks for the suggestion.
> I thought there is no need to keep the newline as is:D

Have a look at some "sane" examples (especially outside of
drivers/staging), maybe that helps getting a picture...

> But I did not understand what do you want me to do, patch is okay or need
> to be resend by adding a newline for readability:)

I would say you need to re-send the series, because 3/4 and 4/4
actually impair readability in their current form.

Note that I gave my Reviewed-by: on another patch of yours, not on
this series.

Another note: from the cover letter, it's apparent that "[Outreachy
kernel]" is part of commit titles. It shouldn't be, that's only a
prefix (git format-patch --subject-prefix) for email.

> 
> payal
> 
> And in 1/4, you might want to add one. In 2/4, there's no need.
> >
> > --
> > Stefano
> >  

One note about quoting: read above. Who wrote what?

I see you're using GMail, which is fine, by all means, but:

- you shouldn't send HTML emails to kernel lists. Especially with
  projects using patchwork
  (example: https://patchwork.ozlabs.org/project/netdev/list/) this
  has a big potential to mess things up

- you should fix your quoting: a sentence I wrote needs a "> >" prefix
  there, otherwise it seems to come from you, and I'll get confused.

That is, I suggest that you set up an email client as also covered by
the tutorial. The GMail web interface is probably not ideal. The
tutorial suggests 'mutt', but it's not mandatory. I'm using claws-mail
to send you this e-mail and for my work in general.

There are other graphical or text-based clients (Evolution, pine,
sylpheed, KMail, many others) that can also be used for this purpose. I
would suggest that you look at screenshots, maybe play with some of
them, find one you're comfortable with, and set it up.

-- 
Stefano

Re: [PATCH 4/4] [Outreachy kernel] staging: qlge: qlge_ethtool.c: remove an unneeded variable

[Payal Kshirsagar]

[-- Attachment #1: Type: text/plain, Size: 4517 bytes --]

On Wed, Mar 11, 2020 at 6:14 PM Stefano Brivio <sbrivio@redhat.com> wrote:

> On Wed, 11 Mar 2020 17:50:35 +0530
> Payal Kshirsagar <payalskshirsagar1234@gmail.com> wrote:
>
> > On Wed, Mar 11, 2020, 5:38 PM Stefano Brivio <sbrivio@redhat.com> wrote:
> >
> > > On Wed, 11 Mar 2020 14:58:15 +0530
> > > Payal Kshirsagar <payalskshirsagar1234@gmail.com> wrote:
> > >
> > > > Remove unneeded temporary local variable, cleanup suggested by
> > > coccinelle.
> > > >
> > > > Signed-off-by: Payal Kshirsagar <payalskshirsagar1234@gmail.com>
> > > > ---
> > > >  drivers/staging/qlge/qlge_ethtool.c | 5 +----
> > > >  1 file changed, 1 insertion(+), 4 deletions(-)
> > > >
> > > > diff --git a/drivers/staging/qlge/qlge_ethtool.c
> > > b/drivers/staging/qlge/qlge_ethtool.c
> > > > index 592ca7edfc44..e15f9723b5c0 100644
> > > > --- a/drivers/staging/qlge/qlge_ethtool.c
> > > > +++ b/drivers/staging/qlge/qlge_ethtool.c
> > > > @@ -692,7 +692,6 @@ static int ql_set_pauseparam(struct net_device
> > > *netdev,
> > > >                            struct ethtool_pauseparam *pause)
> > > >  {
> > > >       struct ql_adapter *qdev = netdev_priv(netdev);
> > > > -     int status = 0;
> > > >
> > > >       if ((pause->rx_pause) && (pause->tx_pause))
> > > >               qdev->link_config |= CFG_PAUSE_STD;
> > > > @@ -700,9 +699,7 @@ static int ql_set_pauseparam(struct net_device
> > > *netdev,
> > > >               qdev->link_config &= ~CFG_PAUSE_STD;
> > > >       else
> > > >               return -EINVAL;
> > > > -
> > > > -     status = ql_mb_set_port_cfg(qdev);
> > > > -     return status;
> > > > +     return ql_mb_set_port_cfg(qdev);
> > >
> > > Here, you're also removing a newline that is typically inserted before
> > > a second return (or the last one in a function) for readability, or
> > > whenever there are two logically distinct branches, same in 3/4.
> > >
> >
> > Thanks for the suggestion.
> > I thought there is no need to keep the newline as is:D
>
> Have a look at some "sane" examples (especially outside of
> drivers/staging), maybe that helps getting a picture...
>
> > But I did not understand what do you want me to do, patch is okay or need
> > to be resend by adding a newline for readability:)
>
> I would say you need to re-send the series, because 3/4 and 4/4
> actually impair readability in their current form.
>
> Note that I gave my Reviewed-by: on another patch of yours, not on
> this series.
>
> Another note: from the cover letter, it's apparent that "[Outreachy
> kernel]" is part of commit titles. It shouldn't be, that's only a
> prefix (git format-patch --subject-prefix) for email.
> If I run git format-patch --subject-prefix="Outreachy Kernel" HEAD^, it
> only adds [Outreachy Kernel] prefix to the subject not [PATCH].  I am only
> able to add either [Outreachy Kernel] or [PATCH]. Please guide me regarding
> the same.
>
>
> > payal
> >
> > And in 1/4, you might want to add one. In 2/4, there's no need.
> > >
> > > --
> > > Stefano
> > >
>
> One note about quoting: read above. Who wrote what?
>
> I see you're using GMail, which is fine, by all means, but:
>
> - you shouldn't send HTML emails to kernel lists. Especially with
>   projects using patchwork
>   (example: https://patchwork.ozlabs.org/project/netdev/list/) this
>   has a big potential to mess things up
>
> - you should fix your quoting: a sentence I wrote needs a "> >" prefix
>   there, otherwise it seems to come from you, and I'll get confused.
>
> That is, I suggest that you set up an email client as also covered by
> the tutorial. The GMail web interface is probably not ideal. The
> tutorial suggests 'mutt', but it's not mandatory. I'm using claws-mail
> to send you this e-mail and for my work in general.
>
> There are other graphical or text-based clients (Evolution, pine,
> sylpheed, KMail, many others) that can also be used for this purpose. I
> would suggest that you look at screenshots, maybe play with some of
> them, find one you're comfortable with, and set it up.
> I followed every step of setting up the gmail as mentioned in tutorial, I
> don't know why this is happening;(
> --
> Stefano
>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/outreachy-kernel/20200311134418.468f571a%40elisabeth
> .
>

[-- Attachment #2: Type: text/html, Size: 6521 bytes --]

Re: [PATCH 4/4] [Outreachy kernel] staging: qlge: qlge_ethtool.c: remove an unneeded variable

[Stefano Brivio]

Payal,

On Wed, 11 Mar 2020 19:16:21 +0530
Payal Kshirsagar <payalskshirsagar1234@gmail.com> wrote:

> On Wed, Mar 11, 2020 at 6:14 PM Stefano Brivio <sbrivio@redhat.com> wrote:
> 
> > There are other graphical or text-based clients (Evolution, pine,
> > sylpheed, KMail, many others) that can also be used for this purpose. I
> > would suggest that you look at screenshots, maybe play with some of
> > them, find one you're comfortable with, and set it up.
> > I followed every step of setting up the gmail as mentioned in tutorial, I
> > don't know why this is happening;(

I guess you set up git to play along with GMail, and that's fine to
send patches -- I see it's working properly.

But, for this discussion, are you sure you are using an actual email
client (and not a browser connected to gmail.com)? That is, are you
using one of those programs I mentioned below?

-- 
Stefano

Re: [PATCH 4/4] [Outreachy kernel] staging: qlge: qlge_ethtool.c: remove an unneeded variable

[Payal Kshirsagar]

[-- Attachment #1: Type: text/plain, Size: 1261 bytes --]

On Wed, Mar 11, 2020, 8:02 PM Stefano Brivio <sbrivio@redhat.com> wrote:

> Payal,
>
> On Wed, 11 Mar 2020 19:16:21 +0530
> Payal Kshirsagar <payalskshirsagar1234@gmail.com> wrote:
>
> > On Wed, Mar 11, 2020 at 6:14 PM Stefano Brivio <sbrivio@redhat.com>
> wrote:
> >
> > > There are other graphical or text-based clients (Evolution, pine,
> > > sylpheed, KMail, many others) that can also be used for this purpose. I
> > > would suggest that you look at screenshots, maybe play with some of
> > > them, find one you're comfortable with, and set it up.
> > > I followed every step of setting up the gmail as mentioned in
> tutorial, I
> > > don't know why this is happening;(
>
> I guess you set up git to play along with GMail, and that's fine to
> send patches -- I see it's working properly.
>
> But, for this discussion, are you sure you are using an actual email
> client (and not a browser connected to gmail.com)? That is, are you
> using one of those programs I mentioned below?
>
> Yes I am using the Gmail not in a browser.
>
>           Sir I am having trouble with adding [Outreachy Kernel] [PATCH]
> prefix to the subject, I am not able to add these two at the same time.
>                           Please suggest me something.

-- 
> Stefano
>
>

[-- Attachment #2: Type: text/html, Size: 2315 bytes --]

Re: [PATCH 4/4] [Outreachy kernel] staging: qlge: qlge_ethtool.c: remove an unneeded variable

[Julia Lawall]

[-- Attachment #1: Type: text/plain, Size: 2561 bytes --]



On Wed, 11 Mar 2020, Payal Kshirsagar wrote:

>
>
> On Wed, Mar 11, 2020, 8:02 PM Stefano Brivio <sbrivio@redhat.com> wrote:
>       Payal,
>
>       On Wed, 11 Mar 2020 19:16:21 +0530
>       Payal Kshirsagar <payalskshirsagar1234@gmail.com> wrote:
>
>       > On Wed, Mar 11, 2020 at 6:14 PM Stefano Brivio
>       <sbrivio@redhat.com> wrote:
>       >
>       > > There are other graphical or text-based clients (Evolution,
>       pine,
>       > > sylpheed, KMail, many others) that can also be used for this
>       purpose. I
>       > > would suggest that you look at screenshots, maybe play with
>       some of
>       > > them, find one you're comfortable with, and set it up.
>       > > I followed every step of setting up the gmail as mentioned
>       in tutorial, I
>       > > don't know why this is happening;(
>
>       I guess you set up git to play along with GMail, and that's fine
>       to
>       send patches -- I see it's working properly.
>
>       But, for this discussion, are you sure you are using an actual
>       email
>       client (and not a browser connected to gmail.com)? That is, are
>       you
>       using one of those programs I mentioned below?                  
>                         
>       Yes I am using the Gmail not in a browser.                      
>                                                                      
>                                       Sir I am having trouble with
>       adding [Outreachy Kernel] [PATCH] prefix to the subject, I am
>       not able to add these two at the same time.                    

You should never add [Outreachy Kernel] to anything.  When you send
messages to the mailing list, that will get added.

I agree with Stefano that your way of responding to messages causes
problems.  If you look above, there is no way to see what you wrote and
what Stefano wrote.

What program do you use to read and respond to your mail?

julia


>                 Please suggest me something.                
>
>       --
>       Stefano
>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/CAJyzNhkd%2BeBh%2BDPbQWR
> CLushYFRTRWKNF%3DkrY5AJG25U56%3DhDQ%40mail.gmail.com.
>
>

Re: [PATCH 4/4] [Outreachy kernel] staging: qlge: qlge_ethtool.c: remove an unneeded variable

[Payal Kshirsagar]

[-- Attachment #1: Type: text/plain, Size: 2517 bytes --]

On Wed, Mar 11, 2020, 8:37 PM Julia Lawall <julia.lawall@inria.fr> wrote:

>
>
> On Wed, 11 Mar 2020, Payal Kshirsagar wrote:
>
> >
> >
> > On Wed, Mar 11, 2020, 8:02 PM Stefano Brivio <sbrivio@redhat.com> wrote:
> >       Payal,
> >
> >       On Wed, 11 Mar 2020 19:16:21 +0530
> >       Payal Kshirsagar <payalskshirsagar1234@gmail.com> wrote:
> >
> >       > On Wed, Mar 11, 2020 at 6:14 PM Stefano Brivio
> >       <sbrivio@redhat.com> wrote:
> >       >
> >       > > There are other graphical or text-based clients (Evolution,
> >       pine,
> >       > > sylpheed, KMail, many others) that can also be used for this
> >       purpose. I
> >       > > would suggest that you look at screenshots, maybe play with
> >       some of
> >       > > them, find one you're comfortable with, and set it up.
> >       > > I followed every step of setting up the gmail as mentioned
> >       in tutorial, I
> >       > > don't know why this is happening;(
> >
> >       I guess you set up git to play along with GMail, and that's fine
> >       to
> >       send patches -- I see it's working properly.
> >
> >       But, for this discussion, are you sure you are using an actual
> >       email
> >       client (and not a browser connected to gmail.com)? That is, are
> >       you
> >       using one of those programs I mentioned below?
> >
> >       Yes I am using the Gmail not in a browser.
> >
> >                                       Sir I am having trouble with
> >       adding [Outreachy Kernel] [PATCH] prefix to the subject, I am
> >       not able to add these two at the same time.
>
> You should never add [Outreachy Kernel] to anything.  When you send
> messages to the mailing list, that will get added.
>
> I agree with Stefano that your way of responding to messages causes
> problems.  If you look above, there is no way to see what you wrote and
> what Stefano wrote.
>
> What program do you use to read and respond to your mail?
>

An android app Gmail.

julia
>
>
> >                 Please suggest me something.
> >
> >       --
> >       Stefano
> >
> > --
> > You received this message because you are subscribed to the Google Groups
> > "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send an
> > email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To view this discussion on the web visithttps://
> groups.google.com/d/msgid/outreachy-kernel/CAJyzNhkd%2BeBh%2BDPbQWR
> > CLushYFRTRWKNF%3DkrY5AJG25U56%3DhDQ%40mail.gmail.com.
> >
> >

[-- Attachment #2: Type: text/html, Size: 4485 bytes --]

Re: [PATCH 4/4] [Outreachy kernel] staging: qlge: qlge_ethtool.c: remove an unneeded variable

[Stefano Brivio]

[Dropping some probably uninterested Cc's]

On Wed, 11 Mar 2020 21:22:54 +0530
Payal Kshirsagar <payalskshirsagar1234@gmail.com> wrote:

> On Wed, Mar 11, 2020, 8:37 PM Julia Lawall <julia.lawall@inria.fr> wrote:
>
> > What program do you use to read and respond to your mail?
> >  
> 
> An android app Gmail.
> 
> julia

Payal-impersonating-julia, :)

If an Android device is what you plan to using for development, it
might be challenging, but I don't exclude it's doable. We'll have to
figure out a way to get your quoting right.

By the way, K-9 Mail is what I use on my smartphone in case of emergency
(laptop/PC not available), with a bit of care it can be used to
contribute as well.

If, on the other hand, you plan on using a regular Linux distribution
for development, I would suggest that you use that system and that you
take some time to set up an e-mail client there.

-- 
Stefano

Re: [PATCH 4/4] [Outreachy kernel] staging: qlge: qlge_ethtool.c: remove an unneeded variable

[Payal Kshirsagar]

[-- Attachment #1: Type: text/plain, Size: 2933 bytes --]

It does not adding [Outreachy Kernel] automatically in my system :(

On March 11, 2020 9:22:54 PM GMT+05:30, Payal Kshirsagar <payalskshirsagar1234@gmail.com> wrote:
>On Wed, Mar 11, 2020, 8:37 PM Julia Lawall <julia.lawall@inria.fr>
>wrote:
>
>>
>>
>> On Wed, 11 Mar 2020, Payal Kshirsagar wrote:
>>
>> >
>> >
>> > On Wed, Mar 11, 2020, 8:02 PM Stefano Brivio <sbrivio@redhat.com>
>wrote:
>> >       Payal,
>> >
>> >       On Wed, 11 Mar 2020 19:16:21 +0530
>> >       Payal Kshirsagar <payalskshirsagar1234@gmail.com> wrote:
>> >
>> >       > On Wed, Mar 11, 2020 at 6:14 PM Stefano Brivio
>> >       <sbrivio@redhat.com> wrote:
>> >       >
>> >       > > There are other graphical or text-based clients
>(Evolution,
>> >       pine,
>> >       > > sylpheed, KMail, many others) that can also be used for
>this
>> >       purpose. I
>> >       > > would suggest that you look at screenshots, maybe play
>with
>> >       some of
>> >       > > them, find one you're comfortable with, and set it up.
>> >       > > I followed every step of setting up the gmail as
>mentioned
>> >       in tutorial, I
>> >       > > don't know why this is happening;(
>> >
>> >       I guess you set up git to play along with GMail, and that's
>fine
>> >       to
>> >       send patches -- I see it's working properly.
>> >
>> >       But, for this discussion, are you sure you are using an
>actual
>> >       email
>> >       client (and not a browser connected to gmail.com)? That is,
>are
>> >       you
>> >       using one of those programs I mentioned below?
>> >
>> >       Yes I am using the Gmail not in a browser.
>> >
>> >                                       Sir I am having trouble with
>> >       adding [Outreachy Kernel] [PATCH] prefix to the subject, I am
>> >       not able to add these two at the same time.
>>
>> You should never add [Outreachy Kernel] to anything.  When you send
>> messages to the mailing list, that will get added.
>>
>> I agree with Stefano that your way of responding to messages causes
>> problems.  If you look above, there is no way to see what you wrote
>and
>> what Stefano wrote.
>>
>> What program do you use to read and respond to your mail?
>>
>
>An android app Gmail.
>
>julia
>>
>>
>> >                 Please suggest me something.
>> >
>> >       --
>> >       Stefano
>> >
>> > --
>> > You received this message because you are subscribed to the Google
>Groups
>> > "outreachy-kernel" group.
>> > To unsubscribe from this group and stop receiving emails from it,
>send an
>> > email to outreachy-kernel+unsubscribe@googlegroups.com.
>> > To view this discussion on the web visithttps://
>> groups.google.com/d/msgid/outreachy-kernel/CAJyzNhkd%2BeBh%2BDPbQWR
>> > CLushYFRTRWKNF%3DkrY5AJG25U56%3DhDQ%40mail.gmail.com.
>> >
>> >

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.

[-- Attachment #2: Type: text/html, Size: 5869 bytes --]

Re: [PATCH 4/4] [Outreachy kernel] staging: qlge: qlge_ethtool.c: remove an unneeded variable

[Julia Lawall]

[-- Attachment #1: Type: text/plain, Size: 3968 bytes --]



On Wed, 11 Mar 2020, Payal Kshirsagar wrote:

> It does not adding [Outreachy Kernel] automatically in my system :(

I don't understand what you mean by "in my system".  [Outreachy kernel]
appears when other people receive your messages via the mailing list.  It
has nothing to do with you.

julia

>
> On March 11, 2020 9:22:54 PM GMT+05:30, Payal Kshirsagar
> <payalskshirsagar1234@gmail.com> wrote:
>
>
>       On Wed, Mar 11, 2020, 8:37 PM Julia Lawall
>       <julia.lawall@inria.fr> wrote:
>
>
>       On Wed, 11 Mar 2020, Payal Kshirsagar wrote:
>
>       >
>       >
>       > On Wed, Mar 11, 2020, 8:02 PM Stefano Brivio
>       <sbrivio@redhat.com> wrote:
>       >       Payal,
>       >
>       >       On Wed, 11 Mar 2020 19:16:21 +0530
>       >       Payal Kshirsagar <payalskshirsagar1234@gmail.com>
>       wrote:
>       >
>       >       > On Wed, Mar 11, 2020 at 6:14 PM Stefano Brivio
>       >       <sbrivio@redhat.com> wrote:
>       >       >
>       >       > > There are other graphical or text-based
>       clients (Evolution,
>       >       pine,
>       >       > > sylpheed, KMail, many others) that can also be
>       used for this
>       >       purpose. I
>       >       > > would suggest that you look at screenshots,
>       maybe play with
>       >       some of
>       >       > > them, find one you're comfortable with, and
>       set it up.
>       >       > > I followed every step of setting up the gmail
>       as mentioned
>       >       in tutorial, I
>       >       > > don't know why this is happening;(
>       >
>       >       I guess you set up git to play along with GMail,
>       and that's fine
>       >       to
>       >       send patches -- I see it's working properly.
>       >
>       >       But, for this discussion, are you sure you are
>       using an actual
>       >       email
>       >       client (and not a browser connected to gmail.com)?
>       That is, are
>       >       you
>       >       using one of those programs I mentioned below?    
>                    
>       >                         
>       >       Yes I am using the Gmail not in a browser.        
>                    
>       >                                                        
>                    
>       >                                       Sir I am having
>       trouble with
>       >       adding [Outreachy Kernel] [PATCH] prefix to the
>       subject, I am
>       >       not able to add these two at the same time.      
>                    
>
>       You should never add [Outreachy Kernel] to anything.  When
>       you send
>       messages to the mailing list, that will get added.
>
>       I agree with Stefano that your way of responding to
>       messages causes
>       problems.  If you look above, there is no way to see what
>       you wrote and
>       what Stefano wrote.
>
>       What program do you use to read and respond to your mail?
>
>
> An android app Gmail.
>
>       julia
>
>
>       >                 Please suggest me something.            
>          
>       >
>       >       --
>       >       Stefano
>       >
>       > --
>       > You received this message because you are subscribed to
>       the Google Groups
>       > "outreachy-kernel" group.
>       > To unsubscribe from this group and stop receiving emails
>       from it, send an
>       > email to outreachy-kernel+unsubscribe@googlegroups.com.
>       > To view this discussion on the webvisithttps://groups.google.com/d/msgid/outreachy-kernel/CAJyzNhkd%2BeBh%2BD
>       PbQWR
>       > CLushYFRTRWKNF%3DkrY5AJG25U56%3DhDQ%40mail.gmail.com.
>       >
>       >
>
>
> --
> Sent from my Android device with K-9 Mail. Please excuse my brevity.
>

Re: [PATCH 4/4] [Outreachy kernel] staging: qlge: qlge_ethtool.c: remove an unneeded variable

[Stefano Brivio]

On Wed, 11 Mar 2020 21:31:30 +0100 (CET)
Julia Lawall <julia.lawall@inria.fr> wrote:

> On Wed, 11 Mar 2020, Payal Kshirsagar wrote:
> 
> > It does not adding [Outreachy Kernel] automatically in my system :(  
> 
> I don't understand what you mean by "in my system".  [Outreachy kernel]
> appears when other people receive your messages via the mailing list.  It
> has nothing to do with you.

I think what happened to Payal here is that K-9 Mail detects the email
as "sent" even when shown in a folder, and shows the copy as sent,
which doesn't then carry the tag added to the subject. Should be fixed
by switching to Evolution :)

-- 
Stefano