From: Kaaira Gupta <kgupta@es.iitr.ac.in>
To: Ian Abbott <abbotti@mev.co.uk>,
H Hartley Sweeten <hsweeten@visionengravers.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
outreachy-kernel@googlegroups.com
Cc: Kaaira Gupta <kgupta@es.iitr.ac.in>
Subject: [PATCH 1/5] staging: comedi: ni_mio_common.c: reformat code
Date: Thu, 12 Mar 2020 00:13:23 +0530 [thread overview]
Message-ID: <20200311184327.25338-2-kgupta@es.iitr.ac.in> (raw)
In-Reply-To: <20200311184327.25338-1-kgupta@es.iitr.ac.in>
reformat the arguments given to ni_stc_writew() to increase code
readability in ni_mio_common.c
Signed-off-by: Kaaira Gupta <kgupta@es.iitr.ac.in>
---
drivers/staging/comedi/drivers/ni_mio_common.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/comedi/drivers/ni_mio_common.c b/drivers/staging/comedi/drivers/ni_mio_common.c
index b72a40a79930..06ed4b1dd875 100644
--- a/drivers/staging/comedi/drivers/ni_mio_common.c
+++ b/drivers/staging/comedi/drivers/ni_mio_common.c
@@ -2445,9 +2445,9 @@ static int ni_ai_cmd(struct comedi_device *dev, struct comedi_subdevice *s)
#endif
if (cmd->start_src == TRIG_NOW) {
- ni_stc_writew(dev, NISTC_AI_CMD2_START1_PULSE |
- devpriv->ai_cmd2,
- NISTC_AI_CMD2_REG);
+ ni_stc_writew(dev, devpriv->ai_cmd2 |
+ NISTC_AI_CMD2_START1_PULSE,
+ NISTC_AI_CMD2_REG);
s->async->inttrig = NULL;
} else if (cmd->start_src == TRIG_EXT) {
s->async->inttrig = NULL;
--
2.17.1
next prev parent reply other threads:[~2020-03-11 18:43 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-11 18:43 [PATCH 0/5] patchset for clean-ups in comedi Kaaira Gupta
2020-03-11 18:43 ` Kaaira Gupta [this message]
2020-03-11 23:20 ` [Outreachy kernel] [PATCH 1/5] staging: comedi: ni_mio_common.c: reformat code Stefano Brivio
2020-03-12 8:16 ` Greg Kroah-Hartman
2020-03-12 14:56 ` Kaaira Gupta
2020-03-12 15:25 ` Greg Kroah-Hartman
2020-03-11 18:43 ` [PATCH 2/5] staging: comedi: check condition in one statement Kaaira Gupta
2020-03-11 23:17 ` [Outreachy kernel] " Stefano Brivio
2020-03-12 8:17 ` Greg Kroah-Hartman
2020-03-12 14:54 ` Kaaira Gupta
2020-03-11 18:43 ` [PATCH 3/5] staging: comedi: drivers: add line after struct Kaaira Gupta
2020-03-12 8:18 ` Greg Kroah-Hartman
2020-03-12 14:53 ` Kaaira Gupta
2020-03-11 18:43 ` [PATCH 4/5] staging: comedi: add braces to prevent precedence Kaaira Gupta
2020-03-12 8:18 ` Greg Kroah-Hartman
2020-03-12 14:53 ` Kaaira Gupta
2020-03-11 18:43 ` [PATCH 5/5] staging: comedi: drivers: use unsigned int Kaaira Gupta
2020-03-11 20:51 ` [Outreachy kernel] " Julia Lawall
2020-03-11 22:11 ` Kaaira Gupta
2020-03-15 20:23 ` Stefano Brivio
2020-03-12 8:17 ` Greg Kroah-Hartman
2020-03-12 14:52 ` Kaaira Gupta
2020-03-12 15:21 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200311184327.25338-2-kgupta@es.iitr.ac.in \
--to=kgupta@es.iitr.ac.in \
--cc=abbotti@mev.co.uk \
--cc=gregkh@linuxfoundation.org \
--cc=hsweeten@visionengravers.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.