Re: [Outreachy kernel] [PATCH 5/5] staging: comedi: drivers: use unsigned int

From: Julia Lawall <julia.lawall@inria.fr>
To: Kaaira Gupta <kgupta@es.iitr.ac.in>
Cc: Ian Abbott <abbotti@mev.co.uk>,
	 H Hartley Sweeten <hsweeten@visionengravers.com>,
	 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	 outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH 5/5] staging: comedi: drivers: use unsigned int
Date: Wed, 11 Mar 2020 21:51:10 +0100 (CET)	[thread overview]
Message-ID: <alpine.DEB.2.21.2003112150260.6093@hadrien> (raw)
In-Reply-To: <20200311184327.25338-6-kgupta@es.iitr.ac.in>

On Thu, 12 Mar 2020, Kaaira Gupta wrote:

> Change i's type to unsigned instead of signed. It's always positive.
> Reported by coccinelle.
>
> Signed-off-by: Kaaira Gupta <kgupta@es.iitr.ac.in>
> ---
>  drivers/staging/comedi/drivers/ni_mio_common.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/comedi/drivers/ni_mio_common.c b/drivers/staging/comedi/drivers/ni_mio_common.c
> index 06ed4b1dd875..034cf8dafaf0 100644
> --- a/drivers/staging/comedi/drivers/ni_mio_common.c
> +++ b/drivers/staging/comedi/drivers/ni_mio_common.c
> @@ -888,7 +888,7 @@ static void ni_sync_ai_dma(struct comedi_device *dev)
>  static int ni_ai_drain_dma(struct comedi_device *dev)
>  {
>  	struct ni_private *devpriv = dev->private;
> -	int i;
> +	unsigned int i;

I'm not sure this is useful.  The value is not going to b lare enough to
require an unsigned.  And loop indices often have type int.

julia

>  	static const int timeout = 10000;
>  	unsigned long flags;
>  	int retval = 0;
> --
> 2.17.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200311184327.25338-6-kgupta%40es.iitr.ac.in.
>