Re: [PATCH 5/5] staging: comedi: drivers: use unsigned int

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Thu, Mar 12, 2020 at 08:22:31PM +0530, Kaaira Gupta wrote:
> On Thu, Mar 12, 2020 at 09:17:14AM +0100, Greg Kroah-Hartman wrote:
> > On Thu, Mar 12, 2020 at 12:13:27AM +0530, Kaaira Gupta wrote:
> > > Change i's type to unsigned instead of signed. It's always positive.
> > > Reported by coccinelle.
> > > 
> > > Signed-off-by: Kaaira Gupta <kgupta@es.iitr.ac.in>
> > > ---
> > >  drivers/staging/comedi/drivers/ni_mio_common.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/staging/comedi/drivers/ni_mio_common.c b/drivers/staging/comedi/drivers/ni_mio_common.c
> > > index 06ed4b1dd875..034cf8dafaf0 100644
> > > --- a/drivers/staging/comedi/drivers/ni_mio_common.c
> > > +++ b/drivers/staging/comedi/drivers/ni_mio_common.c
> > > @@ -888,7 +888,7 @@ static void ni_sync_ai_dma(struct comedi_device *dev)
> > >  static int ni_ai_drain_dma(struct comedi_device *dev)
> > >  {
> > >  	struct ni_private *devpriv = dev->private;
> > > -	int i;
> > > +	unsigned int i;
> > 
> > Why is this needed?
> 
> Since it's always positive and I though that it's maximum value might get
> greater than 2^31, hence I changed it.

Then say so in the changelog text.

But first verify that this really can get that big, otherwise just leave
it alone.

thanks,

greg k-h