From: Kaaira Gupta <kgupta@es.iitr.ac.in>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Kaaira Gupta <kgupta@es.iitr.ac.in>,
Ian Abbott <abbotti@mev.co.uk>,
H Hartley Sweeten <hsweeten@visionengravers.com>,
outreachy-kernel@googlegroups.com
Subject: Re: [PATCH 2/5] staging: comedi: check condition in one statement
Date: Thu, 12 Mar 2020 20:24:50 +0530 [thread overview]
Message-ID: <20200312145450.GD30896@kaaira-HP-Pavilion-Notebook> (raw)
In-Reply-To: <20200312081702.GC11746@kroah.com>
On Thu, Mar 12, 2020 at 09:17:02AM +0100, Greg Kroah-Hartman wrote:
> On Thu, Mar 12, 2020 at 12:13:24AM +0530, Kaaira Gupta wrote:
> > check two conditions in one `if` statement rather than two since both
> > return same thing in file usbdux.c
> >
> > Signed-off-by: Kaaira Gupta <kgupta@es.iitr.ac.in>
> > ---
> > drivers/staging/comedi/drivers/usbdux.c | 4 +---
> > 1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/drivers/staging/comedi/drivers/usbdux.c b/drivers/staging/comedi/drivers/usbdux.c
> > index 0350f303d557..8eff7f140560 100644
> > --- a/drivers/staging/comedi/drivers/usbdux.c
> > +++ b/drivers/staging/comedi/drivers/usbdux.c
> > @@ -617,9 +617,7 @@ static int receive_dux_commands(struct comedi_device *dev, unsigned int command)
> > ret = usb_bulk_msg(usb, usb_rcvbulkpipe(usb, 8),
> > devpriv->insn_buf, SIZEINSNBUF,
> > &nrec, BULK_TIMEOUT);
> > - if (ret < 0)
> > - return ret;
> > - if (le16_to_cpu(devpriv->insn_buf[0]) == command)
> > + if (ret < 0 || le16_to_cpu(devpriv->insn_buf[0]) == command)
> > return ret;
>
> The original is better, please leave it as-is.
OKay!
Thanks!
>
> thanks,
>
> greg k-h
next prev parent reply other threads:[~2020-03-12 14:54 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-11 18:43 [PATCH 0/5] patchset for clean-ups in comedi Kaaira Gupta
2020-03-11 18:43 ` [PATCH 1/5] staging: comedi: ni_mio_common.c: reformat code Kaaira Gupta
2020-03-11 23:20 ` [Outreachy kernel] " Stefano Brivio
2020-03-12 8:16 ` Greg Kroah-Hartman
2020-03-12 14:56 ` Kaaira Gupta
2020-03-12 15:25 ` Greg Kroah-Hartman
2020-03-11 18:43 ` [PATCH 2/5] staging: comedi: check condition in one statement Kaaira Gupta
2020-03-11 23:17 ` [Outreachy kernel] " Stefano Brivio
2020-03-12 8:17 ` Greg Kroah-Hartman
2020-03-12 14:54 ` Kaaira Gupta [this message]
2020-03-11 18:43 ` [PATCH 3/5] staging: comedi: drivers: add line after struct Kaaira Gupta
2020-03-12 8:18 ` Greg Kroah-Hartman
2020-03-12 14:53 ` Kaaira Gupta
2020-03-11 18:43 ` [PATCH 4/5] staging: comedi: add braces to prevent precedence Kaaira Gupta
2020-03-12 8:18 ` Greg Kroah-Hartman
2020-03-12 14:53 ` Kaaira Gupta
2020-03-11 18:43 ` [PATCH 5/5] staging: comedi: drivers: use unsigned int Kaaira Gupta
2020-03-11 20:51 ` [Outreachy kernel] " Julia Lawall
2020-03-11 22:11 ` Kaaira Gupta
2020-03-15 20:23 ` Stefano Brivio
2020-03-12 8:17 ` Greg Kroah-Hartman
2020-03-12 14:52 ` Kaaira Gupta
2020-03-12 15:21 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200312145450.GD30896@kaaira-HP-Pavilion-Notebook \
--to=kgupta@es.iitr.ac.in \
--cc=abbotti@mev.co.uk \
--cc=gregkh@linuxfoundation.org \
--cc=hsweeten@visionengravers.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.