All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: "Ricardo Cañuelo" <ricardo.canuelo@collabora.com>
Cc: kernel@collabora.com, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, geert+renesas@glider.be,
	robh+dt@kernel.org, xuwei5@hisilicon.com
Subject: Re: [PATCH v2 1/6] arm64: dts: renesas: make hdmi encoder nodes compliant with DT bindings
Date: Thu, 14 May 2020 04:33:43 +0300	[thread overview]
Message-ID: <20200514013343.GA7425@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20200511110611.3142-2-ricardo.canuelo@collabora.com>

Hi Ricardo,

Thank you for the patch.

On Mon, May 11, 2020 at 01:06:06PM +0200, Ricardo Cañuelo wrote:
> Small fixes to make these DTs compliant with the adi,adv7511w binding.
> 
> r8a77970-eagle.dts,
> r8a77970-v3msk.dts,
> r8a77980-condor.dts,
> r8a77980-v3hsk.dts,
> r8a77990-ebisu.dts:
>   remove the adi,input-style and adi,input-justification properties.
> 
> r8a77995-draak.dts:
>   Reorder the I2C slave addresses of the hdmi-encoder@39 node and remove
>   the adi,input-style and adi,input-justification properties.
> 
> Signed-off-by: Ricardo Cañuelo <ricardo.canuelo@collabora.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  arch/arm64/boot/dts/renesas/r8a77970-eagle.dts  | 2 --
>  arch/arm64/boot/dts/renesas/r8a77970-v3msk.dts  | 2 --
>  arch/arm64/boot/dts/renesas/r8a77980-condor.dts | 2 --
>  arch/arm64/boot/dts/renesas/r8a77980-v3hsk.dts  | 2 --
>  arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts  | 2 --
>  arch/arm64/boot/dts/renesas/r8a77995-draak.dts  | 6 ++----
>  6 files changed, 2 insertions(+), 14 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/renesas/r8a77970-eagle.dts b/arch/arm64/boot/dts/renesas/r8a77970-eagle.dts
> index 2afb91ec9c8d..ac2156ab3e62 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77970-eagle.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a77970-eagle.dts
> @@ -137,8 +137,6 @@
>  		adi,input-depth = <8>;
>  		adi,input-colorspace = "rgb";
>  		adi,input-clock = "1x";
> -		adi,input-style = <1>;
> -		adi,input-justification = "evenly";
>  
>  		ports {
>  			#address-cells = <1>;
> diff --git a/arch/arm64/boot/dts/renesas/r8a77970-v3msk.dts b/arch/arm64/boot/dts/renesas/r8a77970-v3msk.dts
> index d7c7b9156e08..01c4ba0f7be1 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77970-v3msk.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a77970-v3msk.dts
> @@ -150,8 +150,6 @@
>  		adi,input-depth = <8>;
>  		adi,input-colorspace = "rgb";
>  		adi,input-clock = "1x";
> -		adi,input-style = <1>;
> -		adi,input-justification = "evenly";
>  
>  		ports {
>  			#address-cells = <1>;
> diff --git a/arch/arm64/boot/dts/renesas/r8a77980-condor.dts b/arch/arm64/boot/dts/renesas/r8a77980-condor.dts
> index 3dde028e22a6..ef8350a062af 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77980-condor.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a77980-condor.dts
> @@ -174,8 +174,6 @@
>  		adi,input-depth = <8>;
>  		adi,input-colorspace = "rgb";
>  		adi,input-clock = "1x";
> -		adi,input-style = <1>;
> -		adi,input-justification = "evenly";
>  
>  		ports {
>  			#address-cells = <1>;
> diff --git a/arch/arm64/boot/dts/renesas/r8a77980-v3hsk.dts b/arch/arm64/boot/dts/renesas/r8a77980-v3hsk.dts
> index adbfd8f07d06..6dff04693223 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77980-v3hsk.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a77980-v3hsk.dts
> @@ -141,8 +141,6 @@
>  		adi,input-depth = <8>;
>  		adi,input-colorspace = "rgb";
>  		adi,input-clock = "1x";
> -		adi,input-style = <1>;
> -		adi,input-justification = "evenly";
>  
>  		ports {
>  			#address-cells = <1>;
> diff --git a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
> index 4fd2b14fbb8b..dc24cec46ae1 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
> @@ -360,8 +360,6 @@
>  		adi,input-depth = <8>;
>  		adi,input-colorspace = "rgb";
>  		adi,input-clock = "1x";
> -		adi,input-style = <1>;
> -		adi,input-justification = "evenly";
>  
>  		ports {
>  			#address-cells = <1>;
> diff --git a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
> index 67634cb01d6b..79c73a99d2fe 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
> @@ -272,8 +272,8 @@
>  
>  	hdmi-encoder@39 {
>  		compatible = "adi,adv7511w";
> -		reg = <0x39>, <0x3f>, <0x38>, <0x3c>;
> -		reg-names = "main", "edid", "packet", "cec";
> +		reg = <0x39>, <0x3f>, <0x3c>, <0x38>;
> +		reg-names = "main", "edid", "cec", "packet";
>  		interrupt-parent = <&gpio1>;
>  		interrupts = <28 IRQ_TYPE_LEVEL_LOW>;
>  
> @@ -284,8 +284,6 @@
>  		adi,input-depth = <8>;
>  		adi,input-colorspace = "rgb";
>  		adi,input-clock = "1x";
> -		adi,input-style = <1>;
> -		adi,input-justification = "evenly";
>  
>  		ports {
>  			#address-cells = <1>;

-- 
Regards,

Laurent Pinchart

WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: "Ricardo Cañuelo" <ricardo.canuelo@collabora.com>
Cc: devicetree@vger.kernel.org, geert+renesas@glider.be,
	xuwei5@hisilicon.com, robh+dt@kernel.org, kernel@collabora.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/6] arm64: dts: renesas: make hdmi encoder nodes compliant with DT bindings
Date: Thu, 14 May 2020 04:33:43 +0300	[thread overview]
Message-ID: <20200514013343.GA7425@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20200511110611.3142-2-ricardo.canuelo@collabora.com>

Hi Ricardo,

Thank you for the patch.

On Mon, May 11, 2020 at 01:06:06PM +0200, Ricardo Cañuelo wrote:
> Small fixes to make these DTs compliant with the adi,adv7511w binding.
> 
> r8a77970-eagle.dts,
> r8a77970-v3msk.dts,
> r8a77980-condor.dts,
> r8a77980-v3hsk.dts,
> r8a77990-ebisu.dts:
>   remove the adi,input-style and adi,input-justification properties.
> 
> r8a77995-draak.dts:
>   Reorder the I2C slave addresses of the hdmi-encoder@39 node and remove
>   the adi,input-style and adi,input-justification properties.
> 
> Signed-off-by: Ricardo Cañuelo <ricardo.canuelo@collabora.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  arch/arm64/boot/dts/renesas/r8a77970-eagle.dts  | 2 --
>  arch/arm64/boot/dts/renesas/r8a77970-v3msk.dts  | 2 --
>  arch/arm64/boot/dts/renesas/r8a77980-condor.dts | 2 --
>  arch/arm64/boot/dts/renesas/r8a77980-v3hsk.dts  | 2 --
>  arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts  | 2 --
>  arch/arm64/boot/dts/renesas/r8a77995-draak.dts  | 6 ++----
>  6 files changed, 2 insertions(+), 14 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/renesas/r8a77970-eagle.dts b/arch/arm64/boot/dts/renesas/r8a77970-eagle.dts
> index 2afb91ec9c8d..ac2156ab3e62 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77970-eagle.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a77970-eagle.dts
> @@ -137,8 +137,6 @@
>  		adi,input-depth = <8>;
>  		adi,input-colorspace = "rgb";
>  		adi,input-clock = "1x";
> -		adi,input-style = <1>;
> -		adi,input-justification = "evenly";
>  
>  		ports {
>  			#address-cells = <1>;
> diff --git a/arch/arm64/boot/dts/renesas/r8a77970-v3msk.dts b/arch/arm64/boot/dts/renesas/r8a77970-v3msk.dts
> index d7c7b9156e08..01c4ba0f7be1 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77970-v3msk.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a77970-v3msk.dts
> @@ -150,8 +150,6 @@
>  		adi,input-depth = <8>;
>  		adi,input-colorspace = "rgb";
>  		adi,input-clock = "1x";
> -		adi,input-style = <1>;
> -		adi,input-justification = "evenly";
>  
>  		ports {
>  			#address-cells = <1>;
> diff --git a/arch/arm64/boot/dts/renesas/r8a77980-condor.dts b/arch/arm64/boot/dts/renesas/r8a77980-condor.dts
> index 3dde028e22a6..ef8350a062af 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77980-condor.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a77980-condor.dts
> @@ -174,8 +174,6 @@
>  		adi,input-depth = <8>;
>  		adi,input-colorspace = "rgb";
>  		adi,input-clock = "1x";
> -		adi,input-style = <1>;
> -		adi,input-justification = "evenly";
>  
>  		ports {
>  			#address-cells = <1>;
> diff --git a/arch/arm64/boot/dts/renesas/r8a77980-v3hsk.dts b/arch/arm64/boot/dts/renesas/r8a77980-v3hsk.dts
> index adbfd8f07d06..6dff04693223 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77980-v3hsk.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a77980-v3hsk.dts
> @@ -141,8 +141,6 @@
>  		adi,input-depth = <8>;
>  		adi,input-colorspace = "rgb";
>  		adi,input-clock = "1x";
> -		adi,input-style = <1>;
> -		adi,input-justification = "evenly";
>  
>  		ports {
>  			#address-cells = <1>;
> diff --git a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
> index 4fd2b14fbb8b..dc24cec46ae1 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
> @@ -360,8 +360,6 @@
>  		adi,input-depth = <8>;
>  		adi,input-colorspace = "rgb";
>  		adi,input-clock = "1x";
> -		adi,input-style = <1>;
> -		adi,input-justification = "evenly";
>  
>  		ports {
>  			#address-cells = <1>;
> diff --git a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
> index 67634cb01d6b..79c73a99d2fe 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
> @@ -272,8 +272,8 @@
>  
>  	hdmi-encoder@39 {
>  		compatible = "adi,adv7511w";
> -		reg = <0x39>, <0x3f>, <0x38>, <0x3c>;
> -		reg-names = "main", "edid", "packet", "cec";
> +		reg = <0x39>, <0x3f>, <0x3c>, <0x38>;
> +		reg-names = "main", "edid", "cec", "packet";
>  		interrupt-parent = <&gpio1>;
>  		interrupts = <28 IRQ_TYPE_LEVEL_LOW>;
>  
> @@ -284,8 +284,6 @@
>  		adi,input-depth = <8>;
>  		adi,input-colorspace = "rgb";
>  		adi,input-clock = "1x";
> -		adi,input-style = <1>;
> -		adi,input-justification = "evenly";
>  
>  		ports {
>  			#address-cells = <1>;

-- 
Regards,

Laurent Pinchart

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2020-05-14  1:33 UTC|newest]

Thread overview: 66+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-11 11:06 [PATCH v2 0/6] Convert adi,adv7511.txt DT bindings to yaml Ricardo Cañuelo
2020-05-11 11:06 ` Ricardo Cañuelo
2020-05-11 11:06 ` [PATCH v2 1/6] arm64: dts: renesas: make hdmi encoder nodes compliant with DT bindings Ricardo Cañuelo
2020-05-11 11:06   ` Ricardo Cañuelo
2020-05-11 11:51   ` Geert Uytterhoeven
2020-05-11 11:51     ` Geert Uytterhoeven
2020-05-14  1:33   ` Laurent Pinchart [this message]
2020-05-14  1:33     ` Laurent Pinchart
2020-05-11 11:06 ` [PATCH v2 2/6] ARM: " Ricardo Cañuelo
2020-05-11 11:06   ` Ricardo Cañuelo
2020-05-11 11:51   ` Geert Uytterhoeven
2020-05-11 11:51     ` Geert Uytterhoeven
2020-05-14  1:34   ` Laurent Pinchart
2020-05-14  1:34     ` Laurent Pinchart
2020-05-11 11:06 ` [PATCH v2 3/6] ARM: dts: zynq: add port definitions to hdmi-tx@39 Ricardo Cañuelo
2020-05-11 11:06   ` Ricardo Cañuelo
2020-05-11 12:24   ` Ezequiel Garcia
2020-05-11 12:24     ` Ezequiel Garcia
2020-05-11 12:52     ` Michal Simek
2020-05-11 12:52       ` Michal Simek
2020-05-14  1:36       ` Laurent Pinchart
2020-05-14  1:36         ` Laurent Pinchart
2020-05-11 11:06 ` [PATCH v2 4/6] arm64: dts: hisilicon: hikey: fixes to comply with adi,adv7533 DT binding Ricardo Cañuelo
2020-05-11 11:06   ` [PATCH v2 4/6] arm64: dts: hisilicon: hikey: fixes to comply with adi, adv7533 " Ricardo Cañuelo
2020-05-14  1:37   ` [PATCH v2 4/6] arm64: dts: hisilicon: hikey: fixes to comply with adi,adv7533 " Laurent Pinchart
2020-05-14  1:37     ` Laurent Pinchart
2020-08-04 20:57   ` [PATCH v2 4/6] arm64: dts: hisilicon: hikey: fixes to comply with adi, adv7533 " John Stultz
2020-08-04 20:57     ` John Stultz
2020-08-04 21:24     ` John Stultz
2020-08-04 21:24       ` John Stultz
2020-05-11 11:06 ` [PATCH v2 5/6] ARM: dts: iwg20d-q7-dbcm-ca: remove unneeded properties in hdmi@39 Ricardo Cañuelo
2020-05-11 11:06   ` Ricardo Cañuelo
2020-05-11 11:52   ` Geert Uytterhoeven
2020-05-11 11:52     ` Geert Uytterhoeven
2020-05-14  1:37   ` Laurent Pinchart
2020-05-14  1:37     ` Laurent Pinchart
2020-05-11 11:06 ` [PATCH v2 6/6] dt-bindings: drm: bridge: adi,adv7511.txt: convert to yaml Ricardo Cañuelo
2020-05-11 11:06   ` [PATCH v2 6/6] dt-bindings: drm: bridge: adi, adv7511.txt: " Ricardo Cañuelo
2020-05-14  1:54   ` [PATCH v2 6/6] dt-bindings: drm: bridge: adi,adv7511.txt: " Laurent Pinchart
2020-05-14  1:54     ` Laurent Pinchart
2020-05-14  9:36     ` Ricardo Cañuelo
2020-05-14  9:36       ` Ricardo Cañuelo
2020-05-14 15:22       ` Laurent Pinchart
2020-05-14 15:22         ` Laurent Pinchart
2020-05-18 21:27         ` Rob Herring
2020-05-18 21:27           ` Rob Herring
2020-05-25  7:43         ` Ricardo Cañuelo
2020-05-25  7:43           ` Ricardo Cañuelo
2020-05-26  1:44           ` Laurent Pinchart
2020-05-26  1:44             ` Laurent Pinchart
2020-05-26  7:03             ` Geert Uytterhoeven
2020-05-26  7:03               ` [PATCH v2 6/6] dt-bindings: drm: bridge: adi, adv7511.txt: " Geert Uytterhoeven
2020-05-26 10:11               ` [PATCH v2 6/6] dt-bindings: drm: bridge: adi,adv7511.txt: " Laurent Pinchart
2020-05-26 10:11                 ` Laurent Pinchart
2020-05-26 10:39                 ` Geert Uytterhoeven
2020-05-26 10:39                   ` [PATCH v2 6/6] dt-bindings: drm: bridge: adi, adv7511.txt: " Geert Uytterhoeven
2020-05-26 19:45                   ` [PATCH v2 6/6] dt-bindings: drm: bridge: adi,adv7511.txt: " Ezequiel Garcia
2020-05-26 19:45                     ` Ezequiel Garcia
2020-05-27 17:29               ` Rob Herring
2020-05-27 17:29                 ` [PATCH v2 6/6] dt-bindings: drm: bridge: adi, adv7511.txt: " Rob Herring
2020-05-27 18:18                 ` [PATCH v2 6/6] dt-bindings: drm: bridge: adi,adv7511.txt: " Geert Uytterhoeven
2020-05-27 18:18                   ` [PATCH v2 6/6] dt-bindings: drm: bridge: adi, adv7511.txt: " Geert Uytterhoeven
2020-05-28  6:36                   ` [PATCH v2 6/6] dt-bindings: drm: bridge: adi,adv7511.txt: " Ricardo Cañuelo
2020-05-28  6:36                     ` Ricardo Cañuelo
2020-05-11 11:55 ` [PATCH v2 0/6] Convert adi,adv7511.txt DT bindings " Geert Uytterhoeven
2020-05-11 11:55   ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200514013343.GA7425@pendragon.ideasonboard.com \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=devicetree@vger.kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=kernel@collabora.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=ricardo.canuelo@collabora.com \
    --cc=robh+dt@kernel.org \
    --cc=xuwei5@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.