All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Stultz <john.stultz@linaro.org>
To: "Ricardo Cañuelo" <ricardo.canuelo@collabora.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Wei Xu <xuwei5@hisilicon.com>, Rob Herring <robh+dt@kernel.org>,
	kernel@collabora.com,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Subject: Re: [PATCH v2 4/6] arm64: dts: hisilicon: hikey: fixes to comply with adi, adv7533 DT binding
Date: Tue, 4 Aug 2020 13:57:18 -0700	[thread overview]
Message-ID: <CALAqxLWCCH8sDD+3-Qe=+siUAQgB2jn3349w+VTAj6uySKc8NA@mail.gmail.com> (raw)
In-Reply-To: <20200511110611.3142-5-ricardo.canuelo@collabora.com>

On Mon, May 11, 2020 at 4:07 AM Ricardo Cañuelo
<ricardo.canuelo@collabora.com> wrote:
>
> hi3660-hikey960.dts:
>   Define a 'ports' node for 'adv7533: adv7533@39' and the
>   'adi,dsi-lanes' property to make it compliant with the adi,adv7533 DT
>   binding.
>
>   This fills the requirements to meet the binding requirements,
>   remote endpoints are not defined.
>
> hi6220-hikey.dts:
>   Change property name s/pd-gpio/pd-gpios, gpio properties should be
>   plural. This is just a cosmetic change.
>
> Signed-off-by: Ricardo Cañuelo <ricardo.canuelo@collabora.com>

As a heads up.
So this change sounds sane, but I just bisected it down as the cause
of a regression on HiKey960 where the adv7511 driver doesn't probe.

I'll dig a bit more on what is going on (the DRM driver is still out
of tree, so maybe the DTS bits for that are not quite right?), but if
you have any suggestions, I'll give those a try.

If anyone is curious, my latest patches for the board is here:
https://git.linaro.org/people/john.stultz/android-dev.git/log/?h=dev/hikey960-mainline-WIP&id=4e6cefcc9bc1c13a503fdcb3768b3fd6479d8655

thanks
-john

WARNING: multiple messages have this Message-ID (diff)
From: John Stultz <john.stultz@linaro.org>
To: "Ricardo Cañuelo" <ricardo.canuelo@collabora.com>
Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
	Wei Xu <xuwei5@hisilicon.com>, Rob Herring <robh+dt@kernel.org>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	kernel@collabora.com,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 4/6] arm64: dts: hisilicon: hikey: fixes to comply with adi, adv7533 DT binding
Date: Tue, 4 Aug 2020 13:57:18 -0700	[thread overview]
Message-ID: <CALAqxLWCCH8sDD+3-Qe=+siUAQgB2jn3349w+VTAj6uySKc8NA@mail.gmail.com> (raw)
In-Reply-To: <20200511110611.3142-5-ricardo.canuelo@collabora.com>

On Mon, May 11, 2020 at 4:07 AM Ricardo Cañuelo
<ricardo.canuelo@collabora.com> wrote:
>
> hi3660-hikey960.dts:
>   Define a 'ports' node for 'adv7533: adv7533@39' and the
>   'adi,dsi-lanes' property to make it compliant with the adi,adv7533 DT
>   binding.
>
>   This fills the requirements to meet the binding requirements,
>   remote endpoints are not defined.
>
> hi6220-hikey.dts:
>   Change property name s/pd-gpio/pd-gpios, gpio properties should be
>   plural. This is just a cosmetic change.
>
> Signed-off-by: Ricardo Cañuelo <ricardo.canuelo@collabora.com>

As a heads up.
So this change sounds sane, but I just bisected it down as the cause
of a regression on HiKey960 where the adv7511 driver doesn't probe.

I'll dig a bit more on what is going on (the DRM driver is still out
of tree, so maybe the DTS bits for that are not quite right?), but if
you have any suggestions, I'll give those a try.

If anyone is curious, my latest patches for the board is here:
https://git.linaro.org/people/john.stultz/android-dev.git/log/?h=dev/hikey960-mainline-WIP&id=4e6cefcc9bc1c13a503fdcb3768b3fd6479d8655

thanks
-john

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2020-08-04 20:57 UTC|newest]

Thread overview: 66+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-11 11:06 [PATCH v2 0/6] Convert adi,adv7511.txt DT bindings to yaml Ricardo Cañuelo
2020-05-11 11:06 ` Ricardo Cañuelo
2020-05-11 11:06 ` [PATCH v2 1/6] arm64: dts: renesas: make hdmi encoder nodes compliant with DT bindings Ricardo Cañuelo
2020-05-11 11:06   ` Ricardo Cañuelo
2020-05-11 11:51   ` Geert Uytterhoeven
2020-05-11 11:51     ` Geert Uytterhoeven
2020-05-14  1:33   ` Laurent Pinchart
2020-05-14  1:33     ` Laurent Pinchart
2020-05-11 11:06 ` [PATCH v2 2/6] ARM: " Ricardo Cañuelo
2020-05-11 11:06   ` Ricardo Cañuelo
2020-05-11 11:51   ` Geert Uytterhoeven
2020-05-11 11:51     ` Geert Uytterhoeven
2020-05-14  1:34   ` Laurent Pinchart
2020-05-14  1:34     ` Laurent Pinchart
2020-05-11 11:06 ` [PATCH v2 3/6] ARM: dts: zynq: add port definitions to hdmi-tx@39 Ricardo Cañuelo
2020-05-11 11:06   ` Ricardo Cañuelo
2020-05-11 12:24   ` Ezequiel Garcia
2020-05-11 12:24     ` Ezequiel Garcia
2020-05-11 12:52     ` Michal Simek
2020-05-11 12:52       ` Michal Simek
2020-05-14  1:36       ` Laurent Pinchart
2020-05-14  1:36         ` Laurent Pinchart
2020-05-11 11:06 ` [PATCH v2 4/6] arm64: dts: hisilicon: hikey: fixes to comply with adi,adv7533 DT binding Ricardo Cañuelo
2020-05-11 11:06   ` [PATCH v2 4/6] arm64: dts: hisilicon: hikey: fixes to comply with adi, adv7533 " Ricardo Cañuelo
2020-05-14  1:37   ` [PATCH v2 4/6] arm64: dts: hisilicon: hikey: fixes to comply with adi,adv7533 " Laurent Pinchart
2020-05-14  1:37     ` Laurent Pinchart
2020-08-04 20:57   ` John Stultz [this message]
2020-08-04 20:57     ` [PATCH v2 4/6] arm64: dts: hisilicon: hikey: fixes to comply with adi, adv7533 " John Stultz
2020-08-04 21:24     ` John Stultz
2020-08-04 21:24       ` John Stultz
2020-05-11 11:06 ` [PATCH v2 5/6] ARM: dts: iwg20d-q7-dbcm-ca: remove unneeded properties in hdmi@39 Ricardo Cañuelo
2020-05-11 11:06   ` Ricardo Cañuelo
2020-05-11 11:52   ` Geert Uytterhoeven
2020-05-11 11:52     ` Geert Uytterhoeven
2020-05-14  1:37   ` Laurent Pinchart
2020-05-14  1:37     ` Laurent Pinchart
2020-05-11 11:06 ` [PATCH v2 6/6] dt-bindings: drm: bridge: adi,adv7511.txt: convert to yaml Ricardo Cañuelo
2020-05-11 11:06   ` [PATCH v2 6/6] dt-bindings: drm: bridge: adi, adv7511.txt: " Ricardo Cañuelo
2020-05-14  1:54   ` [PATCH v2 6/6] dt-bindings: drm: bridge: adi,adv7511.txt: " Laurent Pinchart
2020-05-14  1:54     ` Laurent Pinchart
2020-05-14  9:36     ` Ricardo Cañuelo
2020-05-14  9:36       ` Ricardo Cañuelo
2020-05-14 15:22       ` Laurent Pinchart
2020-05-14 15:22         ` Laurent Pinchart
2020-05-18 21:27         ` Rob Herring
2020-05-18 21:27           ` Rob Herring
2020-05-25  7:43         ` Ricardo Cañuelo
2020-05-25  7:43           ` Ricardo Cañuelo
2020-05-26  1:44           ` Laurent Pinchart
2020-05-26  1:44             ` Laurent Pinchart
2020-05-26  7:03             ` Geert Uytterhoeven
2020-05-26  7:03               ` [PATCH v2 6/6] dt-bindings: drm: bridge: adi, adv7511.txt: " Geert Uytterhoeven
2020-05-26 10:11               ` [PATCH v2 6/6] dt-bindings: drm: bridge: adi,adv7511.txt: " Laurent Pinchart
2020-05-26 10:11                 ` Laurent Pinchart
2020-05-26 10:39                 ` Geert Uytterhoeven
2020-05-26 10:39                   ` [PATCH v2 6/6] dt-bindings: drm: bridge: adi, adv7511.txt: " Geert Uytterhoeven
2020-05-26 19:45                   ` [PATCH v2 6/6] dt-bindings: drm: bridge: adi,adv7511.txt: " Ezequiel Garcia
2020-05-26 19:45                     ` Ezequiel Garcia
2020-05-27 17:29               ` Rob Herring
2020-05-27 17:29                 ` [PATCH v2 6/6] dt-bindings: drm: bridge: adi, adv7511.txt: " Rob Herring
2020-05-27 18:18                 ` [PATCH v2 6/6] dt-bindings: drm: bridge: adi,adv7511.txt: " Geert Uytterhoeven
2020-05-27 18:18                   ` [PATCH v2 6/6] dt-bindings: drm: bridge: adi, adv7511.txt: " Geert Uytterhoeven
2020-05-28  6:36                   ` [PATCH v2 6/6] dt-bindings: drm: bridge: adi,adv7511.txt: " Ricardo Cañuelo
2020-05-28  6:36                     ` Ricardo Cañuelo
2020-05-11 11:55 ` [PATCH v2 0/6] Convert adi,adv7511.txt DT bindings " Geert Uytterhoeven
2020-05-11 11:55   ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALAqxLWCCH8sDD+3-Qe=+siUAQgB2jn3349w+VTAj6uySKc8NA@mail.gmail.com' \
    --to=john.stultz@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=kernel@collabora.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=mchehab+huawei@kernel.org \
    --cc=ricardo.canuelo@collabora.com \
    --cc=robh+dt@kernel.org \
    --cc=xuwei5@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.