All of lore.kernel.org
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: "Ricardo Cañuelo" <ricardo.canuelo@collabora.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Collabora Kernel ML <kernel@collabora.com>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	Rob Herring <robh+dt@kernel.org>, Wei Xu <xuwei5@hisilicon.com>
Subject: Re: [PATCH v2 0/6] Convert adi,adv7511.txt DT bindings to yaml
Date: Mon, 11 May 2020 13:55:47 +0200	[thread overview]
Message-ID: <CAMuHMdXuMMRwbU=NrmGqXJ7DYzXpS1v+yM1ngPSZJdRZForPHw@mail.gmail.com> (raw)
In-Reply-To: <20200511110611.3142-1-ricardo.canuelo@collabora.com>

Hi Ricardo,

On Mon, May 11, 2020 at 1:06 PM Ricardo Cañuelo
<ricardo.canuelo@collabora.com> wrote:
> This series convert the adi,adv7511.txt DT bindings to json-schema. As a
> result of the conversion some dts files needed to be updated.
>
> The changes to the dts files are of three types:
>
>   - Reordering of the I2C slave addresses list of the ADV75xx node. The
>     addresses in the 'reg' property and the matching names in
>     'reg-names' for an I2C slave don't need to be in any particular
>     order, but the DT schema defines these properties as a cell array
>     and a string array respectively, which are ordered, so the
>     definitions in the dts files must match the order in the binding.
>
>   - Filling the minimum binding requirements. Most of the time this
>     means creating a 'ports' node in the boards that don't define
>     them. Note, however, that the purpose of this is simply to make the
>     definition compliant with the binding. I didn't define any endpoints
>     for the ports.
>
>   - Removing unneeded properties.
>
> About the binding conversion:
>
>   - The original binding covered five different devices: ADV7511,
>     ADV7511W, ADV7513, ADV7533 and ADV7535. They all share a common set
>     of properties but ADV7533 and ADV7535 have enough differences from
>     the rest to warrant their own binding file. In v1 I modelled all the
>     properties constraints for all five devices in a single file but it
>     turned out a bit too complex. Splitting the binding into one for
>     ADV7511/11W/13 and another for ADV7533/35 makes them much easier to
>     read and maintain.

Thanks for your series!

> Patches 1/6 to 5/6 contain the dts changes. Patch 6/6 contains the
> binding conversion.

If the binding conversion is accepted, I can queue the below in
renesas-fix-for-v5.7, to avoid the conversion introducing a regression.

>   arm64: dts: renesas: make hdmi encoder nodes compliant with DT
>     bindings
>   ARM: dts: renesas: make hdmi encoder nodes compliant with DT bindings
>   ARM: dts: iwg20d-q7-dbcm-ca: remove unneeded properties in hdmi@39

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

WARNING: multiple messages have this Message-ID (diff)
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: "Ricardo Cañuelo" <ricardo.canuelo@collabora.com>
Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>, Wei Xu <xuwei5@hisilicon.com>,
	Rob Herring <robh+dt@kernel.org>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Collabora Kernel ML <kernel@collabora.com>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 0/6] Convert adi,adv7511.txt DT bindings to yaml
Date: Mon, 11 May 2020 13:55:47 +0200	[thread overview]
Message-ID: <CAMuHMdXuMMRwbU=NrmGqXJ7DYzXpS1v+yM1ngPSZJdRZForPHw@mail.gmail.com> (raw)
In-Reply-To: <20200511110611.3142-1-ricardo.canuelo@collabora.com>

Hi Ricardo,

On Mon, May 11, 2020 at 1:06 PM Ricardo Cañuelo
<ricardo.canuelo@collabora.com> wrote:
> This series convert the adi,adv7511.txt DT bindings to json-schema. As a
> result of the conversion some dts files needed to be updated.
>
> The changes to the dts files are of three types:
>
>   - Reordering of the I2C slave addresses list of the ADV75xx node. The
>     addresses in the 'reg' property and the matching names in
>     'reg-names' for an I2C slave don't need to be in any particular
>     order, but the DT schema defines these properties as a cell array
>     and a string array respectively, which are ordered, so the
>     definitions in the dts files must match the order in the binding.
>
>   - Filling the minimum binding requirements. Most of the time this
>     means creating a 'ports' node in the boards that don't define
>     them. Note, however, that the purpose of this is simply to make the
>     definition compliant with the binding. I didn't define any endpoints
>     for the ports.
>
>   - Removing unneeded properties.
>
> About the binding conversion:
>
>   - The original binding covered five different devices: ADV7511,
>     ADV7511W, ADV7513, ADV7533 and ADV7535. They all share a common set
>     of properties but ADV7533 and ADV7535 have enough differences from
>     the rest to warrant their own binding file. In v1 I modelled all the
>     properties constraints for all five devices in a single file but it
>     turned out a bit too complex. Splitting the binding into one for
>     ADV7511/11W/13 and another for ADV7533/35 makes them much easier to
>     read and maintain.

Thanks for your series!

> Patches 1/6 to 5/6 contain the dts changes. Patch 6/6 contains the
> binding conversion.

If the binding conversion is accepted, I can queue the below in
renesas-fix-for-v5.7, to avoid the conversion introducing a regression.

>   arm64: dts: renesas: make hdmi encoder nodes compliant with DT
>     bindings
>   ARM: dts: renesas: make hdmi encoder nodes compliant with DT bindings
>   ARM: dts: iwg20d-q7-dbcm-ca: remove unneeded properties in hdmi@39

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2020-05-11 11:56 UTC|newest]

Thread overview: 66+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-11 11:06 [PATCH v2 0/6] Convert adi,adv7511.txt DT bindings to yaml Ricardo Cañuelo
2020-05-11 11:06 ` Ricardo Cañuelo
2020-05-11 11:06 ` [PATCH v2 1/6] arm64: dts: renesas: make hdmi encoder nodes compliant with DT bindings Ricardo Cañuelo
2020-05-11 11:06   ` Ricardo Cañuelo
2020-05-11 11:51   ` Geert Uytterhoeven
2020-05-11 11:51     ` Geert Uytterhoeven
2020-05-14  1:33   ` Laurent Pinchart
2020-05-14  1:33     ` Laurent Pinchart
2020-05-11 11:06 ` [PATCH v2 2/6] ARM: " Ricardo Cañuelo
2020-05-11 11:06   ` Ricardo Cañuelo
2020-05-11 11:51   ` Geert Uytterhoeven
2020-05-11 11:51     ` Geert Uytterhoeven
2020-05-14  1:34   ` Laurent Pinchart
2020-05-14  1:34     ` Laurent Pinchart
2020-05-11 11:06 ` [PATCH v2 3/6] ARM: dts: zynq: add port definitions to hdmi-tx@39 Ricardo Cañuelo
2020-05-11 11:06   ` Ricardo Cañuelo
2020-05-11 12:24   ` Ezequiel Garcia
2020-05-11 12:24     ` Ezequiel Garcia
2020-05-11 12:52     ` Michal Simek
2020-05-11 12:52       ` Michal Simek
2020-05-14  1:36       ` Laurent Pinchart
2020-05-14  1:36         ` Laurent Pinchart
2020-05-11 11:06 ` [PATCH v2 4/6] arm64: dts: hisilicon: hikey: fixes to comply with adi,adv7533 DT binding Ricardo Cañuelo
2020-05-11 11:06   ` [PATCH v2 4/6] arm64: dts: hisilicon: hikey: fixes to comply with adi, adv7533 " Ricardo Cañuelo
2020-05-14  1:37   ` [PATCH v2 4/6] arm64: dts: hisilicon: hikey: fixes to comply with adi,adv7533 " Laurent Pinchart
2020-05-14  1:37     ` Laurent Pinchart
2020-08-04 20:57   ` [PATCH v2 4/6] arm64: dts: hisilicon: hikey: fixes to comply with adi, adv7533 " John Stultz
2020-08-04 20:57     ` John Stultz
2020-08-04 21:24     ` John Stultz
2020-08-04 21:24       ` John Stultz
2020-05-11 11:06 ` [PATCH v2 5/6] ARM: dts: iwg20d-q7-dbcm-ca: remove unneeded properties in hdmi@39 Ricardo Cañuelo
2020-05-11 11:06   ` Ricardo Cañuelo
2020-05-11 11:52   ` Geert Uytterhoeven
2020-05-11 11:52     ` Geert Uytterhoeven
2020-05-14  1:37   ` Laurent Pinchart
2020-05-14  1:37     ` Laurent Pinchart
2020-05-11 11:06 ` [PATCH v2 6/6] dt-bindings: drm: bridge: adi,adv7511.txt: convert to yaml Ricardo Cañuelo
2020-05-11 11:06   ` [PATCH v2 6/6] dt-bindings: drm: bridge: adi, adv7511.txt: " Ricardo Cañuelo
2020-05-14  1:54   ` [PATCH v2 6/6] dt-bindings: drm: bridge: adi,adv7511.txt: " Laurent Pinchart
2020-05-14  1:54     ` Laurent Pinchart
2020-05-14  9:36     ` Ricardo Cañuelo
2020-05-14  9:36       ` Ricardo Cañuelo
2020-05-14 15:22       ` Laurent Pinchart
2020-05-14 15:22         ` Laurent Pinchart
2020-05-18 21:27         ` Rob Herring
2020-05-18 21:27           ` Rob Herring
2020-05-25  7:43         ` Ricardo Cañuelo
2020-05-25  7:43           ` Ricardo Cañuelo
2020-05-26  1:44           ` Laurent Pinchart
2020-05-26  1:44             ` Laurent Pinchart
2020-05-26  7:03             ` Geert Uytterhoeven
2020-05-26  7:03               ` [PATCH v2 6/6] dt-bindings: drm: bridge: adi, adv7511.txt: " Geert Uytterhoeven
2020-05-26 10:11               ` [PATCH v2 6/6] dt-bindings: drm: bridge: adi,adv7511.txt: " Laurent Pinchart
2020-05-26 10:11                 ` Laurent Pinchart
2020-05-26 10:39                 ` Geert Uytterhoeven
2020-05-26 10:39                   ` [PATCH v2 6/6] dt-bindings: drm: bridge: adi, adv7511.txt: " Geert Uytterhoeven
2020-05-26 19:45                   ` [PATCH v2 6/6] dt-bindings: drm: bridge: adi,adv7511.txt: " Ezequiel Garcia
2020-05-26 19:45                     ` Ezequiel Garcia
2020-05-27 17:29               ` Rob Herring
2020-05-27 17:29                 ` [PATCH v2 6/6] dt-bindings: drm: bridge: adi, adv7511.txt: " Rob Herring
2020-05-27 18:18                 ` [PATCH v2 6/6] dt-bindings: drm: bridge: adi,adv7511.txt: " Geert Uytterhoeven
2020-05-27 18:18                   ` [PATCH v2 6/6] dt-bindings: drm: bridge: adi, adv7511.txt: " Geert Uytterhoeven
2020-05-28  6:36                   ` [PATCH v2 6/6] dt-bindings: drm: bridge: adi,adv7511.txt: " Ricardo Cañuelo
2020-05-28  6:36                     ` Ricardo Cañuelo
2020-05-11 11:55 ` Geert Uytterhoeven [this message]
2020-05-11 11:55   ` [PATCH v2 0/6] Convert adi,adv7511.txt DT bindings " Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMuHMdXuMMRwbU=NrmGqXJ7DYzXpS1v+yM1ngPSZJdRZForPHw@mail.gmail.com' \
    --to=geert@linux-m68k.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kernel@collabora.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=ricardo.canuelo@collabora.com \
    --cc=robh+dt@kernel.org \
    --cc=xuwei5@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.