From: Etienne Carriere <etienne.carriere@linaro.org>
To: sudeep.holla@arm.com
Cc: arnd@arndb.de, catalin.marinas@arm.com, harb@amperecomputing.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, lorenzo.pieralisi@arm.com,
mark.rutland@arm.com, steven.price@arm.com, will@kernel.org
Subject: RE: [PATCH v3 0/7] firmware: smccc: Add basic SMCCC v1.2 + ARCH_SOC_ID support
Date: Fri, 15 May 2020 09:50:32 +0200 [thread overview]
Message-ID: <20200515075032.5325-1-etienne.carriere@linaro.org> (raw)
In-Reply-To: <20200506164411.3284-1-sudeep.holla@arm.com>
> From: Sudeep Holla <sudeep.holla@arm.com>
>
> Hi,
>
> This patch series adds support for SMCCCv1.2 ARCH_SOC_ID.
> This doesn't add other changes added in SMCCC v1.2 yet. They will
> follow these soon along with its first user SPCI/PSA-FF.
>
> This is tested using upstream TF-A + the patch[2] fixing the original
> implementation there.
>
>
> v1[0]->v2[1]:
> - Incorporated comments from Steven Price in patch 5/5
> - Fixed build for CONFIG_PSCI_FW=n on some arm32 platforms
> - Added Steven Price's review tags
>
> v2[1]->v3:
> - Incorporated additional comments from Steven Price in patch 5/5
> and added his review tags
> - Refactored SMCCC code from PSCI and moved it under
> drivers/firmware/smccc/smccc.c
> - Also moved soc_id.c under drivers/firmware/smccc
>
> Regards,
> Sudeep
Hello Sudeep,
In case it helps. I have successfully tested the 7 patches series
on some platforms, playing a bit with few configurations.
Qemu emulator for arm64/cortex-a57 with TF-A (v2.x) as secure firmware.
Qemu emulator for arm/cortex-a15. OP-TEE (v3.x) as secure firmware.
A stm32mp15 device (arm/cortex-a7), tested both TF-A (v2.x) and
OP-TEE (3.7.0, 3.9.0-rc) as runtime secure firmware.
Helper functions arm_smccc_1_1_get_conduit()/arm_smccc_1_1_invoke()
works as expected AFAICT. No regression seen with older secure
firmwares.
For the patches 1 to 6, as I poorly tested [v3,7/7] soc ids,
based on tag next-20200505 [1]:
Tested-by: Etienne Carriere <etienne.carriere@st.com>
Reviewed-by: Etienne Carriere <etienne.carriere@st.com>
For [v3,7/7] firmware: smccc: Add ARCH_SOC_ID support
Acked-by: Etienne Carriere <etienne.carriere@st.com>
[1] 7def1ef0f72c ("Add linux-next specific files for 20200505")
Regards,
Etienne
WARNING: multiple messages have this Message-ID (diff)
From: Etienne Carriere <etienne.carriere@linaro.org>
To: sudeep.holla@arm.com
Cc: mark.rutland@arm.com, lorenzo.pieralisi@arm.com, arnd@arndb.de,
catalin.marinas@arm.com, linux-kernel@vger.kernel.org,
steven.price@arm.com, harb@amperecomputing.com, will@kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: RE: [PATCH v3 0/7] firmware: smccc: Add basic SMCCC v1.2 + ARCH_SOC_ID support
Date: Fri, 15 May 2020 09:50:32 +0200 [thread overview]
Message-ID: <20200515075032.5325-1-etienne.carriere@linaro.org> (raw)
In-Reply-To: <20200506164411.3284-1-sudeep.holla@arm.com>
> From: Sudeep Holla <sudeep.holla@arm.com>
>
> Hi,
>
> This patch series adds support for SMCCCv1.2 ARCH_SOC_ID.
> This doesn't add other changes added in SMCCC v1.2 yet. They will
> follow these soon along with its first user SPCI/PSA-FF.
>
> This is tested using upstream TF-A + the patch[2] fixing the original
> implementation there.
>
>
> v1[0]->v2[1]:
> - Incorporated comments from Steven Price in patch 5/5
> - Fixed build for CONFIG_PSCI_FW=n on some arm32 platforms
> - Added Steven Price's review tags
>
> v2[1]->v3:
> - Incorporated additional comments from Steven Price in patch 5/5
> and added his review tags
> - Refactored SMCCC code from PSCI and moved it under
> drivers/firmware/smccc/smccc.c
> - Also moved soc_id.c under drivers/firmware/smccc
>
> Regards,
> Sudeep
Hello Sudeep,
In case it helps. I have successfully tested the 7 patches series
on some platforms, playing a bit with few configurations.
Qemu emulator for arm64/cortex-a57 with TF-A (v2.x) as secure firmware.
Qemu emulator for arm/cortex-a15. OP-TEE (v3.x) as secure firmware.
A stm32mp15 device (arm/cortex-a7), tested both TF-A (v2.x) and
OP-TEE (3.7.0, 3.9.0-rc) as runtime secure firmware.
Helper functions arm_smccc_1_1_get_conduit()/arm_smccc_1_1_invoke()
works as expected AFAICT. No regression seen with older secure
firmwares.
For the patches 1 to 6, as I poorly tested [v3,7/7] soc ids,
based on tag next-20200505 [1]:
Tested-by: Etienne Carriere <etienne.carriere@st.com>
Reviewed-by: Etienne Carriere <etienne.carriere@st.com>
For [v3,7/7] firmware: smccc: Add ARCH_SOC_ID support
Acked-by: Etienne Carriere <etienne.carriere@st.com>
[1] 7def1ef0f72c ("Add linux-next specific files for 20200505")
Regards,
Etienne
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-05-15 7:51 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-06 16:44 [PATCH v3 0/7] firmware: smccc: Add basic SMCCC v1.2 + ARCH_SOC_ID support Sudeep Holla
2020-05-06 16:44 ` Sudeep Holla
2020-05-06 16:44 ` [PATCH v3 1/7] firmware: smccc: Add HAVE_ARM_SMCCC_DISCOVERY to identify SMCCC v1.1 and above Sudeep Holla
2020-05-06 16:44 ` Sudeep Holla
2020-05-15 11:37 ` Mark Rutland
2020-05-15 11:37 ` Mark Rutland
2020-05-06 16:44 ` [PATCH v3 2/7] firmware: smccc: Update link to latest SMCCC specification Sudeep Holla
2020-05-06 16:44 ` Sudeep Holla
2020-05-15 11:37 ` Mark Rutland
2020-05-15 11:37 ` Mark Rutland
2020-05-15 12:46 ` Sudeep Holla
2020-05-15 12:46 ` Sudeep Holla
2020-05-06 16:44 ` [PATCH v3 3/7] firmware: smccc: Add the definition for SMCCCv1.2 version/error codes Sudeep Holla
2020-05-06 16:44 ` Sudeep Holla
2020-05-15 11:38 ` Mark Rutland
2020-05-15 11:38 ` Mark Rutland
2020-05-15 13:52 ` Sudeep Holla
2020-05-15 13:52 ` Sudeep Holla
2020-05-06 16:44 ` [PATCH v3 4/7] firmware: smccc: Drop smccc_version enum and use ARM_SMCCC_VERSION_1_x instead Sudeep Holla
2020-05-06 16:44 ` Sudeep Holla
2020-05-15 11:39 ` Mark Rutland
2020-05-15 11:39 ` Mark Rutland
2020-05-06 16:44 ` [PATCH v3 5/7] firmware: smccc: Refactor SMCCC specific bits into separate file Sudeep Holla
2020-05-06 16:44 ` Sudeep Holla
2020-05-15 11:49 ` Mark Rutland
2020-05-15 11:49 ` Mark Rutland
2020-05-15 12:53 ` Sudeep Holla
2020-05-15 12:53 ` Sudeep Holla
2020-05-06 16:44 ` [PATCH v3 6/7] firmware: smccc: Add function to fetch SMCCC version Sudeep Holla
2020-05-06 16:44 ` Sudeep Holla
2020-05-15 12:08 ` Mark Rutland
2020-05-15 12:08 ` Mark Rutland
2020-05-15 12:57 ` Sudeep Holla
2020-05-15 12:57 ` Sudeep Holla
2020-05-06 16:44 ` [PATCH v3 7/7] firmware: smccc: Add ARCH_SOC_ID support Sudeep Holla
2020-05-06 16:44 ` Sudeep Holla
2020-05-15 12:50 ` Mark Rutland
2020-05-15 12:50 ` Mark Rutland
2020-05-15 14:13 ` Sudeep Holla
2020-05-15 14:13 ` Sudeep Holla
2020-05-15 7:50 ` Etienne Carriere [this message]
2020-05-15 7:50 ` [PATCH v3 0/7] firmware: smccc: Add basic SMCCC v1.2 + " Etienne Carriere
2020-05-15 9:16 ` Sudeep Holla
2020-05-15 9:16 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200515075032.5325-1-etienne.carriere@linaro.org \
--to=etienne.carriere@linaro.org \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=harb@amperecomputing.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mark.rutland@arm.com \
--cc=steven.price@arm.com \
--cc=sudeep.holla@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.