From: Mark Rutland <mark.rutland@arm.com> To: Sudeep Holla <sudeep.holla@arm.com> Cc: linux-arm-kernel@lists.infradead.org, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>, Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>, Steven Price <steven.price@arm.com>, linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>, harb@amperecomputing.com Subject: Re: [PATCH v3 5/7] firmware: smccc: Refactor SMCCC specific bits into separate file Date: Fri, 15 May 2020 12:49:53 +0100 [thread overview] Message-ID: <20200515114953.GE67718@C02TD0UTHF1T.local> (raw) In-Reply-To: <20200506164411.3284-6-sudeep.holla@arm.com> On Wed, May 06, 2020 at 05:44:09PM +0100, Sudeep Holla wrote: > In order to add newer SMCCC v1.1+ functionality and to avoid cluttering > PSCI firmware driver with SMCCC bits, let us move the SMCCC specific > details under drivers/firmware/smccc/smccc.c > > We can also drop conduit and smccc_version from psci_operations structure > as SMCCC was the sole user and now it maintains those. > > No functionality change in this patch though. > > Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> > --- > MAINTAINERS | 9 +++++++++ > drivers/firmware/Makefile | 3 ++- > drivers/firmware/psci/psci.c | 19 ++++--------------- > drivers/firmware/smccc/Makefile | 3 +++ > drivers/firmware/smccc/smccc.c | 26 ++++++++++++++++++++++++++ > include/linux/arm-smccc.h | 11 +++++++++++ > include/linux/psci.h | 2 -- > 7 files changed, 55 insertions(+), 18 deletions(-) > create mode 100644 drivers/firmware/smccc/Makefile > create mode 100644 drivers/firmware/smccc/smccc.c > > Hi Mark, Lorenzo, > > I have replicated PSCI entry in MAINTAINERS file and added myself to > for SMCCC entry. If you prefer I can merge it under PSCI. Let me know > your preference along with other review comments. > +SECURE MONITOR CALL(SMC) CALLING CONVENTION (SMCCC) > +M: Mark Rutland <mark.rutland@arm.com> > +M: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> > +M: Sudeep Holla <sudeep.holla@arm.com> > +L: linux-arm-kernel@lists.infradead.org > +S: Maintained > +F: drivers/firmware/smccc/ > +F: include/linux/arm-smccc.h As per the above, I'm fine with having this separate from the PSCI entry, and I'm fine with sharing this maintainership. > diff --git a/include/linux/arm-smccc.h b/include/linux/arm-smccc.h > +/** > + * arm_smccc_version_init() - Sets SMCCC version and conduit > + * @version: SMCCC version v1.1 or above > + * @conduit: SMCCC_CONDUIT_SMC or SMCCC_CONDUIT_HVC > + * > + * When SMCCCv1.1 or above is not present, defaults to ARM_SMCCC_VERSION_1_0 > + * and SMCCC_CONDUIT_NONE respectively. > + */ > +void __init arm_smccc_version_init(u32 version, enum arm_smccc_conduit conduit); Given we only expect the PSCI code to call this, could we avoid putting this in a header and just define it within psci.c? Either way: Acked-by: Mark Rutland <mark.rutland@arm.com> Thanks, Mark.
WARNING: multiple messages have this Message-ID (diff)
From: Mark Rutland <mark.rutland@arm.com> To: Sudeep Holla <sudeep.holla@arm.com> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>, Arnd Bergmann <arnd@arndb.de>, Catalin Marinas <catalin.marinas@arm.com>, linux-kernel@vger.kernel.org, Steven Price <steven.price@arm.com>, harb@amperecomputing.com, Will Deacon <will@kernel.org>, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 5/7] firmware: smccc: Refactor SMCCC specific bits into separate file Date: Fri, 15 May 2020 12:49:53 +0100 [thread overview] Message-ID: <20200515114953.GE67718@C02TD0UTHF1T.local> (raw) In-Reply-To: <20200506164411.3284-6-sudeep.holla@arm.com> On Wed, May 06, 2020 at 05:44:09PM +0100, Sudeep Holla wrote: > In order to add newer SMCCC v1.1+ functionality and to avoid cluttering > PSCI firmware driver with SMCCC bits, let us move the SMCCC specific > details under drivers/firmware/smccc/smccc.c > > We can also drop conduit and smccc_version from psci_operations structure > as SMCCC was the sole user and now it maintains those. > > No functionality change in this patch though. > > Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> > --- > MAINTAINERS | 9 +++++++++ > drivers/firmware/Makefile | 3 ++- > drivers/firmware/psci/psci.c | 19 ++++--------------- > drivers/firmware/smccc/Makefile | 3 +++ > drivers/firmware/smccc/smccc.c | 26 ++++++++++++++++++++++++++ > include/linux/arm-smccc.h | 11 +++++++++++ > include/linux/psci.h | 2 -- > 7 files changed, 55 insertions(+), 18 deletions(-) > create mode 100644 drivers/firmware/smccc/Makefile > create mode 100644 drivers/firmware/smccc/smccc.c > > Hi Mark, Lorenzo, > > I have replicated PSCI entry in MAINTAINERS file and added myself to > for SMCCC entry. If you prefer I can merge it under PSCI. Let me know > your preference along with other review comments. > +SECURE MONITOR CALL(SMC) CALLING CONVENTION (SMCCC) > +M: Mark Rutland <mark.rutland@arm.com> > +M: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> > +M: Sudeep Holla <sudeep.holla@arm.com> > +L: linux-arm-kernel@lists.infradead.org > +S: Maintained > +F: drivers/firmware/smccc/ > +F: include/linux/arm-smccc.h As per the above, I'm fine with having this separate from the PSCI entry, and I'm fine with sharing this maintainership. > diff --git a/include/linux/arm-smccc.h b/include/linux/arm-smccc.h > +/** > + * arm_smccc_version_init() - Sets SMCCC version and conduit > + * @version: SMCCC version v1.1 or above > + * @conduit: SMCCC_CONDUIT_SMC or SMCCC_CONDUIT_HVC > + * > + * When SMCCCv1.1 or above is not present, defaults to ARM_SMCCC_VERSION_1_0 > + * and SMCCC_CONDUIT_NONE respectively. > + */ > +void __init arm_smccc_version_init(u32 version, enum arm_smccc_conduit conduit); Given we only expect the PSCI code to call this, could we avoid putting this in a header and just define it within psci.c? Either way: Acked-by: Mark Rutland <mark.rutland@arm.com> Thanks, Mark. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-05-15 11:50 UTC|newest] Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-05-06 16:44 [PATCH v3 0/7] firmware: smccc: Add basic SMCCC v1.2 + ARCH_SOC_ID support Sudeep Holla 2020-05-06 16:44 ` Sudeep Holla 2020-05-06 16:44 ` [PATCH v3 1/7] firmware: smccc: Add HAVE_ARM_SMCCC_DISCOVERY to identify SMCCC v1.1 and above Sudeep Holla 2020-05-06 16:44 ` Sudeep Holla 2020-05-15 11:37 ` Mark Rutland 2020-05-15 11:37 ` Mark Rutland 2020-05-06 16:44 ` [PATCH v3 2/7] firmware: smccc: Update link to latest SMCCC specification Sudeep Holla 2020-05-06 16:44 ` Sudeep Holla 2020-05-15 11:37 ` Mark Rutland 2020-05-15 11:37 ` Mark Rutland 2020-05-15 12:46 ` Sudeep Holla 2020-05-15 12:46 ` Sudeep Holla 2020-05-06 16:44 ` [PATCH v3 3/7] firmware: smccc: Add the definition for SMCCCv1.2 version/error codes Sudeep Holla 2020-05-06 16:44 ` Sudeep Holla 2020-05-15 11:38 ` Mark Rutland 2020-05-15 11:38 ` Mark Rutland 2020-05-15 13:52 ` Sudeep Holla 2020-05-15 13:52 ` Sudeep Holla 2020-05-06 16:44 ` [PATCH v3 4/7] firmware: smccc: Drop smccc_version enum and use ARM_SMCCC_VERSION_1_x instead Sudeep Holla 2020-05-06 16:44 ` Sudeep Holla 2020-05-15 11:39 ` Mark Rutland 2020-05-15 11:39 ` Mark Rutland 2020-05-06 16:44 ` [PATCH v3 5/7] firmware: smccc: Refactor SMCCC specific bits into separate file Sudeep Holla 2020-05-06 16:44 ` Sudeep Holla 2020-05-15 11:49 ` Mark Rutland [this message] 2020-05-15 11:49 ` Mark Rutland 2020-05-15 12:53 ` Sudeep Holla 2020-05-15 12:53 ` Sudeep Holla 2020-05-06 16:44 ` [PATCH v3 6/7] firmware: smccc: Add function to fetch SMCCC version Sudeep Holla 2020-05-06 16:44 ` Sudeep Holla 2020-05-15 12:08 ` Mark Rutland 2020-05-15 12:08 ` Mark Rutland 2020-05-15 12:57 ` Sudeep Holla 2020-05-15 12:57 ` Sudeep Holla 2020-05-06 16:44 ` [PATCH v3 7/7] firmware: smccc: Add ARCH_SOC_ID support Sudeep Holla 2020-05-06 16:44 ` Sudeep Holla 2020-05-15 12:50 ` Mark Rutland 2020-05-15 12:50 ` Mark Rutland 2020-05-15 14:13 ` Sudeep Holla 2020-05-15 14:13 ` Sudeep Holla 2020-05-15 7:50 ` [PATCH v3 0/7] firmware: smccc: Add basic SMCCC v1.2 + " Etienne Carriere 2020-05-15 7:50 ` Etienne Carriere 2020-05-15 9:16 ` Sudeep Holla 2020-05-15 9:16 ` Sudeep Holla
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200515114953.GE67718@C02TD0UTHF1T.local \ --to=mark.rutland@arm.com \ --cc=arnd@arndb.de \ --cc=catalin.marinas@arm.com \ --cc=harb@amperecomputing.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=lorenzo.pieralisi@arm.com \ --cc=steven.price@arm.com \ --cc=sudeep.holla@arm.com \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.