Re: [PATCH v2 01/15] taint: add module firmware crash taint support

[Rafael Aquini <aquini@redhat.com>]

On Fri, May 15, 2020 at 09:28:32PM +0000, Luis Chamberlain wrote:
> Device driver firmware can crash, and sometimes, this can leave your
> system in a state which makes the device or subsystem completely
> useless. Detecting this by inspecting /proc/sys/kernel/tainted instead
> of scraping some magical words from the kernel log, which is driver
> specific, is much easier. So instead provide a helper which lets drivers
> annotate this.
> 
> Once this happens, scrapers can easily look for modules taint flags
> for a firmware crash. This will taint both the kernel and respective
> calling module.
> 
> The new helper module_firmware_crashed() uses LOCKDEP_STILL_OK as this
> fact should in no way shape or form affect lockdep. This taint is device
> driver specific.
> 
> Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
> ---
>  Documentation/admin-guide/tainted-kernels.rst |  6 ++++++
>  include/linux/kernel.h                        |  3 ++-
>  include/linux/module.h                        | 13 +++++++++++++
>  include/trace/events/module.h                 |  3 ++-
>  kernel/module.c                               |  5 +++--
>  kernel/panic.c                                |  1 +
>  tools/debugging/kernel-chktaint               |  7 +++++++
>  7 files changed, 34 insertions(+), 4 deletions(-)
> 

Reviewed-by: Rafael Aquini <aquini@redhat.com>