From: Guenter Roeck <linux@roeck-us.net>
To: Emil Velikov <emil.l.velikov@gmail.com>
Cc: dri-devel@lists.freedesktop.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>,
linux-kernel@vger.kernel.org, Richard Henderson <rth@twiddle.net>,
Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
Matt Turner <mattst88@gmail.com>,
linux-alpha@vger.kernel.org
Subject: Re: [PATCH 01/11] tty/sysrq: alpha: export and use __sysrq_get_key_op()
Date: Wed, 10 Jun 2020 13:51:54 -0700 [thread overview]
Message-ID: <20200610205154.GA14854@roeck-us.net> (raw)
In-Reply-To: <20200513214351.2138580-1-emil.l.velikov@gmail.com>
On Wed, May 13, 2020 at 10:43:41PM +0100, Emil Velikov wrote:
> Export a pointer to the sysrq_get_key_op(). This way we can cleanly
> unregister it, instead of the current solutions of modifuing it inplace.
>
> Since __sysrq_get_key_op() is no longer used externally, let's make it
> a static function.
>
> This patch will allow us to limit access to each and every sysrq op and
> constify the sysrq handling.
>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Jiri Slaby <jslaby@suse.com>
> Cc: linux-kernel@vger.kernel.org
> Cc: Richard Henderson <rth@twiddle.net>
> Cc: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
> Cc: Matt Turner <mattst88@gmail.com>
> Cc: linux-alpha@vger.kernel.org
> Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
> ---
> Please keep me in the CC list, as I'm not subscribed to the list.
>
> IMHO it would be better if this gets merged this via the tty tree.
Still observed:
Building alpha:defconfig ... failed
--------------
Error log:
<stdin>:1511:2: warning: #warning syscall clone3 not implemented [-Wcpp]
arch/alpha/kernel/setup.c:434:13: error: initialization of 'void (*)(int)' from incompatible pointer type 'void (*)(void)' [-Werror=incompatible-pointer-types]
434 | .handler = machine_halt,
| ^~~~~~~~~~~~
arch/alpha/kernel/setup.c:434:13: note: (near initialization for 'srm_sysrq_reboot_op.handler')
I did not see a reply to the initial report. Is this being addressed ?
Guenter
WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux@roeck-us.net>
To: Emil Velikov <emil.l.velikov@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
Jiri Slaby <jslaby@suse.com>, Matt Turner <mattst88@gmail.com>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [PATCH 01/11] tty/sysrq: alpha: export and use __sysrq_get_key_op()
Date: Wed, 10 Jun 2020 13:51:54 -0700 [thread overview]
Message-ID: <20200610205154.GA14854@roeck-us.net> (raw)
In-Reply-To: <20200513214351.2138580-1-emil.l.velikov@gmail.com>
On Wed, May 13, 2020 at 10:43:41PM +0100, Emil Velikov wrote:
> Export a pointer to the sysrq_get_key_op(). This way we can cleanly
> unregister it, instead of the current solutions of modifuing it inplace.
>
> Since __sysrq_get_key_op() is no longer used externally, let's make it
> a static function.
>
> This patch will allow us to limit access to each and every sysrq op and
> constify the sysrq handling.
>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Jiri Slaby <jslaby@suse.com>
> Cc: linux-kernel@vger.kernel.org
> Cc: Richard Henderson <rth@twiddle.net>
> Cc: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
> Cc: Matt Turner <mattst88@gmail.com>
> Cc: linux-alpha@vger.kernel.org
> Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
> ---
> Please keep me in the CC list, as I'm not subscribed to the list.
>
> IMHO it would be better if this gets merged this via the tty tree.
Still observed:
Building alpha:defconfig ... failed
--------------
Error log:
<stdin>:1511:2: warning: #warning syscall clone3 not implemented [-Wcpp]
arch/alpha/kernel/setup.c:434:13: error: initialization of 'void (*)(int)' from incompatible pointer type 'void (*)(void)' [-Werror=incompatible-pointer-types]
434 | .handler = machine_halt,
| ^~~~~~~~~~~~
arch/alpha/kernel/setup.c:434:13: note: (near initialization for 'srm_sysrq_reboot_op.handler')
I did not see a reply to the initial report. Is this being addressed ?
Guenter
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-06-10 20:51 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-13 21:43 [PATCH 01/11] tty/sysrq: alpha: export and use __sysrq_get_key_op() Emil Velikov
2020-05-13 21:43 ` Emil Velikov
2020-05-13 21:43 ` [PATCH 02/11] tty/sysrq: constify the sysrq API Emil Velikov
2020-05-13 21:43 ` Emil Velikov
2020-05-13 21:43 ` [PATCH 03/11] tty/sysrq: constify the the sysrq_key_op(s) Emil Velikov
2020-05-13 21:43 ` Emil Velikov
2020-05-13 21:43 ` [PATCH 04/11] alpha: constify sysrq_key_op Emil Velikov
2020-05-13 21:43 ` Emil Velikov
2020-05-13 21:43 ` [PATCH 05/11] MIPS: " Emil Velikov
2020-05-13 21:43 ` Emil Velikov
2020-05-14 7:49 ` Thomas Bogendoerfer
2020-05-14 7:49 ` Thomas Bogendoerfer
2020-05-13 21:43 ` [PATCH 06/11] powerpc/xmon: " Emil Velikov
2020-05-13 21:43 ` Emil Velikov
2020-05-13 21:43 ` Emil Velikov
2020-05-14 3:44 ` Michael Ellerman
2020-05-14 3:44 ` Michael Ellerman
2020-05-14 3:44 ` Michael Ellerman
2020-05-13 21:43 ` [PATCH 07/11] sparc64: " Emil Velikov
2020-05-13 21:43 ` Emil Velikov
2020-05-13 21:43 ` Emil Velikov
2020-05-13 21:58 ` David Miller
2020-05-13 21:58 ` David Miller
2020-05-13 21:58 ` David Miller
2020-05-13 21:43 ` [PATCH 08/11] drm: " Emil Velikov
2020-05-13 21:43 ` Emil Velikov
2020-05-14 12:36 ` Daniel Vetter
2020-05-14 12:36 ` Daniel Vetter
2020-05-13 21:43 ` [PATCH 09/11] kdb: " Emil Velikov
2020-05-13 21:43 ` Emil Velikov
2020-05-14 16:46 ` Daniel Thompson
2020-05-14 16:46 ` Daniel Thompson
2020-05-13 21:43 ` [PATCH 10/11] kernel/power: " Emil Velikov
2020-05-13 21:43 ` Emil Velikov
2020-05-14 11:20 ` Rafael J. Wysocki
2020-05-14 11:20 ` Rafael J. Wysocki
2020-05-15 10:11 ` Emil Velikov
2020-05-15 10:11 ` Emil Velikov
2020-05-15 10:39 ` Greg Kroah-Hartman
2020-05-15 10:39 ` Greg Kroah-Hartman
2020-05-13 21:43 ` [PATCH 11/11] rcu: " Emil Velikov
2020-05-13 21:43 ` Emil Velikov
2020-05-13 22:41 ` Paul E. McKenney
2020-05-13 22:41 ` Paul E. McKenney
2020-05-15 12:54 ` [PATCH 01/11] tty/sysrq: alpha: export and use __sysrq_get_key_op() Greg Kroah-Hartman
2020-05-15 12:54 ` Greg Kroah-Hartman
2020-06-08 14:38 ` Guenter Roeck
2020-06-08 14:38 ` Guenter Roeck
2020-06-10 20:51 ` Guenter Roeck [this message]
2020-06-10 20:51 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200610205154.GA14854@roeck-us.net \
--to=linux@roeck-us.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.l.velikov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=ink@jurassic.park.msu.ru \
--cc=jslaby@suse.com \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mattst88@gmail.com \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.