From: "Rafael J. Wysocki" <rafael@kernel.org> To: Emil Velikov <emil.l.velikov@gmail.com> Cc: dri-devel <dri-devel@lists.freedesktop.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Jiri Slaby <jslaby@suse.com>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, "Rafael J. Wysocki" <rjw@rjwysocki.net>, Len Brown <len.brown@intel.com>, Linux PM <linux-pm@vger.kernel.org> Subject: Re: [PATCH 10/11] kernel/power: constify sysrq_key_op Date: Thu, 14 May 2020 13:20:51 +0200 [thread overview] Message-ID: <CAJZ5v0iM5H03=RTtk2sZtUzaW0XJ+AaX1M00C8QjvaNz0ZE3bQ@mail.gmail.com> (raw) In-Reply-To: <20200513214351.2138580-10-emil.l.velikov@gmail.com> On Wed, May 13, 2020 at 11:46 PM Emil Velikov <emil.l.velikov@gmail.com> wrote: > > With earlier commits, the API no longer discards the const-ness of the > sysrq_key_op. As such we can add the notation. > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: Jiri Slaby <jslaby@suse.com> > Cc: linux-kernel@vger.kernel.org > Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net> > Cc: Len Brown <len.brown@intel.com> > Cc: linux-pm@vger.kernel.org > Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com> Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> and I'm assuming that this is going to be applied along with the rest of the series. > --- > Please keep me in the CC list, as I'm not subscribed to the list. > > IMHO it would be better if this gets merged this via the tty tree. > --- > kernel/power/poweroff.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/power/poweroff.c b/kernel/power/poweroff.c > index 6d475281c730..562aa0e450ed 100644 > --- a/kernel/power/poweroff.c > +++ b/kernel/power/poweroff.c > @@ -29,7 +29,7 @@ static void handle_poweroff(int key) > schedule_work_on(cpumask_first(cpu_online_mask), &poweroff_work); > } > > -static struct sysrq_key_op sysrq_poweroff_op = { > +static const struct sysrq_key_op sysrq_poweroff_op = { > .handler = handle_poweroff, > .help_msg = "poweroff(o)", > .action_msg = "Power Off", > -- > 2.25.1 >
WARNING: multiple messages have this Message-ID (diff)
From: "Rafael J. Wysocki" <rafael@kernel.org> To: Emil Velikov <emil.l.velikov@gmail.com> Cc: Len Brown <len.brown@intel.com>, Linux PM <linux-pm@vger.kernel.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, "Rafael J. Wysocki" <rjw@rjwysocki.net>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, dri-devel <dri-devel@lists.freedesktop.org>, Jiri Slaby <jslaby@suse.com> Subject: Re: [PATCH 10/11] kernel/power: constify sysrq_key_op Date: Thu, 14 May 2020 13:20:51 +0200 [thread overview] Message-ID: <CAJZ5v0iM5H03=RTtk2sZtUzaW0XJ+AaX1M00C8QjvaNz0ZE3bQ@mail.gmail.com> (raw) In-Reply-To: <20200513214351.2138580-10-emil.l.velikov@gmail.com> On Wed, May 13, 2020 at 11:46 PM Emil Velikov <emil.l.velikov@gmail.com> wrote: > > With earlier commits, the API no longer discards the const-ness of the > sysrq_key_op. As such we can add the notation. > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: Jiri Slaby <jslaby@suse.com> > Cc: linux-kernel@vger.kernel.org > Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net> > Cc: Len Brown <len.brown@intel.com> > Cc: linux-pm@vger.kernel.org > Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com> Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> and I'm assuming that this is going to be applied along with the rest of the series. > --- > Please keep me in the CC list, as I'm not subscribed to the list. > > IMHO it would be better if this gets merged this via the tty tree. > --- > kernel/power/poweroff.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/power/poweroff.c b/kernel/power/poweroff.c > index 6d475281c730..562aa0e450ed 100644 > --- a/kernel/power/poweroff.c > +++ b/kernel/power/poweroff.c > @@ -29,7 +29,7 @@ static void handle_poweroff(int key) > schedule_work_on(cpumask_first(cpu_online_mask), &poweroff_work); > } > > -static struct sysrq_key_op sysrq_poweroff_op = { > +static const struct sysrq_key_op sysrq_poweroff_op = { > .handler = handle_poweroff, > .help_msg = "poweroff(o)", > .action_msg = "Power Off", > -- > 2.25.1 > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-05-14 11:21 UTC|newest] Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-05-13 21:43 [PATCH 01/11] tty/sysrq: alpha: export and use __sysrq_get_key_op() Emil Velikov 2020-05-13 21:43 ` Emil Velikov 2020-05-13 21:43 ` [PATCH 02/11] tty/sysrq: constify the sysrq API Emil Velikov 2020-05-13 21:43 ` Emil Velikov 2020-05-13 21:43 ` [PATCH 03/11] tty/sysrq: constify the the sysrq_key_op(s) Emil Velikov 2020-05-13 21:43 ` Emil Velikov 2020-05-13 21:43 ` [PATCH 04/11] alpha: constify sysrq_key_op Emil Velikov 2020-05-13 21:43 ` Emil Velikov 2020-05-13 21:43 ` [PATCH 05/11] MIPS: " Emil Velikov 2020-05-13 21:43 ` Emil Velikov 2020-05-14 7:49 ` Thomas Bogendoerfer 2020-05-14 7:49 ` Thomas Bogendoerfer 2020-05-13 21:43 ` [PATCH 06/11] powerpc/xmon: " Emil Velikov 2020-05-13 21:43 ` Emil Velikov 2020-05-13 21:43 ` Emil Velikov 2020-05-14 3:44 ` Michael Ellerman 2020-05-14 3:44 ` Michael Ellerman 2020-05-14 3:44 ` Michael Ellerman 2020-05-13 21:43 ` [PATCH 07/11] sparc64: " Emil Velikov 2020-05-13 21:43 ` Emil Velikov 2020-05-13 21:43 ` Emil Velikov 2020-05-13 21:58 ` David Miller 2020-05-13 21:58 ` David Miller 2020-05-13 21:58 ` David Miller 2020-05-13 21:43 ` [PATCH 08/11] drm: " Emil Velikov 2020-05-13 21:43 ` Emil Velikov 2020-05-14 12:36 ` Daniel Vetter 2020-05-14 12:36 ` Daniel Vetter 2020-05-13 21:43 ` [PATCH 09/11] kdb: " Emil Velikov 2020-05-13 21:43 ` Emil Velikov 2020-05-14 16:46 ` Daniel Thompson 2020-05-14 16:46 ` Daniel Thompson 2020-05-13 21:43 ` [PATCH 10/11] kernel/power: " Emil Velikov 2020-05-13 21:43 ` Emil Velikov 2020-05-14 11:20 ` Rafael J. Wysocki [this message] 2020-05-14 11:20 ` Rafael J. Wysocki 2020-05-15 10:11 ` Emil Velikov 2020-05-15 10:11 ` Emil Velikov 2020-05-15 10:39 ` Greg Kroah-Hartman 2020-05-15 10:39 ` Greg Kroah-Hartman 2020-05-13 21:43 ` [PATCH 11/11] rcu: " Emil Velikov 2020-05-13 21:43 ` Emil Velikov 2020-05-13 22:41 ` Paul E. McKenney 2020-05-13 22:41 ` Paul E. McKenney 2020-05-15 12:54 ` [PATCH 01/11] tty/sysrq: alpha: export and use __sysrq_get_key_op() Greg Kroah-Hartman 2020-05-15 12:54 ` Greg Kroah-Hartman 2020-06-08 14:38 ` Guenter Roeck 2020-06-08 14:38 ` Guenter Roeck 2020-06-10 20:51 ` Guenter Roeck 2020-06-10 20:51 ` Guenter Roeck
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAJZ5v0iM5H03=RTtk2sZtUzaW0XJ+AaX1M00C8QjvaNz0ZE3bQ@mail.gmail.com' \ --to=rafael@kernel.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=emil.l.velikov@gmail.com \ --cc=gregkh@linuxfoundation.org \ --cc=jslaby@suse.com \ --cc=len.brown@intel.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=rjw@rjwysocki.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.