All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wei Liu <wei.liu@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Dexuan Cui <decui@microsoft.com>,
	Vitaly Kuznetsov <vkuznets@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>, Jessica Yu <jeyu@kernel.org>,
	x86@kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org,
	linux-mm@kvack.org, Wei Liu <wei.liu@kernel.org>
Subject: Re: [PATCH 1/3] x86/hyperv: allocate the hypercall page with only read and execute bits
Date: Thu, 18 Jun 2020 11:47:29 +0000	[thread overview]
Message-ID: <20200618114729.bnut7gbj2j4uhjnc@liuwe-devbox-debian-v2> (raw)
In-Reply-To: <20200618064307.32739-2-hch@lst.de>

On Thu, Jun 18, 2020 at 08:43:05AM +0200, Christoph Hellwig wrote:
> Avoid a W^X violation cause by the fact that PAGE_KERNEL_EXEC includes the
> writable bit.
> 
> For this resurrect the removed PAGE_KERNEL_RX definitіon, but as
> PAGE_KERNEL_ROX to match arm64 and powerpc.
> 
> Fixes: 78bb17f76edc ("x86/hyperv: use vmalloc_exec for the hypercall page")
> Reported-by: Dexuan Cui <decui@microsoft.com>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Tested-by: Vitaly Kuznetsov <vkuznets@redhat.com>

Acked-by: Wei Liu <wei.liu@kernel.org>

WARNING: multiple messages have this Message-ID (diff)
From: Wei Liu <wei.liu@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-hyperv@vger.kernel.org,
	Peter Zijlstra <peterz@infradead.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	x86@kernel.org, Dexuan Cui <decui@microsoft.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	Wei Liu <wei.liu@kernel.org>, Jessica Yu <jeyu@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Will Deacon <will@kernel.org>,
	Vitaly Kuznetsov <vkuznets@redhat.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] x86/hyperv: allocate the hypercall page with only read and execute bits
Date: Thu, 18 Jun 2020 11:47:29 +0000	[thread overview]
Message-ID: <20200618114729.bnut7gbj2j4uhjnc@liuwe-devbox-debian-v2> (raw)
In-Reply-To: <20200618064307.32739-2-hch@lst.de>

On Thu, Jun 18, 2020 at 08:43:05AM +0200, Christoph Hellwig wrote:
> Avoid a W^X violation cause by the fact that PAGE_KERNEL_EXEC includes the
> writable bit.
> 
> For this resurrect the removed PAGE_KERNEL_RX definitіon, but as
> PAGE_KERNEL_ROX to match arm64 and powerpc.
> 
> Fixes: 78bb17f76edc ("x86/hyperv: use vmalloc_exec for the hypercall page")
> Reported-by: Dexuan Cui <decui@microsoft.com>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Tested-by: Vitaly Kuznetsov <vkuznets@redhat.com>

Acked-by: Wei Liu <wei.liu@kernel.org>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-06-18 11:47 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-18  6:43 fix a hyperv W^X violation and remove vmalloc_exec Christoph Hellwig
2020-06-18  6:43 ` Christoph Hellwig
2020-06-18  6:43 ` [PATCH 1/3] x86/hyperv: allocate the hypercall page with only read and execute bits Christoph Hellwig
2020-06-18  6:43   ` Christoph Hellwig
2020-06-18 11:47   ` Wei Liu [this message]
2020-06-18 11:47     ` Wei Liu
2020-06-18  6:43 ` [PATCH 2/3] arm64: use PAGE_KERNEL_ROX directly in alloc_insn_page Christoph Hellwig
2020-06-18  6:43   ` Christoph Hellwig
2020-06-18  8:55   ` David Hildenbrand
2020-06-18  8:55     ` David Hildenbrand
2020-06-18 10:35     ` Peter Zijlstra
2020-06-18 10:35       ` Peter Zijlstra
2020-06-18 13:50       ` Christoph Hellwig
2020-06-18 13:50         ` Christoph Hellwig
2020-06-18  9:27   ` Peter Zijlstra
2020-06-18  9:27     ` Peter Zijlstra
2020-06-21  2:16   ` Andrew Morton
2020-06-23  9:05     ` Christoph Hellwig
2020-06-23  9:07       ` Will Deacon
2020-06-23  9:37         ` Peter Zijlstra
2020-06-23  9:57           ` Will Deacon
2020-06-27  7:34   ` Ard Biesheuvel
2020-06-27  7:34     ` Ard Biesheuvel
2020-06-27  7:34     ` Ard Biesheuvel
2020-06-27  7:56     ` Christoph Hellwig
2020-06-27  7:56       ` Christoph Hellwig
2020-06-27  7:57       ` Ard Biesheuvel
2020-06-27  7:57         ` Ard Biesheuvel
2020-06-27  7:57         ` Ard Biesheuvel
2020-06-18  6:43 ` [PATCH 3/3] mm: remove vmalloc_exec Christoph Hellwig
2020-06-18  6:43   ` Christoph Hellwig
2020-06-18  8:53   ` David Hildenbrand
2020-06-18  8:53     ` David Hildenbrand
2020-06-18  9:28 ` fix a hyperv W^X violation and " Peter Zijlstra
2020-06-18  9:28   ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200618114729.bnut7gbj2j4uhjnc@liuwe-devbox-debian-v2 \
    --to=wei.liu@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=catalin.marinas@arm.com \
    --cc=decui@microsoft.com \
    --cc=hch@lst.de \
    --cc=jeyu@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-hyperv@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=peterz@infradead.org \
    --cc=vkuznets@redhat.com \
    --cc=will@kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.