[PATCH] xfs: remove SYNC_WAIT and SYNC_TRYLOCK

[PATCH] xfs: remove SYNC_WAIT and SYNC_TRYLOCK

[Christoph Hellwig]

These two definitions are unused now.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 fs/xfs/xfs_icache.h | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/fs/xfs/xfs_icache.h b/fs/xfs/xfs_icache.h
index ae92ca53de423f..3a4c8b382cd0fe 100644
--- a/fs/xfs/xfs_icache.h
+++ b/fs/xfs/xfs_icache.h
@@ -17,9 +17,6 @@ struct xfs_eofblocks {
 	__u64		eof_min_file_size;
 };
 
-#define SYNC_WAIT		0x0001	/* wait for i/o to complete */
-#define SYNC_TRYLOCK		0x0002  /* only try to lock inodes */
-
 /*
  * tags for inode radix tree
  */
-- 
2.26.2

Re: [PATCH] xfs: remove SYNC_WAIT and SYNC_TRYLOCK

[Dave Chinner]

On Fri, Jul 10, 2020 at 07:46:52AM +0200, Christoph Hellwig wrote:
> These two definitions are unused now.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  fs/xfs/xfs_icache.h | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/fs/xfs/xfs_icache.h b/fs/xfs/xfs_icache.h
> index ae92ca53de423f..3a4c8b382cd0fe 100644
> --- a/fs/xfs/xfs_icache.h
> +++ b/fs/xfs/xfs_icache.h
> @@ -17,9 +17,6 @@ struct xfs_eofblocks {
>  	__u64		eof_min_file_size;
>  };
>  
> -#define SYNC_WAIT		0x0001	/* wait for i/o to complete */
> -#define SYNC_TRYLOCK		0x0002  /* only try to lock inodes */

Oh, I didn't realise they'd been removed from the EOF block scanner.
I was too busy removing them from inode reclaim to notice this had
occurred.

Looks good.

Reviewed-by: Dave Chinner <dchinner@redhat.com>

-- 
Dave Chinner
david@fromorbit.com

Re: [PATCH] xfs: remove SYNC_WAIT and SYNC_TRYLOCK

[Chaitanya Kulkarni]

On 7/9/20 22:49, Christoph Hellwig wrote:
> These two definitions are unused now.
> 
> Signed-off-by: Christoph Hellwig<hch@lst.de>

Looks good to me.

Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>

Re: [PATCH] xfs: remove SYNC_WAIT and SYNC_TRYLOCK

[Darrick J. Wong]

On Fri, Jul 10, 2020 at 05:46:52AM +0000, Christoph Hellwig wrote:
> These two definitions are unused now.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Looks ok,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>

--D

> ---
>  fs/xfs/xfs_icache.h | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/fs/xfs/xfs_icache.h b/fs/xfs/xfs_icache.h
> index ae92ca53de423f..3a4c8b382cd0fe 100644
> --- a/fs/xfs/xfs_icache.h
> +++ b/fs/xfs/xfs_icache.h
> @@ -17,9 +17,6 @@ struct xfs_eofblocks {
>  	__u64		eof_min_file_size;
>  };
>  
> -#define SYNC_WAIT		0x0001	/* wait for i/o to complete */
> -#define SYNC_TRYLOCK		0x0002  /* only try to lock inodes */
> -
>  /*
>   * tags for inode radix tree
>   */
> -- 
> 2.26.2
>