* [PATCH] xfs: remove SYNC_WAIT and SYNC_TRYLOCK
@ 2020-07-10 5:46 Christoph Hellwig
2020-07-10 7:31 ` Dave Chinner
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Christoph Hellwig @ 2020-07-10 5:46 UTC (permalink / raw)
To: linux-xfs
These two definitions are unused now.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
fs/xfs/xfs_icache.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/fs/xfs/xfs_icache.h b/fs/xfs/xfs_icache.h
index ae92ca53de423f..3a4c8b382cd0fe 100644
--- a/fs/xfs/xfs_icache.h
+++ b/fs/xfs/xfs_icache.h
@@ -17,9 +17,6 @@ struct xfs_eofblocks {
__u64 eof_min_file_size;
};
-#define SYNC_WAIT 0x0001 /* wait for i/o to complete */
-#define SYNC_TRYLOCK 0x0002 /* only try to lock inodes */
-
/*
* tags for inode radix tree
*/
--
2.26.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] xfs: remove SYNC_WAIT and SYNC_TRYLOCK
2020-07-10 5:46 [PATCH] xfs: remove SYNC_WAIT and SYNC_TRYLOCK Christoph Hellwig
@ 2020-07-10 7:31 ` Dave Chinner
2020-07-11 18:13 ` Chaitanya Kulkarni
2020-07-13 16:20 ` Darrick J. Wong
2 siblings, 0 replies; 4+ messages in thread
From: Dave Chinner @ 2020-07-10 7:31 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: linux-xfs
On Fri, Jul 10, 2020 at 07:46:52AM +0200, Christoph Hellwig wrote:
> These two definitions are unused now.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> fs/xfs/xfs_icache.h | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/fs/xfs/xfs_icache.h b/fs/xfs/xfs_icache.h
> index ae92ca53de423f..3a4c8b382cd0fe 100644
> --- a/fs/xfs/xfs_icache.h
> +++ b/fs/xfs/xfs_icache.h
> @@ -17,9 +17,6 @@ struct xfs_eofblocks {
> __u64 eof_min_file_size;
> };
>
> -#define SYNC_WAIT 0x0001 /* wait for i/o to complete */
> -#define SYNC_TRYLOCK 0x0002 /* only try to lock inodes */
Oh, I didn't realise they'd been removed from the EOF block scanner.
I was too busy removing them from inode reclaim to notice this had
occurred.
Looks good.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] xfs: remove SYNC_WAIT and SYNC_TRYLOCK
2020-07-10 5:46 [PATCH] xfs: remove SYNC_WAIT and SYNC_TRYLOCK Christoph Hellwig
2020-07-10 7:31 ` Dave Chinner
@ 2020-07-11 18:13 ` Chaitanya Kulkarni
2020-07-13 16:20 ` Darrick J. Wong
2 siblings, 0 replies; 4+ messages in thread
From: Chaitanya Kulkarni @ 2020-07-11 18:13 UTC (permalink / raw)
To: Christoph Hellwig, linux-xfs
On 7/9/20 22:49, Christoph Hellwig wrote:
> These two definitions are unused now.
>
> Signed-off-by: Christoph Hellwig<hch@lst.de>
Looks good to me.
Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] xfs: remove SYNC_WAIT and SYNC_TRYLOCK
2020-07-10 5:46 [PATCH] xfs: remove SYNC_WAIT and SYNC_TRYLOCK Christoph Hellwig
2020-07-10 7:31 ` Dave Chinner
2020-07-11 18:13 ` Chaitanya Kulkarni
@ 2020-07-13 16:20 ` Darrick J. Wong
2 siblings, 0 replies; 4+ messages in thread
From: Darrick J. Wong @ 2020-07-13 16:20 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: linux-xfs
On Fri, Jul 10, 2020 at 05:46:52AM +0000, Christoph Hellwig wrote:
> These two definitions are unused now.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Looks ok,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
> fs/xfs/xfs_icache.h | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/fs/xfs/xfs_icache.h b/fs/xfs/xfs_icache.h
> index ae92ca53de423f..3a4c8b382cd0fe 100644
> --- a/fs/xfs/xfs_icache.h
> +++ b/fs/xfs/xfs_icache.h
> @@ -17,9 +17,6 @@ struct xfs_eofblocks {
> __u64 eof_min_file_size;
> };
>
> -#define SYNC_WAIT 0x0001 /* wait for i/o to complete */
> -#define SYNC_TRYLOCK 0x0002 /* only try to lock inodes */
> -
> /*
> * tags for inode radix tree
> */
> --
> 2.26.2
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-07-13 16:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-10 5:46 [PATCH] xfs: remove SYNC_WAIT and SYNC_TRYLOCK Christoph Hellwig
2020-07-10 7:31 ` Dave Chinner
2020-07-11 18:13 ` Chaitanya Kulkarni
2020-07-13 16:20 ` Darrick J. Wong
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.