[PATCH] t/zbd: Improve pass condition of test case #49

[PATCH] t/zbd: Improve pass condition of test case #49

[Shin'ichiro Kawasaki]

The test case #49 runs write workloads with verify option. It checks read
bytes for verify, but it does not check written bytes. To make test pass
condition more accurate, add check of the written bytes.

Fixes: 4844bb4716ab ("t/zbd: Add test case to check zonecapacity option")
Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
---
 t/zbd/test-zbd-support | 1 +
 1 file changed, 1 insertion(+)

diff --git a/t/zbd/test-zbd-support b/t/zbd/test-zbd-support
index e53a20c5..471a3487 100755
--- a/t/zbd/test-zbd-support
+++ b/t/zbd/test-zbd-support
@@ -856,6 +856,7 @@ test49() {
 		    --zonecapacity=${capacity} \
 		    --verify=md5  --size=${size} >>"${logfile}.${test_number}" 2>&1 ||
 	return $?
+    check_written $((capacity * 2)) || return $?
     check_read $((capacity * 2)) || return $?
 }
 
-- 
2.26.2

Re: [PATCH] t/zbd: Improve pass condition of test case #49

[Damien Le Moal]

On 2020/07/22 18:26, Shin'ichiro Kawasaki wrote:
> The test case #49 runs write workloads with verify option. It checks read
> bytes for verify, but it does not check written bytes. To make test pass
> condition more accurate, add check of the written bytes.
> 
> Fixes: 4844bb4716ab ("t/zbd: Add test case to check zonecapacity option")
> Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
> ---
>  t/zbd/test-zbd-support | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/t/zbd/test-zbd-support b/t/zbd/test-zbd-support
> index e53a20c5..471a3487 100755
> --- a/t/zbd/test-zbd-support
> +++ b/t/zbd/test-zbd-support
> @@ -856,6 +856,7 @@ test49() {
>  		    --zonecapacity=${capacity} \
>  		    --verify=md5  --size=${size} >>"${logfile}.${test_number}" 2>&1 ||
>  	return $?
> +    check_written $((capacity * 2)) || return $?
>      check_read $((capacity * 2)) || return $?
>  }
>  
> 

Looks good.

Reviewed-by: Damien Le Moal <damien.lemoal@wdc.com>

-- 
Damien Le Moal
Western Digital Research

Re: [PATCH] t/zbd: Improve pass condition of test case #49

[Jens Axboe]

On 7/22/20 3:26 AM, Shin'ichiro Kawasaki wrote:
> The test case #49 runs write workloads with verify option. It checks read
> bytes for verify, but it does not check written bytes. To make test pass
> condition more accurate, add check of the written bytes.

Applied,  thanks.

-- 
Jens Axboe