* [PATCH] t/zbd: Improve pass condition of test case #49
@ 2020-07-22 9:26 Shin'ichiro Kawasaki
2020-07-22 9:38 ` Damien Le Moal
2020-07-22 13:38 ` Jens Axboe
0 siblings, 2 replies; 3+ messages in thread
From: Shin'ichiro Kawasaki @ 2020-07-22 9:26 UTC (permalink / raw)
To: fio, Jens Axboe; +Cc: Damien Le Moal, Hans Holmberg, Shinichiro Kawasaki
The test case #49 runs write workloads with verify option. It checks read
bytes for verify, but it does not check written bytes. To make test pass
condition more accurate, add check of the written bytes.
Fixes: 4844bb4716ab ("t/zbd: Add test case to check zonecapacity option")
Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
---
t/zbd/test-zbd-support | 1 +
1 file changed, 1 insertion(+)
diff --git a/t/zbd/test-zbd-support b/t/zbd/test-zbd-support
index e53a20c5..471a3487 100755
--- a/t/zbd/test-zbd-support
+++ b/t/zbd/test-zbd-support
@@ -856,6 +856,7 @@ test49() {
--zonecapacity=${capacity} \
--verify=md5 --size=${size} >>"${logfile}.${test_number}" 2>&1 ||
return $?
+ check_written $((capacity * 2)) || return $?
check_read $((capacity * 2)) || return $?
}
--
2.26.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] t/zbd: Improve pass condition of test case #49
2020-07-22 9:26 [PATCH] t/zbd: Improve pass condition of test case #49 Shin'ichiro Kawasaki
@ 2020-07-22 9:38 ` Damien Le Moal
2020-07-22 13:38 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Damien Le Moal @ 2020-07-22 9:38 UTC (permalink / raw)
To: Shinichiro Kawasaki, fio, Jens Axboe; +Cc: Hans Holmberg
On 2020/07/22 18:26, Shin'ichiro Kawasaki wrote:
> The test case #49 runs write workloads with verify option. It checks read
> bytes for verify, but it does not check written bytes. To make test pass
> condition more accurate, add check of the written bytes.
>
> Fixes: 4844bb4716ab ("t/zbd: Add test case to check zonecapacity option")
> Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
> ---
> t/zbd/test-zbd-support | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/t/zbd/test-zbd-support b/t/zbd/test-zbd-support
> index e53a20c5..471a3487 100755
> --- a/t/zbd/test-zbd-support
> +++ b/t/zbd/test-zbd-support
> @@ -856,6 +856,7 @@ test49() {
> --zonecapacity=${capacity} \
> --verify=md5 --size=${size} >>"${logfile}.${test_number}" 2>&1 ||
> return $?
> + check_written $((capacity * 2)) || return $?
> check_read $((capacity * 2)) || return $?
> }
>
>
Looks good.
Reviewed-by: Damien Le Moal <damien.lemoal@wdc.com>
--
Damien Le Moal
Western Digital Research
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] t/zbd: Improve pass condition of test case #49
2020-07-22 9:26 [PATCH] t/zbd: Improve pass condition of test case #49 Shin'ichiro Kawasaki
2020-07-22 9:38 ` Damien Le Moal
@ 2020-07-22 13:38 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2020-07-22 13:38 UTC (permalink / raw)
To: Shin'ichiro Kawasaki, fio; +Cc: Damien Le Moal, Hans Holmberg
On 7/22/20 3:26 AM, Shin'ichiro Kawasaki wrote:
> The test case #49 runs write workloads with verify option. It checks read
> bytes for verify, but it does not check written bytes. To make test pass
> condition more accurate, add check of the written bytes.
Applied, thanks.
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-22 13:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-22 9:26 [PATCH] t/zbd: Improve pass condition of test case #49 Shin'ichiro Kawasaki
2020-07-22 9:38 ` Damien Le Moal
2020-07-22 13:38 ` Jens Axboe
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.