From: Sam Ravnborg <sam@ravnborg.org> To: Kevin Tang <kevin3.tang@gmail.com> Cc: maarten.lankhorst@linux.intel.com, mripard@kernel.org, sean@poorly.run, airlied@linux.ie, daniel@ffwll.ch, robh+dt@kernel.org, mark.rutland@arm.com, orsonzhai@gmail.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, zhang.lyra@gmail.com Subject: Re: [PATCH RFC v6 1/6] dt-bindings: display: add Unisoc's drm master bindings Date: Tue, 28 Jul 2020 22:27:32 +0200 [thread overview] Message-ID: <20200728202732.GB1277651@ravnborg.org> (raw) In-Reply-To: <1595930879-2478-2-git-send-email-kevin3.tang@gmail.com> Hi Kevin On Tue, Jul 28, 2020 at 06:07:54PM +0800, Kevin Tang wrote: > From: Kevin Tang <kevin.tang@unisoc.com> > > The Unisoc DRM master device is a virtual device needed to list all > DPU devices or other display interface nodes that comprise the > graphics subsystem > > Cc: Orson Zhai <orsonzhai@gmail.com> > Cc: Chunyan Zhang <zhang.lyra@gmail.com> > Signed-off-by: Kevin Tang <kevin.tang@unisoc.com> > --- > .../devicetree/bindings/display/sprd/drm.yaml | 36 ++++++++++++++++++++++ > 1 file changed, 36 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/sprd/drm.yaml > > diff --git a/Documentation/devicetree/bindings/display/sprd/drm.yaml b/Documentation/devicetree/bindings/display/sprd/drm.yaml > new file mode 100644 > index 0000000..b5792c0 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/sprd/drm.yaml drm seems like a sub-optimal name. How about usign the compatible name "display-subsystem" as it is a bit more specific (but not good). > @@ -0,0 +1,36 @@ > +# SPDX-License-Identifier: GPL-2.0 Any chance this can be (GPL-2.0-only OR BSD-2-Clause). I noticed that for example clock/sprd,sc9863a-clk.yaml uses this license so I hope this is OK. > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/sprd/drm.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Unisoc DRM master device > + > +maintainers: > + - Mark Rutland <mark.rutland@arm.com> > + > +description: | > + The Unisoc DRM master device is a virtual device needed to list all > + DPU devices or other display interface nodes that comprise the > + graphics subsystem. > + > +properties: > + compatible: > + const: sprd,display-subsystem > + > + ports: > + description: > + Should contain a list of phandles pointing to display interface port > + of DPU devices. Add type - like this: $ref: /schemas/types.yaml#/definitions/phandle-array See for example display/rockchip/rockchip-drm.yaml Any specific reason why this is not a ports node like used by many other display bindings? In other words - I think this is too simple. > + > +required: > + - compatible > + - ports > + Add: additionalProperties: false so we catch if other properties sneak in. > +examples: > + - | > + display-subsystem { > + compatible = "sprd,display-subsystem"; > + ports = <&dpu_out>; > + }; > + > -- > 2.7.4 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org> To: Kevin Tang <kevin3.tang@gmail.com> Cc: mark.rutland@arm.com, airlied@linux.ie, zhang.lyra@gmail.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org, dri-devel@lists.freedesktop.org, orsonzhai@gmail.com, sean@poorly.run Subject: Re: [PATCH RFC v6 1/6] dt-bindings: display: add Unisoc's drm master bindings Date: Tue, 28 Jul 2020 22:27:32 +0200 [thread overview] Message-ID: <20200728202732.GB1277651@ravnborg.org> (raw) In-Reply-To: <1595930879-2478-2-git-send-email-kevin3.tang@gmail.com> Hi Kevin On Tue, Jul 28, 2020 at 06:07:54PM +0800, Kevin Tang wrote: > From: Kevin Tang <kevin.tang@unisoc.com> > > The Unisoc DRM master device is a virtual device needed to list all > DPU devices or other display interface nodes that comprise the > graphics subsystem > > Cc: Orson Zhai <orsonzhai@gmail.com> > Cc: Chunyan Zhang <zhang.lyra@gmail.com> > Signed-off-by: Kevin Tang <kevin.tang@unisoc.com> > --- > .../devicetree/bindings/display/sprd/drm.yaml | 36 ++++++++++++++++++++++ > 1 file changed, 36 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/sprd/drm.yaml > > diff --git a/Documentation/devicetree/bindings/display/sprd/drm.yaml b/Documentation/devicetree/bindings/display/sprd/drm.yaml > new file mode 100644 > index 0000000..b5792c0 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/sprd/drm.yaml drm seems like a sub-optimal name. How about usign the compatible name "display-subsystem" as it is a bit more specific (but not good). > @@ -0,0 +1,36 @@ > +# SPDX-License-Identifier: GPL-2.0 Any chance this can be (GPL-2.0-only OR BSD-2-Clause). I noticed that for example clock/sprd,sc9863a-clk.yaml uses this license so I hope this is OK. > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/sprd/drm.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Unisoc DRM master device > + > +maintainers: > + - Mark Rutland <mark.rutland@arm.com> > + > +description: | > + The Unisoc DRM master device is a virtual device needed to list all > + DPU devices or other display interface nodes that comprise the > + graphics subsystem. > + > +properties: > + compatible: > + const: sprd,display-subsystem > + > + ports: > + description: > + Should contain a list of phandles pointing to display interface port > + of DPU devices. Add type - like this: $ref: /schemas/types.yaml#/definitions/phandle-array See for example display/rockchip/rockchip-drm.yaml Any specific reason why this is not a ports node like used by many other display bindings? In other words - I think this is too simple. > + > +required: > + - compatible > + - ports > + Add: additionalProperties: false so we catch if other properties sneak in. > +examples: > + - | > + display-subsystem { > + compatible = "sprd,display-subsystem"; > + ports = <&dpu_out>; > + }; > + > -- > 2.7.4 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-07-28 20:27 UTC|newest] Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-28 10:07 [PATCH RFC v6 0/6] Add Unisoc's drm kms module Kevin Tang 2020-07-28 10:07 ` Kevin Tang 2020-07-28 10:07 ` [PATCH RFC v6 1/6] dt-bindings: display: add Unisoc's drm master bindings Kevin Tang 2020-07-28 10:07 ` Kevin Tang 2020-07-28 20:27 ` Sam Ravnborg [this message] 2020-07-28 20:27 ` Sam Ravnborg 2020-08-26 17:11 ` Kevin Tang 2020-08-26 17:11 ` Kevin Tang 2020-08-28 17:57 ` Sam Ravnborg 2020-08-28 17:57 ` Sam Ravnborg 2020-08-28 19:39 ` Rob Herring 2020-08-28 19:39 ` Rob Herring 2020-07-28 10:07 ` [PATCH RFC v6 2/6] drm/sprd: add Unisoc's drm kms master Kevin Tang 2020-07-28 10:07 ` Kevin Tang 2020-07-28 12:25 ` Randy Dunlap 2020-07-28 12:25 ` Randy Dunlap 2020-07-28 20:45 ` Sam Ravnborg 2020-07-28 20:45 ` Sam Ravnborg 2020-08-28 16:04 ` Kevin Tang 2020-08-28 16:04 ` Kevin Tang 2020-08-28 17:55 ` Sam Ravnborg 2020-08-28 17:55 ` Sam Ravnborg 2020-07-28 10:07 ` [PATCH RFC v6 3/6] dt-bindings: display: add Unisoc's dpu bindings Kevin Tang 2020-07-28 10:07 ` Kevin Tang 2020-07-28 20:51 ` Sam Ravnborg 2020-07-28 20:51 ` Sam Ravnborg 2020-07-28 10:07 ` [PATCH RFC v6 4/6] drm/sprd: add Unisoc's drm display controller driver Kevin Tang 2020-07-28 10:07 ` Kevin Tang 2020-07-28 21:13 ` Sam Ravnborg 2020-07-28 21:13 ` Sam Ravnborg 2020-08-28 17:08 ` Kevin Tang 2020-08-28 17:08 ` Kevin Tang 2020-11-17 3:07 ` Kevin Tang 2020-11-17 3:07 ` Kevin Tang 2020-07-28 21:51 ` Daniel Vetter 2020-07-28 21:51 ` Daniel Vetter 2020-08-29 17:10 ` Kevin Tang 2020-08-29 17:10 ` Kevin Tang 2021-01-05 11:09 ` Kevin Tang 2020-07-28 10:07 ` [PATCH RFC v6 5/6] dt-bindings: display: add Unisoc's mipi dsi&dphy bindings Kevin Tang 2020-07-28 10:07 ` Kevin Tang 2020-07-28 10:07 ` [PATCH RFC v6 6/6] drm/sprd: add Unisoc's drm mipi dsi&dphy driver Kevin Tang 2020-07-28 10:07 ` Kevin Tang 2020-07-28 16:33 ` kernel test robot 2020-07-28 10:12 ` [PATCH RFC v6 0/6] Add Unisoc's drm kms module Daniel Vetter 2020-07-28 10:12 ` Daniel Vetter 2020-08-04 17:29 ` Rob Herring 2020-08-04 17:29 ` Rob Herring 2020-07-28 21:20 ` Sam Ravnborg 2020-07-28 21:20 ` Sam Ravnborg
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200728202732.GB1277651@ravnborg.org \ --to=sam@ravnborg.org \ --cc=airlied@linux.ie \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=kevin3.tang@gmail.com \ --cc=linux-kernel@vger.kernel.org \ --cc=maarten.lankhorst@linux.intel.com \ --cc=mark.rutland@arm.com \ --cc=mripard@kernel.org \ --cc=orsonzhai@gmail.com \ --cc=robh+dt@kernel.org \ --cc=sean@poorly.run \ --cc=zhang.lyra@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.