From: Rob Herring <robh+dt@kernel.org> To: Kevin Tang <kevin3.tang@gmail.com> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>, Maxime Ripard <mripard@kernel.org>, Sean Paul <sean@poorly.run>, David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>, Mark Rutland <mark.rutland@arm.com>, Orson Zhai <orsonzhai@gmail.com>, Lyra Zhang <zhang.lyra@gmail.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, dri-devel <dri-devel@lists.freedesktop.org> Subject: Re: [PATCH RFC v6 1/6] dt-bindings: display: add Unisoc's drm master bindings Date: Fri, 28 Aug 2020 13:39:34 -0600 [thread overview] Message-ID: <CAL_JsqKn+=idtoRiSqwSNQwfsiVRSrDSznQXWrpm=RET_hegRw@mail.gmail.com> (raw) In-Reply-To: <1595930879-2478-2-git-send-email-kevin3.tang@gmail.com> On Tue, Jul 28, 2020 at 4:08 AM Kevin Tang <kevin3.tang@gmail.com> wrote: > > From: Kevin Tang <kevin.tang@unisoc.com> > > The Unisoc DRM master device is a virtual device needed to list all > DPU devices or other display interface nodes that comprise the > graphics subsystem > > Cc: Orson Zhai <orsonzhai@gmail.com> > Cc: Chunyan Zhang <zhang.lyra@gmail.com> > Signed-off-by: Kevin Tang <kevin.tang@unisoc.com> > --- > .../devicetree/bindings/display/sprd/drm.yaml | 36 ++++++++++++++++++++++ > 1 file changed, 36 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/sprd/drm.yaml If you want bindings reviewed, then you need to Cc devicetree@vger.kernel.org. Otherwise you may be waiting until the 6th version or later or never. > > diff --git a/Documentation/devicetree/bindings/display/sprd/drm.yaml b/Documentation/devicetree/bindings/display/sprd/drm.yaml > new file mode 100644 > index 0000000..b5792c0 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/sprd/drm.yaml > @@ -0,0 +1,36 @@ > +# SPDX-License-Identifier: GPL-2.0 New bindings should be dual licensed: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/sprd/drm.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Unisoc DRM master device DRM is a Linux thing and shouldn't be part of a binding. > + > +maintainers: > + - Mark Rutland <mark.rutland@arm.com> No, this should be you or someone that knows the h/w. > + > +description: | > + The Unisoc DRM master device is a virtual device needed to list all > + DPU devices or other display interface nodes that comprise the > + graphics subsystem. > + > +properties: > + compatible: > + const: sprd,display-subsystem > + > + ports: > + description: > + Should contain a list of phandles pointing to display interface port > + of DPU devices. > + > +required: > + - compatible > + - ports > + > +examples: > + - | > + display-subsystem { > + compatible = "sprd,display-subsystem"; > + ports = <&dpu_out>; We generally try to avoid this virtual node as it doesn't represent any h/w. Can't you bind the driver to the DPU directly? Rob
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh+dt@kernel.org> To: Kevin Tang <kevin3.tang@gmail.com> Cc: Mark Rutland <mark.rutland@arm.com>, David Airlie <airlied@linux.ie>, Lyra Zhang <zhang.lyra@gmail.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, dri-devel <dri-devel@lists.freedesktop.org>, Orson Zhai <orsonzhai@gmail.com>, Sean Paul <sean@poorly.run> Subject: Re: [PATCH RFC v6 1/6] dt-bindings: display: add Unisoc's drm master bindings Date: Fri, 28 Aug 2020 13:39:34 -0600 [thread overview] Message-ID: <CAL_JsqKn+=idtoRiSqwSNQwfsiVRSrDSznQXWrpm=RET_hegRw@mail.gmail.com> (raw) In-Reply-To: <1595930879-2478-2-git-send-email-kevin3.tang@gmail.com> On Tue, Jul 28, 2020 at 4:08 AM Kevin Tang <kevin3.tang@gmail.com> wrote: > > From: Kevin Tang <kevin.tang@unisoc.com> > > The Unisoc DRM master device is a virtual device needed to list all > DPU devices or other display interface nodes that comprise the > graphics subsystem > > Cc: Orson Zhai <orsonzhai@gmail.com> > Cc: Chunyan Zhang <zhang.lyra@gmail.com> > Signed-off-by: Kevin Tang <kevin.tang@unisoc.com> > --- > .../devicetree/bindings/display/sprd/drm.yaml | 36 ++++++++++++++++++++++ > 1 file changed, 36 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/sprd/drm.yaml If you want bindings reviewed, then you need to Cc devicetree@vger.kernel.org. Otherwise you may be waiting until the 6th version or later or never. > > diff --git a/Documentation/devicetree/bindings/display/sprd/drm.yaml b/Documentation/devicetree/bindings/display/sprd/drm.yaml > new file mode 100644 > index 0000000..b5792c0 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/sprd/drm.yaml > @@ -0,0 +1,36 @@ > +# SPDX-License-Identifier: GPL-2.0 New bindings should be dual licensed: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/sprd/drm.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Unisoc DRM master device DRM is a Linux thing and shouldn't be part of a binding. > + > +maintainers: > + - Mark Rutland <mark.rutland@arm.com> No, this should be you or someone that knows the h/w. > + > +description: | > + The Unisoc DRM master device is a virtual device needed to list all > + DPU devices or other display interface nodes that comprise the > + graphics subsystem. > + > +properties: > + compatible: > + const: sprd,display-subsystem > + > + ports: > + description: > + Should contain a list of phandles pointing to display interface port > + of DPU devices. > + > +required: > + - compatible > + - ports > + > +examples: > + - | > + display-subsystem { > + compatible = "sprd,display-subsystem"; > + ports = <&dpu_out>; We generally try to avoid this virtual node as it doesn't represent any h/w. Can't you bind the driver to the DPU directly? Rob _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-08-28 19:39 UTC|newest] Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-28 10:07 [PATCH RFC v6 0/6] Add Unisoc's drm kms module Kevin Tang 2020-07-28 10:07 ` Kevin Tang 2020-07-28 10:07 ` [PATCH RFC v6 1/6] dt-bindings: display: add Unisoc's drm master bindings Kevin Tang 2020-07-28 10:07 ` Kevin Tang 2020-07-28 20:27 ` Sam Ravnborg 2020-07-28 20:27 ` Sam Ravnborg 2020-08-26 17:11 ` Kevin Tang 2020-08-26 17:11 ` Kevin Tang 2020-08-28 17:57 ` Sam Ravnborg 2020-08-28 17:57 ` Sam Ravnborg 2020-08-28 19:39 ` Rob Herring [this message] 2020-08-28 19:39 ` Rob Herring 2020-07-28 10:07 ` [PATCH RFC v6 2/6] drm/sprd: add Unisoc's drm kms master Kevin Tang 2020-07-28 10:07 ` Kevin Tang 2020-07-28 12:25 ` Randy Dunlap 2020-07-28 12:25 ` Randy Dunlap 2020-07-28 20:45 ` Sam Ravnborg 2020-07-28 20:45 ` Sam Ravnborg 2020-08-28 16:04 ` Kevin Tang 2020-08-28 16:04 ` Kevin Tang 2020-08-28 17:55 ` Sam Ravnborg 2020-08-28 17:55 ` Sam Ravnborg 2020-07-28 10:07 ` [PATCH RFC v6 3/6] dt-bindings: display: add Unisoc's dpu bindings Kevin Tang 2020-07-28 10:07 ` Kevin Tang 2020-07-28 20:51 ` Sam Ravnborg 2020-07-28 20:51 ` Sam Ravnborg 2020-07-28 10:07 ` [PATCH RFC v6 4/6] drm/sprd: add Unisoc's drm display controller driver Kevin Tang 2020-07-28 10:07 ` Kevin Tang 2020-07-28 21:13 ` Sam Ravnborg 2020-07-28 21:13 ` Sam Ravnborg 2020-08-28 17:08 ` Kevin Tang 2020-08-28 17:08 ` Kevin Tang 2020-11-17 3:07 ` Kevin Tang 2020-11-17 3:07 ` Kevin Tang 2020-07-28 21:51 ` Daniel Vetter 2020-07-28 21:51 ` Daniel Vetter 2020-08-29 17:10 ` Kevin Tang 2020-08-29 17:10 ` Kevin Tang 2021-01-05 11:09 ` Kevin Tang 2020-07-28 10:07 ` [PATCH RFC v6 5/6] dt-bindings: display: add Unisoc's mipi dsi&dphy bindings Kevin Tang 2020-07-28 10:07 ` Kevin Tang 2020-07-28 10:07 ` [PATCH RFC v6 6/6] drm/sprd: add Unisoc's drm mipi dsi&dphy driver Kevin Tang 2020-07-28 10:07 ` Kevin Tang 2020-07-28 16:33 ` kernel test robot 2020-07-28 10:12 ` [PATCH RFC v6 0/6] Add Unisoc's drm kms module Daniel Vetter 2020-07-28 10:12 ` Daniel Vetter 2020-08-04 17:29 ` Rob Herring 2020-08-04 17:29 ` Rob Herring 2020-07-28 21:20 ` Sam Ravnborg 2020-07-28 21:20 ` Sam Ravnborg
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAL_JsqKn+=idtoRiSqwSNQwfsiVRSrDSznQXWrpm=RET_hegRw@mail.gmail.com' \ --to=robh+dt@kernel.org \ --cc=airlied@linux.ie \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=kevin3.tang@gmail.com \ --cc=linux-kernel@vger.kernel.org \ --cc=maarten.lankhorst@linux.intel.com \ --cc=mark.rutland@arm.com \ --cc=mripard@kernel.org \ --cc=orsonzhai@gmail.com \ --cc=sean@poorly.run \ --cc=zhang.lyra@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.