From: Sam Ravnborg <sam@ravnborg.org> To: Kevin Tang <kevin3.tang@gmail.com> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>, Maxime Ripard <mripard@kernel.org>, Sean Paul <sean@poorly.run>, David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Orson Zhai <orsonzhai@gmail.com>, "Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>, ML dri-devel <dri-devel@lists.freedesktop.org>, Chunyan Zhang <zhang.lyra@gmail.com> Subject: Re: [PATCH RFC v6 2/6] drm/sprd: add Unisoc's drm kms master Date: Fri, 28 Aug 2020 19:55:48 +0200 [thread overview] Message-ID: <20200828175548.GA660103@ravnborg.org> (raw) In-Reply-To: <CAFPSGXaXxr+Du0ptbBHguEPgoHULozSUb-rS3-61pef1fF6b-g@mail.gmail.com> Hi Kevin > > > > > + > > > + drm->dev_private = sprd; > > dev_private is deprecated. Alwyas use upclassing. > dev_private is deprecated ? I see everyone is still using it, so it > will be deprecated in the future? It is deprecated - and a lot of drivers is in need up an update to get away from using it. From the kernel-doc: /** * @dev_private: * * DRM driver private data. This is deprecated and should be left set to * NULL. * * Instead of using this pointer it is recommended that drivers use * drm_dev_init() and embed struct &drm_device in their larger * per-device structure. */ void *dev_private; > > > + } > > > + /* with irq_enabled = true, we can use the vblank feature. */ > > > + drm->irq_enabled = true; > > Can drm_irq_install() be used? > > Then this flag shall not be set by the driver, And the interrupt numbers on different Soc are not necessarily the same > > > We need to set "IRQ_NOAUTOEN" flag for CRTC IRQ, you can see that we > manually turn the interrupt on and off by crtc > atomic_enable/atomic_disable > and the interrupt number on different Soc are not necessarily the > same. So intall interrupt in kms maybe is not suitable for us... Maybe drm_irq_install() does not fit the need here. But please take an extra look as what is does is quite basic. And no need to roll your own if there is available infrstructure that can be used. But there is nothing wrong rolloing your own if needed. Sam
WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org> To: Kevin Tang <kevin3.tang@gmail.com> Cc: Mark Rutland <mark.rutland@arm.com>, David Airlie <airlied@linux.ie>, Chunyan Zhang <zhang.lyra@gmail.com>, "Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>, ML dri-devel <dri-devel@lists.freedesktop.org>, Orson Zhai <orsonzhai@gmail.com>, Sean Paul <sean@poorly.run> Subject: Re: [PATCH RFC v6 2/6] drm/sprd: add Unisoc's drm kms master Date: Fri, 28 Aug 2020 19:55:48 +0200 [thread overview] Message-ID: <20200828175548.GA660103@ravnborg.org> (raw) In-Reply-To: <CAFPSGXaXxr+Du0ptbBHguEPgoHULozSUb-rS3-61pef1fF6b-g@mail.gmail.com> Hi Kevin > > > > > + > > > + drm->dev_private = sprd; > > dev_private is deprecated. Alwyas use upclassing. > dev_private is deprecated ? I see everyone is still using it, so it > will be deprecated in the future? It is deprecated - and a lot of drivers is in need up an update to get away from using it. From the kernel-doc: /** * @dev_private: * * DRM driver private data. This is deprecated and should be left set to * NULL. * * Instead of using this pointer it is recommended that drivers use * drm_dev_init() and embed struct &drm_device in their larger * per-device structure. */ void *dev_private; > > > + } > > > + /* with irq_enabled = true, we can use the vblank feature. */ > > > + drm->irq_enabled = true; > > Can drm_irq_install() be used? > > Then this flag shall not be set by the driver, And the interrupt numbers on different Soc are not necessarily the same > > > We need to set "IRQ_NOAUTOEN" flag for CRTC IRQ, you can see that we > manually turn the interrupt on and off by crtc > atomic_enable/atomic_disable > and the interrupt number on different Soc are not necessarily the > same. So intall interrupt in kms maybe is not suitable for us... Maybe drm_irq_install() does not fit the need here. But please take an extra look as what is does is quite basic. And no need to roll your own if there is available infrstructure that can be used. But there is nothing wrong rolloing your own if needed. Sam _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-08-28 17:56 UTC|newest] Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-28 10:07 [PATCH RFC v6 0/6] Add Unisoc's drm kms module Kevin Tang 2020-07-28 10:07 ` Kevin Tang 2020-07-28 10:07 ` [PATCH RFC v6 1/6] dt-bindings: display: add Unisoc's drm master bindings Kevin Tang 2020-07-28 10:07 ` Kevin Tang 2020-07-28 20:27 ` Sam Ravnborg 2020-07-28 20:27 ` Sam Ravnborg 2020-08-26 17:11 ` Kevin Tang 2020-08-26 17:11 ` Kevin Tang 2020-08-28 17:57 ` Sam Ravnborg 2020-08-28 17:57 ` Sam Ravnborg 2020-08-28 19:39 ` Rob Herring 2020-08-28 19:39 ` Rob Herring 2020-07-28 10:07 ` [PATCH RFC v6 2/6] drm/sprd: add Unisoc's drm kms master Kevin Tang 2020-07-28 10:07 ` Kevin Tang 2020-07-28 12:25 ` Randy Dunlap 2020-07-28 12:25 ` Randy Dunlap 2020-07-28 20:45 ` Sam Ravnborg 2020-07-28 20:45 ` Sam Ravnborg 2020-08-28 16:04 ` Kevin Tang 2020-08-28 16:04 ` Kevin Tang 2020-08-28 17:55 ` Sam Ravnborg [this message] 2020-08-28 17:55 ` Sam Ravnborg 2020-07-28 10:07 ` [PATCH RFC v6 3/6] dt-bindings: display: add Unisoc's dpu bindings Kevin Tang 2020-07-28 10:07 ` Kevin Tang 2020-07-28 20:51 ` Sam Ravnborg 2020-07-28 20:51 ` Sam Ravnborg 2020-07-28 10:07 ` [PATCH RFC v6 4/6] drm/sprd: add Unisoc's drm display controller driver Kevin Tang 2020-07-28 10:07 ` Kevin Tang 2020-07-28 21:13 ` Sam Ravnborg 2020-07-28 21:13 ` Sam Ravnborg 2020-08-28 17:08 ` Kevin Tang 2020-08-28 17:08 ` Kevin Tang 2020-11-17 3:07 ` Kevin Tang 2020-11-17 3:07 ` Kevin Tang 2020-07-28 21:51 ` Daniel Vetter 2020-07-28 21:51 ` Daniel Vetter 2020-08-29 17:10 ` Kevin Tang 2020-08-29 17:10 ` Kevin Tang 2021-01-05 11:09 ` Kevin Tang 2020-07-28 10:07 ` [PATCH RFC v6 5/6] dt-bindings: display: add Unisoc's mipi dsi&dphy bindings Kevin Tang 2020-07-28 10:07 ` Kevin Tang 2020-07-28 10:07 ` [PATCH RFC v6 6/6] drm/sprd: add Unisoc's drm mipi dsi&dphy driver Kevin Tang 2020-07-28 10:07 ` Kevin Tang 2020-07-28 16:33 ` kernel test robot 2020-07-28 10:12 ` [PATCH RFC v6 0/6] Add Unisoc's drm kms module Daniel Vetter 2020-07-28 10:12 ` Daniel Vetter 2020-08-04 17:29 ` Rob Herring 2020-08-04 17:29 ` Rob Herring 2020-07-28 21:20 ` Sam Ravnborg 2020-07-28 21:20 ` Sam Ravnborg
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200828175548.GA660103@ravnborg.org \ --to=sam@ravnborg.org \ --cc=airlied@linux.ie \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=kevin3.tang@gmail.com \ --cc=linux-kernel@vger.kernel.org \ --cc=maarten.lankhorst@linux.intel.com \ --cc=mark.rutland@arm.com \ --cc=mripard@kernel.org \ --cc=orsonzhai@gmail.com \ --cc=robh+dt@kernel.org \ --cc=sean@poorly.run \ --cc=zhang.lyra@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.