From: Krzysztof Kozlowski <krzk@kernel.org> To: Russell King <linux@armlinux.org.uk>, Kukjin Kim <kgene@kernel.org>, Krzysztof Kozlowski <krzk@kernel.org>, Simtec Linux Team <linux@simtec.co.uk>, Maxime Coquelin <mcoquelin.stm32@gmail.com>, Alexandre Torgue <alexandre.torgue@st.com>, Kyungmin Park <kyungmin.park@samsung.com>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>, Sylwester Nawrocki <s.nawrocki@samsung.com>, Tomasz Figa <tomasz.figa@gmail.com>, Chanwoo Choi <cw00.choi@samsung.com>, Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@kernel.org>, Wim Van Sebroeck <wim@linux-watchdog.org>, Guenter Roeck <linux@roeck-us.net>, Arnd Bergmann <arnd@arndb.de>, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, patches@opensource.cirrus.com, linux-clk@vger.kernel.org, linux-watchdog@vger.kernel.org Cc: Sergio Prado <sergio.prado@e-labworks.com>, Marek Szyprowski <m.szyprowski@samsung.com>, Sylwester Nawrocki <snawrocki@kernel.org>, Cedric Roux <sed@free.fr>, Lihua Yao <ylhuajnu@outlook.com> Subject: [PATCH v2 01/13] clk: samsung: s3c64xx: declare s3c64xx_clk_init() in shared header Date: Tue, 4 Aug 2020 21:26:42 +0200 [thread overview] Message-ID: <20200804192654.12783-2-krzk@kernel.org> (raw) In-Reply-To: <20200804192654.12783-1-krzk@kernel.org> The s3c64xx_clk_init() is defined and used by the clk-s3c64xx driver and also used in the mach-s3c64xx machine code. Move the declaration to a header to fix W=1 build warning: drivers/clk/samsung/clk-s3c64xx.c:391:13: warning: no previous prototype for 's3c64xx_clk_init' [-Wmissing-prototypes] 391 | void __init s3c64xx_clk_init(struct device_node *np, unsigned long xtal_f, Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> Reviewed-by: Tomasz Figa <tomasz.figa@gmail.com> --- Changes since v1: 1. Drop __init from header (as suggested by Stephen), 2. Add necessary header and forward declaration (as suggested by Stephen), 3. Add review tag. --- MAINTAINERS | 1 + arch/arm/mach-s3c64xx/common.c | 1 + arch/arm/mach-s3c64xx/common.h | 2 -- drivers/clk/samsung/clk-s3c64xx.c | 1 + include/linux/clk/samsung.h | 24 ++++++++++++++++++++++++ 5 files changed, 27 insertions(+), 2 deletions(-) create mode 100644 include/linux/clk/samsung.h diff --git a/MAINTAINERS b/MAINTAINERS index a2885ec15bb8..5675fc9bfa00 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -15294,6 +15294,7 @@ F: Documentation/devicetree/bindings/clock/samsung,s3c* F: Documentation/devicetree/bindings/clock/samsung,s5p* F: drivers/clk/samsung/ F: include/dt-bindings/clock/exynos*.h +F: include/linux/clk/samsung.h SAMSUNG SPI DRIVERS M: Kukjin Kim <kgene@kernel.org> diff --git a/arch/arm/mach-s3c64xx/common.c b/arch/arm/mach-s3c64xx/common.c index 13e91074308a..a655bf0c7802 100644 --- a/arch/arm/mach-s3c64xx/common.c +++ b/arch/arm/mach-s3c64xx/common.c @@ -24,6 +24,7 @@ #include <linux/platform_device.h> #include <linux/reboot.h> #include <linux/io.h> +#include <linux/clk/samsung.h> #include <linux/dma-mapping.h> #include <linux/irq.h> #include <linux/gpio.h> diff --git a/arch/arm/mach-s3c64xx/common.h b/arch/arm/mach-s3c64xx/common.h index 03670887a764..f4eca42cdc86 100644 --- a/arch/arm/mach-s3c64xx/common.h +++ b/arch/arm/mach-s3c64xx/common.h @@ -22,8 +22,6 @@ void s3c64xx_init_io(struct map_desc *mach_desc, int size); void s3c64xx_restart(enum reboot_mode mode, const char *cmd); struct device_node; -void s3c64xx_clk_init(struct device_node *np, unsigned long xtal_f, - unsigned long xusbxti_f, bool is_s3c6400, void __iomem *reg_base); void s3c64xx_set_xtal_freq(unsigned long freq); void s3c64xx_set_xusbxti_freq(unsigned long freq); diff --git a/drivers/clk/samsung/clk-s3c64xx.c b/drivers/clk/samsung/clk-s3c64xx.c index b96d33e5eb45..56f95b63f71f 100644 --- a/drivers/clk/samsung/clk-s3c64xx.c +++ b/drivers/clk/samsung/clk-s3c64xx.c @@ -7,6 +7,7 @@ #include <linux/slab.h> #include <linux/clk-provider.h> +#include <linux/clk/samsung.h> #include <linux/of.h> #include <linux/of_address.h> diff --git a/include/linux/clk/samsung.h b/include/linux/clk/samsung.h new file mode 100644 index 000000000000..7a0824b22eed --- /dev/null +++ b/include/linux/clk/samsung.h @@ -0,0 +1,24 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* + * Copyright (c) 2020 Krzysztof Kozlowski <krzk@kernel.org> + */ + +#ifndef __LINUX_CLK_SAMSUNG_H_ +#define __LINUX_CLK_SAMSUNG_H_ + +#include <linux/compiler_types.h> + +struct device_node; + +#ifdef CONFIG_ARCH_S3C64XX +void s3c64xx_clk_init(struct device_node *np, unsigned long xtal_f, + unsigned long xusbxti_f, bool s3c6400, + void __iomem *base); +#else +static inline void s3c64xx_clk_init(struct device_node *np, + unsigned long xtal_f, + unsigned long xusbxti_f, + bool s3c6400, void __iomem *base) { } +#endif /* CONFIG_ARCH_S3C64XX */ + +#endif /* __LINUX_CLK_SAMSUNG_H_ */ -- 2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org> To: Russell King <linux@armlinux.org.uk>, Kukjin Kim <kgene@kernel.org>, Krzysztof Kozlowski <krzk@kernel.org>, Simtec Linux Team <linux@simtec.co.uk>, Maxime Coquelin <mcoquelin.stm32@gmail.com>, Alexandre Torgue <alexandre.torgue@st.com>, Kyungmin Park <kyungmin.park@samsung.com>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>, Sylwester Nawrocki <s.nawrocki@samsung.com>, Tomasz Figa <tomasz.figa@gmail.com>, Chanwoo Choi <cw00.choi@samsung.com>, Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@kernel.org>, Wim Van Sebroeck <wim@linux-watchdog.org>, Guenter Roeck <linux@roeck-us.net>, Arnd Bergmann <arnd@arndb.de>, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, patches@opensource.cirrus.com, linux-clk@vger.kernel.org, linux-watchdog@vger.kernel.org Cc: Sylwester Nawrocki <snawrocki@kernel.org>, Lihua Yao <ylhuajnu@outlook.com>, Cedric Roux <sed@free.fr>, Sergio Prado <sergio.prado@e-labworks.com>, Marek Szyprowski <m.szyprowski@samsung.com> Subject: [PATCH v2 01/13] clk: samsung: s3c64xx: declare s3c64xx_clk_init() in shared header Date: Tue, 4 Aug 2020 21:26:42 +0200 [thread overview] Message-ID: <20200804192654.12783-2-krzk@kernel.org> (raw) In-Reply-To: <20200804192654.12783-1-krzk@kernel.org> The s3c64xx_clk_init() is defined and used by the clk-s3c64xx driver and also used in the mach-s3c64xx machine code. Move the declaration to a header to fix W=1 build warning: drivers/clk/samsung/clk-s3c64xx.c:391:13: warning: no previous prototype for 's3c64xx_clk_init' [-Wmissing-prototypes] 391 | void __init s3c64xx_clk_init(struct device_node *np, unsigned long xtal_f, Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> Reviewed-by: Tomasz Figa <tomasz.figa@gmail.com> --- Changes since v1: 1. Drop __init from header (as suggested by Stephen), 2. Add necessary header and forward declaration (as suggested by Stephen), 3. Add review tag. --- MAINTAINERS | 1 + arch/arm/mach-s3c64xx/common.c | 1 + arch/arm/mach-s3c64xx/common.h | 2 -- drivers/clk/samsung/clk-s3c64xx.c | 1 + include/linux/clk/samsung.h | 24 ++++++++++++++++++++++++ 5 files changed, 27 insertions(+), 2 deletions(-) create mode 100644 include/linux/clk/samsung.h diff --git a/MAINTAINERS b/MAINTAINERS index a2885ec15bb8..5675fc9bfa00 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -15294,6 +15294,7 @@ F: Documentation/devicetree/bindings/clock/samsung,s3c* F: Documentation/devicetree/bindings/clock/samsung,s5p* F: drivers/clk/samsung/ F: include/dt-bindings/clock/exynos*.h +F: include/linux/clk/samsung.h SAMSUNG SPI DRIVERS M: Kukjin Kim <kgene@kernel.org> diff --git a/arch/arm/mach-s3c64xx/common.c b/arch/arm/mach-s3c64xx/common.c index 13e91074308a..a655bf0c7802 100644 --- a/arch/arm/mach-s3c64xx/common.c +++ b/arch/arm/mach-s3c64xx/common.c @@ -24,6 +24,7 @@ #include <linux/platform_device.h> #include <linux/reboot.h> #include <linux/io.h> +#include <linux/clk/samsung.h> #include <linux/dma-mapping.h> #include <linux/irq.h> #include <linux/gpio.h> diff --git a/arch/arm/mach-s3c64xx/common.h b/arch/arm/mach-s3c64xx/common.h index 03670887a764..f4eca42cdc86 100644 --- a/arch/arm/mach-s3c64xx/common.h +++ b/arch/arm/mach-s3c64xx/common.h @@ -22,8 +22,6 @@ void s3c64xx_init_io(struct map_desc *mach_desc, int size); void s3c64xx_restart(enum reboot_mode mode, const char *cmd); struct device_node; -void s3c64xx_clk_init(struct device_node *np, unsigned long xtal_f, - unsigned long xusbxti_f, bool is_s3c6400, void __iomem *reg_base); void s3c64xx_set_xtal_freq(unsigned long freq); void s3c64xx_set_xusbxti_freq(unsigned long freq); diff --git a/drivers/clk/samsung/clk-s3c64xx.c b/drivers/clk/samsung/clk-s3c64xx.c index b96d33e5eb45..56f95b63f71f 100644 --- a/drivers/clk/samsung/clk-s3c64xx.c +++ b/drivers/clk/samsung/clk-s3c64xx.c @@ -7,6 +7,7 @@ #include <linux/slab.h> #include <linux/clk-provider.h> +#include <linux/clk/samsung.h> #include <linux/of.h> #include <linux/of_address.h> diff --git a/include/linux/clk/samsung.h b/include/linux/clk/samsung.h new file mode 100644 index 000000000000..7a0824b22eed --- /dev/null +++ b/include/linux/clk/samsung.h @@ -0,0 +1,24 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* + * Copyright (c) 2020 Krzysztof Kozlowski <krzk@kernel.org> + */ + +#ifndef __LINUX_CLK_SAMSUNG_H_ +#define __LINUX_CLK_SAMSUNG_H_ + +#include <linux/compiler_types.h> + +struct device_node; + +#ifdef CONFIG_ARCH_S3C64XX +void s3c64xx_clk_init(struct device_node *np, unsigned long xtal_f, + unsigned long xusbxti_f, bool s3c6400, + void __iomem *base); +#else +static inline void s3c64xx_clk_init(struct device_node *np, + unsigned long xtal_f, + unsigned long xusbxti_f, + bool s3c6400, void __iomem *base) { } +#endif /* CONFIG_ARCH_S3C64XX */ + +#endif /* __LINUX_CLK_SAMSUNG_H_ */ -- 2.17.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-08-04 19:27 UTC|newest] Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-08-04 19:26 [PATCH v2 00/13] clk/watchdog/ARM: Cleanup of various S3C bits Krzysztof Kozlowski 2020-08-04 19:26 ` Krzysztof Kozlowski 2020-08-04 19:26 ` Krzysztof Kozlowski [this message] 2020-08-04 19:26 ` [PATCH v2 01/13] clk: samsung: s3c64xx: declare s3c64xx_clk_init() in shared header Krzysztof Kozlowski 2020-08-05 1:22 ` Chanwoo Choi 2020-08-05 1:22 ` Chanwoo Choi 2020-08-12 7:57 ` Stephen Boyd 2020-08-12 7:57 ` Stephen Boyd 2020-08-04 19:26 ` [PATCH v2 02/13] clk: samsung: s3c24xx: declare s3c24xx_common_clk_init() " Krzysztof Kozlowski 2020-08-04 19:26 ` Krzysztof Kozlowski 2020-08-05 1:23 ` Chanwoo Choi 2020-08-05 1:23 ` Chanwoo Choi 2020-08-12 7:57 ` Stephen Boyd 2020-08-12 7:57 ` Stephen Boyd 2020-08-04 19:26 ` [PATCH v2 03/13] ARM: s3c64xx: include header to fix -Wmissing-prototypes Krzysztof Kozlowski 2020-08-04 19:26 ` Krzysztof Kozlowski 2020-08-12 7:58 ` Stephen Boyd 2020-08-12 7:58 ` Stephen Boyd 2020-08-04 19:26 ` [PATCH v2 04/13] ARM: s3c: remove plat-samsung/.../samsung-time.h Krzysztof Kozlowski 2020-08-04 19:26 ` Krzysztof Kozlowski 2020-08-04 19:26 ` [PATCH v2 05/13] ARM: samsung: fix language typo Krzysztof Kozlowski 2020-08-04 19:26 ` Krzysztof Kozlowski 2020-08-12 7:59 ` Stephen Boyd 2020-08-12 7:59 ` Stephen Boyd 2020-08-04 19:26 ` [PATCH v2 06/13] ARM: samsung: remove HAVE_S3C2410_WATCHDOG and use direct dependencies Krzysztof Kozlowski 2020-08-04 19:26 ` Krzysztof Kozlowski 2020-08-17 16:57 ` Krzysztof Kozlowski 2020-08-17 16:57 ` Krzysztof Kozlowski 2020-08-17 17:00 ` Tomasz Figa 2020-08-17 17:00 ` Tomasz Figa 2020-08-17 18:02 ` Guenter Roeck 2020-08-17 18:02 ` Guenter Roeck 2020-08-19 18:16 ` Krzysztof Kozlowski 2020-08-19 18:16 ` Krzysztof Kozlowski 2020-08-04 19:26 ` [PATCH v2 07/13] ARM: s3c64xx: switch to generic watchdog driver reset Krzysztof Kozlowski 2020-08-04 19:26 ` Krzysztof Kozlowski 2020-08-19 18:17 ` Krzysztof Kozlowski 2020-08-19 18:17 ` Krzysztof Kozlowski 2020-08-04 19:26 ` [PATCH v2 08/13] ARM: s3c24xx: fix missing system reset Krzysztof Kozlowski 2020-08-04 19:26 ` Krzysztof Kozlowski 2020-08-19 18:18 ` Krzysztof Kozlowski 2020-08-19 18:18 ` Krzysztof Kozlowski 2020-08-04 19:26 ` [PATCH v2 09/13] ARM: s3c24xx: include common.h header in s3c2443.c Krzysztof Kozlowski 2020-08-04 19:26 ` Krzysztof Kozlowski 2020-08-04 19:26 ` [PATCH v2 10/13] ARM: s3c24xx: sdhci: include plat/sdhci.h header Krzysztof Kozlowski 2020-08-04 19:26 ` Krzysztof Kozlowski 2020-08-04 19:26 ` [PATCH v2 11/13] ARM: s3c24xx: ts: include platform data header Krzysztof Kozlowski 2020-08-04 19:26 ` Krzysztof Kozlowski 2020-08-04 19:26 ` [PATCH v2 12/13] ARM: s3c24xx: ts: document function argument Krzysztof Kozlowski 2020-08-04 19:26 ` Krzysztof Kozlowski 2020-08-04 19:26 ` [PATCH v2 13/13] ARM: s3c24xx: camif: include header with prototypes and unify declaration Krzysztof Kozlowski 2020-08-04 19:26 ` Krzysztof Kozlowski 2020-08-12 7:59 ` Stephen Boyd 2020-08-12 7:59 ` Stephen Boyd 2020-08-12 9:14 ` Arnd Bergmann 2020-08-12 9:14 ` Arnd Bergmann 2020-08-12 10:46 ` Sylwester Nawrocki 2020-08-12 10:46 ` Sylwester Nawrocki 2020-08-12 11:28 ` Arnd Bergmann 2020-08-12 11:28 ` Arnd Bergmann 2020-08-12 13:11 ` Sylwester Nawrocki 2020-08-12 13:11 ` Sylwester Nawrocki 2020-08-12 13:31 ` Krzysztof Kozlowski 2020-08-12 13:31 ` Krzysztof Kozlowski 2020-08-12 15:58 ` Sylwester Nawrocki 2020-08-12 15:58 ` Sylwester Nawrocki 2020-08-12 17:13 ` Krzysztof Kozlowski 2020-08-12 17:13 ` Krzysztof Kozlowski 2020-08-12 18:49 ` Sylwester Nawrocki 2020-08-12 18:49 ` Sylwester Nawrocki 2020-08-27 20:52 ` Cedric Roux 2020-08-27 20:52 ` Cedric Roux 2020-09-06 15:41 ` Krzysztof Kozlowski 2020-09-06 15:41 ` Krzysztof Kozlowski 2020-08-05 8:18 ` [PATCH v2 00/13] clk/watchdog/ARM: Cleanup of various S3C bits Lihua Yao 2020-08-06 12:16 ` Krzysztof Kozlowski 2020-08-06 12:16 ` Krzysztof Kozlowski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200804192654.12783-2-krzk@kernel.org \ --to=krzk@kernel.org \ --cc=alexandre.torgue@st.com \ --cc=arnd@arndb.de \ --cc=catalin.marinas@arm.com \ --cc=cw00.choi@samsung.com \ --cc=kgene@kernel.org \ --cc=kyungmin.park@samsung.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=linux-stm32@st-md-mailman.stormreply.com \ --cc=linux-watchdog@vger.kernel.org \ --cc=linux@armlinux.org.uk \ --cc=linux@roeck-us.net \ --cc=linux@simtec.co.uk \ --cc=m.szyprowski@samsung.com \ --cc=mcoquelin.stm32@gmail.com \ --cc=mturquette@baylibre.com \ --cc=patches@opensource.cirrus.com \ --cc=s.nawrocki@samsung.com \ --cc=sboyd@kernel.org \ --cc=sed@free.fr \ --cc=sergio.prado@e-labworks.com \ --cc=snawrocki@kernel.org \ --cc=tomasz.figa@gmail.com \ --cc=will@kernel.org \ --cc=wim@linux-watchdog.org \ --cc=ylhuajnu@outlook.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.