From: Arnd Bergmann <arnd@arndb.de> To: Sylwester Nawrocki <s.nawrocki@samsung.com> Cc: Stephen Boyd <sboyd@kernel.org>, Alexandre Torgue <alexandre.torgue@st.com>, Catalin Marinas <catalin.marinas@arm.com>, Chanwoo Choi <cw00.choi@samsung.com>, Guenter Roeck <linux@roeck-us.net>, Krzysztof Kozlowski <krzk@kernel.org>, Kukjin Kim <kgene@kernel.org>, Kyungmin Park <kyungmin.park@samsung.com>, Maxime Coquelin <mcoquelin.stm32@gmail.com>, Michael Turquette <mturquette@baylibre.com>, Russell King <linux@armlinux.org.uk>, Simtec Linux Team <linux@simtec.co.uk>, Tomasz Figa <tomasz.figa@gmail.com>, Will Deacon <will@kernel.org>, Wim Van Sebroeck <wim@linux-watchdog.org>, Linux ARM <linux-arm-kernel@lists.infradead.org>, linux-clk <linux-clk@vger.kernel.org>, "moderated list:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES" <linux-samsung-soc@vger.kernel.org>, linux-stm32@st-md-mailman.stormreply.com, LINUXWATCHDOG <linux-watchdog@vger.kernel.org>, patches@opensource.cirrus.com, Sergio Prado <sergio.prado@e-labworks.com>, Marek Szyprowski <m.szyprowski@samsung.com>, Sylwester Nawrocki <snawrocki@kernel.org>, Cedric Roux <sed@free.fr>, Lihua Yao <ylhuajnu@outlook.com> Subject: Re: [PATCH v2 13/13] ARM: s3c24xx: camif: include header with prototypes and unify declaration Date: Wed, 12 Aug 2020 13:28:35 +0200 [thread overview] Message-ID: <CAK8P3a1xXe56k5nKuCJ-25h1VqWKRb9JGnFrr=SPg_icay-vZA@mail.gmail.com> (raw) In-Reply-To: <8066413c-367d-2f8d-3e7b-dacd954675be@samsung.com> On Wed, Aug 12, 2020 at 12:46 PM Sylwester Nawrocki <s.nawrocki@samsung.com> wrote: > On 12.08.2020 11:14, Arnd Bergmann wrote: > > > > It seems there have never been any callers and the entire file > > can just be removed, with the rest of that platform_data header > > file moved to drivers/media/platform/s3c-camif/. > > Yes, it seems that patch never made it to mainline: > https://git.linuxtv.org/snawrocki/media.git/commit/?h=testing/s3c-camif&id=355cbf835aff2aabf78390931cbbaa608af77967 I suppose it would still apply if anyone was interested, but I see your point. > I doubt there are still users of camera on the s3c2440 boards > with current mainline kernels, if any at all, there are much > better HW alternatives right now. I see two board files (and no DT) instantiate the camif device: NexVision Nexcoder 2440 and the FriendlyARM mini2440. Can you say whether the camif on those would actually work at all without your patch? If not, we know that there are no users of that driver and could either drop it completely or move it to staging for a release or two. Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de> To: Sylwester Nawrocki <s.nawrocki@samsung.com> Cc: Catalin Marinas <catalin.marinas@arm.com>, Michael Turquette <mturquette@baylibre.com>, Tomasz Figa <tomasz.figa@gmail.com>, Will Deacon <will@kernel.org>, linux-clk <linux-clk@vger.kernel.org>, LINUXWATCHDOG <linux-watchdog@vger.kernel.org>, "moderated list:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES" <linux-samsung-soc@vger.kernel.org>, Sylwester Nawrocki <snawrocki@kernel.org>, Cedric Roux <sed@free.fr>, Russell King <linux@armlinux.org.uk>, Krzysztof Kozlowski <krzk@kernel.org>, linux-stm32@st-md-mailman.stormreply.com, Lihua Yao <ylhuajnu@outlook.com>, Chanwoo Choi <cw00.choi@samsung.com>, Kukjin Kim <kgene@kernel.org>, Marek Szyprowski <m.szyprowski@samsung.com>, Guenter Roeck <linux@roeck-us.net>, Sergio Prado <sergio.prado@e-labworks.com>, Alexandre Torgue <alexandre.torgue@st.com>, Wim Van Sebroeck <wim@linux-watchdog.org>, Simtec Linux Team <linux@simtec.co.uk>, Linux ARM <linux-arm-kernel@lists.infradead.org>, Stephen Boyd <sboyd@kernel.org>, patches@opensource.cirrus.com, Kyungmin Park <kyungmin.park@samsung.com>, Maxime Coquelin <mcoquelin.stm32@gmail.com> Subject: Re: [PATCH v2 13/13] ARM: s3c24xx: camif: include header with prototypes and unify declaration Date: Wed, 12 Aug 2020 13:28:35 +0200 [thread overview] Message-ID: <CAK8P3a1xXe56k5nKuCJ-25h1VqWKRb9JGnFrr=SPg_icay-vZA@mail.gmail.com> (raw) In-Reply-To: <8066413c-367d-2f8d-3e7b-dacd954675be@samsung.com> On Wed, Aug 12, 2020 at 12:46 PM Sylwester Nawrocki <s.nawrocki@samsung.com> wrote: > On 12.08.2020 11:14, Arnd Bergmann wrote: > > > > It seems there have never been any callers and the entire file > > can just be removed, with the rest of that platform_data header > > file moved to drivers/media/platform/s3c-camif/. > > Yes, it seems that patch never made it to mainline: > https://git.linuxtv.org/snawrocki/media.git/commit/?h=testing/s3c-camif&id=355cbf835aff2aabf78390931cbbaa608af77967 I suppose it would still apply if anyone was interested, but I see your point. > I doubt there are still users of camera on the s3c2440 boards > with current mainline kernels, if any at all, there are much > better HW alternatives right now. I see two board files (and no DT) instantiate the camif device: NexVision Nexcoder 2440 and the FriendlyARM mini2440. Can you say whether the camif on those would actually work at all without your patch? If not, we know that there are no users of that driver and could either drop it completely or move it to staging for a release or two. Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-08-12 11:28 UTC|newest] Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-08-04 19:26 [PATCH v2 00/13] clk/watchdog/ARM: Cleanup of various S3C bits Krzysztof Kozlowski 2020-08-04 19:26 ` Krzysztof Kozlowski 2020-08-04 19:26 ` [PATCH v2 01/13] clk: samsung: s3c64xx: declare s3c64xx_clk_init() in shared header Krzysztof Kozlowski 2020-08-04 19:26 ` Krzysztof Kozlowski 2020-08-05 1:22 ` Chanwoo Choi 2020-08-05 1:22 ` Chanwoo Choi 2020-08-12 7:57 ` Stephen Boyd 2020-08-12 7:57 ` Stephen Boyd 2020-08-04 19:26 ` [PATCH v2 02/13] clk: samsung: s3c24xx: declare s3c24xx_common_clk_init() " Krzysztof Kozlowski 2020-08-04 19:26 ` Krzysztof Kozlowski 2020-08-05 1:23 ` Chanwoo Choi 2020-08-05 1:23 ` Chanwoo Choi 2020-08-12 7:57 ` Stephen Boyd 2020-08-12 7:57 ` Stephen Boyd 2020-08-04 19:26 ` [PATCH v2 03/13] ARM: s3c64xx: include header to fix -Wmissing-prototypes Krzysztof Kozlowski 2020-08-04 19:26 ` Krzysztof Kozlowski 2020-08-12 7:58 ` Stephen Boyd 2020-08-12 7:58 ` Stephen Boyd 2020-08-04 19:26 ` [PATCH v2 04/13] ARM: s3c: remove plat-samsung/.../samsung-time.h Krzysztof Kozlowski 2020-08-04 19:26 ` Krzysztof Kozlowski 2020-08-04 19:26 ` [PATCH v2 05/13] ARM: samsung: fix language typo Krzysztof Kozlowski 2020-08-04 19:26 ` Krzysztof Kozlowski 2020-08-12 7:59 ` Stephen Boyd 2020-08-12 7:59 ` Stephen Boyd 2020-08-04 19:26 ` [PATCH v2 06/13] ARM: samsung: remove HAVE_S3C2410_WATCHDOG and use direct dependencies Krzysztof Kozlowski 2020-08-04 19:26 ` Krzysztof Kozlowski 2020-08-17 16:57 ` Krzysztof Kozlowski 2020-08-17 16:57 ` Krzysztof Kozlowski 2020-08-17 17:00 ` Tomasz Figa 2020-08-17 17:00 ` Tomasz Figa 2020-08-17 18:02 ` Guenter Roeck 2020-08-17 18:02 ` Guenter Roeck 2020-08-19 18:16 ` Krzysztof Kozlowski 2020-08-19 18:16 ` Krzysztof Kozlowski 2020-08-04 19:26 ` [PATCH v2 07/13] ARM: s3c64xx: switch to generic watchdog driver reset Krzysztof Kozlowski 2020-08-04 19:26 ` Krzysztof Kozlowski 2020-08-19 18:17 ` Krzysztof Kozlowski 2020-08-19 18:17 ` Krzysztof Kozlowski 2020-08-04 19:26 ` [PATCH v2 08/13] ARM: s3c24xx: fix missing system reset Krzysztof Kozlowski 2020-08-04 19:26 ` Krzysztof Kozlowski 2020-08-19 18:18 ` Krzysztof Kozlowski 2020-08-19 18:18 ` Krzysztof Kozlowski 2020-08-04 19:26 ` [PATCH v2 09/13] ARM: s3c24xx: include common.h header in s3c2443.c Krzysztof Kozlowski 2020-08-04 19:26 ` Krzysztof Kozlowski 2020-08-04 19:26 ` [PATCH v2 10/13] ARM: s3c24xx: sdhci: include plat/sdhci.h header Krzysztof Kozlowski 2020-08-04 19:26 ` Krzysztof Kozlowski 2020-08-04 19:26 ` [PATCH v2 11/13] ARM: s3c24xx: ts: include platform data header Krzysztof Kozlowski 2020-08-04 19:26 ` Krzysztof Kozlowski 2020-08-04 19:26 ` [PATCH v2 12/13] ARM: s3c24xx: ts: document function argument Krzysztof Kozlowski 2020-08-04 19:26 ` Krzysztof Kozlowski 2020-08-04 19:26 ` [PATCH v2 13/13] ARM: s3c24xx: camif: include header with prototypes and unify declaration Krzysztof Kozlowski 2020-08-04 19:26 ` Krzysztof Kozlowski 2020-08-12 7:59 ` Stephen Boyd 2020-08-12 7:59 ` Stephen Boyd 2020-08-12 9:14 ` Arnd Bergmann 2020-08-12 9:14 ` Arnd Bergmann 2020-08-12 10:46 ` Sylwester Nawrocki 2020-08-12 10:46 ` Sylwester Nawrocki 2020-08-12 11:28 ` Arnd Bergmann [this message] 2020-08-12 11:28 ` Arnd Bergmann 2020-08-12 13:11 ` Sylwester Nawrocki 2020-08-12 13:11 ` Sylwester Nawrocki 2020-08-12 13:31 ` Krzysztof Kozlowski 2020-08-12 13:31 ` Krzysztof Kozlowski 2020-08-12 15:58 ` Sylwester Nawrocki 2020-08-12 15:58 ` Sylwester Nawrocki 2020-08-12 17:13 ` Krzysztof Kozlowski 2020-08-12 17:13 ` Krzysztof Kozlowski 2020-08-12 18:49 ` Sylwester Nawrocki 2020-08-12 18:49 ` Sylwester Nawrocki 2020-08-27 20:52 ` Cedric Roux 2020-08-27 20:52 ` Cedric Roux 2020-09-06 15:41 ` Krzysztof Kozlowski 2020-09-06 15:41 ` Krzysztof Kozlowski 2020-08-05 8:18 ` [PATCH v2 00/13] clk/watchdog/ARM: Cleanup of various S3C bits Lihua Yao 2020-08-06 12:16 ` Krzysztof Kozlowski 2020-08-06 12:16 ` Krzysztof Kozlowski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAK8P3a1xXe56k5nKuCJ-25h1VqWKRb9JGnFrr=SPg_icay-vZA@mail.gmail.com' \ --to=arnd@arndb.de \ --cc=alexandre.torgue@st.com \ --cc=catalin.marinas@arm.com \ --cc=cw00.choi@samsung.com \ --cc=kgene@kernel.org \ --cc=krzk@kernel.org \ --cc=kyungmin.park@samsung.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=linux-stm32@st-md-mailman.stormreply.com \ --cc=linux-watchdog@vger.kernel.org \ --cc=linux@armlinux.org.uk \ --cc=linux@roeck-us.net \ --cc=linux@simtec.co.uk \ --cc=m.szyprowski@samsung.com \ --cc=mcoquelin.stm32@gmail.com \ --cc=mturquette@baylibre.com \ --cc=patches@opensource.cirrus.com \ --cc=s.nawrocki@samsung.com \ --cc=sboyd@kernel.org \ --cc=sed@free.fr \ --cc=sergio.prado@e-labworks.com \ --cc=snawrocki@kernel.org \ --cc=tomasz.figa@gmail.com \ --cc=will@kernel.org \ --cc=wim@linux-watchdog.org \ --cc=ylhuajnu@outlook.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.