From: Tomasz Figa <tomasz.figa@gmail.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Guenter Roeck <linux@roeck-us.net>,
Russell King <linux@armlinux.org.uk>,
Kukjin Kim <kgene@kernel.org>,
Simtec Linux Team <linux@simtec.co.uk>,
Arnd Bergmann <arnd@arndb.de>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
"moderated list:SAMSUNG SOC CLOCK DRIVERS"
<linux-samsung-soc@vger.kernel.org>,
linux-stm32@st-md-mailman.stormreply.com,
patches@opensource.cirrus.com,
"open list:COMMON CLK FRAMEWORK" <linux-clk@vger.kernel.org>,
linux-watchdog@vger.kernel.org,
Sergio Prado <sergio.prado@e-labworks.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Sylwester Nawrocki <snawrocki@kernel.org>,
Cedric Roux <sed@free.fr>, Lihua Yao <ylhuajnu@outlook.com>
Subject: Re: [PATCH v2 06/13] ARM: samsung: remove HAVE_S3C2410_WATCHDOG and use direct dependencies
Date: Mon, 17 Aug 2020 19:00:54 +0200 [thread overview]
Message-ID: <CA+Ln22Hw8_FT0s2N0rBo=2XVmuLagj=BFrTkTGd10J7d4B1Jow@mail.gmail.com> (raw)
In-Reply-To: <20200817165748.GA29664@kozik-lap>
2020年8月17日(月) 18:57 Krzysztof Kozlowski <krzk@kernel.org>:
>
> On Tue, Aug 04, 2020 at 09:26:47PM +0200, Krzysztof Kozlowski wrote:
> > A separate Kconfig option HAVE_S3C2410_WATCHDOG for Samsung SoCs is not
> > really needed and the s3c24xx watchdog driver can depend on Samsung ARM
> > architectures instead.
> >
> > The "HAVE_xxx_WATCHDOG" pattern of dependency is not popular and Samsung
> > platforms are here exceptions. All others just depend on
> > CONFIG_ARCH_xxx.
> >
> > This makes the code slightly smaller without any change in
> > functionality.
> >
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> >
> > ---
> >
> > Changes since v1:
> > 1. Re-add the dependency on architectures to keep same functionality.
>
> Hi Guenter, Tomasz,
>
> Does such removal of HAVE_S3C2410_WATCHDOG makes sense for you?
I don't have any objections and the patch itself is trivial.
Best regards,
Tomasz
WARNING: multiple messages have this Message-ID (diff)
From: Tomasz Figa <tomasz.figa@gmail.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Michael Turquette <mturquette@baylibre.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Will Deacon <will@kernel.org>,
"open list:COMMON CLK FRAMEWORK" <linux-clk@vger.kernel.org>,
linux-watchdog@vger.kernel.org,
"moderated list:SAMSUNG SOC CLOCK DRIVERS"
<linux-samsung-soc@vger.kernel.org>,
Sylwester Nawrocki <snawrocki@kernel.org>,
Cedric Roux <sed@free.fr>, Russell King <linux@armlinux.org.uk>,
linux-stm32@st-md-mailman.stormreply.com,
Lihua Yao <ylhuajnu@outlook.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Kukjin Kim <kgene@kernel.org>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Guenter Roeck <linux@roeck-us.net>,
Sergio Prado <sergio.prado@e-labworks.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
Arnd Bergmann <arnd@arndb.de>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Simtec Linux Team <linux@simtec.co.uk>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
Stephen Boyd <sboyd@kernel.org>,
patches@opensource.cirrus.com,
Kyungmin Park <kyungmin.park@samsung.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>
Subject: Re: [PATCH v2 06/13] ARM: samsung: remove HAVE_S3C2410_WATCHDOG and use direct dependencies
Date: Mon, 17 Aug 2020 19:00:54 +0200 [thread overview]
Message-ID: <CA+Ln22Hw8_FT0s2N0rBo=2XVmuLagj=BFrTkTGd10J7d4B1Jow@mail.gmail.com> (raw)
In-Reply-To: <20200817165748.GA29664@kozik-lap>
2020年8月17日(月) 18:57 Krzysztof Kozlowski <krzk@kernel.org>:
>
> On Tue, Aug 04, 2020 at 09:26:47PM +0200, Krzysztof Kozlowski wrote:
> > A separate Kconfig option HAVE_S3C2410_WATCHDOG for Samsung SoCs is not
> > really needed and the s3c24xx watchdog driver can depend on Samsung ARM
> > architectures instead.
> >
> > The "HAVE_xxx_WATCHDOG" pattern of dependency is not popular and Samsung
> > platforms are here exceptions. All others just depend on
> > CONFIG_ARCH_xxx.
> >
> > This makes the code slightly smaller without any change in
> > functionality.
> >
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> >
> > ---
> >
> > Changes since v1:
> > 1. Re-add the dependency on architectures to keep same functionality.
>
> Hi Guenter, Tomasz,
>
> Does such removal of HAVE_S3C2410_WATCHDOG makes sense for you?
I don't have any objections and the patch itself is trivial.
Best regards,
Tomasz
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-08-17 17:01 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-04 19:26 [PATCH v2 00/13] clk/watchdog/ARM: Cleanup of various S3C bits Krzysztof Kozlowski
2020-08-04 19:26 ` Krzysztof Kozlowski
2020-08-04 19:26 ` [PATCH v2 01/13] clk: samsung: s3c64xx: declare s3c64xx_clk_init() in shared header Krzysztof Kozlowski
2020-08-04 19:26 ` Krzysztof Kozlowski
2020-08-05 1:22 ` Chanwoo Choi
2020-08-05 1:22 ` Chanwoo Choi
2020-08-12 7:57 ` Stephen Boyd
2020-08-12 7:57 ` Stephen Boyd
2020-08-04 19:26 ` [PATCH v2 02/13] clk: samsung: s3c24xx: declare s3c24xx_common_clk_init() " Krzysztof Kozlowski
2020-08-04 19:26 ` Krzysztof Kozlowski
2020-08-05 1:23 ` Chanwoo Choi
2020-08-05 1:23 ` Chanwoo Choi
2020-08-12 7:57 ` Stephen Boyd
2020-08-12 7:57 ` Stephen Boyd
2020-08-04 19:26 ` [PATCH v2 03/13] ARM: s3c64xx: include header to fix -Wmissing-prototypes Krzysztof Kozlowski
2020-08-04 19:26 ` Krzysztof Kozlowski
2020-08-12 7:58 ` Stephen Boyd
2020-08-12 7:58 ` Stephen Boyd
2020-08-04 19:26 ` [PATCH v2 04/13] ARM: s3c: remove plat-samsung/.../samsung-time.h Krzysztof Kozlowski
2020-08-04 19:26 ` Krzysztof Kozlowski
2020-08-04 19:26 ` [PATCH v2 05/13] ARM: samsung: fix language typo Krzysztof Kozlowski
2020-08-04 19:26 ` Krzysztof Kozlowski
2020-08-12 7:59 ` Stephen Boyd
2020-08-12 7:59 ` Stephen Boyd
2020-08-04 19:26 ` [PATCH v2 06/13] ARM: samsung: remove HAVE_S3C2410_WATCHDOG and use direct dependencies Krzysztof Kozlowski
2020-08-04 19:26 ` Krzysztof Kozlowski
2020-08-17 16:57 ` Krzysztof Kozlowski
2020-08-17 16:57 ` Krzysztof Kozlowski
2020-08-17 17:00 ` Tomasz Figa [this message]
2020-08-17 17:00 ` Tomasz Figa
2020-08-17 18:02 ` Guenter Roeck
2020-08-17 18:02 ` Guenter Roeck
2020-08-19 18:16 ` Krzysztof Kozlowski
2020-08-19 18:16 ` Krzysztof Kozlowski
2020-08-04 19:26 ` [PATCH v2 07/13] ARM: s3c64xx: switch to generic watchdog driver reset Krzysztof Kozlowski
2020-08-04 19:26 ` Krzysztof Kozlowski
2020-08-19 18:17 ` Krzysztof Kozlowski
2020-08-19 18:17 ` Krzysztof Kozlowski
2020-08-04 19:26 ` [PATCH v2 08/13] ARM: s3c24xx: fix missing system reset Krzysztof Kozlowski
2020-08-04 19:26 ` Krzysztof Kozlowski
2020-08-19 18:18 ` Krzysztof Kozlowski
2020-08-19 18:18 ` Krzysztof Kozlowski
2020-08-04 19:26 ` [PATCH v2 09/13] ARM: s3c24xx: include common.h header in s3c2443.c Krzysztof Kozlowski
2020-08-04 19:26 ` Krzysztof Kozlowski
2020-08-04 19:26 ` [PATCH v2 10/13] ARM: s3c24xx: sdhci: include plat/sdhci.h header Krzysztof Kozlowski
2020-08-04 19:26 ` Krzysztof Kozlowski
2020-08-04 19:26 ` [PATCH v2 11/13] ARM: s3c24xx: ts: include platform data header Krzysztof Kozlowski
2020-08-04 19:26 ` Krzysztof Kozlowski
2020-08-04 19:26 ` [PATCH v2 12/13] ARM: s3c24xx: ts: document function argument Krzysztof Kozlowski
2020-08-04 19:26 ` Krzysztof Kozlowski
2020-08-04 19:26 ` [PATCH v2 13/13] ARM: s3c24xx: camif: include header with prototypes and unify declaration Krzysztof Kozlowski
2020-08-04 19:26 ` Krzysztof Kozlowski
2020-08-12 7:59 ` Stephen Boyd
2020-08-12 7:59 ` Stephen Boyd
2020-08-12 9:14 ` Arnd Bergmann
2020-08-12 9:14 ` Arnd Bergmann
2020-08-12 10:46 ` Sylwester Nawrocki
2020-08-12 10:46 ` Sylwester Nawrocki
2020-08-12 11:28 ` Arnd Bergmann
2020-08-12 11:28 ` Arnd Bergmann
2020-08-12 13:11 ` Sylwester Nawrocki
2020-08-12 13:11 ` Sylwester Nawrocki
2020-08-12 13:31 ` Krzysztof Kozlowski
2020-08-12 13:31 ` Krzysztof Kozlowski
2020-08-12 15:58 ` Sylwester Nawrocki
2020-08-12 15:58 ` Sylwester Nawrocki
2020-08-12 17:13 ` Krzysztof Kozlowski
2020-08-12 17:13 ` Krzysztof Kozlowski
2020-08-12 18:49 ` Sylwester Nawrocki
2020-08-12 18:49 ` Sylwester Nawrocki
2020-08-27 20:52 ` Cedric Roux
2020-08-27 20:52 ` Cedric Roux
2020-09-06 15:41 ` Krzysztof Kozlowski
2020-09-06 15:41 ` Krzysztof Kozlowski
2020-08-05 8:18 ` [PATCH v2 00/13] clk/watchdog/ARM: Cleanup of various S3C bits Lihua Yao
2020-08-06 12:16 ` Krzysztof Kozlowski
2020-08-06 12:16 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+Ln22Hw8_FT0s2N0rBo=2XVmuLagj=BFrTkTGd10J7d4B1Jow@mail.gmail.com' \
--to=tomasz.figa@gmail.com \
--cc=alexandre.torgue@st.com \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=cw00.choi@samsung.com \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linux@roeck-us.net \
--cc=linux@simtec.co.uk \
--cc=m.szyprowski@samsung.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=mturquette@baylibre.com \
--cc=patches@opensource.cirrus.com \
--cc=s.nawrocki@samsung.com \
--cc=sboyd@kernel.org \
--cc=sed@free.fr \
--cc=sergio.prado@e-labworks.com \
--cc=snawrocki@kernel.org \
--cc=will@kernel.org \
--cc=wim@linux-watchdog.org \
--cc=ylhuajnu@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.