From: kernel test robot <lkp@intel.com>
To: Valentin Schneider <valentin.schneider@arm.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Cc: kbuild-all@lists.01.org, mingo@kernel.org, peterz@infradead.org,
vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
morten.rasmussen@arm.com, Quentin Perret <qperret@google.com>
Subject: Re: [PATCH v5 06/17] sched/debug: Output SD flag names rather than their values
Date: Thu, 13 Aug 2020 00:35:18 +0800 [thread overview]
Message-ID: <202008130025.XjiXqp1O%lkp@intel.com> (raw)
In-Reply-To: <20200812125300.11889-7-valentin.schneider@arm.com>
[-- Attachment #1: Type: text/plain, Size: 4469 bytes --]
Hi Valentin,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on tip/sched/core]
[also build test WARNING on tip/auto-latest linux/master linus/master v5.8 next-20200812]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Valentin-Schneider/sched-Instrument-sched-domain-flags/20200812-205638
base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 949bcb8135a96a6923e676646bd29cbe69e8350f
config: i386-randconfig-s001-20200811 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.2-168-g9554805c-dirty
# save the attached .config to linux build tree
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
kernel/sched/debug.c:327:9: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected struct sched_domain *[assigned] sd @@ got struct sched_domain [noderef] __rcu *parent @@
kernel/sched/debug.c:327:9: sparse: expected struct sched_domain *[assigned] sd
kernel/sched/debug.c:327:9: sparse: got struct sched_domain [noderef] __rcu *parent
kernel/sched/debug.c:334:9: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected struct sched_domain *[assigned] sd @@ got struct sched_domain [noderef] __rcu *parent @@
kernel/sched/debug.c:334:9: sparse: expected struct sched_domain *[assigned] sd
kernel/sched/debug.c:334:9: sparse: got struct sched_domain [noderef] __rcu *parent
kernel/sched/debug.c:486:22: sparse: sparse: incompatible types in comparison expression (different address spaces):
kernel/sched/debug.c:486:22: sparse: struct task_struct [noderef] __rcu *
kernel/sched/debug.c:486:22: sparse: struct task_struct *
kernel/sched/debug.c:694:9: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct task_struct *tsk @@ got struct task_struct [noderef] __rcu *curr @@
kernel/sched/debug.c:694:9: sparse: expected struct task_struct *tsk
kernel/sched/debug.c:694:9: sparse: got struct task_struct [noderef] __rcu *curr
kernel/sched/debug.c:694:9: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct task_struct *tsk @@ got struct task_struct [noderef] __rcu *curr @@
kernel/sched/debug.c:694:9: sparse: expected struct task_struct *tsk
kernel/sched/debug.c:694:9: sparse: got struct task_struct [noderef] __rcu *curr
>> kernel/sched/debug.c:279:17: sparse: sparse: non size-preserving pointer to integer cast
>> kernel/sched/debug.c:279:17: sparse: sparse: non size-preserving integer to pointer cast
vim +279 kernel/sched/debug.c
247
248 static int sd_ctl_doflags(struct ctl_table *table, int write,
249 void *buffer, size_t *lenp, loff_t *ppos)
250 {
251 unsigned long flags = *(unsigned long *)table->data;
252 size_t data_size = 0;
253 size_t len = 0;
254 char *tmp;
255 int idx;
256
257 if (write)
258 return 0;
259
260 for_each_set_bit(idx, &flags, __SD_FLAG_CNT) {
261 char *name = sd_flag_debug[idx].name;
262
263 /* Name plus whitespace */
264 data_size += strlen(name) + 1;
265 }
266
267 if (*ppos > data_size) {
268 *lenp = 0;
269 return 0;
270 }
271
272 tmp = kcalloc(data_size + 1, sizeof(tmp), GFP_KERNEL);
273 for_each_set_bit(idx, &flags, __SD_FLAG_CNT) {
274 char *name = sd_flag_debug[idx].name;
275
276 len += snprintf(tmp + len, strlen(name) + 2, "%s ", name);
277 }
278
> 279 tmp += *ppos;
280 len -= *ppos;
281
282 if (len > *lenp)
283 len = *lenp;
284 if (len)
285 memcpy(buffer, tmp, len);
286 if (len < *lenp) {
287 ((char *)buffer)[len] = '\n';
288 len++;
289 }
290
291 *lenp = len;
292 *ppos += len;
293
294 kfree(tmp);
295
296 return 0;
297 }
298
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 35386 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: Valentin Schneider <valentin.schneider@arm.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Cc: vincent.guittot@linaro.org, Quentin Perret <qperret@google.com>,
peterz@infradead.org, morten.rasmussen@arm.com,
kbuild-all@lists.01.org, mingo@kernel.org,
dietmar.eggemann@arm.com
Subject: Re: [PATCH v5 06/17] sched/debug: Output SD flag names rather than their values
Date: Thu, 13 Aug 2020 00:35:18 +0800 [thread overview]
Message-ID: <202008130025.XjiXqp1O%lkp@intel.com> (raw)
In-Reply-To: <20200812125300.11889-7-valentin.schneider@arm.com>
[-- Attachment #1: Type: text/plain, Size: 4469 bytes --]
Hi Valentin,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on tip/sched/core]
[also build test WARNING on tip/auto-latest linux/master linus/master v5.8 next-20200812]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Valentin-Schneider/sched-Instrument-sched-domain-flags/20200812-205638
base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 949bcb8135a96a6923e676646bd29cbe69e8350f
config: i386-randconfig-s001-20200811 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.2-168-g9554805c-dirty
# save the attached .config to linux build tree
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
kernel/sched/debug.c:327:9: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected struct sched_domain *[assigned] sd @@ got struct sched_domain [noderef] __rcu *parent @@
kernel/sched/debug.c:327:9: sparse: expected struct sched_domain *[assigned] sd
kernel/sched/debug.c:327:9: sparse: got struct sched_domain [noderef] __rcu *parent
kernel/sched/debug.c:334:9: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected struct sched_domain *[assigned] sd @@ got struct sched_domain [noderef] __rcu *parent @@
kernel/sched/debug.c:334:9: sparse: expected struct sched_domain *[assigned] sd
kernel/sched/debug.c:334:9: sparse: got struct sched_domain [noderef] __rcu *parent
kernel/sched/debug.c:486:22: sparse: sparse: incompatible types in comparison expression (different address spaces):
kernel/sched/debug.c:486:22: sparse: struct task_struct [noderef] __rcu *
kernel/sched/debug.c:486:22: sparse: struct task_struct *
kernel/sched/debug.c:694:9: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct task_struct *tsk @@ got struct task_struct [noderef] __rcu *curr @@
kernel/sched/debug.c:694:9: sparse: expected struct task_struct *tsk
kernel/sched/debug.c:694:9: sparse: got struct task_struct [noderef] __rcu *curr
kernel/sched/debug.c:694:9: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct task_struct *tsk @@ got struct task_struct [noderef] __rcu *curr @@
kernel/sched/debug.c:694:9: sparse: expected struct task_struct *tsk
kernel/sched/debug.c:694:9: sparse: got struct task_struct [noderef] __rcu *curr
>> kernel/sched/debug.c:279:17: sparse: sparse: non size-preserving pointer to integer cast
>> kernel/sched/debug.c:279:17: sparse: sparse: non size-preserving integer to pointer cast
vim +279 kernel/sched/debug.c
247
248 static int sd_ctl_doflags(struct ctl_table *table, int write,
249 void *buffer, size_t *lenp, loff_t *ppos)
250 {
251 unsigned long flags = *(unsigned long *)table->data;
252 size_t data_size = 0;
253 size_t len = 0;
254 char *tmp;
255 int idx;
256
257 if (write)
258 return 0;
259
260 for_each_set_bit(idx, &flags, __SD_FLAG_CNT) {
261 char *name = sd_flag_debug[idx].name;
262
263 /* Name plus whitespace */
264 data_size += strlen(name) + 1;
265 }
266
267 if (*ppos > data_size) {
268 *lenp = 0;
269 return 0;
270 }
271
272 tmp = kcalloc(data_size + 1, sizeof(tmp), GFP_KERNEL);
273 for_each_set_bit(idx, &flags, __SD_FLAG_CNT) {
274 char *name = sd_flag_debug[idx].name;
275
276 len += snprintf(tmp + len, strlen(name) + 2, "%s ", name);
277 }
278
> 279 tmp += *ppos;
280 len -= *ppos;
281
282 if (len > *lenp)
283 len = *lenp;
284 if (len)
285 memcpy(buffer, tmp, len);
286 if (len < *lenp) {
287 ((char *)buffer)[len] = '\n';
288 len++;
289 }
290
291 *lenp = len;
292 *ppos += len;
293
294 kfree(tmp);
295
296 return 0;
297 }
298
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 35386 bytes --]
[-- Attachment #3: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v5 06/17] sched/debug: Output SD flag names rather than their values
Date: Thu, 13 Aug 2020 00:35:18 +0800 [thread overview]
Message-ID: <202008130025.XjiXqp1O%lkp@intel.com> (raw)
In-Reply-To: <20200812125300.11889-7-valentin.schneider@arm.com>
[-- Attachment #1: Type: text/plain, Size: 4571 bytes --]
Hi Valentin,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on tip/sched/core]
[also build test WARNING on tip/auto-latest linux/master linus/master v5.8 next-20200812]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Valentin-Schneider/sched-Instrument-sched-domain-flags/20200812-205638
base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 949bcb8135a96a6923e676646bd29cbe69e8350f
config: i386-randconfig-s001-20200811 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.2-168-g9554805c-dirty
# save the attached .config to linux build tree
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
kernel/sched/debug.c:327:9: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected struct sched_domain *[assigned] sd @@ got struct sched_domain [noderef] __rcu *parent @@
kernel/sched/debug.c:327:9: sparse: expected struct sched_domain *[assigned] sd
kernel/sched/debug.c:327:9: sparse: got struct sched_domain [noderef] __rcu *parent
kernel/sched/debug.c:334:9: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected struct sched_domain *[assigned] sd @@ got struct sched_domain [noderef] __rcu *parent @@
kernel/sched/debug.c:334:9: sparse: expected struct sched_domain *[assigned] sd
kernel/sched/debug.c:334:9: sparse: got struct sched_domain [noderef] __rcu *parent
kernel/sched/debug.c:486:22: sparse: sparse: incompatible types in comparison expression (different address spaces):
kernel/sched/debug.c:486:22: sparse: struct task_struct [noderef] __rcu *
kernel/sched/debug.c:486:22: sparse: struct task_struct *
kernel/sched/debug.c:694:9: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct task_struct *tsk @@ got struct task_struct [noderef] __rcu *curr @@
kernel/sched/debug.c:694:9: sparse: expected struct task_struct *tsk
kernel/sched/debug.c:694:9: sparse: got struct task_struct [noderef] __rcu *curr
kernel/sched/debug.c:694:9: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct task_struct *tsk @@ got struct task_struct [noderef] __rcu *curr @@
kernel/sched/debug.c:694:9: sparse: expected struct task_struct *tsk
kernel/sched/debug.c:694:9: sparse: got struct task_struct [noderef] __rcu *curr
>> kernel/sched/debug.c:279:17: sparse: sparse: non size-preserving pointer to integer cast
>> kernel/sched/debug.c:279:17: sparse: sparse: non size-preserving integer to pointer cast
vim +279 kernel/sched/debug.c
247
248 static int sd_ctl_doflags(struct ctl_table *table, int write,
249 void *buffer, size_t *lenp, loff_t *ppos)
250 {
251 unsigned long flags = *(unsigned long *)table->data;
252 size_t data_size = 0;
253 size_t len = 0;
254 char *tmp;
255 int idx;
256
257 if (write)
258 return 0;
259
260 for_each_set_bit(idx, &flags, __SD_FLAG_CNT) {
261 char *name = sd_flag_debug[idx].name;
262
263 /* Name plus whitespace */
264 data_size += strlen(name) + 1;
265 }
266
267 if (*ppos > data_size) {
268 *lenp = 0;
269 return 0;
270 }
271
272 tmp = kcalloc(data_size + 1, sizeof(tmp), GFP_KERNEL);
273 for_each_set_bit(idx, &flags, __SD_FLAG_CNT) {
274 char *name = sd_flag_debug[idx].name;
275
276 len += snprintf(tmp + len, strlen(name) + 2, "%s ", name);
277 }
278
> 279 tmp += *ppos;
280 len -= *ppos;
281
282 if (len > *lenp)
283 len = *lenp;
284 if (len)
285 memcpy(buffer, tmp, len);
286 if (len < *lenp) {
287 ((char *)buffer)[len] = '\n';
288 len++;
289 }
290
291 *lenp = len;
292 *ppos += len;
293
294 kfree(tmp);
295
296 return 0;
297 }
298
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 35386 bytes --]
next prev parent reply other threads:[~2020-08-12 17:06 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-12 12:52 [PATCH v5 00/17] sched: Instrument sched domain flags Valentin Schneider
2020-08-12 12:52 ` Valentin Schneider
2020-08-12 12:52 ` [PATCH v5 01/17] ARM, sched/topology: Remove SD_SHARE_POWERDOMAIN Valentin Schneider
2020-08-12 12:52 ` Valentin Schneider
2020-08-12 12:52 ` [PATCH v5 02/17] ARM: Revert back to default scheduler topology Valentin Schneider
2020-08-12 12:52 ` Valentin Schneider
2020-08-13 19:16 ` Ingo Molnar
2020-08-13 19:16 ` Ingo Molnar
2020-08-13 22:27 ` Valentin Schneider
2020-08-13 22:27 ` Valentin Schneider
2020-08-12 12:52 ` [PATCH v5 03/17] sched/topology: Split out SD_* flags declaration to its own file Valentin Schneider
2020-08-12 12:52 ` Valentin Schneider
2020-08-12 12:52 ` [PATCH v5 04/17] sched/topology: Define and assign sched_domain flag metadata Valentin Schneider
2020-08-12 12:52 ` Valentin Schneider
2020-08-12 12:52 ` [PATCH v5 05/17] sched/topology: Verify SD_* flags setup when sched_debug is on Valentin Schneider
2020-08-12 12:52 ` Valentin Schneider
2020-08-12 12:52 ` [PATCH v5 06/17] sched/debug: Output SD flag names rather than their values Valentin Schneider
2020-08-12 12:52 ` Valentin Schneider
2020-08-12 16:35 ` kernel test robot [this message]
2020-08-12 16:35 ` kernel test robot
2020-08-12 16:35 ` kernel test robot
2020-08-12 18:51 ` Valentin Schneider
2020-08-12 18:51 ` Valentin Schneider
2020-08-12 18:51 ` Valentin Schneider
2020-08-13 12:02 ` Luc Van Oostenryck
2020-08-13 12:02 ` Luc Van Oostenryck
2020-08-13 12:02 ` Luc Van Oostenryck
2020-08-13 13:13 ` Valentin Schneider
2020-08-13 13:13 ` Valentin Schneider
2020-08-13 13:13 ` Valentin Schneider
2020-08-12 17:59 ` kernel test robot
2020-08-12 17:59 ` kernel test robot
2020-08-12 17:59 ` kernel test robot
2020-08-12 17:59 ` [PATCH] sched/debug: fix noderef.cocci warnings kernel test robot
2020-08-12 17:59 ` kernel test robot
2020-08-12 17:59 ` kernel test robot
2020-08-12 18:52 ` Valentin Schneider
2020-08-12 18:52 ` Valentin Schneider
2020-08-12 18:52 ` Valentin Schneider
2020-08-12 12:52 ` [PATCH v5 07/17] sched/topology: Introduce SD metaflag for flags needing > 1 groups Valentin Schneider
2020-08-12 12:52 ` Valentin Schneider
2020-08-12 12:52 ` [PATCH v5 08/17] sched/topology: Use prebuilt SD flag degeneration mask Valentin Schneider
2020-08-12 12:52 ` Valentin Schneider
2020-08-12 12:52 ` [PATCH v5 09/17] sched/topology: Remove SD_SERIALIZE degeneration special case Valentin Schneider
2020-08-12 12:52 ` Valentin Schneider
2020-08-12 12:52 ` [PATCH v5 10/17] sched/topology: Propagate SD_ASYM_CPUCAPACITY upwards Valentin Schneider
2020-08-12 12:52 ` Valentin Schneider
2020-08-12 12:52 ` [PATCH v5 11/17] sched/topology: Mark SD_PREFER_SIBLING as SDF_NEEDS_GROUPS Valentin Schneider
2020-08-12 12:52 ` Valentin Schneider
2020-08-12 12:52 ` [PATCH v5 12/17] sched/topology: Mark SD_BALANCE_WAKE " Valentin Schneider
2020-08-12 12:52 ` Valentin Schneider
2020-08-12 12:52 ` [PATCH v5 13/17] sched/topology: Mark SD_SERIALIZE " Valentin Schneider
2020-08-12 12:52 ` Valentin Schneider
2020-08-12 12:52 ` [PATCH v5 14/17] sched/topology: Mark SD_ASYM_PACKING " Valentin Schneider
2020-08-12 12:52 ` Valentin Schneider
2020-08-12 12:52 ` [PATCH v5 15/17] sched/topology: Mark SD_OVERLAP " Valentin Schneider
2020-08-12 12:52 ` Valentin Schneider
2020-08-12 12:52 ` [PATCH v5 16/17] sched/topology: Mark SD_NUMA " Valentin Schneider
2020-08-12 12:52 ` Valentin Schneider
2020-08-12 12:53 ` [PATCH v5 17/17] sched/topology: Expand use of SD_DEGENERATE_GROUPS_MASK to flags not needing groups Valentin Schneider
2020-08-12 12:53 ` Valentin Schneider
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202008130025.XjiXqp1O%lkp@intel.com \
--to=lkp@intel.com \
--cc=dietmar.eggemann@arm.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=morten.rasmussen@arm.com \
--cc=peterz@infradead.org \
--cc=qperret@google.com \
--cc=valentin.schneider@arm.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.