From: Valentin Schneider <valentin.schneider@arm.com>
To: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Cc: kernel test robot <lkp@intel.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, kbuild-all@lists.01.org,
mingo@kernel.org, peterz@infradead.org,
vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
morten.rasmussen@arm.com, Quentin Perret <qperret@google.com>
Subject: Re: [PATCH v5 06/17] sched/debug: Output SD flag names rather than their values
Date: Thu, 13 Aug 2020 14:13:10 +0100 [thread overview]
Message-ID: <2507c6d6-eb66-504e-aba6-1333ce064da8@arm.com> (raw)
In-Reply-To: <20200813120249.vdadn3nutkx3mq7y@ltop.local>
On 13/08/2020 13:02, Luc Van Oostenryck wrote:
> On Wed, Aug 12, 2020 at 07:51:08PM +0100, Valentin Schneider wrote:
>> On 12/08/20 17:35, kernel test robot wrote:
>>
>>> config: i386-randconfig-s001-20200811 (attached as .config)
>>> reproduce:
>>> # sparse version: v0.6.2-168-g9554805c-dirty
>>> make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386
>>>
>>>>> kernel/sched/debug.c:279:17: sparse: sparse: non size-preserving pointer to integer cast
>>>>> kernel/sched/debug.c:279:17: sparse: sparse: non size-preserving integer to pointer cast
>>>
>>> > 279 tmp += *ppos;
>>
>> I pretty much copied kernel/sysctl.c::_proc_do_string() and I think that's
>> exactly the same types here: char* buffer incremented by loff_t offset. It
>> does look fine to me, but I can't really parse that warning.
>
> The warnings mean that there is a cast from a pointer to an integer with
> a size other than the size of a pointer and the other way around.
>
> I's indeed the case here, on i386, where pointers are 32-bit and loff_t
> is 64-bit. But yes, I agree:
> 1) these messages are far from clear
> 2) these casts are internal and are probably not appropriate here.
>
> I'll look later what can be done at sparse level.
>
Thanks!
> Regards,
> -- Luc
>
WARNING: multiple messages have this Message-ID (diff)
From: Valentin Schneider <valentin.schneider@arm.com>
To: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Cc: morten.rasmussen@arm.com, kbuild-all@lists.01.org,
kernel test robot <lkp@intel.com>,
Quentin Perret <qperret@google.com>,
peterz@infradead.org, linux-kernel@vger.kernel.org,
dietmar.eggemann@arm.com, vincent.guittot@linaro.org,
mingo@kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 06/17] sched/debug: Output SD flag names rather than their values
Date: Thu, 13 Aug 2020 14:13:10 +0100 [thread overview]
Message-ID: <2507c6d6-eb66-504e-aba6-1333ce064da8@arm.com> (raw)
In-Reply-To: <20200813120249.vdadn3nutkx3mq7y@ltop.local>
On 13/08/2020 13:02, Luc Van Oostenryck wrote:
> On Wed, Aug 12, 2020 at 07:51:08PM +0100, Valentin Schneider wrote:
>> On 12/08/20 17:35, kernel test robot wrote:
>>
>>> config: i386-randconfig-s001-20200811 (attached as .config)
>>> reproduce:
>>> # sparse version: v0.6.2-168-g9554805c-dirty
>>> make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386
>>>
>>>>> kernel/sched/debug.c:279:17: sparse: sparse: non size-preserving pointer to integer cast
>>>>> kernel/sched/debug.c:279:17: sparse: sparse: non size-preserving integer to pointer cast
>>>
>>> > 279 tmp += *ppos;
>>
>> I pretty much copied kernel/sysctl.c::_proc_do_string() and I think that's
>> exactly the same types here: char* buffer incremented by loff_t offset. It
>> does look fine to me, but I can't really parse that warning.
>
> The warnings mean that there is a cast from a pointer to an integer with
> a size other than the size of a pointer and the other way around.
>
> I's indeed the case here, on i386, where pointers are 32-bit and loff_t
> is 64-bit. But yes, I agree:
> 1) these messages are far from clear
> 2) these casts are internal and are probably not appropriate here.
>
> I'll look later what can be done at sparse level.
>
Thanks!
> Regards,
> -- Luc
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Valentin Schneider <valentin.schneider@arm.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v5 06/17] sched/debug: Output SD flag names rather than their values
Date: Thu, 13 Aug 2020 14:13:10 +0100 [thread overview]
Message-ID: <2507c6d6-eb66-504e-aba6-1333ce064da8@arm.com> (raw)
In-Reply-To: <20200813120249.vdadn3nutkx3mq7y@ltop.local>
[-- Attachment #1: Type: text/plain, Size: 1314 bytes --]
On 13/08/2020 13:02, Luc Van Oostenryck wrote:
> On Wed, Aug 12, 2020 at 07:51:08PM +0100, Valentin Schneider wrote:
>> On 12/08/20 17:35, kernel test robot wrote:
>>
>>> config: i386-randconfig-s001-20200811 (attached as .config)
>>> reproduce:
>>> # sparse version: v0.6.2-168-g9554805c-dirty
>>> make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386
>>>
>>>>> kernel/sched/debug.c:279:17: sparse: sparse: non size-preserving pointer to integer cast
>>>>> kernel/sched/debug.c:279:17: sparse: sparse: non size-preserving integer to pointer cast
>>>
>>> > 279 tmp += *ppos;
>>
>> I pretty much copied kernel/sysctl.c::_proc_do_string() and I think that's
>> exactly the same types here: char* buffer incremented by loff_t offset. It
>> does look fine to me, but I can't really parse that warning.
>
> The warnings mean that there is a cast from a pointer to an integer with
> a size other than the size of a pointer and the other way around.
>
> I's indeed the case here, on i386, where pointers are 32-bit and loff_t
> is 64-bit. But yes, I agree:
> 1) these messages are far from clear
> 2) these casts are internal and are probably not appropriate here.
>
> I'll look later what can be done at sparse level.
>
Thanks!
> Regards,
> -- Luc
>
next prev parent reply other threads:[~2020-08-13 13:14 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-12 12:52 [PATCH v5 00/17] sched: Instrument sched domain flags Valentin Schneider
2020-08-12 12:52 ` Valentin Schneider
2020-08-12 12:52 ` [PATCH v5 01/17] ARM, sched/topology: Remove SD_SHARE_POWERDOMAIN Valentin Schneider
2020-08-12 12:52 ` Valentin Schneider
2020-08-12 12:52 ` [PATCH v5 02/17] ARM: Revert back to default scheduler topology Valentin Schneider
2020-08-12 12:52 ` Valentin Schneider
2020-08-13 19:16 ` Ingo Molnar
2020-08-13 19:16 ` Ingo Molnar
2020-08-13 22:27 ` Valentin Schneider
2020-08-13 22:27 ` Valentin Schneider
2020-08-12 12:52 ` [PATCH v5 03/17] sched/topology: Split out SD_* flags declaration to its own file Valentin Schneider
2020-08-12 12:52 ` Valentin Schneider
2020-08-12 12:52 ` [PATCH v5 04/17] sched/topology: Define and assign sched_domain flag metadata Valentin Schneider
2020-08-12 12:52 ` Valentin Schneider
2020-08-12 12:52 ` [PATCH v5 05/17] sched/topology: Verify SD_* flags setup when sched_debug is on Valentin Schneider
2020-08-12 12:52 ` Valentin Schneider
2020-08-12 12:52 ` [PATCH v5 06/17] sched/debug: Output SD flag names rather than their values Valentin Schneider
2020-08-12 12:52 ` Valentin Schneider
2020-08-12 16:35 ` kernel test robot
2020-08-12 16:35 ` kernel test robot
2020-08-12 16:35 ` kernel test robot
2020-08-12 18:51 ` Valentin Schneider
2020-08-12 18:51 ` Valentin Schneider
2020-08-12 18:51 ` Valentin Schneider
2020-08-13 12:02 ` Luc Van Oostenryck
2020-08-13 12:02 ` Luc Van Oostenryck
2020-08-13 12:02 ` Luc Van Oostenryck
2020-08-13 13:13 ` Valentin Schneider [this message]
2020-08-13 13:13 ` Valentin Schneider
2020-08-13 13:13 ` Valentin Schneider
2020-08-12 17:59 ` kernel test robot
2020-08-12 17:59 ` kernel test robot
2020-08-12 17:59 ` kernel test robot
2020-08-12 17:59 ` [PATCH] sched/debug: fix noderef.cocci warnings kernel test robot
2020-08-12 17:59 ` kernel test robot
2020-08-12 17:59 ` kernel test robot
2020-08-12 18:52 ` Valentin Schneider
2020-08-12 18:52 ` Valentin Schneider
2020-08-12 18:52 ` Valentin Schneider
2020-08-12 12:52 ` [PATCH v5 07/17] sched/topology: Introduce SD metaflag for flags needing > 1 groups Valentin Schneider
2020-08-12 12:52 ` Valentin Schneider
2020-08-12 12:52 ` [PATCH v5 08/17] sched/topology: Use prebuilt SD flag degeneration mask Valentin Schneider
2020-08-12 12:52 ` Valentin Schneider
2020-08-12 12:52 ` [PATCH v5 09/17] sched/topology: Remove SD_SERIALIZE degeneration special case Valentin Schneider
2020-08-12 12:52 ` Valentin Schneider
2020-08-12 12:52 ` [PATCH v5 10/17] sched/topology: Propagate SD_ASYM_CPUCAPACITY upwards Valentin Schneider
2020-08-12 12:52 ` Valentin Schneider
2020-08-12 12:52 ` [PATCH v5 11/17] sched/topology: Mark SD_PREFER_SIBLING as SDF_NEEDS_GROUPS Valentin Schneider
2020-08-12 12:52 ` Valentin Schneider
2020-08-12 12:52 ` [PATCH v5 12/17] sched/topology: Mark SD_BALANCE_WAKE " Valentin Schneider
2020-08-12 12:52 ` Valentin Schneider
2020-08-12 12:52 ` [PATCH v5 13/17] sched/topology: Mark SD_SERIALIZE " Valentin Schneider
2020-08-12 12:52 ` Valentin Schneider
2020-08-12 12:52 ` [PATCH v5 14/17] sched/topology: Mark SD_ASYM_PACKING " Valentin Schneider
2020-08-12 12:52 ` Valentin Schneider
2020-08-12 12:52 ` [PATCH v5 15/17] sched/topology: Mark SD_OVERLAP " Valentin Schneider
2020-08-12 12:52 ` Valentin Schneider
2020-08-12 12:52 ` [PATCH v5 16/17] sched/topology: Mark SD_NUMA " Valentin Schneider
2020-08-12 12:52 ` Valentin Schneider
2020-08-12 12:53 ` [PATCH v5 17/17] sched/topology: Expand use of SD_DEGENERATE_GROUPS_MASK to flags not needing groups Valentin Schneider
2020-08-12 12:53 ` Valentin Schneider
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2507c6d6-eb66-504e-aba6-1333ce064da8@arm.com \
--to=valentin.schneider@arm.com \
--cc=dietmar.eggemann@arm.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=luc.vanoostenryck@gmail.com \
--cc=mingo@kernel.org \
--cc=morten.rasmussen@arm.com \
--cc=peterz@infradead.org \
--cc=qperret@google.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.