All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Valentin Schneider <valentin.schneider@arm.com>
Cc: linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Russell King <linux@armlinux.org.uk>,
	Dietmar Eggemann <dietmar.eggemann@arm.com>,
	peterz@infradead.org, vincent.guittot@linaro.org,
	morten.rasmussen@arm.com, Quentin Perret <qperret@google.com>
Subject: Re: [PATCH v5 02/17] ARM: Revert back to default scheduler topology.
Date: Thu, 13 Aug 2020 21:16:14 +0200	[thread overview]
Message-ID: <20200813191614.GB2337490@gmail.com> (raw)
In-Reply-To: <20200812125300.11889-3-valentin.schneider@arm.com>


* Valentin Schneider <valentin.schneider@arm.com> wrote:

> The ARM-specific GMC level is meant to be built using the thread sibling
> mask, but no devicetree in arch/arm/boot/dts uses the 'thread' cpu-map
> binding. With SD_SHARE_POWERDOMAIN gone, this topology level can be
> removed, at which point ARM no longer benefits from having a custom defined
> topology table.
> 
> Delete the GMC topology level by making ARM use the default scheduler
> topology table. This essentially reverts commit
> 
>   fb2aa85564f4 ("sched, ARM: Create a dedicated scheduler topology table")
> 
> Cc: Russell King <linux@armlinux.org.uk>
> Suggested-by: Dietmar Eggemann <dietmar.eggemann@arm.com>
> Reviewed-by: Dietmar Eggemann <dietmar.eggemann@arm.com>
> Signed-off-by: Valentin Schneider <valentin.schneider@arm.com>

Minor changelog nit, it's helpful to add this final sentence:

    No change in functionality is expected.

( If indeed no change in functionality is expected. ;-)

Thanks,

	Ingo

WARNING: multiple messages have this Message-ID (diff)
From: Ingo Molnar <mingo@kernel.org>
To: Valentin Schneider <valentin.schneider@arm.com>
Cc: morten.rasmussen@arm.com, vincent.guittot@linaro.org,
	Quentin Perret <qperret@google.com>,
	peterz@infradead.org, linux-kernel@vger.kernel.org,
	Russell King <linux@armlinux.org.uk>,
	Dietmar Eggemann <dietmar.eggemann@arm.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 02/17] ARM: Revert back to default scheduler topology.
Date: Thu, 13 Aug 2020 21:16:14 +0200	[thread overview]
Message-ID: <20200813191614.GB2337490@gmail.com> (raw)
In-Reply-To: <20200812125300.11889-3-valentin.schneider@arm.com>


* Valentin Schneider <valentin.schneider@arm.com> wrote:

> The ARM-specific GMC level is meant to be built using the thread sibling
> mask, but no devicetree in arch/arm/boot/dts uses the 'thread' cpu-map
> binding. With SD_SHARE_POWERDOMAIN gone, this topology level can be
> removed, at which point ARM no longer benefits from having a custom defined
> topology table.
> 
> Delete the GMC topology level by making ARM use the default scheduler
> topology table. This essentially reverts commit
> 
>   fb2aa85564f4 ("sched, ARM: Create a dedicated scheduler topology table")
> 
> Cc: Russell King <linux@armlinux.org.uk>
> Suggested-by: Dietmar Eggemann <dietmar.eggemann@arm.com>
> Reviewed-by: Dietmar Eggemann <dietmar.eggemann@arm.com>
> Signed-off-by: Valentin Schneider <valentin.schneider@arm.com>

Minor changelog nit, it's helpful to add this final sentence:

    No change in functionality is expected.

( If indeed no change in functionality is expected. ;-)

Thanks,

	Ingo

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-08-13 19:16 UTC|newest]

Thread overview: 61+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-12 12:52 [PATCH v5 00/17] sched: Instrument sched domain flags Valentin Schneider
2020-08-12 12:52 ` Valentin Schneider
2020-08-12 12:52 ` [PATCH v5 01/17] ARM, sched/topology: Remove SD_SHARE_POWERDOMAIN Valentin Schneider
2020-08-12 12:52   ` Valentin Schneider
2020-08-12 12:52 ` [PATCH v5 02/17] ARM: Revert back to default scheduler topology Valentin Schneider
2020-08-12 12:52   ` Valentin Schneider
2020-08-13 19:16   ` Ingo Molnar [this message]
2020-08-13 19:16     ` Ingo Molnar
2020-08-13 22:27     ` Valentin Schneider
2020-08-13 22:27       ` Valentin Schneider
2020-08-12 12:52 ` [PATCH v5 03/17] sched/topology: Split out SD_* flags declaration to its own file Valentin Schneider
2020-08-12 12:52   ` Valentin Schneider
2020-08-12 12:52 ` [PATCH v5 04/17] sched/topology: Define and assign sched_domain flag metadata Valentin Schneider
2020-08-12 12:52   ` Valentin Schneider
2020-08-12 12:52 ` [PATCH v5 05/17] sched/topology: Verify SD_* flags setup when sched_debug is on Valentin Schneider
2020-08-12 12:52   ` Valentin Schneider
2020-08-12 12:52 ` [PATCH v5 06/17] sched/debug: Output SD flag names rather than their values Valentin Schneider
2020-08-12 12:52   ` Valentin Schneider
2020-08-12 16:35   ` kernel test robot
2020-08-12 16:35     ` kernel test robot
2020-08-12 16:35     ` kernel test robot
2020-08-12 18:51     ` Valentin Schneider
2020-08-12 18:51       ` Valentin Schneider
2020-08-12 18:51       ` Valentin Schneider
2020-08-13 12:02       ` Luc Van Oostenryck
2020-08-13 12:02         ` Luc Van Oostenryck
2020-08-13 12:02         ` Luc Van Oostenryck
2020-08-13 13:13         ` Valentin Schneider
2020-08-13 13:13           ` Valentin Schneider
2020-08-13 13:13           ` Valentin Schneider
2020-08-12 17:59   ` kernel test robot
2020-08-12 17:59     ` kernel test robot
2020-08-12 17:59     ` kernel test robot
2020-08-12 17:59   ` [PATCH] sched/debug: fix noderef.cocci warnings kernel test robot
2020-08-12 17:59     ` kernel test robot
2020-08-12 17:59     ` kernel test robot
2020-08-12 18:52     ` Valentin Schneider
2020-08-12 18:52       ` Valentin Schneider
2020-08-12 18:52       ` Valentin Schneider
2020-08-12 12:52 ` [PATCH v5 07/17] sched/topology: Introduce SD metaflag for flags needing > 1 groups Valentin Schneider
2020-08-12 12:52   ` Valentin Schneider
2020-08-12 12:52 ` [PATCH v5 08/17] sched/topology: Use prebuilt SD flag degeneration mask Valentin Schneider
2020-08-12 12:52   ` Valentin Schneider
2020-08-12 12:52 ` [PATCH v5 09/17] sched/topology: Remove SD_SERIALIZE degeneration special case Valentin Schneider
2020-08-12 12:52   ` Valentin Schneider
2020-08-12 12:52 ` [PATCH v5 10/17] sched/topology: Propagate SD_ASYM_CPUCAPACITY upwards Valentin Schneider
2020-08-12 12:52   ` Valentin Schneider
2020-08-12 12:52 ` [PATCH v5 11/17] sched/topology: Mark SD_PREFER_SIBLING as SDF_NEEDS_GROUPS Valentin Schneider
2020-08-12 12:52   ` Valentin Schneider
2020-08-12 12:52 ` [PATCH v5 12/17] sched/topology: Mark SD_BALANCE_WAKE " Valentin Schneider
2020-08-12 12:52   ` Valentin Schneider
2020-08-12 12:52 ` [PATCH v5 13/17] sched/topology: Mark SD_SERIALIZE " Valentin Schneider
2020-08-12 12:52   ` Valentin Schneider
2020-08-12 12:52 ` [PATCH v5 14/17] sched/topology: Mark SD_ASYM_PACKING " Valentin Schneider
2020-08-12 12:52   ` Valentin Schneider
2020-08-12 12:52 ` [PATCH v5 15/17] sched/topology: Mark SD_OVERLAP " Valentin Schneider
2020-08-12 12:52   ` Valentin Schneider
2020-08-12 12:52 ` [PATCH v5 16/17] sched/topology: Mark SD_NUMA " Valentin Schneider
2020-08-12 12:52   ` Valentin Schneider
2020-08-12 12:53 ` [PATCH v5 17/17] sched/topology: Expand use of SD_DEGENERATE_GROUPS_MASK to flags not needing groups Valentin Schneider
2020-08-12 12:53   ` Valentin Schneider

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200813191614.GB2337490@gmail.com \
    --to=mingo@kernel.org \
    --cc=dietmar.eggemann@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=morten.rasmussen@arm.com \
    --cc=peterz@infradead.org \
    --cc=qperret@google.com \
    --cc=valentin.schneider@arm.com \
    --cc=vincent.guittot@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.