* [PATCH] i2c: busses: replace spin_lock_irqsave by spin_lock in hard IRQ
@ 2020-09-09 4:10 ` Barry Song
0 siblings, 0 replies; 14+ messages in thread
From: Barry Song @ 2020-09-09 4:10 UTC (permalink / raw)
To: linux-i2c, wsa, linux-arm-kernel
Cc: Barry Song, Gregory CLEMENT, linuxarm, Bjorn Andersson,
Akash Asthana, Andy Gross, Manivannan Sadhasivam,
Mukesh Savaliya, Andreas Färber
The code has been in a irq-disabled context since it is hard IRQ. There
is no necessity to do it again.
Cc: Gregory CLEMENT <gregory.clement@bootlin.com>
Cc: "Andreas Färber" <afaerber@suse.de>
Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: Akash Asthana <akashast@codeaurora.org>
Cc: Mukesh Savaliya <msavaliy@codeaurora.org>
Cc: Andy Gross <agross@kernel.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Barry Song <song.bao.hua@hisilicon.com>
---
drivers/i2c/busses/i2c-mv64xxx.c | 5 ++---
drivers/i2c/busses/i2c-owl.c | 5 ++---
drivers/i2c/busses/i2c-qcom-geni.c | 5 ++---
3 files changed, 6 insertions(+), 9 deletions(-)
diff --git a/drivers/i2c/busses/i2c-mv64xxx.c b/drivers/i2c/busses/i2c-mv64xxx.c
index 8d9d4ffdcd24..e0e45fc19b8f 100644
--- a/drivers/i2c/busses/i2c-mv64xxx.c
+++ b/drivers/i2c/busses/i2c-mv64xxx.c
@@ -496,11 +496,10 @@ static irqreturn_t
mv64xxx_i2c_intr(int irq, void *dev_id)
{
struct mv64xxx_i2c_data *drv_data = dev_id;
- unsigned long flags;
u32 status;
irqreturn_t rc = IRQ_NONE;
- spin_lock_irqsave(&drv_data->lock, flags);
+ spin_lock(&drv_data->lock);
if (drv_data->offload_enabled)
rc = mv64xxx_i2c_intr_offload(drv_data);
@@ -517,7 +516,7 @@ mv64xxx_i2c_intr(int irq, void *dev_id)
rc = IRQ_HANDLED;
}
- spin_unlock_irqrestore(&drv_data->lock, flags);
+ spin_unlock(&drv_data->lock);
return rc;
}
diff --git a/drivers/i2c/busses/i2c-owl.c b/drivers/i2c/busses/i2c-owl.c
index 672f1f239bd6..618d3013d0b6 100644
--- a/drivers/i2c/busses/i2c-owl.c
+++ b/drivers/i2c/busses/i2c-owl.c
@@ -165,10 +165,9 @@ static irqreturn_t owl_i2c_interrupt(int irq, void *_dev)
{
struct owl_i2c_dev *i2c_dev = _dev;
struct i2c_msg *msg = i2c_dev->msg;
- unsigned long flags;
unsigned int stat, fifostat;
- spin_lock_irqsave(&i2c_dev->lock, flags);
+ spin_lock(&i2c_dev->lock);
i2c_dev->err = 0;
@@ -208,7 +207,7 @@ static irqreturn_t owl_i2c_interrupt(int irq, void *_dev)
OWL_I2C_STAT_IRQP, true);
complete_all(&i2c_dev->msg_complete);
- spin_unlock_irqrestore(&i2c_dev->lock, flags);
+ spin_unlock(&i2c_dev->lock);
return IRQ_HANDLED;
}
diff --git a/drivers/i2c/busses/i2c-qcom-geni.c b/drivers/i2c/busses/i2c-qcom-geni.c
index dead5db3315a..8b4c35f47a70 100644
--- a/drivers/i2c/busses/i2c-qcom-geni.c
+++ b/drivers/i2c/busses/i2c-qcom-geni.c
@@ -210,9 +210,8 @@ static irqreturn_t geni_i2c_irq(int irq, void *dev)
u32 dma;
u32 val;
struct i2c_msg *cur;
- unsigned long flags;
- spin_lock_irqsave(&gi2c->lock, flags);
+ spin_lock(&gi2c->lock);
m_stat = readl_relaxed(base + SE_GENI_M_IRQ_STATUS);
rx_st = readl_relaxed(base + SE_GENI_RX_FIFO_STATUS);
dm_tx_st = readl_relaxed(base + SE_DMA_TX_IRQ_STAT);
@@ -294,7 +293,7 @@ static irqreturn_t geni_i2c_irq(int irq, void *dev)
dm_rx_st & RX_DMA_DONE || dm_rx_st & RX_RESET_DONE)
complete(&gi2c->done);
- spin_unlock_irqrestore(&gi2c->lock, flags);
+ spin_unlock(&gi2c->lock);
return IRQ_HANDLED;
}
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH] i2c: busses: replace spin_lock_irqsave by spin_lock in hard IRQ
2020-09-09 4:10 ` Barry Song
(?)
@ 2020-09-10 11:40 ` Akash Asthana
-1 siblings, 0 replies; 14+ messages in thread
From: Akash Asthana @ 2020-09-10 11:40 UTC (permalink / raw)
To: Barry Song, linux-i2c, wsa, linux-arm-kernel
Cc: Gregory CLEMENT, linuxarm, Bjorn Andersson, Andy Gross,
Manivannan Sadhasivam, Mukesh Savaliya, Andreas Färber
On 9/9/2020 9:40 AM, Barry Song wrote:
> The code has been in a irq-disabled context since it is hard IRQ. There
> is no necessity to do it again.
>
> Cc: Gregory CLEMENT <gregory.clement@bootlin.com>
> Cc: "Andreas Färber" <afaerber@suse.de>
> Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> Cc: Akash Asthana <akashast@codeaurora.org>
> Cc: Mukesh Savaliya <msavaliy@codeaurora.org>
> Cc: Andy Gross <agross@kernel.org>
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Signed-off-by: Barry Song <song.bao.hua@hisilicon.com>
> ---
Reviewed-by: Akash Asthana <akashast@codeaurora.org>
> drivers/i2c/busses/i2c-mv64xxx.c | 5 ++---
> drivers/i2c/busses/i2c-owl.c | 5 ++---
> drivers/i2c/busses/i2c-qcom-geni.c | 5 ++---
> 3 files changed, 6 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-mv64xxx.c b/drivers/i2c/busses/i2c-mv64xxx.c
> index 8d9d4ffdcd24..e0e45fc19b8f 100644
> --- a/drivers/i2c/busses/i2c-mv64xxx.c
> +++ b/drivers/i2c/busses/i2c-mv64xxx.c
> @@ -496,11 +496,10 @@ static irqreturn_t
> mv64xxx_i2c_intr(int irq, void *dev_id)
> {
> struct mv64xxx_i2c_data *drv_data = dev_id;
> - unsigned long flags;
> u32 status;
> irqreturn_t rc = IRQ_NONE;
>
> - spin_lock_irqsave(&drv_data->lock, flags);
> + spin_lock(&drv_data->lock);
>
> if (drv_data->offload_enabled)
> rc = mv64xxx_i2c_intr_offload(drv_data);
> @@ -517,7 +516,7 @@ mv64xxx_i2c_intr(int irq, void *dev_id)
>
> rc = IRQ_HANDLED;
> }
> - spin_unlock_irqrestore(&drv_data->lock, flags);
> + spin_unlock(&drv_data->lock);
>
> return rc;
> }
> diff --git a/drivers/i2c/busses/i2c-owl.c b/drivers/i2c/busses/i2c-owl.c
> index 672f1f239bd6..618d3013d0b6 100644
> --- a/drivers/i2c/busses/i2c-owl.c
> +++ b/drivers/i2c/busses/i2c-owl.c
> @@ -165,10 +165,9 @@ static irqreturn_t owl_i2c_interrupt(int irq, void *_dev)
> {
> struct owl_i2c_dev *i2c_dev = _dev;
> struct i2c_msg *msg = i2c_dev->msg;
> - unsigned long flags;
> unsigned int stat, fifostat;
>
> - spin_lock_irqsave(&i2c_dev->lock, flags);
> + spin_lock(&i2c_dev->lock);
>
> i2c_dev->err = 0;
>
> @@ -208,7 +207,7 @@ static irqreturn_t owl_i2c_interrupt(int irq, void *_dev)
> OWL_I2C_STAT_IRQP, true);
>
> complete_all(&i2c_dev->msg_complete);
> - spin_unlock_irqrestore(&i2c_dev->lock, flags);
> + spin_unlock(&i2c_dev->lock);
>
> return IRQ_HANDLED;
> }
> diff --git a/drivers/i2c/busses/i2c-qcom-geni.c b/drivers/i2c/busses/i2c-qcom-geni.c
> index dead5db3315a..8b4c35f47a70 100644
> --- a/drivers/i2c/busses/i2c-qcom-geni.c
> +++ b/drivers/i2c/busses/i2c-qcom-geni.c
> @@ -210,9 +210,8 @@ static irqreturn_t geni_i2c_irq(int irq, void *dev)
> u32 dma;
> u32 val;
> struct i2c_msg *cur;
> - unsigned long flags;
>
> - spin_lock_irqsave(&gi2c->lock, flags);
> + spin_lock(&gi2c->lock);
> m_stat = readl_relaxed(base + SE_GENI_M_IRQ_STATUS);
> rx_st = readl_relaxed(base + SE_GENI_RX_FIFO_STATUS);
> dm_tx_st = readl_relaxed(base + SE_DMA_TX_IRQ_STAT);
> @@ -294,7 +293,7 @@ static irqreturn_t geni_i2c_irq(int irq, void *dev)
> dm_rx_st & RX_DMA_DONE || dm_rx_st & RX_RESET_DONE)
> complete(&gi2c->done);
>
> - spin_unlock_irqrestore(&gi2c->lock, flags);
> + spin_unlock(&gi2c->lock);
>
> return IRQ_HANDLED;
> }
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,\na Linux Foundation Collaborative Project
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH] i2c: busses: replace spin_lock_irqsave by spin_lock in hard IRQ
2020-09-09 4:10 ` Barry Song
(?)
(?)
@ 2020-09-10 11:40 ` Akash Asthana
-1 siblings, 0 replies; 14+ messages in thread
From: Akash Asthana @ 2020-09-10 11:40 UTC (permalink / raw)
To: Barry Song, linux-i2c, wsa, linux-arm-kernel
Cc: linuxarm, Gregory CLEMENT, Andreas Färber,
Manivannan Sadhasivam, Mukesh Savaliya, Andy Gross,
Bjorn Andersson
On 9/9/2020 9:40 AM, Barry Song wrote:
> The code has been in a irq-disabled context since it is hard IRQ. There
> is no necessity to do it again.
>
> Cc: Gregory CLEMENT <gregory.clement@bootlin.com>
> Cc: "Andreas Färber" <afaerber@suse.de>
> Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> Cc: Akash Asthana <akashast@codeaurora.org>
> Cc: Mukesh Savaliya <msavaliy@codeaurora.org>
> Cc: Andy Gross <agross@kernel.org>
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Signed-off-by: Barry Song <song.bao.hua@hisilicon.com>
> ---
Reviewed-by: Akash Asthana <akashast@codeaurora.org>
> drivers/i2c/busses/i2c-mv64xxx.c | 5 ++---
> drivers/i2c/busses/i2c-owl.c | 5 ++---
> drivers/i2c/busses/i2c-qcom-geni.c | 5 ++---
> 3 files changed, 6 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-mv64xxx.c b/drivers/i2c/busses/i2c-mv64xxx.c
> index 8d9d4ffdcd24..e0e45fc19b8f 100644
> --- a/drivers/i2c/busses/i2c-mv64xxx.c
> +++ b/drivers/i2c/busses/i2c-mv64xxx.c
> @@ -496,11 +496,10 @@ static irqreturn_t
> mv64xxx_i2c_intr(int irq, void *dev_id)
> {
> struct mv64xxx_i2c_data *drv_data = dev_id;
> - unsigned long flags;
> u32 status;
> irqreturn_t rc = IRQ_NONE;
>
> - spin_lock_irqsave(&drv_data->lock, flags);
> + spin_lock(&drv_data->lock);
>
> if (drv_data->offload_enabled)
> rc = mv64xxx_i2c_intr_offload(drv_data);
> @@ -517,7 +516,7 @@ mv64xxx_i2c_intr(int irq, void *dev_id)
>
> rc = IRQ_HANDLED;
> }
> - spin_unlock_irqrestore(&drv_data->lock, flags);
> + spin_unlock(&drv_data->lock);
>
> return rc;
> }
> diff --git a/drivers/i2c/busses/i2c-owl.c b/drivers/i2c/busses/i2c-owl.c
> index 672f1f239bd6..618d3013d0b6 100644
> --- a/drivers/i2c/busses/i2c-owl.c
> +++ b/drivers/i2c/busses/i2c-owl.c
> @@ -165,10 +165,9 @@ static irqreturn_t owl_i2c_interrupt(int irq, void *_dev)
> {
> struct owl_i2c_dev *i2c_dev = _dev;
> struct i2c_msg *msg = i2c_dev->msg;
> - unsigned long flags;
> unsigned int stat, fifostat;
>
> - spin_lock_irqsave(&i2c_dev->lock, flags);
> + spin_lock(&i2c_dev->lock);
>
> i2c_dev->err = 0;
>
> @@ -208,7 +207,7 @@ static irqreturn_t owl_i2c_interrupt(int irq, void *_dev)
> OWL_I2C_STAT_IRQP, true);
>
> complete_all(&i2c_dev->msg_complete);
> - spin_unlock_irqrestore(&i2c_dev->lock, flags);
> + spin_unlock(&i2c_dev->lock);
>
> return IRQ_HANDLED;
> }
> diff --git a/drivers/i2c/busses/i2c-qcom-geni.c b/drivers/i2c/busses/i2c-qcom-geni.c
> index dead5db3315a..8b4c35f47a70 100644
> --- a/drivers/i2c/busses/i2c-qcom-geni.c
> +++ b/drivers/i2c/busses/i2c-qcom-geni.c
> @@ -210,9 +210,8 @@ static irqreturn_t geni_i2c_irq(int irq, void *dev)
> u32 dma;
> u32 val;
> struct i2c_msg *cur;
> - unsigned long flags;
>
> - spin_lock_irqsave(&gi2c->lock, flags);
> + spin_lock(&gi2c->lock);
> m_stat = readl_relaxed(base + SE_GENI_M_IRQ_STATUS);
> rx_st = readl_relaxed(base + SE_GENI_RX_FIFO_STATUS);
> dm_tx_st = readl_relaxed(base + SE_DMA_TX_IRQ_STAT);
> @@ -294,7 +293,7 @@ static irqreturn_t geni_i2c_irq(int irq, void *dev)
> dm_rx_st & RX_DMA_DONE || dm_rx_st & RX_RESET_DONE)
> complete(&gi2c->done);
>
> - spin_unlock_irqrestore(&gi2c->lock, flags);
> + spin_unlock(&gi2c->lock);
>
> return IRQ_HANDLED;
> }
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,\na Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH] i2c: busses: replace spin_lock_irqsave by spin_lock in hard IRQ
2020-09-09 4:10 ` Barry Song
` (2 preceding siblings ...)
(?)
@ 2020-09-10 18:18 ` Mukesh, Savaliya
-1 siblings, 0 replies; 14+ messages in thread
From: Mukesh, Savaliya @ 2020-09-10 18:18 UTC (permalink / raw)
To: Barry Song, linux-i2c, wsa, linux-arm-kernel
Cc: linuxarm, Gregory CLEMENT, Andreas Färber,
Manivannan Sadhasivam, Akash Asthana, Andy Gross,
Bjorn Andersson
On 9/9/2020 9:40 AM, Barry Song wrote:
> The code has been in a irq-disabled context since it is hard IRQ. There
> is no necessity to do it again.
>
> Cc: Gregory CLEMENT <gregory.clement@bootlin.com>
> Cc: "Andreas Färber" <afaerber@suse.de>
> Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> Cc: Akash Asthana <akashast@codeaurora.org>
> Cc: Mukesh Savaliya <msavaliy@codeaurora.org>
> Cc: Andy Gross <agross@kernel.org>
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Signed-off-by: Barry Song <song.bao.hua@hisilicon.com>
> ---
Reviewed-by: Mukesh Kumar Savaliya <msavaliy@codeaurora.org>
> drivers/i2c/busses/i2c-mv64xxx.c | 5 ++---
> drivers/i2c/busses/i2c-owl.c | 5 ++---
> drivers/i2c/busses/i2c-qcom-geni.c | 5 ++---
> 3 files changed, 6 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-mv64xxx.c b/drivers/i2c/busses/i2c-mv64xxx.c
> index 8d9d4ffdcd24..e0e45fc19b8f 100644
> --- a/drivers/i2c/busses/i2c-mv64xxx.c
> +++ b/drivers/i2c/busses/i2c-mv64xxx.c
> @@ -496,11 +496,10 @@ static irqreturn_t
> mv64xxx_i2c_intr(int irq, void *dev_id)
> {
> struct mv64xxx_i2c_data *drv_data = dev_id;
> - unsigned long flags;
> u32 status;
> irqreturn_t rc = IRQ_NONE;
>
> - spin_lock_irqsave(&drv_data->lock, flags);
> + spin_lock(&drv_data->lock);
>
> if (drv_data->offload_enabled)
> rc = mv64xxx_i2c_intr_offload(drv_data);
> @@ -517,7 +516,7 @@ mv64xxx_i2c_intr(int irq, void *dev_id)
>
> rc = IRQ_HANDLED;
> }
> - spin_unlock_irqrestore(&drv_data->lock, flags);
> + spin_unlock(&drv_data->lock);
>
> return rc;
> }
> diff --git a/drivers/i2c/busses/i2c-owl.c b/drivers/i2c/busses/i2c-owl.c
> index 672f1f239bd6..618d3013d0b6 100644
> --- a/drivers/i2c/busses/i2c-owl.c
> +++ b/drivers/i2c/busses/i2c-owl.c
> @@ -165,10 +165,9 @@ static irqreturn_t owl_i2c_interrupt(int irq, void *_dev)
> {
> struct owl_i2c_dev *i2c_dev = _dev;
> struct i2c_msg *msg = i2c_dev->msg;
> - unsigned long flags;
> unsigned int stat, fifostat;
>
> - spin_lock_irqsave(&i2c_dev->lock, flags);
> + spin_lock(&i2c_dev->lock);
>
> i2c_dev->err = 0;
>
> @@ -208,7 +207,7 @@ static irqreturn_t owl_i2c_interrupt(int irq, void *_dev)
> OWL_I2C_STAT_IRQP, true);
>
> complete_all(&i2c_dev->msg_complete);
> - spin_unlock_irqrestore(&i2c_dev->lock, flags);
> + spin_unlock(&i2c_dev->lock);
>
> return IRQ_HANDLED;
> }
> diff --git a/drivers/i2c/busses/i2c-qcom-geni.c b/drivers/i2c/busses/i2c-qcom-geni.c
> index dead5db3315a..8b4c35f47a70 100644
> --- a/drivers/i2c/busses/i2c-qcom-geni.c
> +++ b/drivers/i2c/busses/i2c-qcom-geni.c
> @@ -210,9 +210,8 @@ static irqreturn_t geni_i2c_irq(int irq, void *dev)
> u32 dma;
> u32 val;
> struct i2c_msg *cur;
> - unsigned long flags;
>
> - spin_lock_irqsave(&gi2c->lock, flags);
> + spin_lock(&gi2c->lock);
> m_stat = readl_relaxed(base + SE_GENI_M_IRQ_STATUS);
> rx_st = readl_relaxed(base + SE_GENI_RX_FIFO_STATUS);
> dm_tx_st = readl_relaxed(base + SE_DMA_TX_IRQ_STAT);
> @@ -294,7 +293,7 @@ static irqreturn_t geni_i2c_irq(int irq, void *dev)
> dm_rx_st & RX_DMA_DONE || dm_rx_st & RX_RESET_DONE)
> complete(&gi2c->done);
>
> - spin_unlock_irqrestore(&gi2c->lock, flags);
> + spin_unlock(&gi2c->lock);
>
> return IRQ_HANDLED;
> }
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH] i2c: busses: replace spin_lock_irqsave by spin_lock in hard IRQ
2020-09-09 4:10 ` Barry Song
` (3 preceding siblings ...)
(?)
@ 2020-09-10 18:18 ` Mukesh, Savaliya
-1 siblings, 0 replies; 14+ messages in thread
From: Mukesh, Savaliya @ 2020-09-10 18:18 UTC (permalink / raw)
To: Barry Song, linux-i2c, wsa, linux-arm-kernel
Cc: Gregory CLEMENT, linuxarm, Bjorn Andersson, Akash Asthana,
Andy Gross, Manivannan Sadhasivam, Andreas Färber
On 9/9/2020 9:40 AM, Barry Song wrote:
> The code has been in a irq-disabled context since it is hard IRQ. There
> is no necessity to do it again.
>
> Cc: Gregory CLEMENT <gregory.clement@bootlin.com>
> Cc: "Andreas Färber" <afaerber@suse.de>
> Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> Cc: Akash Asthana <akashast@codeaurora.org>
> Cc: Mukesh Savaliya <msavaliy@codeaurora.org>
> Cc: Andy Gross <agross@kernel.org>
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Signed-off-by: Barry Song <song.bao.hua@hisilicon.com>
> ---
Reviewed-by: Mukesh Kumar Savaliya <msavaliy@codeaurora.org>
> drivers/i2c/busses/i2c-mv64xxx.c | 5 ++---
> drivers/i2c/busses/i2c-owl.c | 5 ++---
> drivers/i2c/busses/i2c-qcom-geni.c | 5 ++---
> 3 files changed, 6 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-mv64xxx.c b/drivers/i2c/busses/i2c-mv64xxx.c
> index 8d9d4ffdcd24..e0e45fc19b8f 100644
> --- a/drivers/i2c/busses/i2c-mv64xxx.c
> +++ b/drivers/i2c/busses/i2c-mv64xxx.c
> @@ -496,11 +496,10 @@ static irqreturn_t
> mv64xxx_i2c_intr(int irq, void *dev_id)
> {
> struct mv64xxx_i2c_data *drv_data = dev_id;
> - unsigned long flags;
> u32 status;
> irqreturn_t rc = IRQ_NONE;
>
> - spin_lock_irqsave(&drv_data->lock, flags);
> + spin_lock(&drv_data->lock);
>
> if (drv_data->offload_enabled)
> rc = mv64xxx_i2c_intr_offload(drv_data);
> @@ -517,7 +516,7 @@ mv64xxx_i2c_intr(int irq, void *dev_id)
>
> rc = IRQ_HANDLED;
> }
> - spin_unlock_irqrestore(&drv_data->lock, flags);
> + spin_unlock(&drv_data->lock);
>
> return rc;
> }
> diff --git a/drivers/i2c/busses/i2c-owl.c b/drivers/i2c/busses/i2c-owl.c
> index 672f1f239bd6..618d3013d0b6 100644
> --- a/drivers/i2c/busses/i2c-owl.c
> +++ b/drivers/i2c/busses/i2c-owl.c
> @@ -165,10 +165,9 @@ static irqreturn_t owl_i2c_interrupt(int irq, void *_dev)
> {
> struct owl_i2c_dev *i2c_dev = _dev;
> struct i2c_msg *msg = i2c_dev->msg;
> - unsigned long flags;
> unsigned int stat, fifostat;
>
> - spin_lock_irqsave(&i2c_dev->lock, flags);
> + spin_lock(&i2c_dev->lock);
>
> i2c_dev->err = 0;
>
> @@ -208,7 +207,7 @@ static irqreturn_t owl_i2c_interrupt(int irq, void *_dev)
> OWL_I2C_STAT_IRQP, true);
>
> complete_all(&i2c_dev->msg_complete);
> - spin_unlock_irqrestore(&i2c_dev->lock, flags);
> + spin_unlock(&i2c_dev->lock);
>
> return IRQ_HANDLED;
> }
> diff --git a/drivers/i2c/busses/i2c-qcom-geni.c b/drivers/i2c/busses/i2c-qcom-geni.c
> index dead5db3315a..8b4c35f47a70 100644
> --- a/drivers/i2c/busses/i2c-qcom-geni.c
> +++ b/drivers/i2c/busses/i2c-qcom-geni.c
> @@ -210,9 +210,8 @@ static irqreturn_t geni_i2c_irq(int irq, void *dev)
> u32 dma;
> u32 val;
> struct i2c_msg *cur;
> - unsigned long flags;
>
> - spin_lock_irqsave(&gi2c->lock, flags);
> + spin_lock(&gi2c->lock);
> m_stat = readl_relaxed(base + SE_GENI_M_IRQ_STATUS);
> rx_st = readl_relaxed(base + SE_GENI_RX_FIFO_STATUS);
> dm_tx_st = readl_relaxed(base + SE_DMA_TX_IRQ_STAT);
> @@ -294,7 +293,7 @@ static irqreturn_t geni_i2c_irq(int irq, void *dev)
> dm_rx_st & RX_DMA_DONE || dm_rx_st & RX_RESET_DONE)
> complete(&gi2c->done);
>
> - spin_unlock_irqrestore(&gi2c->lock, flags);
> + spin_unlock(&gi2c->lock);
>
> return IRQ_HANDLED;
> }
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread[parent not found: <24424594-963c-c744-846f-cf79b6024b1c@codeaurora.org>]
* Re: [PATCH] i2c: busses: replace spin_lock_irqsave by spin_lock in hard IRQ
[not found] ` <24424594-963c-c744-846f-cf79b6024b1c@codeaurora.org>
@ 2020-09-21 9:34 ` Wolfram Sang
0 siblings, 0 replies; 14+ messages in thread
From: Wolfram Sang @ 2020-09-21 9:34 UTC (permalink / raw)
To: Akash Asthana
Cc: Barry Song, linux-i2c, linux-arm-kernel, linuxarm,
Gregory CLEMENT, Andreas Färber, Manivannan Sadhasivam,
Mukesh Savaliya, Andy Gross, Bjorn Andersson
[-- Attachment #1: Type: text/plain, Size: 871 bytes --]
On Thu, Sep 10, 2020 at 05:10:20PM +0530, Akash Asthana wrote:
>
> On 9/9/2020 9:40 AM, Barry Song wrote:
> > The code has been in a irq-disabled context since it is hard IRQ. There
> > is no necessity to do it again.
> >
> > Cc: Gregory CLEMENT <gregory.clement@bootlin.com>
> > Cc: "Andreas Färber" <afaerber@suse.de>
> > Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> > Cc: Akash Asthana <akashast@codeaurora.org>
> > Cc: Mukesh Savaliya <msavaliy@codeaurora.org>
> > Cc: Andy Gross <agross@kernel.org>
> > Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> > Signed-off-by: Barry Song <song.bao.hua@hisilicon.com>
> > ---
> Reviewed-by: Akash Asthana <akashast@codeaurora.org>
Thanks! Did you review the whole patch or only the qcom-geni part?
(and please don't include the full message when you only reply to a part
of it).
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH] i2c: busses: replace spin_lock_irqsave by spin_lock in hard IRQ
@ 2020-09-21 9:34 ` Wolfram Sang
0 siblings, 0 replies; 14+ messages in thread
From: Wolfram Sang @ 2020-09-21 9:34 UTC (permalink / raw)
To: Akash Asthana
Cc: Barry Song, Gregory CLEMENT, linuxarm, Bjorn Andersson,
Andy Gross, linux-i2c, Manivannan Sadhasivam, Mukesh Savaliya,
Andreas Färber, linux-arm-kernel
[-- Attachment #1.1: Type: text/plain, Size: 871 bytes --]
On Thu, Sep 10, 2020 at 05:10:20PM +0530, Akash Asthana wrote:
>
> On 9/9/2020 9:40 AM, Barry Song wrote:
> > The code has been in a irq-disabled context since it is hard IRQ. There
> > is no necessity to do it again.
> >
> > Cc: Gregory CLEMENT <gregory.clement@bootlin.com>
> > Cc: "Andreas Färber" <afaerber@suse.de>
> > Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> > Cc: Akash Asthana <akashast@codeaurora.org>
> > Cc: Mukesh Savaliya <msavaliy@codeaurora.org>
> > Cc: Andy Gross <agross@kernel.org>
> > Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> > Signed-off-by: Barry Song <song.bao.hua@hisilicon.com>
> > ---
> Reviewed-by: Akash Asthana <akashast@codeaurora.org>
Thanks! Did you review the whole patch or only the qcom-geni part?
(and please don't include the full message when you only reply to a part
of it).
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] i2c: busses: replace spin_lock_irqsave by spin_lock in hard IRQ
2020-09-21 9:34 ` Wolfram Sang
@ 2020-09-21 11:44 ` Akash Asthana
-1 siblings, 0 replies; 14+ messages in thread
From: Akash Asthana @ 2020-09-21 11:44 UTC (permalink / raw)
To: Wolfram Sang
Cc: Barry Song, linux-i2c, linux-arm-kernel, linuxarm,
Gregory CLEMENT, Andreas Färber, Manivannan Sadhasivam,
Mukesh Savaliya, Andy Gross, Bjorn Andersson
Hi Wolfram,
On 9/21/2020 3:04 PM, Wolfram Sang wrote:
> On Thu, Sep 10, 2020 at 05:10:20PM +0530, Akash Asthana wrote:
>> On 9/9/2020 9:40 AM, Barry Song wrote:
>>> The code has been in a irq-disabled context since it is hard IRQ. There
>>> is no necessity to do it again.
>>>
>>> Cc: Gregory CLEMENT <gregory.clement@bootlin.com>
>>> Cc: "Andreas Färber" <afaerber@suse.de>
>>> Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
>>> Cc: Akash Asthana <akashast@codeaurora.org>
>>> Cc: Mukesh Savaliya <msavaliy@codeaurora.org>
>>> Cc: Andy Gross <agross@kernel.org>
>>> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
>>> Signed-off-by: Barry Song <song.bao.hua@hisilicon.com>
>>> ---
>> Reviewed-by: Akash Asthana <akashast@codeaurora.org>
> Thanks! Did you review the whole patch or only the qcom-geni part?
I reviewed the whole patch.
> (and please don't include the full message when you only reply to a part
> of it).
Sure thanks.
Regards,
Akash
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,\na Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] i2c: busses: replace spin_lock_irqsave by spin_lock in hard IRQ
@ 2020-09-21 11:44 ` Akash Asthana
0 siblings, 0 replies; 14+ messages in thread
From: Akash Asthana @ 2020-09-21 11:44 UTC (permalink / raw)
To: Wolfram Sang
Cc: Barry Song, Gregory CLEMENT, linuxarm, Bjorn Andersson,
Andy Gross, linux-i2c, Manivannan Sadhasivam, Mukesh Savaliya,
Andreas Färber, linux-arm-kernel
Hi Wolfram,
On 9/21/2020 3:04 PM, Wolfram Sang wrote:
> On Thu, Sep 10, 2020 at 05:10:20PM +0530, Akash Asthana wrote:
>> On 9/9/2020 9:40 AM, Barry Song wrote:
>>> The code has been in a irq-disabled context since it is hard IRQ. There
>>> is no necessity to do it again.
>>>
>>> Cc: Gregory CLEMENT <gregory.clement@bootlin.com>
>>> Cc: "Andreas Färber" <afaerber@suse.de>
>>> Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
>>> Cc: Akash Asthana <akashast@codeaurora.org>
>>> Cc: Mukesh Savaliya <msavaliy@codeaurora.org>
>>> Cc: Andy Gross <agross@kernel.org>
>>> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
>>> Signed-off-by: Barry Song <song.bao.hua@hisilicon.com>
>>> ---
>> Reviewed-by: Akash Asthana <akashast@codeaurora.org>
> Thanks! Did you review the whole patch or only the qcom-geni part?
I reviewed the whole patch.
> (and please don't include the full message when you only reply to a part
> of it).
Sure thanks.
Regards,
Akash
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,\na Linux Foundation Collaborative Project
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
[parent not found: <268c12c2-c72d-809c-9ecc-520ef274c1c3@codeaurora.org>]
* Re: [PATCH] i2c: busses: replace spin_lock_irqsave by spin_lock in hard IRQ
[not found] ` <268c12c2-c72d-809c-9ecc-520ef274c1c3@codeaurora.org>
@ 2020-09-21 9:39 ` Wolfram Sang
0 siblings, 0 replies; 14+ messages in thread
From: Wolfram Sang @ 2020-09-21 9:39 UTC (permalink / raw)
To: Mukesh, Savaliya
Cc: Barry Song, linux-i2c, linux-arm-kernel, linuxarm,
Gregory CLEMENT, Andreas Färber, Manivannan Sadhasivam,
Akash Asthana, Andy Gross, Bjorn Andersson
[-- Attachment #1: Type: text/plain, Size: 882 bytes --]
On Thu, Sep 10, 2020 at 11:48:02PM +0530, Mukesh, Savaliya wrote:
>
> On 9/9/2020 9:40 AM, Barry Song wrote:
> > The code has been in a irq-disabled context since it is hard IRQ. There
> > is no necessity to do it again.
> >
> > Cc: Gregory CLEMENT <gregory.clement@bootlin.com>
> > Cc: "Andreas Färber" <afaerber@suse.de>
> > Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> > Cc: Akash Asthana <akashast@codeaurora.org>
> > Cc: Mukesh Savaliya <msavaliy@codeaurora.org>
> > Cc: Andy Gross <agross@kernel.org>
> > Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> > Signed-off-by: Barry Song <song.bao.hua@hisilicon.com>
> > ---
> Reviewed-by: Mukesh Kumar Savaliya <msavaliy@codeaurora.org>
Thanks! Did you review the whole patch or only the qcom-geni part?
(and please don't include the full message when you only reply to a part
of it).
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH] i2c: busses: replace spin_lock_irqsave by spin_lock in hard IRQ
@ 2020-09-21 9:39 ` Wolfram Sang
0 siblings, 0 replies; 14+ messages in thread
From: Wolfram Sang @ 2020-09-21 9:39 UTC (permalink / raw)
To: Mukesh, Savaliya
Cc: Barry Song, Gregory CLEMENT, linuxarm, Bjorn Andersson,
Akash Asthana, Andy Gross, linux-i2c, Manivannan Sadhasivam,
Andreas Färber, linux-arm-kernel
[-- Attachment #1.1: Type: text/plain, Size: 882 bytes --]
On Thu, Sep 10, 2020 at 11:48:02PM +0530, Mukesh, Savaliya wrote:
>
> On 9/9/2020 9:40 AM, Barry Song wrote:
> > The code has been in a irq-disabled context since it is hard IRQ. There
> > is no necessity to do it again.
> >
> > Cc: Gregory CLEMENT <gregory.clement@bootlin.com>
> > Cc: "Andreas Färber" <afaerber@suse.de>
> > Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> > Cc: Akash Asthana <akashast@codeaurora.org>
> > Cc: Mukesh Savaliya <msavaliy@codeaurora.org>
> > Cc: Andy Gross <agross@kernel.org>
> > Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> > Signed-off-by: Barry Song <song.bao.hua@hisilicon.com>
> > ---
> Reviewed-by: Mukesh Kumar Savaliya <msavaliy@codeaurora.org>
Thanks! Did you review the whole patch or only the qcom-geni part?
(and please don't include the full message when you only reply to a part
of it).
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] i2c: busses: replace spin_lock_irqsave by spin_lock in hard IRQ
2020-09-09 4:10 ` Barry Song
@ 2020-09-29 19:42 ` Wolfram Sang
-1 siblings, 0 replies; 14+ messages in thread
From: Wolfram Sang @ 2020-09-29 19:42 UTC (permalink / raw)
To: Barry Song
Cc: linux-i2c, linux-arm-kernel, linuxarm, Gregory CLEMENT,
Andreas Färber, Manivannan Sadhasivam, Akash Asthana,
Mukesh Savaliya, Andy Gross, Bjorn Andersson
[-- Attachment #1: Type: text/plain, Size: 614 bytes --]
On Wed, Sep 09, 2020 at 04:10:01PM +1200, Barry Song wrote:
> The code has been in a irq-disabled context since it is hard IRQ. There
> is no necessity to do it again.
>
> Cc: Gregory CLEMENT <gregory.clement@bootlin.com>
> Cc: "Andreas Färber" <afaerber@suse.de>
> Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> Cc: Akash Asthana <akashast@codeaurora.org>
> Cc: Mukesh Savaliya <msavaliy@codeaurora.org>
> Cc: Andy Gross <agross@kernel.org>
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Signed-off-by: Barry Song <song.bao.hua@hisilicon.com>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] i2c: busses: replace spin_lock_irqsave by spin_lock in hard IRQ
@ 2020-09-29 19:42 ` Wolfram Sang
0 siblings, 0 replies; 14+ messages in thread
From: Wolfram Sang @ 2020-09-29 19:42 UTC (permalink / raw)
To: Barry Song
Cc: Gregory CLEMENT, linuxarm, Bjorn Andersson, Akash Asthana,
Andy Gross, linux-i2c, Manivannan Sadhasivam, Mukesh Savaliya,
Andreas Färber, linux-arm-kernel
[-- Attachment #1.1: Type: text/plain, Size: 614 bytes --]
On Wed, Sep 09, 2020 at 04:10:01PM +1200, Barry Song wrote:
> The code has been in a irq-disabled context since it is hard IRQ. There
> is no necessity to do it again.
>
> Cc: Gregory CLEMENT <gregory.clement@bootlin.com>
> Cc: "Andreas Färber" <afaerber@suse.de>
> Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> Cc: Akash Asthana <akashast@codeaurora.org>
> Cc: Mukesh Savaliya <msavaliy@codeaurora.org>
> Cc: Andy Gross <agross@kernel.org>
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Signed-off-by: Barry Song <song.bao.hua@hisilicon.com>
Applied to for-next, thanks!
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread