From: Ankit Nautiyal <ankit.k.nautiyal@intel.com> To: intel-gfx@lists.freedesktop.org Cc: vandita.kulkarni@intel.com, uma.shankar@intel.com, dri-devel@lists.freedesktop.org, swati2.sharma@intel.com Subject: [RFC 08/13] drm/i915: Add support for enabling link status and recovery Date: Thu, 15 Oct 2020 16:22:54 +0530 [thread overview] Message-ID: <20201015105259.27934-9-ankit.k.nautiyal@intel.com> (raw) In-Reply-To: <20201015105259.27934-1-ankit.k.nautiyal@intel.com> From: Swati Sharma <swati2.sharma@intel.com> In this patch enabled support for link status and recovery in i915 driver. HDMI link loss indication to upstream DP source is indicated via IRQ_HPD. This is followed by reading of HDMI link configuration status (HDMI_TX_LINK_ACTIVE_STATUS). If the PCON → HDMI 2.1 link status is off; reinitiate frl link training to recover. Also, HDMI FRL link error count range for each individual FRL active lane is indicated by DOWNSTREAM_HDMI_ERROR_STATUS_LN registers. Signed-off-by: Swati Sharma <swati2.sharma@intel.com> Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com> --- drivers/gpu/drm/i915/display/intel_dp.c | 47 +++++++++++++++++++++++-- 1 file changed, 44 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c index 668165dd2b1a..e6c4cb844e37 100644 --- a/drivers/gpu/drm/i915/display/intel_dp.c +++ b/drivers/gpu/drm/i915/display/intel_dp.c @@ -5955,6 +5955,29 @@ intel_dp_check_mst_status(struct intel_dp *intel_dp) return link_ok; } +static void +intel_dp_handle_hdmi_link_status_change(struct intel_dp *intel_dp) +{ + bool is_active; + u8 buf = 0; + + is_active = drm_dp_pcon_hdmi_link_active(&intel_dp->aux); + if (intel_dp->frl.is_trained && !is_active) { + if (drm_dp_dpcd_readb(&intel_dp->aux, DP_PCON_HDMI_LINK_CONFIG_1, &buf) < 0) + return; + + buf &= ~DP_PCON_ENABLE_HDMI_LINK; + if (drm_dp_dpcd_writeb(&intel_dp->aux, DP_PCON_HDMI_LINK_CONFIG_1, buf) < 0) + return; + + intel_dp->frl.is_trained = false; + intel_dp->frl.trained_rate_gbps = 0; + + intel_dp_check_frl_training(intel_dp); + drm_dp_pcon_hdmi_frl_link_error_count(&intel_dp->aux, &intel_dp->attached_connector->base); + } +} + static bool intel_dp_needs_link_retrain(struct intel_dp *intel_dp) { @@ -6320,7 +6343,7 @@ intel_dp_hotplug(struct intel_encoder *encoder, return state; } -static void intel_dp_check_service_irq(struct intel_dp *intel_dp) +static void intel_dp_check_device_service_irq(struct intel_dp *intel_dp) { struct drm_i915_private *i915 = dp_to_i915(intel_dp); u8 val; @@ -6344,6 +6367,23 @@ static void intel_dp_check_service_irq(struct intel_dp *intel_dp) drm_dbg_kms(&i915->drm, "Sink specific irq unhandled\n"); } +static void intel_dp_check_link_service_irq(struct intel_dp *intel_dp) +{ + u8 val; + + if (intel_dp->dpcd[DP_DPCD_REV] < 0x11) + return; + + if (drm_dp_dpcd_readb(&intel_dp->aux, + DP_LINK_SERVICE_IRQ_VECTOR_ESI0, &val) != 1 || !val) + return; + + drm_dp_dpcd_writeb(&intel_dp->aux, DP_LINK_SERVICE_IRQ_VECTOR_ESI0, val); + + if (val & HDMI_LINK_STATUS_CHANGED) + intel_dp_handle_hdmi_link_status_change(intel_dp); +} + /* * According to DP spec * 5.1.2: @@ -6383,7 +6423,8 @@ intel_dp_short_pulse(struct intel_dp *intel_dp) return false; } - intel_dp_check_service_irq(intel_dp); + intel_dp_check_device_service_irq(intel_dp); + intel_dp_check_link_service_irq(intel_dp); /* Handle CEC interrupts, if any */ drm_dp_cec_irq(&intel_dp->aux); @@ -6815,7 +6856,7 @@ intel_dp_detect(struct drm_connector *connector, to_intel_connector(connector)->detect_edid) status = connector_status_connected; - intel_dp_check_service_irq(intel_dp); + intel_dp_check_device_service_irq(intel_dp); out: if (status != connector_status_connected && !intel_dp->is_mst) -- 2.17.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Ankit Nautiyal <ankit.k.nautiyal@intel.com> To: intel-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Subject: [Intel-gfx] [RFC 08/13] drm/i915: Add support for enabling link status and recovery Date: Thu, 15 Oct 2020 16:22:54 +0530 [thread overview] Message-ID: <20201015105259.27934-9-ankit.k.nautiyal@intel.com> (raw) In-Reply-To: <20201015105259.27934-1-ankit.k.nautiyal@intel.com> From: Swati Sharma <swati2.sharma@intel.com> In this patch enabled support for link status and recovery in i915 driver. HDMI link loss indication to upstream DP source is indicated via IRQ_HPD. This is followed by reading of HDMI link configuration status (HDMI_TX_LINK_ACTIVE_STATUS). If the PCON → HDMI 2.1 link status is off; reinitiate frl link training to recover. Also, HDMI FRL link error count range for each individual FRL active lane is indicated by DOWNSTREAM_HDMI_ERROR_STATUS_LN registers. Signed-off-by: Swati Sharma <swati2.sharma@intel.com> Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com> --- drivers/gpu/drm/i915/display/intel_dp.c | 47 +++++++++++++++++++++++-- 1 file changed, 44 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c index 668165dd2b1a..e6c4cb844e37 100644 --- a/drivers/gpu/drm/i915/display/intel_dp.c +++ b/drivers/gpu/drm/i915/display/intel_dp.c @@ -5955,6 +5955,29 @@ intel_dp_check_mst_status(struct intel_dp *intel_dp) return link_ok; } +static void +intel_dp_handle_hdmi_link_status_change(struct intel_dp *intel_dp) +{ + bool is_active; + u8 buf = 0; + + is_active = drm_dp_pcon_hdmi_link_active(&intel_dp->aux); + if (intel_dp->frl.is_trained && !is_active) { + if (drm_dp_dpcd_readb(&intel_dp->aux, DP_PCON_HDMI_LINK_CONFIG_1, &buf) < 0) + return; + + buf &= ~DP_PCON_ENABLE_HDMI_LINK; + if (drm_dp_dpcd_writeb(&intel_dp->aux, DP_PCON_HDMI_LINK_CONFIG_1, buf) < 0) + return; + + intel_dp->frl.is_trained = false; + intel_dp->frl.trained_rate_gbps = 0; + + intel_dp_check_frl_training(intel_dp); + drm_dp_pcon_hdmi_frl_link_error_count(&intel_dp->aux, &intel_dp->attached_connector->base); + } +} + static bool intel_dp_needs_link_retrain(struct intel_dp *intel_dp) { @@ -6320,7 +6343,7 @@ intel_dp_hotplug(struct intel_encoder *encoder, return state; } -static void intel_dp_check_service_irq(struct intel_dp *intel_dp) +static void intel_dp_check_device_service_irq(struct intel_dp *intel_dp) { struct drm_i915_private *i915 = dp_to_i915(intel_dp); u8 val; @@ -6344,6 +6367,23 @@ static void intel_dp_check_service_irq(struct intel_dp *intel_dp) drm_dbg_kms(&i915->drm, "Sink specific irq unhandled\n"); } +static void intel_dp_check_link_service_irq(struct intel_dp *intel_dp) +{ + u8 val; + + if (intel_dp->dpcd[DP_DPCD_REV] < 0x11) + return; + + if (drm_dp_dpcd_readb(&intel_dp->aux, + DP_LINK_SERVICE_IRQ_VECTOR_ESI0, &val) != 1 || !val) + return; + + drm_dp_dpcd_writeb(&intel_dp->aux, DP_LINK_SERVICE_IRQ_VECTOR_ESI0, val); + + if (val & HDMI_LINK_STATUS_CHANGED) + intel_dp_handle_hdmi_link_status_change(intel_dp); +} + /* * According to DP spec * 5.1.2: @@ -6383,7 +6423,8 @@ intel_dp_short_pulse(struct intel_dp *intel_dp) return false; } - intel_dp_check_service_irq(intel_dp); + intel_dp_check_device_service_irq(intel_dp); + intel_dp_check_link_service_irq(intel_dp); /* Handle CEC interrupts, if any */ drm_dp_cec_irq(&intel_dp->aux); @@ -6815,7 +6856,7 @@ intel_dp_detect(struct drm_connector *connector, to_intel_connector(connector)->detect_edid) status = connector_status_connected; - intel_dp_check_service_irq(intel_dp); + intel_dp_check_device_service_irq(intel_dp); out: if (status != connector_status_connected && !intel_dp->is_mst) -- 2.17.1 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-10-15 11:00 UTC|newest] Thread overview: 86+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-10-15 10:52 [RFC 00/13] Add support for DP-HDMI2.1 PCON Ankit Nautiyal 2020-10-15 10:52 ` [Intel-gfx] " Ankit Nautiyal 2020-10-15 10:52 ` [RFC 01/13] drm/edid: Add additional HFVSDB fields for HDMI2.1 Ankit Nautiyal 2020-10-15 10:52 ` [Intel-gfx] " Ankit Nautiyal 2020-10-18 20:47 ` Shankar, Uma 2020-10-18 20:47 ` [Intel-gfx] " Shankar, Uma 2020-11-01 5:31 ` Nautiyal, Ankit K 2020-11-01 5:31 ` [Intel-gfx] " Nautiyal, Ankit K 2020-10-15 10:52 ` [RFC 02/13] drm/edid: Parse MAX_FRL field from HFVSDB block Ankit Nautiyal 2020-10-15 10:52 ` [Intel-gfx] " Ankit Nautiyal 2020-10-18 20:47 ` Shankar, Uma 2020-10-18 20:47 ` [Intel-gfx] " Shankar, Uma 2020-11-01 5:41 ` Nautiyal, Ankit K 2020-11-01 5:41 ` [Intel-gfx] " Nautiyal, Ankit K 2020-10-15 10:52 ` [RFC 03/13] drm/dp_helper: Add FRL training support for a DP-HDMI2.1 PCON Ankit Nautiyal 2020-10-15 10:52 ` [Intel-gfx] " Ankit Nautiyal 2020-10-18 21:33 ` Shankar, Uma 2020-10-18 21:33 ` [Intel-gfx] " Shankar, Uma 2020-11-01 5:53 ` Nautiyal, Ankit K 2020-11-01 5:53 ` [Intel-gfx] " Nautiyal, Ankit K 2020-10-15 10:52 ` [RFC 04/13] drm/i915: Capture max frl rate for PCON in dfp cap structure Ankit Nautiyal 2020-10-15 10:52 ` [Intel-gfx] " Ankit Nautiyal 2020-10-18 21:41 ` Shankar, Uma 2020-10-18 21:41 ` [Intel-gfx] " Shankar, Uma 2020-11-01 5:56 ` Nautiyal, Ankit K 2020-11-01 5:56 ` [Intel-gfx] " Nautiyal, Ankit K 2020-10-15 10:52 ` [RFC 05/13] drm/i915: Add support for starting FRL training for HDMI2.1 via PCON Ankit Nautiyal 2020-10-15 10:52 ` [Intel-gfx] " Ankit Nautiyal 2020-10-18 22:14 ` Shankar, Uma 2020-10-18 22:14 ` [Intel-gfx] " Shankar, Uma 2020-11-01 6:01 ` Nautiyal, Ankit K 2020-11-01 6:01 ` [Intel-gfx] " Nautiyal, Ankit K 2020-10-15 10:52 ` [RFC 06/13] drm/i915: Check for FRL training before DP Link training Ankit Nautiyal 2020-10-15 10:52 ` [Intel-gfx] " Ankit Nautiyal 2020-10-18 22:21 ` Shankar, Uma 2020-10-18 22:21 ` [Intel-gfx] " Shankar, Uma 2020-11-01 6:06 ` Nautiyal, Ankit K 2020-11-01 6:06 ` [Intel-gfx] " Nautiyal, Ankit K 2020-10-15 10:52 ` [RFC 07/13] drm/dp_helper: Add support for link status and link recovery Ankit Nautiyal 2020-10-15 10:52 ` [Intel-gfx] " Ankit Nautiyal 2020-10-18 22:37 ` Shankar, Uma 2020-10-18 22:37 ` [Intel-gfx] " Shankar, Uma 2020-11-01 6:18 ` Nautiyal, Ankit K 2020-11-01 6:18 ` [Intel-gfx] " Nautiyal, Ankit K 2020-10-15 10:52 ` Ankit Nautiyal [this message] 2020-10-15 10:52 ` [Intel-gfx] [RFC 08/13] drm/i915: Add support for enabling link status and recovery Ankit Nautiyal 2020-10-18 22:49 ` Shankar, Uma 2020-10-18 22:49 ` [Intel-gfx] " Shankar, Uma 2020-11-01 6:26 ` Nautiyal, Ankit K 2020-11-01 6:26 ` [Intel-gfx] " Nautiyal, Ankit K 2020-10-15 10:52 ` [RFC 09/13] drm/edid: Parse DSC1.2 cap fields from HFVSDB block Ankit Nautiyal 2020-10-15 10:52 ` [Intel-gfx] " Ankit Nautiyal 2020-10-18 23:01 ` Shankar, Uma 2020-10-18 23:01 ` [Intel-gfx] " Shankar, Uma 2020-11-01 6:52 ` Nautiyal, Ankit K 2020-11-01 6:52 ` [Intel-gfx] " Nautiyal, Ankit K 2020-10-15 10:52 ` [RFC 10/13] drm/dp_helper: Add support for Configuring DSC for HDMI2.1 Pcon Ankit Nautiyal 2020-10-15 10:52 ` [Intel-gfx] " Ankit Nautiyal 2020-10-18 23:19 ` Shankar, Uma 2020-10-18 23:19 ` [Intel-gfx] " Shankar, Uma 2020-11-01 7:00 ` Nautiyal, Ankit K 2020-11-01 7:00 ` [Intel-gfx] " Nautiyal, Ankit K 2020-10-15 10:52 ` [RFC 11/13] drm/i915: Read DSC capabilities of the HDMI2.1 PCON encoder Ankit Nautiyal 2020-10-15 10:52 ` [Intel-gfx] " Ankit Nautiyal 2020-10-15 14:19 ` kernel test robot 2020-10-15 14:19 ` [RFC PATCH] drm/i915: intel_dp_get_pcon_dsc_cap() can be static kernel test robot 2020-10-15 14:47 ` [Intel-gfx] [RFC 11/13] drm/i915: Read DSC capabilities of the HDMI2.1 PCON encoder kernel test robot 2020-10-15 15:10 ` kernel test robot 2020-10-15 17:07 ` kernel test robot 2020-10-15 17:07 ` [PATCH] drm/i915: fix semicolon.cocci warnings kernel test robot 2020-10-18 23:32 ` [RFC 11/13] drm/i915: Read DSC capabilities of the HDMI2.1 PCON encoder Shankar, Uma 2020-10-18 23:32 ` [Intel-gfx] " Shankar, Uma 2020-10-18 23:34 ` Shankar, Uma 2020-10-18 23:34 ` [Intel-gfx] " Shankar, Uma 2020-11-01 7:14 ` Nautiyal, Ankit K 2020-11-01 7:14 ` [Intel-gfx] " Nautiyal, Ankit K 2020-11-01 7:13 ` Nautiyal, Ankit K 2020-11-01 7:13 ` [Intel-gfx] " Nautiyal, Ankit K 2020-10-15 10:52 ` [RFC 12/13] drm/i915: Add helper functions for calculating DSC parameters for HDMI2.1 Ankit Nautiyal 2020-10-15 10:52 ` [Intel-gfx] " Ankit Nautiyal 2020-10-15 10:52 ` [RFC 13/13] drm/i915: Configure PCON for DSC1.1 to DSC1.2 encoding Ankit Nautiyal 2020-10-15 10:52 ` [Intel-gfx] " Ankit Nautiyal 2020-10-15 11:37 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Add support for DP-HDMI2.1 PCON (rev3) Patchwork 2020-10-15 11:39 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork 2020-10-15 12:02 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2020-10-15 13:41 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201015105259.27934-9-ankit.k.nautiyal@intel.com \ --to=ankit.k.nautiyal@intel.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=intel-gfx@lists.freedesktop.org \ --cc=swati2.sharma@intel.com \ --cc=uma.shankar@intel.com \ --cc=vandita.kulkarni@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.