All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Pali Rohár" <pali@kernel.org>
To: u-boot@lists.denx.de
Subject: [PATCH 01/13] serial: usbtty: Fix puts function
Date: Sun, 29 Nov 2020 17:46:06 +0100	[thread overview]
Message-ID: <20201129164618.5829-2-pali@kernel.org> (raw)
In-Reply-To: <20201129164618.5829-1-pali@kernel.org>

This function has incorrect implementation of prepending CR prior LF.
Without this patch it prepended CR prior whole string which is going to be
written and let LF without leading CR. Fix this issue by inserting CR at
correct place to make output on usbtty serial console more readable.

Signed-off-by: Pali Roh?r <pali@kernel.org>
---
 drivers/serial/usbtty.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/serial/usbtty.c b/drivers/serial/usbtty.c
index f1c1a260da..02f8edf200 100644
--- a/drivers/serial/usbtty.c
+++ b/drivers/serial/usbtty.c
@@ -500,8 +500,8 @@ void usbtty_puts(struct stdio_dev *dev, const char *str)
 		n = next_nl_pos (str);
 
 		if (str[n] == '\n') {
-			__usbtty_puts("\r", 1);
-			__usbtty_puts(str, n + 1);
+			__usbtty_puts(str, n);
+			__usbtty_puts("\r\n", 2);
 			str += (n + 1);
 			len -= (n + 1);
 		} else {
-- 
2.20.1

  reply	other threads:[~2020-11-29 16:46 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-29 16:46 [PATCH 00/13] Nokia RX-51: Fix USB TTY console and enable it Pali Rohár
2020-11-29 16:46 ` Pali Rohár [this message]
2020-11-29 17:50   ` [PATCH 01/13] serial: usbtty: Fix puts function Pavel Machek
2020-11-29 16:46 ` [PATCH 02/13] usb: musb: Fix compilation of gadget code Pali Rohár
2020-11-29 17:52   ` Pavel Machek
2021-01-16  0:18     ` Pali Rohár
2020-11-29 16:46 ` [PATCH 03/13] usb: musb: Always clear the data toggle bit when configuring ep Pali Rohár
2020-11-29 17:52   ` Pavel Machek
2020-11-29 16:46 ` [PATCH 04/13] usb: musb: Fix configuring FIFO for endpoints Pali Rohár
2020-11-29 17:53   ` Pavel Machek
2020-12-26 18:08   ` [PATCH v2] " Pali Rohár
2020-11-29 16:46 ` [PATCH 05/13] usb: musb: Read value of PERI_RXCSR to 16bit variable Pali Rohár
2020-11-29 17:53   ` Pavel Machek
2020-11-29 16:46 ` [PATCH 06/13] usb: musb: Fix transmission of bigger buffers Pali Rohár
2020-11-29 17:55   ` Pavel Machek
2020-11-29 16:46 ` [PATCH 07/13] usb: gadget: Do not export usbd_device_* arrays Pali Rohár
2020-11-29 17:57   ` Pavel Machek
2020-12-26 18:12   ` [PATCH v2] " Pali Rohár
2020-11-29 16:49 ` [PATCH 08/13] usb: gadget: Use dbg_ep0() macro instead of serial_printf() Pali Rohár
2020-11-29 17:57   ` Pavel Machek
2020-11-29 16:51 ` [PATCH 09/13] arm: omap3: Compile lowlevel_init() function only when it is used Pali Rohár
2020-11-29 17:59   ` Pavel Machek
2020-11-29 16:52 ` [PATCH 10/13] arm: omap3: Compile s_init() " Pali Rohár
2020-11-29 18:00   ` Pavel Machek
2020-11-29 16:52 ` [PATCH 11/13] Nokia RX-51: Remove function set_muxconf_regs() Pali Rohár
2020-11-29 16:52 ` [PATCH 12/13] Nokia RX-51: Move content of rx51.h to rx51.c Pali Rohár
2020-11-29 16:52 ` [PATCH 13/13] Nokia RX-51: Enable usbtty serial console by default Pali Rohár
2020-11-29 18:11   ` Pavel Machek
2020-11-30 19:27   ` [PATCH v2] " Pali Rohár
2020-12-22 14:26     ` Lokesh Vutla
2020-12-22 14:58       ` Pali Rohár
2020-12-22 15:06         ` Lokesh Vutla
2020-12-22 15:08           ` Lokesh Vutla
2020-12-22 15:09             ` Lokesh Vutla
2020-12-22 15:17               ` Pali Rohár
2020-12-22 15:38                 ` Lokesh Vutla
2020-12-22 16:02                   ` Pali Rohár
2020-12-23  6:05                     ` Lokesh Vutla
2020-12-26 17:01                       ` Pali Rohár
2020-12-27 16:28   ` [PATCH 13/13] " Andy Shevchenko
2020-12-27 16:35     ` Pali Rohár
2020-12-27 16:42       ` Andy Shevchenko
2020-12-27 16:50         ` Pali Rohár
2020-12-10 20:01 ` [PATCH 00/13] Nokia RX-51: Fix USB TTY console and enable it Pali Rohár
2020-12-11 10:53   ` Lokesh Vutla
2020-12-19 23:46     ` Pali Rohár
2020-12-27 16:32 ` Pali Rohár
2021-01-17 10:37 ` Lokesh Vutla
2021-02-01 15:30   ` Pali Rohár

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201129164618.5829-2-pali@kernel.org \
    --to=pali@kernel.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.