From: "Pali Rohár" <pali@kernel.org>
To: u-boot@lists.denx.de
Subject: [PATCH 13/13] Nokia RX-51: Enable usbtty serial console by default
Date: Sun, 27 Dec 2020 17:50:43 +0100 [thread overview]
Message-ID: <20201227165043.wk7menyrvurxrr2c@pali> (raw)
In-Reply-To: <CAHp75VdewScRJ0M5K9S4ihW+s08K4Z8wk4kaEkAesVwu7kA3sw@mail.gmail.com>
On Sunday 27 December 2020 18:42:19 Andy Shevchenko wrote:
> On Sun, Dec 27, 2020 at 6:35 PM Pali Roh?r <pali@kernel.org> wrote:
> > On Sunday 27 December 2020 18:28:25 Andy Shevchenko wrote:
> > > On Sun, Nov 29, 2020 at 6:53 PM Pali Roh?r <pali@kernel.org> wrote:
> > > >
> > > > Now when usbtty serial console is fixed in U-Boot enable it for Nokia RX-51
> > > > board by default.
> > > >
> > > > CONFIG_CONSOLE_MUX is already used and U-Boot console is available for
> > > > all in/out devices. Therefore there is no need to have separate commands
> > > > 'run sercon', 'run usbcon' and 'run vgacon', so remove them.
> > > >
> > > > As space for U-Boot is limited to 256kB, disable some other unused options
> > > > so CONFIG_USB_TTY can be enabled.
> > > >
> > > > Nokia RX-51 does not have easily accessible UART serial console so the only
> > > > option for easy debugging is to use device's keyboard+screen or this usbtty
> > > > serial console over USB.
> > >
> > > I think it's not a good idea to revive usbtty.
> >
> > Well, but u-boot does not support anything else for Nokia N900. And main
> > issues here are musb bugs which this patch series is fixing. For
> > debugging is serial console (e.g. usbtty) needed.
>
> I'm not against musb fixes, I'm against promoting usbtty.
> Why composite + f_serial can't be used for that?
Because nobody looked at it and invested time in it. usbtty was there
for a long time and is working fine right now (with these musb patches).
> > > I was recently playing around f_serial.c (I can send you the half
> > > baked stuff, which by a lot of twisted code in DWC3 driver is not
> > > working properly, actually almost not working) and I think that would
> > > be the right thing to do.
> > >
> > > usbtty quite old, intrusive way of serial console via USB supported
> > > only by outdated hardware (like this Nokia N-900), while f_serial
> > > gotta work on better recent base. And I believe musb should be, if
> > > needed, patched to support composite devices.
> > >
> > > So, kinda disagreement from my side as a summary on this.
> > > But disclaimer, I'm not a maintainer here, just my 2 cents.
>
>
>
> --
> With Best Regards,
> Andy Shevchenko
next prev parent reply other threads:[~2020-12-27 16:50 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-29 16:46 [PATCH 00/13] Nokia RX-51: Fix USB TTY console and enable it Pali Rohár
2020-11-29 16:46 ` [PATCH 01/13] serial: usbtty: Fix puts function Pali Rohár
2020-11-29 17:50 ` Pavel Machek
2020-11-29 16:46 ` [PATCH 02/13] usb: musb: Fix compilation of gadget code Pali Rohár
2020-11-29 17:52 ` Pavel Machek
2021-01-16 0:18 ` Pali Rohár
2020-11-29 16:46 ` [PATCH 03/13] usb: musb: Always clear the data toggle bit when configuring ep Pali Rohár
2020-11-29 17:52 ` Pavel Machek
2020-11-29 16:46 ` [PATCH 04/13] usb: musb: Fix configuring FIFO for endpoints Pali Rohár
2020-11-29 17:53 ` Pavel Machek
2020-12-26 18:08 ` [PATCH v2] " Pali Rohár
2020-11-29 16:46 ` [PATCH 05/13] usb: musb: Read value of PERI_RXCSR to 16bit variable Pali Rohár
2020-11-29 17:53 ` Pavel Machek
2020-11-29 16:46 ` [PATCH 06/13] usb: musb: Fix transmission of bigger buffers Pali Rohár
2020-11-29 17:55 ` Pavel Machek
2020-11-29 16:46 ` [PATCH 07/13] usb: gadget: Do not export usbd_device_* arrays Pali Rohár
2020-11-29 17:57 ` Pavel Machek
2020-12-26 18:12 ` [PATCH v2] " Pali Rohár
2020-11-29 16:49 ` [PATCH 08/13] usb: gadget: Use dbg_ep0() macro instead of serial_printf() Pali Rohár
2020-11-29 17:57 ` Pavel Machek
2020-11-29 16:51 ` [PATCH 09/13] arm: omap3: Compile lowlevel_init() function only when it is used Pali Rohár
2020-11-29 17:59 ` Pavel Machek
2020-11-29 16:52 ` [PATCH 10/13] arm: omap3: Compile s_init() " Pali Rohár
2020-11-29 18:00 ` Pavel Machek
2020-11-29 16:52 ` [PATCH 11/13] Nokia RX-51: Remove function set_muxconf_regs() Pali Rohár
2020-11-29 16:52 ` [PATCH 12/13] Nokia RX-51: Move content of rx51.h to rx51.c Pali Rohár
2020-11-29 16:52 ` [PATCH 13/13] Nokia RX-51: Enable usbtty serial console by default Pali Rohár
2020-11-29 18:11 ` Pavel Machek
2020-11-30 19:27 ` [PATCH v2] " Pali Rohár
2020-12-22 14:26 ` Lokesh Vutla
2020-12-22 14:58 ` Pali Rohár
2020-12-22 15:06 ` Lokesh Vutla
2020-12-22 15:08 ` Lokesh Vutla
2020-12-22 15:09 ` Lokesh Vutla
2020-12-22 15:17 ` Pali Rohár
2020-12-22 15:38 ` Lokesh Vutla
2020-12-22 16:02 ` Pali Rohár
2020-12-23 6:05 ` Lokesh Vutla
2020-12-26 17:01 ` Pali Rohár
2020-12-27 16:28 ` [PATCH 13/13] " Andy Shevchenko
2020-12-27 16:35 ` Pali Rohár
2020-12-27 16:42 ` Andy Shevchenko
2020-12-27 16:50 ` Pali Rohár [this message]
2020-12-10 20:01 ` [PATCH 00/13] Nokia RX-51: Fix USB TTY console and enable it Pali Rohár
2020-12-11 10:53 ` Lokesh Vutla
2020-12-19 23:46 ` Pali Rohár
2020-12-27 16:32 ` Pali Rohár
2021-01-17 10:37 ` Lokesh Vutla
2021-02-01 15:30 ` Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201227165043.wk7menyrvurxrr2c@pali \
--to=pali@kernel.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.