All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: u-boot@lists.denx.de
Subject: [PATCH 04/13] usb: musb: Fix configuring FIFO for endpoints
Date: Sun, 29 Nov 2020 18:53:27 +0100	[thread overview]
Message-ID: <20201129175327.GF27274@amd> (raw)
In-Reply-To: <20201129164618.5829-5-pali@kernel.org>

On Sun 2020-11-29 17:46:09, Pali Roh?r wrote:
> This patch fixes configuring FIFO for one-directional endpoints which have
> either RX or TX queue and therefore only one FIFO.
> 
> Without this patch if FIFO size was zero then idx was incorrectly
> calculated (expr. ffs(0)-1 is not zero) and size overflowed in fifosz
> register. This register uses has only 4 bits for FIFO size.
> 
> This patch is fixing it by setting zero size and zero address when
> particular endpoint does not use FIFO.
> 
> This issue caused loose of packets on USB bus in both directions and
> basically usbtty was unusable.
> 
> Signed-off-by: Pali Roh?r <pali@kernel.org>

Reviewed-by: Pavel Machek <pavel@ucw.cz>


-- 
http://www.livejournal.com/~pavelmachek
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20201129/7cca4dd6/attachment.sig>

  reply	other threads:[~2020-11-29 17:53 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-29 16:46 [PATCH 00/13] Nokia RX-51: Fix USB TTY console and enable it Pali Rohár
2020-11-29 16:46 ` [PATCH 01/13] serial: usbtty: Fix puts function Pali Rohár
2020-11-29 17:50   ` Pavel Machek
2020-11-29 16:46 ` [PATCH 02/13] usb: musb: Fix compilation of gadget code Pali Rohár
2020-11-29 17:52   ` Pavel Machek
2021-01-16  0:18     ` Pali Rohár
2020-11-29 16:46 ` [PATCH 03/13] usb: musb: Always clear the data toggle bit when configuring ep Pali Rohár
2020-11-29 17:52   ` Pavel Machek
2020-11-29 16:46 ` [PATCH 04/13] usb: musb: Fix configuring FIFO for endpoints Pali Rohár
2020-11-29 17:53   ` Pavel Machek [this message]
2020-12-26 18:08   ` [PATCH v2] " Pali Rohár
2020-11-29 16:46 ` [PATCH 05/13] usb: musb: Read value of PERI_RXCSR to 16bit variable Pali Rohár
2020-11-29 17:53   ` Pavel Machek
2020-11-29 16:46 ` [PATCH 06/13] usb: musb: Fix transmission of bigger buffers Pali Rohár
2020-11-29 17:55   ` Pavel Machek
2020-11-29 16:46 ` [PATCH 07/13] usb: gadget: Do not export usbd_device_* arrays Pali Rohár
2020-11-29 17:57   ` Pavel Machek
2020-12-26 18:12   ` [PATCH v2] " Pali Rohár
2020-11-29 16:49 ` [PATCH 08/13] usb: gadget: Use dbg_ep0() macro instead of serial_printf() Pali Rohár
2020-11-29 17:57   ` Pavel Machek
2020-11-29 16:51 ` [PATCH 09/13] arm: omap3: Compile lowlevel_init() function only when it is used Pali Rohár
2020-11-29 17:59   ` Pavel Machek
2020-11-29 16:52 ` [PATCH 10/13] arm: omap3: Compile s_init() " Pali Rohár
2020-11-29 18:00   ` Pavel Machek
2020-11-29 16:52 ` [PATCH 11/13] Nokia RX-51: Remove function set_muxconf_regs() Pali Rohár
2020-11-29 16:52 ` [PATCH 12/13] Nokia RX-51: Move content of rx51.h to rx51.c Pali Rohár
2020-11-29 16:52 ` [PATCH 13/13] Nokia RX-51: Enable usbtty serial console by default Pali Rohár
2020-11-29 18:11   ` Pavel Machek
2020-11-30 19:27   ` [PATCH v2] " Pali Rohár
2020-12-22 14:26     ` Lokesh Vutla
2020-12-22 14:58       ` Pali Rohár
2020-12-22 15:06         ` Lokesh Vutla
2020-12-22 15:08           ` Lokesh Vutla
2020-12-22 15:09             ` Lokesh Vutla
2020-12-22 15:17               ` Pali Rohár
2020-12-22 15:38                 ` Lokesh Vutla
2020-12-22 16:02                   ` Pali Rohár
2020-12-23  6:05                     ` Lokesh Vutla
2020-12-26 17:01                       ` Pali Rohár
2020-12-27 16:28   ` [PATCH 13/13] " Andy Shevchenko
2020-12-27 16:35     ` Pali Rohár
2020-12-27 16:42       ` Andy Shevchenko
2020-12-27 16:50         ` Pali Rohár
2020-12-10 20:01 ` [PATCH 00/13] Nokia RX-51: Fix USB TTY console and enable it Pali Rohár
2020-12-11 10:53   ` Lokesh Vutla
2020-12-19 23:46     ` Pali Rohár
2020-12-27 16:32 ` Pali Rohár
2021-01-17 10:37 ` Lokesh Vutla
2021-02-01 15:30   ` Pali Rohár

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201129175327.GF27274@amd \
    --to=pavel@ucw.cz \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.