From: Christoph Hellwig <hch@lst.de> To: Jens Axboe <axboe@kernel.dk> Cc: Tejun Heo <tj@kernel.org>, Coly Li <colyli@suse.de>, Song Liu <song@kernel.org>, dm-devel@redhat.com, linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org, linux-s390@vger.kernel.org, linux-block@vger.kernel.org Subject: [PATCH 1/9] brd: remove the end of device check in brd_do_bvec Date: Tue, 1 Dec 2020 17:54:16 +0100 [thread overview] Message-ID: <20201201165424.2030647-2-hch@lst.de> (raw) In-Reply-To: <20201201165424.2030647-1-hch@lst.de> The block layer already checks for this conditions in bio_check_eod before calling the driver. Signed-off-by: Christoph Hellwig <hch@lst.de> --- drivers/block/brd.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/block/brd.c b/drivers/block/brd.c index c43a6ab4b1f39f..c7c8214190795c 100644 --- a/drivers/block/brd.c +++ b/drivers/block/brd.c @@ -285,14 +285,10 @@ static int brd_do_bvec(struct brd_device *brd, struct page *page, static blk_qc_t brd_submit_bio(struct bio *bio) { struct brd_device *brd = bio->bi_disk->private_data; + sector_t sector = bio->bi_iter.bi_sector; struct bio_vec bvec; - sector_t sector; struct bvec_iter iter; - sector = bio->bi_iter.bi_sector; - if (bio_end_sector(bio) > get_capacity(bio->bi_disk)) - goto io_error; - bio_for_each_segment(bvec, bio, iter) { unsigned int len = bvec.bv_len; int err; -- 2.29.2
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de> To: Jens Axboe <axboe@kernel.dk> Cc: linux-s390@vger.kernel.org, linux-bcache@vger.kernel.org, Coly Li <colyli@suse.de>, linux-raid@vger.kernel.org, Song Liu <song@kernel.org>, dm-devel@redhat.com, linux-block@vger.kernel.org, Tejun Heo <tj@kernel.org> Subject: [dm-devel] [PATCH 1/9] brd: remove the end of device check in brd_do_bvec Date: Tue, 1 Dec 2020 17:54:16 +0100 [thread overview] Message-ID: <20201201165424.2030647-2-hch@lst.de> (raw) In-Reply-To: <20201201165424.2030647-1-hch@lst.de> The block layer already checks for this conditions in bio_check_eod before calling the driver. Signed-off-by: Christoph Hellwig <hch@lst.de> --- drivers/block/brd.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/block/brd.c b/drivers/block/brd.c index c43a6ab4b1f39f..c7c8214190795c 100644 --- a/drivers/block/brd.c +++ b/drivers/block/brd.c @@ -285,14 +285,10 @@ static int brd_do_bvec(struct brd_device *brd, struct page *page, static blk_qc_t brd_submit_bio(struct bio *bio) { struct brd_device *brd = bio->bi_disk->private_data; + sector_t sector = bio->bi_iter.bi_sector; struct bio_vec bvec; - sector_t sector; struct bvec_iter iter; - sector = bio->bi_iter.bi_sector; - if (bio_end_sector(bio) > get_capacity(bio->bi_disk)) - goto io_error; - bio_for_each_segment(bvec, bio, iter) { unsigned int len = bvec.bv_len; int err; -- 2.29.2 -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2020-12-01 16:55 UTC|newest] Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-12-01 16:54 store a pointer to the block_device in struct bio (again) Christoph Hellwig 2020-12-01 16:54 ` [dm-devel] " Christoph Hellwig 2020-12-01 16:54 ` Christoph Hellwig [this message] 2020-12-01 16:54 ` [dm-devel] [PATCH 1/9] brd: remove the end of device check in brd_do_bvec Christoph Hellwig 2020-12-02 22:39 ` Tejun Heo 2020-12-02 22:39 ` [dm-devel] " Tejun Heo 2020-12-01 16:54 ` [PATCH 2/9] dcssblk: " Christoph Hellwig 2020-12-01 16:54 ` [dm-devel] " Christoph Hellwig 2020-12-02 22:39 ` Tejun Heo 2020-12-02 22:39 ` [dm-devel] " Tejun Heo 2020-12-01 16:54 ` [PATCH 3/9] block: store a block_device pointer in struct bio Christoph Hellwig 2020-12-01 16:54 ` [dm-devel] " Christoph Hellwig 2020-12-02 22:54 ` Tejun Heo 2020-12-02 22:54 ` [dm-devel] " Tejun Heo 2020-12-03 6:39 ` Ming Lei 2020-12-03 6:39 ` [dm-devel] " Ming Lei 2020-12-03 7:10 ` Ming Lei 2020-12-03 7:10 ` [dm-devel] " Ming Lei 2020-12-03 8:29 ` Christoph Hellwig 2020-12-03 8:29 ` [dm-devel] " Christoph Hellwig 2020-12-03 9:32 ` Ming Lei 2020-12-03 9:32 ` [dm-devel] " Ming Lei 2020-12-03 20:53 ` Keith Busch 2020-12-03 20:53 ` [dm-devel] " Keith Busch 2020-12-01 16:54 ` [PATCH 4/9] block: simplify submit_bio_checks a bit Christoph Hellwig 2020-12-01 16:54 ` [dm-devel] " Christoph Hellwig 2020-12-02 22:55 ` Tejun Heo 2020-12-02 22:55 ` [dm-devel] " Tejun Heo 2020-12-01 16:54 ` [PATCH 5/9] block: use ->bi_bdev for bio based I/O accounting Christoph Hellwig 2020-12-01 16:54 ` [dm-devel] " Christoph Hellwig 2020-12-02 23:05 ` Tejun Heo 2020-12-02 23:05 ` [dm-devel] " Tejun Heo 2020-12-01 16:54 ` [PATCH 6/9] blk-mq: use ->bi_bdev for " Christoph Hellwig 2020-12-01 16:54 ` [dm-devel] " Christoph Hellwig 2020-12-02 23:06 ` Tejun Heo 2020-12-02 23:06 ` [dm-devel] " Tejun Heo 2020-12-01 16:54 ` [PATCH 7/9] block: add a disk_uevent helper Christoph Hellwig 2020-12-01 16:54 ` [dm-devel] " Christoph Hellwig 2020-12-02 23:08 ` Tejun Heo 2020-12-02 23:08 ` [dm-devel] " Tejun Heo 2020-12-01 16:54 ` [PATCH 8/9] block: remove DISK_PITER_REVERSE Christoph Hellwig 2020-12-01 16:54 ` [dm-devel] " Christoph Hellwig 2020-12-02 23:15 ` Tejun Heo 2020-12-02 23:15 ` [dm-devel] " Tejun Heo 2020-12-01 16:54 ` [PATCH 9/9] block: use an xarray for disk->part_tbl Christoph Hellwig 2020-12-01 16:54 ` [dm-devel] " Christoph Hellwig 2020-12-02 23:22 ` Tejun Heo 2020-12-02 23:22 ` [dm-devel] " Tejun Heo 2020-12-02 22:35 ` store a pointer to the block_device in struct bio (again) Tejun Heo 2020-12-02 22:35 ` [dm-devel] " Tejun Heo 2020-12-02 22:37 ` Tejun Heo 2020-12-02 22:37 ` [dm-devel] " Tejun Heo 2020-12-04 16:43 ` Jens Axboe 2020-12-04 16:43 ` [dm-devel] " Jens Axboe 2020-12-07 18:56 ` Qian Cai 2020-12-07 18:56 ` [dm-devel] " Qian Cai 2020-12-07 19:01 ` Christoph Hellwig 2020-12-07 19:01 ` [dm-devel] " Christoph Hellwig 2020-12-07 20:20 ` Jens Axboe 2020-12-07 20:20 ` [dm-devel] " Jens Axboe 2020-12-08 11:04 ` Christoph Hellwig 2020-12-08 11:04 ` [dm-devel] " Christoph Hellwig 2020-12-08 13:08 ` Qian Cai 2020-12-08 13:08 ` [dm-devel] " Qian Cai 2020-12-08 13:38 ` Daniel Wagner 2020-12-08 13:38 ` [dm-devel] " Daniel Wagner 2020-12-08 14:15 ` Jens Axboe 2020-12-08 14:15 ` [dm-devel] " Jens Axboe
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201201165424.2030647-2-hch@lst.de \ --to=hch@lst.de \ --cc=axboe@kernel.dk \ --cc=colyli@suse.de \ --cc=dm-devel@redhat.com \ --cc=linux-bcache@vger.kernel.org \ --cc=linux-block@vger.kernel.org \ --cc=linux-raid@vger.kernel.org \ --cc=linux-s390@vger.kernel.org \ --cc=song@kernel.org \ --cc=tj@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.