All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>, Coly Li <colyli@suse.de>,
	Song Liu <song@kernel.org>,
	dm-devel@redhat.com, linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org, linux-s390@vger.kernel.org,
	linux-block@vger.kernel.org
Subject: Re: store a pointer to the block_device in struct bio (again)
Date: Wed, 2 Dec 2020 17:37:03 -0500	[thread overview]
Message-ID: <X8gXDx0DU+sqJoPc@mtj.duckdns.org> (raw)
In-Reply-To: <X8gWqZ6li+CvgF4i@mtj.duckdns.org>

On Wed, Dec 02, 2020 at 05:35:21PM -0500, Tejun Heo wrote:
> On Tue, Dec 01, 2020 at 05:54:15PM +0100, Christoph Hellwig wrote:
> > Hi Jens,
> > 
> > this series switches back from storing the gendisk + partno to storing
> > a block_device pointer in struct bio.  The reason is two fold:  for one
> > the new struct block_device actually is always available, removing the
> > need to avoid originally.  Second the merge struct block_device is much
> > more useful than the old one, as storing it avoids the need for looking
> > up what used to be hd_struct during partition remapping and I/O
> > accounting.
> > 
> > Note that this series depends on the posted but not merged
> > "block tracepoint cleanups" series.
> 
> I'm late but everything looks good to me. So much better than the mess we
> had before. Thank you.
> 
> The only thing I noticed is that blkdev_get_no_open() can now use
> kobject_get() instead of kobject_get_unless_zero() as bdev lookup is
> synchronously disabled before device_del().

Oops, sorry, this was supposed to be a reply to the earlier hd_struct
removal patchset. Reviewing this patchset now.

Thanks.

-- 
tejun

WARNING: multiple messages have this Message-ID (diff)
From: Tejun Heo <tj@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>,
	linux-s390@vger.kernel.org, linux-bcache@vger.kernel.org,
	Coly Li <colyli@suse.de>,
	linux-raid@vger.kernel.org, Song Liu <song@kernel.org>,
	dm-devel@redhat.com, linux-block@vger.kernel.org
Subject: Re: [dm-devel] store a pointer to the block_device in struct bio (again)
Date: Wed, 2 Dec 2020 17:37:03 -0500	[thread overview]
Message-ID: <X8gXDx0DU+sqJoPc@mtj.duckdns.org> (raw)
In-Reply-To: <X8gWqZ6li+CvgF4i@mtj.duckdns.org>

On Wed, Dec 02, 2020 at 05:35:21PM -0500, Tejun Heo wrote:
> On Tue, Dec 01, 2020 at 05:54:15PM +0100, Christoph Hellwig wrote:
> > Hi Jens,
> > 
> > this series switches back from storing the gendisk + partno to storing
> > a block_device pointer in struct bio.  The reason is two fold:  for one
> > the new struct block_device actually is always available, removing the
> > need to avoid originally.  Second the merge struct block_device is much
> > more useful than the old one, as storing it avoids the need for looking
> > up what used to be hd_struct during partition remapping and I/O
> > accounting.
> > 
> > Note that this series depends on the posted but not merged
> > "block tracepoint cleanups" series.
> 
> I'm late but everything looks good to me. So much better than the mess we
> had before. Thank you.
> 
> The only thing I noticed is that blkdev_get_no_open() can now use
> kobject_get() instead of kobject_get_unless_zero() as bdev lookup is
> synchronously disabled before device_del().

Oops, sorry, this was supposed to be a reply to the earlier hd_struct
removal patchset. Reviewing this patchset now.

Thanks.

-- 
tejun

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel


  reply	other threads:[~2020-12-02 22:47 UTC|newest]

Thread overview: 68+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-01 16:54 store a pointer to the block_device in struct bio (again) Christoph Hellwig
2020-12-01 16:54 ` [dm-devel] " Christoph Hellwig
2020-12-01 16:54 ` [PATCH 1/9] brd: remove the end of device check in brd_do_bvec Christoph Hellwig
2020-12-01 16:54   ` [dm-devel] " Christoph Hellwig
2020-12-02 22:39   ` Tejun Heo
2020-12-02 22:39     ` [dm-devel] " Tejun Heo
2020-12-01 16:54 ` [PATCH 2/9] dcssblk: " Christoph Hellwig
2020-12-01 16:54   ` [dm-devel] " Christoph Hellwig
2020-12-02 22:39   ` Tejun Heo
2020-12-02 22:39     ` [dm-devel] " Tejun Heo
2020-12-01 16:54 ` [PATCH 3/9] block: store a block_device pointer in struct bio Christoph Hellwig
2020-12-01 16:54   ` [dm-devel] " Christoph Hellwig
2020-12-02 22:54   ` Tejun Heo
2020-12-02 22:54     ` [dm-devel] " Tejun Heo
2020-12-03  6:39   ` Ming Lei
2020-12-03  6:39     ` [dm-devel] " Ming Lei
2020-12-03  7:10     ` Ming Lei
2020-12-03  7:10       ` [dm-devel] " Ming Lei
2020-12-03  8:29       ` Christoph Hellwig
2020-12-03  8:29         ` [dm-devel] " Christoph Hellwig
2020-12-03  9:32         ` Ming Lei
2020-12-03  9:32           ` [dm-devel] " Ming Lei
2020-12-03 20:53   ` Keith Busch
2020-12-03 20:53     ` [dm-devel] " Keith Busch
2020-12-01 16:54 ` [PATCH 4/9] block: simplify submit_bio_checks a bit Christoph Hellwig
2020-12-01 16:54   ` [dm-devel] " Christoph Hellwig
2020-12-02 22:55   ` Tejun Heo
2020-12-02 22:55     ` [dm-devel] " Tejun Heo
2020-12-01 16:54 ` [PATCH 5/9] block: use ->bi_bdev for bio based I/O accounting Christoph Hellwig
2020-12-01 16:54   ` [dm-devel] " Christoph Hellwig
2020-12-02 23:05   ` Tejun Heo
2020-12-02 23:05     ` [dm-devel] " Tejun Heo
2020-12-01 16:54 ` [PATCH 6/9] blk-mq: use ->bi_bdev for " Christoph Hellwig
2020-12-01 16:54   ` [dm-devel] " Christoph Hellwig
2020-12-02 23:06   ` Tejun Heo
2020-12-02 23:06     ` [dm-devel] " Tejun Heo
2020-12-01 16:54 ` [PATCH 7/9] block: add a disk_uevent helper Christoph Hellwig
2020-12-01 16:54   ` [dm-devel] " Christoph Hellwig
2020-12-02 23:08   ` Tejun Heo
2020-12-02 23:08     ` [dm-devel] " Tejun Heo
2020-12-01 16:54 ` [PATCH 8/9] block: remove DISK_PITER_REVERSE Christoph Hellwig
2020-12-01 16:54   ` [dm-devel] " Christoph Hellwig
2020-12-02 23:15   ` Tejun Heo
2020-12-02 23:15     ` [dm-devel] " Tejun Heo
2020-12-01 16:54 ` [PATCH 9/9] block: use an xarray for disk->part_tbl Christoph Hellwig
2020-12-01 16:54   ` [dm-devel] " Christoph Hellwig
2020-12-02 23:22   ` Tejun Heo
2020-12-02 23:22     ` [dm-devel] " Tejun Heo
2020-12-02 22:35 ` store a pointer to the block_device in struct bio (again) Tejun Heo
2020-12-02 22:35   ` [dm-devel] " Tejun Heo
2020-12-02 22:37   ` Tejun Heo [this message]
2020-12-02 22:37     ` Tejun Heo
2020-12-04 16:43 ` Jens Axboe
2020-12-04 16:43   ` [dm-devel] " Jens Axboe
2020-12-07 18:56 ` Qian Cai
2020-12-07 18:56   ` [dm-devel] " Qian Cai
2020-12-07 19:01   ` Christoph Hellwig
2020-12-07 19:01     ` [dm-devel] " Christoph Hellwig
2020-12-07 20:20     ` Jens Axboe
2020-12-07 20:20       ` [dm-devel] " Jens Axboe
2020-12-08 11:04   ` Christoph Hellwig
2020-12-08 11:04     ` [dm-devel] " Christoph Hellwig
2020-12-08 13:08     ` Qian Cai
2020-12-08 13:08       ` [dm-devel] " Qian Cai
2020-12-08 13:38     ` Daniel Wagner
2020-12-08 13:38       ` [dm-devel] " Daniel Wagner
2020-12-08 14:15     ` Jens Axboe
2020-12-08 14:15       ` [dm-devel] " Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=X8gXDx0DU+sqJoPc@mtj.duckdns.org \
    --to=tj@kernel.org \
    --cc=axboe@kernel.dk \
    --cc=colyli@suse.de \
    --cc=dm-devel@redhat.com \
    --cc=hch@lst.de \
    --cc=linux-bcache@vger.kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=song@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.