From: Colin King <colin.king@canonical.com> To: Nilesh Javali <njavali@marvell.com>, Manish Rangankar <mrangankar@marvell.com>, GR-QLogic-Storage-Upstream@marvell.com, "James E . J . Bottomley" <jejb@linux.ibm.com>, "Martin K . Petersen" <martin.petersen@oracle.com>, linux-scsi@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] scsi: qla4xxx: remove redundant assignment to variable rval Date: Fri, 4 Dec 2020 19:18:10 +0000 [thread overview] Message-ID: <20201204191810.1150995-1-colin.king@canonical.com> (raw) From: Colin Ian King <colin.king@canonical.com> The variable rval is being initialized with a value that is never read and it is being updated later with a new value. The initialization is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King <colin.king@canonical.com> --- drivers/scsi/qla4xxx/ql4_nx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qla4xxx/ql4_nx.c b/drivers/scsi/qla4xxx/ql4_nx.c index fd30fbd0d33c..e6e35e6958f6 100644 --- a/drivers/scsi/qla4xxx/ql4_nx.c +++ b/drivers/scsi/qla4xxx/ql4_nx.c @@ -1767,7 +1767,7 @@ qla4_82xx_start_firmware(struct scsi_qla_host *ha, uint32_t image_start) int qla4_82xx_try_start_fw(struct scsi_qla_host *ha) { - int rval = QLA_ERROR; + int rval; /* * FW Load priority: -- 2.29.2
WARNING: multiple messages have this Message-ID (diff)
From: Colin King <colin.king@canonical.com> To: Nilesh Javali <njavali@marvell.com>, Manish Rangankar <mrangankar@marvell.com>, GR-QLogic-Storage-Upstream@marvell.com, "James E . J . Bottomley" <jejb@linux.ibm.com>, "Martin K . Petersen" <martin.petersen@oracle.com>, linux-scsi@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] scsi: qla4xxx: remove redundant assignment to variable rval Date: Fri, 04 Dec 2020 19:18:10 +0000 [thread overview] Message-ID: <20201204191810.1150995-1-colin.king@canonical.com> (raw) In-Reply-To: <MW2PR07MB40429AAD3AC7C40972012788E3140@MW2PR07MB4042.namprd07.prod.outlook.com> From: Colin Ian King <colin.king@canonical.com> The variable rval is being initialized with a value that is never read and it is being updated later with a new value. The initialization is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King <colin.king@canonical.com> --- drivers/scsi/qla4xxx/ql4_nx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qla4xxx/ql4_nx.c b/drivers/scsi/qla4xxx/ql4_nx.c index fd30fbd0d33c..e6e35e6958f6 100644 --- a/drivers/scsi/qla4xxx/ql4_nx.c +++ b/drivers/scsi/qla4xxx/ql4_nx.c @@ -1767,7 +1767,7 @@ qla4_82xx_start_firmware(struct scsi_qla_host *ha, uint32_t image_start) int qla4_82xx_try_start_fw(struct scsi_qla_host *ha) { - int rval = QLA_ERROR; + int rval; /* * FW Load priority: -- 2.29.2
next reply other threads:[~2020-12-04 19:18 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-12-04 19:18 Colin King [this message] 2020-12-04 19:18 ` [PATCH] scsi: qla4xxx: remove redundant assignment to variable rval Colin King 2020-12-08 1:58 ` Martin K. Petersen 2020-12-08 1:58 ` Martin K. Petersen 2020-12-09 17:23 ` Martin K. Petersen 2020-12-09 17:23 ` Martin K. Petersen -- strict thread matches above, loose matches on Subject: below -- 2020-11-03 12:01 [PATCH] scsi: qla4xxx: Remove " Jing Xiangfeng 2020-11-17 5:53 ` Martin K. Petersen 2020-11-20 3:31 ` Martin K. Petersen 2018-09-26 13:08 [PATCH] scsi: qla4xxx: remove redundant check on drvr_wait Colin King 2018-09-26 13:08 ` Colin King 2018-09-27 11:15 ` Rangankar, Manish 2018-09-27 11:15 ` Rangankar, Manish 2018-09-27 11:15 ` Rangankar, Manish 2018-09-28 6:30 ` Martin K. Petersen 2018-09-28 6:30 ` Martin K. Petersen
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201204191810.1150995-1-colin.king@canonical.com \ --to=colin.king@canonical.com \ --cc=GR-QLogic-Storage-Upstream@marvell.com \ --cc=jejb@linux.ibm.com \ --cc=kernel-janitors@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-scsi@vger.kernel.org \ --cc=martin.petersen@oracle.com \ --cc=mrangankar@marvell.com \ --cc=njavali@marvell.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.