From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Colin King <colin.king@canonical.com>
Cc: Nilesh Javali <njavali@marvell.com>,
Manish Rangankar <mrangankar@marvell.com>,
GR-QLogic-Storage-Upstream@marvell.com,
"James E . J . Bottomley" <jejb@linux.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: qla4xxx: remove redundant assignment to variable rval
Date: Mon, 07 Dec 2020 20:58:39 -0500 [thread overview]
Message-ID: <yq1im9dys6v.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20201204191810.1150995-1-colin.king@canonical.com> (Colin King's message of "Fri, 4 Dec 2020 19:18:10 +0000")
Colin,
> The variable rval is being initialized with a value that is never read
> and it is being updated later with a new value. The initialization is
> redundant and can be removed.
Applied to 5.11/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
WARNING: multiple messages have this Message-ID (diff)
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Colin King <colin.king@canonical.com>
Cc: Nilesh Javali <njavali@marvell.com>,
Manish Rangankar <mrangankar@marvell.com>,
GR-QLogic-Storage-Upstream@marvell.com,
"James E . J . Bottomley" <jejb@linux.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: qla4xxx: remove redundant assignment to variable rval
Date: Tue, 08 Dec 2020 01:58:39 +0000 [thread overview]
Message-ID: <yq1im9dys6v.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20201204191810.1150995-1-colin.king@canonical.com> (Colin King's message of "Fri, 4 Dec 2020 19:18:10 +0000")
Colin,
> The variable rval is being initialized with a value that is never read
> and it is being updated later with a new value. The initialization is
> redundant and can be removed.
Applied to 5.11/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2020-12-08 1:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-04 19:18 [PATCH] scsi: qla4xxx: remove redundant assignment to variable rval Colin King
2020-12-04 19:18 ` Colin King
2020-12-08 1:58 ` Martin K. Petersen [this message]
2020-12-08 1:58 ` Martin K. Petersen
2020-12-09 17:23 ` Martin K. Petersen
2020-12-09 17:23 ` Martin K. Petersen
-- strict thread matches above, loose matches on Subject: below --
2020-11-03 12:01 [PATCH] scsi: qla4xxx: Remove " Jing Xiangfeng
2020-11-17 5:53 ` Martin K. Petersen
2020-11-20 3:31 ` Martin K. Petersen
2018-09-26 13:08 [PATCH] scsi: qla4xxx: remove redundant check on drvr_wait Colin King
2018-09-26 13:08 ` Colin King
2018-09-27 11:15 ` Rangankar, Manish
2018-09-27 11:15 ` Rangankar, Manish
2018-09-27 11:15 ` Rangankar, Manish
2018-09-28 6:30 ` Martin K. Petersen
2018-09-28 6:30 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1im9dys6v.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=GR-QLogic-Storage-Upstream@marvell.com \
--cc=colin.king@canonical.com \
--cc=jejb@linux.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mrangankar@marvell.com \
--cc=njavali@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.