From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Colin King <colin.king@canonical.com>
Cc: QLogic-Storage-Upstream@qlogic.com,
"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: qla4xxx: remove redundant check on drvr_wait
Date: Fri, 28 Sep 2018 02:30:51 -0400 [thread overview]
Message-ID: <yq18t3mb0bo.fsf@oracle.com> (raw)
In-Reply-To: <20180926130848.30645-1-colin.king@canonical.com> (Colin King's message of "Wed, 26 Sep 2018 14:08:48 +0100")
Colin,
> The check for a non-zero drvr_wait is redundant as the same check is
> performed earlier in the outer while loop, the inner check will always
> be true if we reached this point inside the while loop. Remove the
> redundant if check.
Applied to 4.20/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
WARNING: multiple messages have this Message-ID (diff)
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Colin King <colin.king@canonical.com>
Cc: QLogic-Storage-Upstream@qlogic.com,
"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: qla4xxx: remove redundant check on drvr_wait
Date: Fri, 28 Sep 2018 06:30:51 +0000 [thread overview]
Message-ID: <yq18t3mb0bo.fsf@oracle.com> (raw)
In-Reply-To: <20180926130848.30645-1-colin.king@canonical.com> (Colin King's message of "Wed, 26 Sep 2018 14:08:48 +0100")
Colin,
> The check for a non-zero drvr_wait is redundant as the same check is
> performed earlier in the outer while loop, the inner check will always
> be true if we reached this point inside the while loop. Remove the
> redundant if check.
Applied to 4.20/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2018-09-28 6:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-26 13:08 [PATCH] scsi: qla4xxx: remove redundant check on drvr_wait Colin King
2018-09-26 13:08 ` Colin King
2018-09-27 11:15 ` Rangankar, Manish
2018-09-27 11:15 ` Rangankar, Manish
2018-09-27 11:15 ` Rangankar, Manish
2018-09-28 6:30 ` Martin K. Petersen [this message]
2018-09-28 6:30 ` Martin K. Petersen
2020-12-04 19:18 [PATCH] scsi: qla4xxx: remove redundant assignment to variable rval Colin King
2020-12-04 19:18 ` Colin King
2020-12-08 1:58 ` Martin K. Petersen
2020-12-08 1:58 ` Martin K. Petersen
2020-12-09 17:23 ` Martin K. Petersen
2020-12-09 17:23 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq18t3mb0bo.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=QLogic-Storage-Upstream@qlogic.com \
--cc=colin.king@canonical.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.