[driver-core:driver-core-testing 22/33] drivers/of/property.c:1331:5-8: Unneeded variable: "ret". Return "0" on line 1343

[driver-core:driver-core-testing 22/33] drivers/of/property.c:1331:5-8: Unneeded variable: "ret". Return "0" on line 1343

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1148 bytes --]

CC: kbuild-all(a)lists.01.org
CC: devel(a)driverdev.osuosl.org
TO: Saravana Kannan <saravanak@google.com>
CC: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>

Hi Saravana,

First bad commit (maybe != root cause):

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git driver-core-testing
head:   3577afb0052fca65e67efdfc8e0859bb7bac87a6
commit: 8a06d1ea061739dd2e60aff3d64a58892e4031cf [22/33] of: property: Update implementation of add_links() to create fwnode links
:::::: branch date: 7 hours ago
:::::: commit date: 8 hours ago
config: arc-randconfig-c004-20201209 (attached as .config)
compiler: arceb-elf-gcc (GCC) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>


"coccinelle warnings: (new ones prefixed by >>)"
>> drivers/of/property.c:1331:5-8: Unneeded variable: "ret". Return "0" on line 1343

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 29065 bytes --]

[PATCH] of: property: fix returnvar.cocci warnings

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1842 bytes --]

CC: kbuild-all(a)lists.01.org
CC: devel(a)driverdev.osuosl.org
TO: Saravana Kannan <saravanak@google.com>
CC: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
CC: Rob Herring <robh+dt@kernel.org>
CC: Frank Rowand <frowand.list@gmail.com>
CC: devicetree(a)vger.kernel.org
CC: linux-kernel(a)vger.kernel.org

From: kernel test robot <lkp@intel.com>

drivers/of/property.c:1331:5-8: Unneeded variable: "ret". Return "0" on line 1343


 Remove unneeded variable used to store return value.

Generated by: scripts/coccinelle/misc/returnvar.cocci

Fixes: 8a06d1ea0617 ("of: property: Update implementation of add_links() to create fwnode links")
CC: Saravana Kannan <saravanak@google.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git driver-core-testing
head:   3577afb0052fca65e67efdfc8e0859bb7bac87a6
commit: 8a06d1ea061739dd2e60aff3d64a58892e4031cf [22/33] of: property: Update implementation of add_links() to create fwnode links
:::::: branch date: 7 hours ago
:::::: commit date: 8 hours ago

Please take the patch only if it's a positive warning. Thanks!

 property.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

--- a/drivers/of/property.c
+++ b/drivers/of/property.c
@@ -1328,7 +1328,6 @@ static int of_link_property(struct devic
 	const struct supplier_bindings *s = of_supplier_bindings;
 	unsigned int i = 0;
 	bool matched = false;
-	int ret = 0;
 
 	/* Do not stop at first failed link, link all available suppliers. */
 	while (!matched && s->parse_prop) {
@@ -1340,7 +1339,7 @@ static int of_link_property(struct devic
 		}
 		s++;
 	}
-	return ret;
+	return 0;
 }
 
 static int of_fwnode_add_links(struct fwnode_handle *fwnode)

[PATCH] of: property: fix returnvar.cocci warnings

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 2019 bytes --]

CC: kbuild-all(a)lists.01.org
In-Reply-To: <20201104232356.4038506-16-saravanak@google.com>
References: <20201104232356.4038506-16-saravanak@google.com>
TO: Saravana Kannan <saravanak@google.com>
TO: "Rafael J. Wysocki" <rjw@rjwysocki.net>
TO: Len Brown <lenb@kernel.org>
TO: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
TO: Ard Biesheuvel <ardb@kernel.org>
TO: Rob Herring <robh+dt@kernel.org>
TO: Frank Rowand <frowand.list@gmail.com>
TO: Marc Zyngier <maz@kernel.org>
TO: Thomas Gleixner <tglx@linutronix.de>
CC: Saravana Kannan <saravanak@google.com>
CC: Tomi Valkeinen <tomi.valkeinen@ti.com>

From: kernel test robot <lkp@intel.com>

drivers/of/property.c:1331:5-8: Unneeded variable: "ret". Return "0" on line 1343


 Remove unneeded variable used to store return value.

Generated by: scripts/coccinelle/misc/returnvar.cocci

CC: Saravana Kannan <saravanak@google.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

url:    https://github.com/0day-ci/linux/commits/Saravana-Kannan/Refactor-fw_devlink-to-significantly-improve-boot-time/20201105-072804
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git 3cea11cd5e3b00d91caf0b4730194039b45c5891
:::::: branch date: 5 days ago
:::::: commit date: 5 days ago

Please take the patch only if it's a positive warning. Thanks!

 property.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

--- a/drivers/of/property.c
+++ b/drivers/of/property.c
@@ -1328,7 +1328,6 @@ static int of_link_property(struct devic
 	const struct supplier_bindings *s = of_supplier_bindings;
 	unsigned int i = 0;
 	bool matched = false;
-	int ret = 0;
 
 	/* Do not stop at first failed link, link all available suppliers. */
 	while (!matched && s->parse_prop) {
@@ -1340,7 +1339,7 @@ static int of_link_property(struct devic
 		}
 		s++;
 	}
-	return ret;
+	return 0;
 }
 
 static int of_fwnode_add_links(struct fwnode_handle *fwnode,