* [linux-stable-rc:linux-4.19.y 5835/9999] arch/x86/kernel/cpu/mcheck/mce_amd.c:552:6: warning: no previous prototype for 'disable_err_thresholding'
@ 2021-01-19 17:36 kernel test robot
2021-01-19 17:41 ` Borislav Petkov
0 siblings, 1 reply; 6+ messages in thread
From: kernel test robot @ 2021-01-19 17:36 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 2706 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
head: e864f43593ccf9180c61738abdf1c1dde091367d
commit: 938de2324afb53acd20893cd8eec8ee6f80de646 [5835/9999] x86/MCE/AMD: Carve out the MC4_MISC thresholding quirk
config: i386-randconfig-r005-20210118 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
# https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/commit/?id=938de2324afb53acd20893cd8eec8ee6f80de646
git remote add linux-stable-rc https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
git fetch --no-tags linux-stable-rc linux-4.19.y
git checkout 938de2324afb53acd20893cd8eec8ee6f80de646
# save the attached .config to linux build tree
make W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> arch/x86/kernel/cpu/mcheck/mce_amd.c:552:6: warning: no previous prototype for 'disable_err_thresholding' [-Wmissing-prototypes]
552 | void disable_err_thresholding(struct cpuinfo_x86 *c)
| ^~~~~~~~~~~~~~~~~~~~~~~~
arch/x86/kernel/cpu/mcheck/mce_amd.c:864:39: warning: no previous prototype for 'smp_deferred_error_interrupt' [-Wmissing-prototypes]
864 | asmlinkage __visible void __irq_entry smp_deferred_error_interrupt(struct pt_regs *regs)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
vim +/disable_err_thresholding +552 arch/x86/kernel/cpu/mcheck/mce_amd.c
547
548 /*
549 * Turn off MC4_MISC thresholding banks on all family 0x15 models since
550 * they're not supported there.
551 */
> 552 void disable_err_thresholding(struct cpuinfo_x86 *c)
553 {
554 int i;
555 u64 hwcr;
556 bool need_toggle;
557 u32 msrs[] = {
558 0x00000413, /* MC4_MISC0 */
559 0xc0000408, /* MC4_MISC1 */
560 };
561
562 if (c->x86 != 0x15)
563 return;
564
565 rdmsrl(MSR_K7_HWCR, hwcr);
566
567 /* McStatusWrEn has to be set */
568 need_toggle = !(hwcr & BIT(18));
569
570 if (need_toggle)
571 wrmsrl(MSR_K7_HWCR, hwcr | BIT(18));
572
573 /* Clear CntP bit safely */
574 for (i = 0; i < ARRAY_SIZE(msrs); i++)
575 msr_clear_bit(msrs[i], 62);
576
577 /* restore old settings */
578 if (need_toggle)
579 wrmsrl(MSR_K7_HWCR, hwcr);
580 }
581
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 26467 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [linux-stable-rc:linux-4.19.y 5835/9999] arch/x86/kernel/cpu/mcheck/mce_amd.c:552:6: warning: no previous prototype for 'disable_err_thresholding'
2021-01-19 17:36 [linux-stable-rc:linux-4.19.y 5835/9999] arch/x86/kernel/cpu/mcheck/mce_amd.c:552:6: warning: no previous prototype for 'disable_err_thresholding' kernel test robot
@ 2021-01-19 17:41 ` Borislav Petkov
2021-01-20 11:01 ` Greg Kroah-Hartman
0 siblings, 1 reply; 6+ messages in thread
From: Borislav Petkov @ 2021-01-19 17:41 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 1764 bytes --]
On Wed, Jan 20, 2021 at 01:36:14AM +0800, kernel test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
> head: e864f43593ccf9180c61738abdf1c1dde091367d
> commit: 938de2324afb53acd20893cd8eec8ee6f80de646 [5835/9999] x86/MCE/AMD: Carve out the MC4_MISC thresholding quirk
> config: i386-randconfig-r005-20210118 (attached as .config)
> compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
> reproduce (this is a W=1 build):
> # https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/commit/?id=938de2324afb53acd20893cd8eec8ee6f80de646
> git remote add linux-stable-rc https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
> git fetch --no-tags linux-stable-rc linux-4.19.y
> git checkout 938de2324afb53acd20893cd8eec8ee6f80de646
> # save the attached .config to linux build tree
> make W=1 ARCH=i386
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All warnings (new ones prefixed by >>):
>
> >> arch/x86/kernel/cpu/mcheck/mce_amd.c:552:6: warning: no previous prototype for 'disable_err_thresholding' [-Wmissing-prototypes]
> 552 | void disable_err_thresholding(struct cpuinfo_x86 *c)
Why are you running W=1 build tests on stable kernels?
Especially -Wmissing-prototypes is a complete waste of time for those.
And the fix
47cd84e98f51 ("x86/mce/amd: Make disable_err_thresholding() static")
would be a complete waste of backporting bandwidth and it doesn't even
fit the stable rules.
--
Regards/Gruss,
Boris.
SUSE Software Solutions Germany GmbH, GF: Felix Imendörffer, HRB 36809, AG Nürnberg
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [linux-stable-rc:linux-4.19.y 5835/9999] arch/x86/kernel/cpu/mcheck/mce_amd.c:552:6: warning: no previous prototype for 'disable_err_thresholding'
2021-01-19 17:41 ` Borislav Petkov
@ 2021-01-20 11:01 ` Greg Kroah-Hartman
2021-01-21 9:38 ` Rong Chen
0 siblings, 1 reply; 6+ messages in thread
From: Greg Kroah-Hartman @ 2021-01-20 11:01 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 1917 bytes --]
On Tue, Jan 19, 2021 at 06:41:02PM +0100, Borislav Petkov wrote:
> On Wed, Jan 20, 2021 at 01:36:14AM +0800, kernel test robot wrote:
> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
> > head: e864f43593ccf9180c61738abdf1c1dde091367d
> > commit: 938de2324afb53acd20893cd8eec8ee6f80de646 [5835/9999] x86/MCE/AMD: Carve out the MC4_MISC thresholding quirk
> > config: i386-randconfig-r005-20210118 (attached as .config)
> > compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
> > reproduce (this is a W=1 build):
> > # https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/commit/?id=938de2324afb53acd20893cd8eec8ee6f80de646
> > git remote add linux-stable-rc https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
> > git fetch --no-tags linux-stable-rc linux-4.19.y
> > git checkout 938de2324afb53acd20893cd8eec8ee6f80de646
> > # save the attached .config to linux build tree
> > make W=1 ARCH=i386
> >
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <lkp@intel.com>
> >
> > All warnings (new ones prefixed by >>):
> >
> > >> arch/x86/kernel/cpu/mcheck/mce_amd.c:552:6: warning: no previous prototype for 'disable_err_thresholding' [-Wmissing-prototypes]
> > 552 | void disable_err_thresholding(struct cpuinfo_x86 *c)
>
> Why are you running W=1 build tests on stable kernels?
>
> Especially -Wmissing-prototypes is a complete waste of time for those.
>
> And the fix
>
> 47cd84e98f51 ("x86/mce/amd: Make disable_err_thresholding() static")
>
> would be a complete waste of backporting bandwidth and it doesn't even
> fit the stable rules.
I agree, this noisy checks should be verified that they actually are
pointing out a real issue before sending them out.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [linux-stable-rc:linux-4.19.y 5835/9999] arch/x86/kernel/cpu/mcheck/mce_amd.c:552:6: warning: no previous prototype for 'disable_err_thresholding'
2021-01-20 11:01 ` Greg Kroah-Hartman
@ 2021-01-21 9:38 ` Rong Chen
2021-01-21 10:39 ` Borislav Petkov
0 siblings, 1 reply; 6+ messages in thread
From: Rong Chen @ 2021-01-21 9:38 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 2093 bytes --]
On 1/20/21 7:01 PM, Greg Kroah-Hartman wrote:
> On Tue, Jan 19, 2021 at 06:41:02PM +0100, Borislav Petkov wrote:
>> On Wed, Jan 20, 2021 at 01:36:14AM +0800, kernel test robot wrote:
>>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
>>> head: e864f43593ccf9180c61738abdf1c1dde091367d
>>> commit: 938de2324afb53acd20893cd8eec8ee6f80de646 [5835/9999] x86/MCE/AMD: Carve out the MC4_MISC thresholding quirk
>>> config: i386-randconfig-r005-20210118 (attached as .config)
>>> compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
>>> reproduce (this is a W=1 build):
>>> # https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/commit/?id=938de2324afb53acd20893cd8eec8ee6f80de646
>>> git remote add linux-stable-rc https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
>>> git fetch --no-tags linux-stable-rc linux-4.19.y
>>> git checkout 938de2324afb53acd20893cd8eec8ee6f80de646
>>> # save the attached .config to linux build tree
>>> make W=1 ARCH=i386
>>>
>>> If you fix the issue, kindly add following tag as appropriate
>>> Reported-by: kernel test robot <lkp@intel.com>
>>>
>>> All warnings (new ones prefixed by >>):
>>>
>>>>> arch/x86/kernel/cpu/mcheck/mce_amd.c:552:6: warning: no previous prototype for 'disable_err_thresholding' [-Wmissing-prototypes]
>>> 552 | void disable_err_thresholding(struct cpuinfo_x86 *c)
>> Why are you running W=1 build tests on stable kernels?
>>
>> Especially -Wmissing-prototypes is a complete waste of time for those.
>>
>> And the fix
>>
>> 47cd84e98f51 ("x86/mce/amd: Make disable_err_thresholding() static")
>>
>> would be a complete waste of backporting bandwidth and it doesn't even
>> fit the stable rules.
> I agree, this noisy checks should be verified that they actually are
> pointing out a real issue before sending them out.
>
> thanks,
>
> greg k-h
Hi all,
Sorry for the noise, we'll disable W=1 for stable kernels firstly.
Best Regards,
Rong Chen
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [linux-stable-rc:linux-4.19.y 5835/9999] arch/x86/kernel/cpu/mcheck/mce_amd.c:552:6: warning: no previous prototype for 'disable_err_thresholding'
2021-01-21 9:38 ` Rong Chen
@ 2021-01-21 10:39 ` Borislav Petkov
2021-01-21 12:41 ` Philip Li
0 siblings, 1 reply; 6+ messages in thread
From: Borislav Petkov @ 2021-01-21 10:39 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 871 bytes --]
On Thu, Jan 21, 2021 at 05:38:55PM +0800, Rong Chen wrote:
> Sorry for the noise, we'll disable W=1 for stable kernels firstly.
Well, this is the thing: W=1 might make sense *sometimes* because it
enables a couple of warnings. One of them is -Wmissing-prototypes which
doesn't make sense for stable, as explained earlier.
So you need to either
* disable -Wmissing-prototypes only which means stable-specific patch
and stable folks don't like that.
or
* analyze the reports *before* sending them out. You could simply not
send reports which come solely from -Wmissing-prototypes warnings.
or
* patch the stable tree locally with your own patch
or
* ...
It all depends on what is done easier in your infra.
HTH.
--
Regards/Gruss,
Boris.
SUSE Software Solutions Germany GmbH, GF: Felix Imendörffer, HRB 36809, AG Nürnberg
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [linux-stable-rc:linux-4.19.y 5835/9999] arch/x86/kernel/cpu/mcheck/mce_amd.c:552:6: warning: no previous prototype for 'disable_err_thresholding'
2021-01-21 10:39 ` Borislav Petkov
@ 2021-01-21 12:41 ` Philip Li
0 siblings, 0 replies; 6+ messages in thread
From: Philip Li @ 2021-01-21 12:41 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 1424 bytes --]
On Thu, Jan 21, 2021 at 11:39:08AM +0100, Borislav Petkov wrote:
> On Thu, Jan 21, 2021 at 05:38:55PM +0800, Rong Chen wrote:
> > Sorry for the noise, we'll disable W=1 for stable kernels firstly.
>
> Well, this is the thing: W=1 might make sense *sometimes* because it
> enables a couple of warnings. One of them is -Wmissing-prototypes which
> doesn't make sense for stable, as explained earlier.
Thanks for the input, this helps and we can focus on this warning firstly
to reduce meaningless reports for stable.
>
> So you need to either
>
> * disable -Wmissing-prototypes only which means stable-specific patch
> and stable folks don't like that.
>
> or
>
> * analyze the reports *before* sending them out. You could simply not
> send reports which come solely from -Wmissing-prototypes warnings.
We will look into above 2 options to see which one is easiler to
fit what we have in place. Thanks for your suggestions.
>
> or
>
> * patch the stable tree locally with your own patch
>
> or
>
> * ...
>
> It all depends on what is done easier in your infra.
>
> HTH.
>
> --
> Regards/Gruss,
> Boris.
>
> SUSE Software Solutions Germany GmbH, GF: Felix Imendörffer, HRB 36809, AG Nürnberg
> _______________________________________________
> kbuild-all mailing list -- kbuild-all(a)lists.01.org
> To unsubscribe send an email to kbuild-all-leave(a)lists.01.org
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-01-21 12:41 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-19 17:36 [linux-stable-rc:linux-4.19.y 5835/9999] arch/x86/kernel/cpu/mcheck/mce_amd.c:552:6: warning: no previous prototype for 'disable_err_thresholding' kernel test robot
2021-01-19 17:41 ` Borislav Petkov
2021-01-20 11:01 ` Greg Kroah-Hartman
2021-01-21 9:38 ` Rong Chen
2021-01-21 10:39 ` Borislav Petkov
2021-01-21 12:41 ` Philip Li
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.