* hwmon: (nct6683) Support ASRock boards.
@ 2021-01-19 5:12 Blaž Hrastnik
2021-01-19 5:15 ` Blaž Hrastnik
2021-01-21 19:25 ` Guenter Roeck
0 siblings, 2 replies; 4+ messages in thread
From: Blaž Hrastnik @ 2021-01-19 5:12 UTC (permalink / raw)
To: Jean Delvare, Guenter Roeck, Jonathan Corbet, linux-hwmon,
linux-doc, linux-kernel
Tested with ASRock X570 Phantom Gaming-ITX/TB3. It also appears
on other ASRock boards.
Signed-off-by: Blaž Hrastnik <blaz@mxxn.io>
---
Documentation/hwmon/nct6683.rst | 1 +
drivers/hwmon/nct6683.c | 3 +++
2 files changed, 4 insertions(+)
diff --git a/Documentation/hwmon/nct6683.rst b/Documentation/hwmon/nct6683.rst
index 8646ad519..2e1408d17 100644
--- a/Documentation/hwmon/nct6683.rst
+++ b/Documentation/hwmon/nct6683.rst
@@ -61,5 +61,6 @@ Board Firmware version
Intel DH87RL NCT6683D EC firmware version 1.0 build 04/03/13
Intel DH87MC NCT6683D EC firmware version 1.0 build 04/03/13
Intel DB85FL NCT6683D EC firmware version 1.0 build 04/03/13
+ASRock X570 NCT6683D EC firmware version 1.0 build 06/28/19
MSI B550 NCT6687D EC firmware version 1.0 build 05/07/20
=============== ===============================================
diff --git a/drivers/hwmon/nct6683.c b/drivers/hwmon/nct6683.c
index 7f7e30f0d..a23047a3b 100644
--- a/drivers/hwmon/nct6683.c
+++ b/drivers/hwmon/nct6683.c
@@ -169,6 +169,7 @@ superio_exit(int ioreg)
#define NCT6683_CUSTOMER_ID_INTEL 0x805
#define NCT6683_CUSTOMER_ID_MITAC 0xa0e
#define NCT6683_CUSTOMER_ID_MSI 0x201
+#define NCT6683_CUSTOMER_ID_ASROCK 0xe2c
#define NCT6683_REG_BUILD_YEAR 0x604
#define NCT6683_REG_BUILD_MONTH 0x605
@@ -1225,6 +1226,8 @@ static int nct6683_probe(struct platform_device *pdev)
break;
case NCT6683_CUSTOMER_ID_MSI:
break;
+ case NCT6683_CUSTOMER_ID_ASROCK:
+ break;
default:
if (!force)
return -ENODEV;
--
2.29.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: hwmon: (nct6683) Support ASRock boards.
2021-01-19 5:12 hwmon: (nct6683) Support ASRock boards Blaž Hrastnik
@ 2021-01-19 5:15 ` Blaž Hrastnik
2021-01-19 5:49 ` Guenter Roeck
2021-01-21 19:25 ` Guenter Roeck
1 sibling, 1 reply; 4+ messages in thread
From: Blaž Hrastnik @ 2021-01-19 5:15 UTC (permalink / raw)
To: Jean Delvare, Guenter Roeck, Jonathan Corbet, linux-hwmon,
linux-doc, lkml
Cc: David Bartley
(cc-ing David Bartley, who wrote the MSI patch)
I had a follow-up question: I noticed that support for MSI was added in
December, but there's this conditional that wasn't changed:
/* Only update pwm values for Mitac boards */
if (data->customer_id == NCT6683_CUSTOMER_ID_MITAC)
return attr->mode | S_IWUSR;
Should this continue to only apply for Mitac boards, or should it be changed to
!= NCT6683_CUSTOMER_ID_INTEL?
Blaž
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: hwmon: (nct6683) Support ASRock boards.
2021-01-19 5:15 ` Blaž Hrastnik
@ 2021-01-19 5:49 ` Guenter Roeck
0 siblings, 0 replies; 4+ messages in thread
From: Guenter Roeck @ 2021-01-19 5:49 UTC (permalink / raw)
To: Blaž Hrastnik, Jean Delvare, Jonathan Corbet, linux-hwmon,
linux-doc, lkml
Cc: David Bartley
On 1/18/21 9:15 PM, Blaž Hrastnik wrote:
> (cc-ing David Bartley, who wrote the MSI patch)
>
> I had a follow-up question: I noticed that support for MSI was added in
> December, but there's this conditional that wasn't changed:
>
> /* Only update pwm values for Mitac boards */
> if (data->customer_id == NCT6683_CUSTOMER_ID_MITAC)
> return attr->mode | S_IWUSR;
>
> Should this continue to only apply for Mitac boards, or should it be changed to
> != NCT6683_CUSTOMER_ID_INTEL?
>
No, this has to be tested explicitly for each vendor.
Guenter
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: hwmon: (nct6683) Support ASRock boards.
2021-01-19 5:12 hwmon: (nct6683) Support ASRock boards Blaž Hrastnik
2021-01-19 5:15 ` Blaž Hrastnik
@ 2021-01-21 19:25 ` Guenter Roeck
1 sibling, 0 replies; 4+ messages in thread
From: Guenter Roeck @ 2021-01-21 19:25 UTC (permalink / raw)
To: Blaž Hrastnik
Cc: Jean Delvare, Jonathan Corbet, linux-hwmon, linux-doc, linux-kernel
On Tue, Jan 19, 2021 at 02:12:41PM +0900, Blaž Hrastnik wrote:
> Tested with ASRock X570 Phantom Gaming-ITX/TB3. It also appears
> on other ASRock boards.
>
> Signed-off-by: Blaž Hrastnik <blaz@mxxn.io>
Applied.
Thanks,
Guenter
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-01-21 19:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-19 5:12 hwmon: (nct6683) Support ASRock boards Blaž Hrastnik
2021-01-19 5:15 ` Blaž Hrastnik
2021-01-19 5:49 ` Guenter Roeck
2021-01-21 19:25 ` Guenter Roeck
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.