All of lore.kernel.org
 help / color / mirror / Atom feed
From: <kostap@marvell.com>
To: <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>
Cc: <linux@armlinux.org.uk>, <robh+dt@kernel.org>,
	<sebastian.hesselbarth@gmail.com>, <gregory.clement@bootlin.com>,
	<andrew@lunn.ch>, <mw@semihalf.com>, <jaz@semihalf.com>,
	<nadavh@marvell.com>, <stefanc@marvell.com>, <bpeled@marvell.com>,
	"Konstantin Porotchkin" <kostap@marvell.com>
Subject: [PATCH 02/11] dts: mvebu: Update A8K AP806 SDHCI settings
Date: Wed, 3 Feb 2021 15:31:29 +0200	[thread overview]
Message-ID: <20210203133138.10754-3-kostap@marvell.com> (raw)
In-Reply-To: <20210203133138.10754-1-kostap@marvell.com>

From: Konstantin Porotchkin <kostap@marvell.com>

Update the settings for AP806 SDHCI interface according to
latest Xenon drivers changes.
- no need to select the PHY slow mode anymore
- recommended to add HS400 support at 1.8V signalling on AP806-B0
- fix the bus witdth for A8040 DB from 4 to 8 bits.

Signed-off-by: Konstantin Porotchkin <kostap@marvell.com>
---
 arch/arm64/boot/dts/marvell/armada-8040-db.dts     | 11 ++++++++++-
 arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi |  5 -----
 arch/arm64/boot/dts/marvell/armada-ap80x.dtsi      |  1 -
 3 files changed, 10 insertions(+), 7 deletions(-)

diff --git a/arch/arm64/boot/dts/marvell/armada-8040-db.dts b/arch/arm64/boot/dts/marvell/armada-8040-db.dts
index 09fb5256f1db..6362e654a823 100644
--- a/arch/arm64/boot/dts/marvell/armada-8040-db.dts
+++ b/arch/arm64/boot/dts/marvell/armada-8040-db.dts
@@ -347,7 +347,16 @@
 
 &ap_sdhci0 {
 	status = "okay";
-	bus-width = <4>;
+	bus-width = <8>;
+	/* The below property should be added to boards with AP806-B0
+	 * for enabling HS400 speed mode. Otherwise the device highest
+	 * speed mode will be HS200.
+	 * Should not be added to boards with earlier release of AP806
+	 * since it will cause SDHCI driver to fail upon initialization.
+	 * Reference - HWE-7296210 (errata for releases A0/A1/A2)
+	 *
+	 * mmc-hs400-1_8v;
+	 */
 	non-removable;
 };
 
diff --git a/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi b/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi
index 73733b4126e2..69653de998e2 100644
--- a/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi
+++ b/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi
@@ -109,11 +109,6 @@
 
 &ap_sdhci0 {
 	bus-width = <8>;
-	/*
-	 * Not stable in HS modes - phy needs "more calibration", so add
-	 * the "slow-mode" and disable SDR104, SDR50 and DDR50 modes.
-	 */
-	marvell,xenon-phy-slow-mode;
 	no-1-8-v;
 	no-sd;
 	no-sdio;
diff --git a/arch/arm64/boot/dts/marvell/armada-ap80x.dtsi b/arch/arm64/boot/dts/marvell/armada-ap80x.dtsi
index 12e477f1aeb9..edd6131a0587 100644
--- a/arch/arm64/boot/dts/marvell/armada-ap80x.dtsi
+++ b/arch/arm64/boot/dts/marvell/armada-ap80x.dtsi
@@ -257,7 +257,6 @@
 				clock-names = "core";
 				clocks = <&ap_clk 4>;
 				dma-coherent;
-				marvell,xenon-phy-slow-mode;
 				status = "disabled";
 			};
 
-- 
2.17.1


WARNING: multiple messages have this Message-ID (diff)
From: <kostap@marvell.com>
To: <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>
Cc: andrew@lunn.ch, jaz@semihalf.com, gregory.clement@bootlin.com,
	linux@armlinux.org.uk, nadavh@marvell.com, robh+dt@kernel.org,
	Konstantin Porotchkin <kostap@marvell.com>,
	stefanc@marvell.com, mw@semihalf.com, bpeled@marvell.com,
	sebastian.hesselbarth@gmail.com
Subject: [PATCH 02/11] dts: mvebu: Update A8K AP806 SDHCI settings
Date: Wed, 3 Feb 2021 15:31:29 +0200	[thread overview]
Message-ID: <20210203133138.10754-3-kostap@marvell.com> (raw)
In-Reply-To: <20210203133138.10754-1-kostap@marvell.com>

From: Konstantin Porotchkin <kostap@marvell.com>

Update the settings for AP806 SDHCI interface according to
latest Xenon drivers changes.
- no need to select the PHY slow mode anymore
- recommended to add HS400 support at 1.8V signalling on AP806-B0
- fix the bus witdth for A8040 DB from 4 to 8 bits.

Signed-off-by: Konstantin Porotchkin <kostap@marvell.com>
---
 arch/arm64/boot/dts/marvell/armada-8040-db.dts     | 11 ++++++++++-
 arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi |  5 -----
 arch/arm64/boot/dts/marvell/armada-ap80x.dtsi      |  1 -
 3 files changed, 10 insertions(+), 7 deletions(-)

diff --git a/arch/arm64/boot/dts/marvell/armada-8040-db.dts b/arch/arm64/boot/dts/marvell/armada-8040-db.dts
index 09fb5256f1db..6362e654a823 100644
--- a/arch/arm64/boot/dts/marvell/armada-8040-db.dts
+++ b/arch/arm64/boot/dts/marvell/armada-8040-db.dts
@@ -347,7 +347,16 @@
 
 &ap_sdhci0 {
 	status = "okay";
-	bus-width = <4>;
+	bus-width = <8>;
+	/* The below property should be added to boards with AP806-B0
+	 * for enabling HS400 speed mode. Otherwise the device highest
+	 * speed mode will be HS200.
+	 * Should not be added to boards with earlier release of AP806
+	 * since it will cause SDHCI driver to fail upon initialization.
+	 * Reference - HWE-7296210 (errata for releases A0/A1/A2)
+	 *
+	 * mmc-hs400-1_8v;
+	 */
 	non-removable;
 };
 
diff --git a/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi b/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi
index 73733b4126e2..69653de998e2 100644
--- a/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi
+++ b/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi
@@ -109,11 +109,6 @@
 
 &ap_sdhci0 {
 	bus-width = <8>;
-	/*
-	 * Not stable in HS modes - phy needs "more calibration", so add
-	 * the "slow-mode" and disable SDR104, SDR50 and DDR50 modes.
-	 */
-	marvell,xenon-phy-slow-mode;
 	no-1-8-v;
 	no-sd;
 	no-sdio;
diff --git a/arch/arm64/boot/dts/marvell/armada-ap80x.dtsi b/arch/arm64/boot/dts/marvell/armada-ap80x.dtsi
index 12e477f1aeb9..edd6131a0587 100644
--- a/arch/arm64/boot/dts/marvell/armada-ap80x.dtsi
+++ b/arch/arm64/boot/dts/marvell/armada-ap80x.dtsi
@@ -257,7 +257,6 @@
 				clock-names = "core";
 				clocks = <&ap_clk 4>;
 				dma-coherent;
-				marvell,xenon-phy-slow-mode;
 				status = "disabled";
 			};
 
-- 
2.17.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2021-02-03 13:42 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-03 13:31 [PATCH 00/11] Device tree fixes for Armada family kostap
2021-02-03 13:31 ` kostap
2021-02-03 13:31 ` [PATCH 01/11] fix: arm64: dts: replace wrong regulator on ap emmc kostap
2021-02-03 13:31   ` kostap
2021-02-03 13:31 ` kostap [this message]
2021-02-03 13:31   ` [PATCH 02/11] dts: mvebu: Update A8K AP806 SDHCI settings kostap
2021-02-03 13:58   ` Baruch Siach
2021-02-03 13:58     ` Baruch Siach
2021-02-03 14:37     ` [EXT] " Kostya Porotchkin
2021-02-03 14:37       ` Kostya Porotchkin
2021-02-03 14:38       ` Russell King - ARM Linux admin
2021-02-03 14:38         ` Russell King - ARM Linux admin
2021-02-03 14:50         ` Kostya Porotchkin
2021-02-03 14:50           ` Kostya Porotchkin
2021-02-03 15:03           ` Kostya Porotchkin
2021-02-03 15:03             ` Kostya Porotchkin
2021-02-03 16:11           ` Russell King - ARM Linux admin
2021-02-03 16:11             ` Russell King - ARM Linux admin
2021-02-03 16:57             ` Kostya Porotchkin
2021-02-03 16:57               ` Kostya Porotchkin
2021-02-05  9:33               ` Marcin Wojtas
2021-02-05  9:33                 ` Marcin Wojtas
2021-02-03 13:31 ` [PATCH 03/11] dts: mvebu: Add pin control definitions for SDIO interafce kostap
2021-02-03 13:31   ` kostap
2021-02-03 14:00   ` Baruch Siach
2021-02-03 14:00     ` Baruch Siach
2021-02-03 14:39     ` [EXT] " Kostya Porotchkin
2021-02-03 14:39       ` Kostya Porotchkin
2021-02-03 14:28   ` Russell King - ARM Linux admin
2021-02-03 14:28     ` Russell King - ARM Linux admin
2021-02-03 14:41     ` [EXT] " Kostya Porotchkin
2021-02-03 14:41       ` Kostya Porotchkin
2021-02-03 15:41       ` Andrew Lunn
2021-02-03 15:41         ` Andrew Lunn
2021-02-03 15:49         ` Kostya Porotchkin
2021-02-03 15:49           ` Kostya Porotchkin
2021-02-03 13:31 ` [PATCH 04/11] fix: dts: a8k: Add CP eMMC regulator and update device parameters kostap
2021-02-03 13:31   ` kostap
2021-02-03 13:31 ` [PATCH 05/11] arm64: dts: marvell: armada-3720-db: add comphy references kostap
2021-02-03 13:31   ` kostap
2021-02-03 13:31 ` [PATCH 06/11] arm64: dts: marvell: armada-3270-espressobin: " kostap
2021-02-03 13:31   ` kostap
2021-02-03 13:31 ` [PATCH 07/11] fix: ARM64: dts: cp110: Switch to 8-bit ECC NAND setting kostap
2021-02-03 13:31   ` kostap
2021-02-03 13:31 ` [PATCH 08/11] arm64: dts: marvell: armada-3720-db: add eeprom description kostap
2021-02-03 13:31   ` kostap
2021-02-03 13:31 ` [PATCH 09/11] dts: a3700: enable dma coherence for PCIE interface kostap
2021-02-03 13:31   ` kostap
2021-02-05  9:45   ` Marcin Wojtas
2021-02-05  9:45     ` Marcin Wojtas
2021-02-03 13:31 ` [PATCH 10/11] dts: marvell: add 2 eeprom properties to A8K DB device tree kostap
2021-02-03 13:31   ` kostap
2021-02-03 13:31 ` [PATCH 11/11] dts: marvell: add 2 eeprom properties to A7K " kostap
2021-02-03 13:31   ` kostap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210203133138.10754-3-kostap@marvell.com \
    --to=kostap@marvell.com \
    --cc=andrew@lunn.ch \
    --cc=bpeled@marvell.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gregory.clement@bootlin.com \
    --cc=jaz@semihalf.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mw@semihalf.com \
    --cc=nadavh@marvell.com \
    --cc=robh+dt@kernel.org \
    --cc=sebastian.hesselbarth@gmail.com \
    --cc=stefanc@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.