All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcin Wojtas <mw@semihalf.com>
To: Kostya Porotchkin <kostap@marvell.com>
Cc: "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	"Russell King - ARM Linux" <linux@armlinux.org.uk>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Sebastian Hesselbarth" <sebastian.hesselbarth@gmail.com>,
	"Grégory Clement" <gregory.clement@bootlin.com>,
	"Andrew Lunn" <andrew@lunn.ch>,
	"Grzegorz Jaszczyk" <jaz@semihalf.com>,
	nadavh@marvell.com, "Stefan Chulski" <stefanc@marvell.com>,
	"Ben Peled (בן פלד)" <bpeled@marvell.com>
Subject: Re: [PATCH 09/11] dts: a3700: enable dma coherence for PCIE interface
Date: Fri, 5 Feb 2021 10:45:32 +0100	[thread overview]
Message-ID: <CAPv3WKcuOXdN4zRSaGm1RnaBaXLsCtuT7CRMBAPDFvnBL76oEw@mail.gmail.com> (raw)
In-Reply-To: <20210203133138.10754-10-kostap@marvell.com>

Hi Kosta,

śr., 3 lut 2021 o 14:32 <kostap@marvell.com> napisał(a):
>
> From: Stefan Chulski <stefanc@marvell.com>
>
> Enavble PCIe dma coherence for A3700 platform
>

While at it, can we also add:

--- a/arch/arm64/boot/dts/marvell/armada-37xx.dtsi
+++ b/arch/arm64/boot/dts/marvell/armada-37xx.dtsi
@@ -71,6 +71,7 @@ soc {
                compatible = "simple-bus";
                #address-cells = <2>;
                #size-cells = <2>;
+               dma-coherent;
                ranges;

                internal-regs@d0000000 {

so that to enable it for all bus-attached interfaces? This safe and
will boost IO performance.

Thanks,
Marcin

> Signed-off-by: Stefan Chulski <stefanc@marvell.com>
> Signed-off-by: Konstantin Porotchkin <kostap@marvell.com>
> ---
>  arch/arm64/boot/dts/marvell/armada-37xx.dtsi | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-37xx.dtsi b/arch/arm64/boot/dts/marvell/armada-37xx.dtsi
> index d5b6c0a1c54a..5c0df06bc707 100644
> --- a/arch/arm64/boot/dts/marvell/armada-37xx.dtsi
> +++ b/arch/arm64/boot/dts/marvell/armada-37xx.dtsi
> @@ -486,6 +486,7 @@
>                         #interrupt-cells = <1>;
>                         msi-parent = <&pcie0>;
>                         msi-controller;
> +                       dma-coherent;
>                         ranges = <0x82000000 0 0xe8000000   0 0xe8000000 0 0x1000000 /* Port 0 MEM */
>                                   0x81000000 0 0xe9000000   0 0xe9000000 0 0x10000>; /* Port 0 IO*/
>                         interrupt-map-mask = <0 0 0 7>;
> --
> 2.17.1
>

WARNING: multiple messages have this Message-ID (diff)
From: Marcin Wojtas <mw@semihalf.com>
To: Kostya Porotchkin <kostap@marvell.com>
Cc: devicetree@vger.kernel.org, "Andrew Lunn" <andrew@lunn.ch>,
	"Grzegorz Jaszczyk" <jaz@semihalf.com>,
	"Grégory Clement" <gregory.clement@bootlin.com>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	"Russell King - ARM Linux" <linux@armlinux.org.uk>,
	nadavh@marvell.com, "Rob Herring" <robh+dt@kernel.org>,
	"Stefan Chulski" <stefanc@marvell.com>,
	"Ben Peled (בן פלד)" <bpeled@marvell.com>,
	linux-arm-kernel@lists.infradead.org,
	"Sebastian Hesselbarth" <sebastian.hesselbarth@gmail.com>
Subject: Re: [PATCH 09/11] dts: a3700: enable dma coherence for PCIE interface
Date: Fri, 5 Feb 2021 10:45:32 +0100	[thread overview]
Message-ID: <CAPv3WKcuOXdN4zRSaGm1RnaBaXLsCtuT7CRMBAPDFvnBL76oEw@mail.gmail.com> (raw)
In-Reply-To: <20210203133138.10754-10-kostap@marvell.com>

Hi Kosta,

śr., 3 lut 2021 o 14:32 <kostap@marvell.com> napisał(a):
>
> From: Stefan Chulski <stefanc@marvell.com>
>
> Enavble PCIe dma coherence for A3700 platform
>

While at it, can we also add:

--- a/arch/arm64/boot/dts/marvell/armada-37xx.dtsi
+++ b/arch/arm64/boot/dts/marvell/armada-37xx.dtsi
@@ -71,6 +71,7 @@ soc {
                compatible = "simple-bus";
                #address-cells = <2>;
                #size-cells = <2>;
+               dma-coherent;
                ranges;

                internal-regs@d0000000 {

so that to enable it for all bus-attached interfaces? This safe and
will boost IO performance.

Thanks,
Marcin

> Signed-off-by: Stefan Chulski <stefanc@marvell.com>
> Signed-off-by: Konstantin Porotchkin <kostap@marvell.com>
> ---
>  arch/arm64/boot/dts/marvell/armada-37xx.dtsi | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-37xx.dtsi b/arch/arm64/boot/dts/marvell/armada-37xx.dtsi
> index d5b6c0a1c54a..5c0df06bc707 100644
> --- a/arch/arm64/boot/dts/marvell/armada-37xx.dtsi
> +++ b/arch/arm64/boot/dts/marvell/armada-37xx.dtsi
> @@ -486,6 +486,7 @@
>                         #interrupt-cells = <1>;
>                         msi-parent = <&pcie0>;
>                         msi-controller;
> +                       dma-coherent;
>                         ranges = <0x82000000 0 0xe8000000   0 0xe8000000 0 0x1000000 /* Port 0 MEM */
>                                   0x81000000 0 0xe9000000   0 0xe9000000 0 0x10000>; /* Port 0 IO*/
>                         interrupt-map-mask = <0 0 0 7>;
> --
> 2.17.1
>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-02-05  9:54 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-03 13:31 [PATCH 00/11] Device tree fixes for Armada family kostap
2021-02-03 13:31 ` kostap
2021-02-03 13:31 ` [PATCH 01/11] fix: arm64: dts: replace wrong regulator on ap emmc kostap
2021-02-03 13:31   ` kostap
2021-02-03 13:31 ` [PATCH 02/11] dts: mvebu: Update A8K AP806 SDHCI settings kostap
2021-02-03 13:31   ` kostap
2021-02-03 13:58   ` Baruch Siach
2021-02-03 13:58     ` Baruch Siach
2021-02-03 14:37     ` [EXT] " Kostya Porotchkin
2021-02-03 14:37       ` Kostya Porotchkin
2021-02-03 14:38       ` Russell King - ARM Linux admin
2021-02-03 14:38         ` Russell King - ARM Linux admin
2021-02-03 14:50         ` Kostya Porotchkin
2021-02-03 14:50           ` Kostya Porotchkin
2021-02-03 15:03           ` Kostya Porotchkin
2021-02-03 15:03             ` Kostya Porotchkin
2021-02-03 16:11           ` Russell King - ARM Linux admin
2021-02-03 16:11             ` Russell King - ARM Linux admin
2021-02-03 16:57             ` Kostya Porotchkin
2021-02-03 16:57               ` Kostya Porotchkin
2021-02-05  9:33               ` Marcin Wojtas
2021-02-05  9:33                 ` Marcin Wojtas
2021-02-03 13:31 ` [PATCH 03/11] dts: mvebu: Add pin control definitions for SDIO interafce kostap
2021-02-03 13:31   ` kostap
2021-02-03 14:00   ` Baruch Siach
2021-02-03 14:00     ` Baruch Siach
2021-02-03 14:39     ` [EXT] " Kostya Porotchkin
2021-02-03 14:39       ` Kostya Porotchkin
2021-02-03 14:28   ` Russell King - ARM Linux admin
2021-02-03 14:28     ` Russell King - ARM Linux admin
2021-02-03 14:41     ` [EXT] " Kostya Porotchkin
2021-02-03 14:41       ` Kostya Porotchkin
2021-02-03 15:41       ` Andrew Lunn
2021-02-03 15:41         ` Andrew Lunn
2021-02-03 15:49         ` Kostya Porotchkin
2021-02-03 15:49           ` Kostya Porotchkin
2021-02-03 13:31 ` [PATCH 04/11] fix: dts: a8k: Add CP eMMC regulator and update device parameters kostap
2021-02-03 13:31   ` kostap
2021-02-03 13:31 ` [PATCH 05/11] arm64: dts: marvell: armada-3720-db: add comphy references kostap
2021-02-03 13:31   ` kostap
2021-02-03 13:31 ` [PATCH 06/11] arm64: dts: marvell: armada-3270-espressobin: " kostap
2021-02-03 13:31   ` kostap
2021-02-03 13:31 ` [PATCH 07/11] fix: ARM64: dts: cp110: Switch to 8-bit ECC NAND setting kostap
2021-02-03 13:31   ` kostap
2021-02-03 13:31 ` [PATCH 08/11] arm64: dts: marvell: armada-3720-db: add eeprom description kostap
2021-02-03 13:31   ` kostap
2021-02-03 13:31 ` [PATCH 09/11] dts: a3700: enable dma coherence for PCIE interface kostap
2021-02-03 13:31   ` kostap
2021-02-05  9:45   ` Marcin Wojtas [this message]
2021-02-05  9:45     ` Marcin Wojtas
2021-02-03 13:31 ` [PATCH 10/11] dts: marvell: add 2 eeprom properties to A8K DB device tree kostap
2021-02-03 13:31   ` kostap
2021-02-03 13:31 ` [PATCH 11/11] dts: marvell: add 2 eeprom properties to A7K " kostap
2021-02-03 13:31   ` kostap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPv3WKcuOXdN4zRSaGm1RnaBaXLsCtuT7CRMBAPDFvnBL76oEw@mail.gmail.com \
    --to=mw@semihalf.com \
    --cc=andrew@lunn.ch \
    --cc=bpeled@marvell.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gregory.clement@bootlin.com \
    --cc=jaz@semihalf.com \
    --cc=kostap@marvell.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=nadavh@marvell.com \
    --cc=robh+dt@kernel.org \
    --cc=sebastian.hesselbarth@gmail.com \
    --cc=stefanc@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.