All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kurt Manucredo <fuzzybritches@protonmail.com>
To: gregkh@linuxfoundation.org, ross.schm.dev@gmail.com,
	straube.linux@gmail.com, dan.carpenter@oracle.com,
	d.straghkov@ispras.ru, tiwai@suse.de
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
	Kurt Manucredo <fuzzybritches@protonmail.com>
Subject: [PATCH] Staging: rtl8723bs: code-style fix
Date: Thu, 18 Feb 2021 16:33:10 +0000	[thread overview]
Message-ID: <20210218163204.7-1-fuzzybritches@protonmail.com> (raw)

Signed-off-by: Kurt Manucredo <fuzzybritches@protonmail.com>
---

Checkpatch complains the constant needs to be on the right side of the
comparison. The preferred way is: 

 drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c
index 089c6ec19373..96feced698ac 100644
--- a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c
+++ b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c
@@ -2146,7 +2146,7 @@ void rtw_get_sec_iv(struct adapter *padapter, u8 *pcur_dot11txpn, u8 *StaAddr)
 	struct security_priv *psecpriv = &padapter->securitypriv;
 
 	memset(pcur_dot11txpn, 0, 8);
-	if (StaAddr == NULL)
+	if (!StaAddr)
 		return;
 	psta = rtw_get_stainfo(&padapter->stapriv, StaAddr);
 	DBG_871X("%s(): StaAddr: %02x %02x %02x %02x %02x %02x\n",
-- 
2.20.1



WARNING: multiple messages have this Message-ID (diff)
From: Kurt Manucredo <fuzzybritches@protonmail.com>
To: gregkh@linuxfoundation.org, ross.schm.dev@gmail.com,
	straube.linux@gmail.com, dan.carpenter@oracle.com,
	d.straghkov@ispras.ru, tiwai@suse.de
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
	Kurt Manucredo <fuzzybritches@protonmail.com>
Subject: [PATCH] Staging: rtl8723bs: code-style fix
Date: Thu, 18 Feb 2021 16:33:10 +0000	[thread overview]
Message-ID: <20210218163204.7-1-fuzzybritches@protonmail.com> (raw)

Signed-off-by: Kurt Manucredo <fuzzybritches@protonmail.com>
---

Checkpatch complains the constant needs to be on the right side of the
comparison. The preferred way is: 

 drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c
index 089c6ec19373..96feced698ac 100644
--- a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c
+++ b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c
@@ -2146,7 +2146,7 @@ void rtw_get_sec_iv(struct adapter *padapter, u8 *pcur_dot11txpn, u8 *StaAddr)
 	struct security_priv *psecpriv = &padapter->securitypriv;
 
 	memset(pcur_dot11txpn, 0, 8);
-	if (StaAddr == NULL)
+	if (!StaAddr)
 		return;
 	psta = rtw_get_stainfo(&padapter->stapriv, StaAddr);
 	DBG_871X("%s(): StaAddr: %02x %02x %02x %02x %02x %02x\n",
-- 
2.20.1


_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

             reply	other threads:[~2021-02-18 18:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-18 16:33 Kurt Manucredo [this message]
2021-02-18 16:33 ` [PATCH] Staging: rtl8723bs: code-style fix Kurt Manucredo
2021-02-18 17:46 ` Greg KH
2021-02-18 17:46   ` Greg KH
2021-02-19  6:57 ` Dan Carpenter
2021-02-19  6:57   ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210218163204.7-1-fuzzybritches@protonmail.com \
    --to=fuzzybritches@protonmail.com \
    --cc=d.straghkov@ispras.ru \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ross.schm.dev@gmail.com \
    --cc=straube.linux@gmail.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.